1. 12 Oct, 2007 3 commits
    • unknown's avatar
      BUG#29549 (Endians: rpl_ndb_myisam2ndb,rpl_ndb_innodb2ndb and rpl_ndb_mix_innodb failed on): · b3b01cf4
      unknown authored
      Post-merge fixes. Setting write bit before calling Field::store() since the function asserts that
      the write bit has been set.
      
      
      sql/field.cc:
        Setting bit in write set to prevent assertion from throwing when calling Field::store().
      b3b01cf4
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 7619a5ef
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl
      
      
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/rpl_record.cc:
        Manual merge.
      7619a5ef
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · bc2ecae3
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b29549-mysql-5.1-target-5.1.22
      
      
      mysql-test/suite/rpl/t/disabled.def:
        Auto merged
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/rpl_record.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      BitKeeper/deleted/.del-rpl_ndb_innodb2ndb.result~1:
        Delete: mysql-test/suite/rpl_ndb/r/rpl_ndb_innodb2ndb.result
      BitKeeper/deleted/.del-rpl_ndb_myisam2ndb.result~1:
        Delete: mysql-test/suite/rpl_ndb/r/rpl_ndb_myisam2ndb.result
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb-slave.opt:
        Manual merge
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb.test:
        Manual merge
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb-slave.opt:
        Manual merge
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb.test:
        Manual merge
      sql/log_event.cc:
        Manual merge
      sql/field.cc:
        Manual merge and adding comment.
      sql/field.h:
        Manual merge.
      bc2ecae3
  2. 11 Oct, 2007 1 commit
    • unknown's avatar
      BUG#29549 (Endians: test failures on Solaris): · 06fb8c2d
      unknown authored
      Refactoring code to add parameter to pack() and unpack() functions with
      purpose of indicating if data should be packed in little-endian or
      native order. Using new functions to always pack data for binary log
      in little-endian order. The purpose of this refactoring is to allow
      proper implementation of endian-agnostic pack() and unpack() functions.
      
      Eliminating several versions of virtual pack() and unpack() functions
      in favor for one single virtual function which is overridden in
      subclasses.
      
      Implementing pack() and unpack() functions for some field types that
      packed data in native format regardless of the value of the
      st_table_share::db_low_byte_first flag.
      
      The field types that were packed in native format regardless are:
      Field_real, Field_decimal, Field_tiny, Field_short, Field_medium,
      Field_long, Field_longlong, and Field_blob.
      
      Before the patch, row-based logging wrote the rows incorrectly on
      big-endian machines where the storage engine defined its own
      low_byte_first() to be FALSE on big-endian machines (the default
      is TRUE), while little-endian machines wrote the fields in correct
      order. The only known storage engine that does this is NDB. In effect,
      this means that row-based replication from or to a big-endian
      machine where the table was using NDB as storage engine failed if the
      other engine was either non-NDB or on a little-endian machine.
      
      With this patch, row-based logging is now always done in little-endian
      order, while ORDER BY uses the native order if the storage engine
      defines low_byte_first() to return FALSE for big-endian machines.
      
      In addition, the max_data_length() function available in Field_blob
      was generalized to the entire Field hierarchy to give the maximum
      number of bytes that Field::pack() will write.
      
      
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        Sorting by columns that produces deterministic order.
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_row_extraColmaster_ndb.result:
        Result change.
      mysql-test/suite/rpl/t/disabled.def:
        Enabling tests.
      mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test:
        Adding missing sync_slave_with_master causing slave to keep tables
        after shutdown.
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Enabling tests.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb-slave.opt:
        Adding --new option
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb.test:
        Adding have_log_bin.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb-slave.opt:
        Adding --new option
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb.test:
        Adding have_log_bin
      mysql-test/t/partition.test:
        Adding have_archive, since that is used in the test.
      sql/field.cc:
        Eliminating all two-argument pack() and unpack() functions and moving
        functionality into the four-argument version. The four argument version
        is introduced so that it is possible to avoid using the storage engine
        default when writing and reading the packed format (the unpacked format
        still uses the storage engine's default). This is used by row-based
        replication to write the fields in a storage engine- and endian-agnostic
        format.
        
        Packing integral and floating-point numbers in little-endian format
        (if requested).
        
        Using pad_char for the field instead of spaces (0x20) when unpacking.
        
        Adding some Doxygen documentation.
        ---
        Adding max_data_length() to denote the maximum number of bytes that
        pack() will write.
        
        Adding casts to remove warnings for debug printouts.
      sql/field.h:
        Eliminating all virtual pack() and unpack() functions except the four-
        argument version, which now is the function that shall be overridden.
        The two-argument versions are convenience functions, to prevent changes
        to code that uses these.
        
        Adding code to pack integer numbers and floating-point numbers in
        little-endian format, if requested.
        ---
        Adding max_data_length() to denote the maximum number of bytes that
        pack() will write.
      sql/log.cc:
        Removing debug printout causing crash when starting NDB on Solaris.
      sql/log_event.cc:
        Adding missing #ifndef causing compile failure. Adding debug printouts.
      sql/rpl_record.cc:
        Debriding code. Using new pack() and unpack() functions to always pack
        fields little-endian. Adding debug printouts.
        ---
        Using max_data_length() when packing field into row.
        
        Adding casts to debug printouts.
      sql/sql_show.cc:
        Adding code that causes crash on Solaris machines since printf() cannot
        handle NULL values for strings properly.
      mysql-test/suite/rpl_ndb/r/rpl_ndb_innodb2ndb.result:
        New BitKeeper file ``mysql-test/suite/rpl_ndb/r/rpl_ndb_innodb2ndb.result''
      mysql-test/suite/rpl_ndb/r/rpl_ndb_myisam2ndb.result:
        New BitKeeper file ``mysql-test/suite/rpl_ndb/r/rpl_ndb_myisam2ndb.result''
      06fb8c2d
  3. 10 Oct, 2007 1 commit
    • unknown's avatar
      BUG#29046: rpl_stm_mystery22 unstable · e8e20954
      unknown authored
      Problem: rpl_stm_mystery22 is unstable.
      
      Reason: At one place, the test case *should* wait until the SQL thread on the
      slave receives an error, but instead it waits until the SQL thread stops. The
      SQL thread may stop before the error flag is set, so that when the test case
      continues to execute, the error flag is not set.
      
      Fix: Introduce the subroutine mysql-test/include/wait_for_slave_sql_error.inc,
      which waits until there is an error in the sql thread of the slave.
      
      Re-commit: fixed one logical error and two smaller things noted by Mats.
      
      
      mysql-test/suite/rpl/t/rpl_stm_mystery22.test:
        Use the new wait_for_slave_sql_error.inc instead of wait_for_slave_to_stop.
        There may be a delay from when the slave stops to when Last_SQL_Errno is set,
        so it is not safe to merely wait until the slave stops.
      mysql-test/include/wait_for_slave_sql_error.inc:
        New BitKeeper file ``mysql-test/include/wait_for_slave_sql_error.inc''
        This is a subroutine that waits until the sql thread on the slave receives an
        error, as indicated by Last_SQL_Errno in "SHOW SLAVE STATUS".
      e8e20954
  4. 04 Oct, 2007 3 commits
    • unknown's avatar
      manual merge · 0f0e0e1a
      unknown authored
      
      sql/log.h:
        manual merge: moving 5.0 hunk into the correct file.
      0f0e0e1a
    • unknown's avatar
      Merge koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/BARE/5.0 · 7258005c
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/5.1-merge
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/mysql.result:
        Auto merged
      mysql-test/t/mysql.test:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_class.h:
        conflicting hunk is for log.h
      7258005c
    • unknown's avatar
      Bug#29323 mysql client only accetps ANSI encoded files · d0b076b6
      unknown authored
      Fix: ignore BOM marker in the first line.
      
      
      client/mysql.cc:
        Skip BOM marker in the very first line.
      mysql-test/r/mysql.result:
        Adding test
      mysql-test/t/mysql.test:
        Adding test
      d0b076b6
  5. 03 Oct, 2007 5 commits
  6. 02 Oct, 2007 3 commits
  7. 01 Oct, 2007 6 commits
  8. 26 Sep, 2007 1 commit
    • unknown's avatar
      Bug #26000 SHOW SLAVE STATUS can crash mysqld during shutdown process · 184cddab
      unknown authored
      active_mi has been reset (shutdown) at the time of quering with 
      SHOW SLAVE STATUS so that 
      at handling of SHOW an attempt to read its members segfaults.
      
      Fixed with checking the value of active_mi before to call show_master_info()
      Merely send_ok() is invoked when active_mi does not exist.
      A test can not be easiely written.
      
      Notice, there are more analogical cases in the code which require a similar
      treatment (to be reported as a bug separately). 
      
      
      sql/sql_parse.cc:
        Ignore reporting and send only OK if master info struct has been destoyed.
        As this must be at shutdown merely a warning is sent to the client.
      184cddab
  9. 25 Sep, 2007 3 commits
  10. 24 Sep, 2007 3 commits
  11. 22 Sep, 2007 1 commit
  12. 21 Sep, 2007 3 commits
  13. 20 Sep, 2007 7 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · cdd5e2a4
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b31076-mysql-5.1-rpl
      
      
      sql/log_event.cc:
        Auto merged
      cdd5e2a4
    • unknown's avatar
      BUG#31076 (Server crashes when start slave is issued): · e40080ea
      unknown authored
      Row-based replication crashes when replicating from pre-5.1.22 to 5.1.22
      due to an uninitialized variable.
      
      
      sql/log_event.cc:
        Initializing m_null_bits to null so that it can be detected that it
        was not initialized later.
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_bug31076.result''
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_bug31076.test''
      e40080ea
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · c9f5a087
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      c9f5a087
    • unknown's avatar
      result fix · ae270c42
      unknown authored
      ae270c42
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 83540130
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/grant.result:
        Auto merged
      83540130
    • unknown's avatar
      result fix · ad57f912
      unknown authored
      ad57f912
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · d0f79424
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/alter_table.result:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/ctype_collate.result:
        Auto merged
      mysql-test/r/ctype_recoding.result:
        Auto merged
      mysql-test/r/default.result:
        Auto merged
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/key.result:
        Auto merged
      mysql-test/r/mysql.result:
        Auto merged
      mysql-test/r/ps_1general.result:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/r/type_enum.result:
        Auto merged
      mysql-test/r/type_ranges.result:
        Auto merged
      mysql-test/r/show_check.result:
        manual merge
      mysql-test/t/information_schema.test:
        manual merge
      sql/sql_show.cc:
        manual merge
      d0f79424