1. 29 Nov, 2006 3 commits
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug20637 · b9567227
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug20637
      
      
      sql/sql_yacc.yy:
        Auto merged
      b9567227
    • unknown's avatar
      BUG#20637: "load data concurrent infile" locks the table · c707c7ea
      unknown authored
      Note that we ignore CONCURRENT if LOAD DATA CONCURRENT is used from
      inside a stored routine and MySQL is compiled with Query Cache support
      (this is not in the manual).
      
      The problem was that the condition test of "we are inside stored routine"
      was reversed, thus CONCURRENT _worked only_ from stored routine.  The
      solution is to use proper condition test.
      
      No test case is provided because the test case would require a large
      amount of input, and it's hard to tell is SELECT is really blocked or
      just slow (subject to race).
      
      
      sql/sql_yacc.yy:
        Fix the condition of TL_WRITE_CONCURRENT_INSERT on LOAD DATA CONCURRENT,
        which was reversed, and return valid value if we are in SP.
      c707c7ea
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 0e978328
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      libmysql/libmysql.c:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      server-tools/instance-manager/mysql_connection.cc:
        Rollback Monty's removals of explicit casts
      tests/mysql_client_test.c:
        SCCS merged
      0e978328
  2. 28 Nov, 2006 3 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · fe99bda8
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-24486
      
      
      sql/sql_parse.cc:
        Auto merged
      fe99bda8
    • unknown's avatar
      A fix for Bug#24486 "Valgrind warnings: sp_head(), · 76833ac4
      unknown authored
      deadlock_innodb:events_grant". This was a memory leak introduced by 
      the patch for Bug 22830.
      Post-review fixes.
      
      
      sql/sql_parse.cc:
        A fix for Bug#24486 "Valgrind warnings: sp_head(),
         deadlock_innodb:events_grant": delete the sphead object before
        returning with an error.
      76833ac4
    • unknown's avatar
      Fixed portablity problem · 76b4ccbd
      unknown authored
      Removed warnings from mysqltest scripts
      
      
      cmd-line-utils/readline/undo.c:
        Fixed portability problem
      mysql-test/include/mix2.inc:
        Removed mysqltest warnings
      mysql-test/include/query_cache.inc:
        Removed mysqltest warnings
      mysql-test/r/ndb_binlog_ddl_multi.result:
        Update tests after fixing wrong connection command in test
      mysql-test/t/greedy_optimizer.test:
        Removed mysqltest warnings
      mysql-test/t/join.test:
        Removed mysqltest warnings
      mysql-test/t/ndb_binlog_ddl_multi.test:
        Removed mysqltest warnings
      mysql-test/t/ndb_blob_partition.test:
        Removed mysqltest warnings
      mysql-test/t/ndb_index_ordered.test:
        Removed mysqltest warnings
      storage/ndb/src/kernel/vm/Rope.cpp:
        Removed compiler warning
      76b4ccbd
  3. 27 Nov, 2006 3 commits
    • unknown's avatar
      Disabled syncronization test at it fails on multiple platforms. (Bug #24529) · 13bb3fa8
      unknown authored
      Fixed that test_thr_alarm works
      
      
      mysql-test/mysql-test-run.pl:
        Fixed typo
      mysql-test/r/synchronization.result:
        Updated results
      mysql-test/t/disabled.def:
        Disabled syncronization test at it fails on multiple platforms. (Bug #24529)
      mysql-test/t/synchronization.test:
        Drop used tables
      mysys/Makefile.am:
        Added 'debug' to be able to build test cases
      mysys/thr_alarm.c:
        Fixed test case
      13bb3fa8
    • unknown's avatar
      Removed compiler warnings · c1477a3f
      unknown authored
      Ensure that my_size_t is always unsigned (to get predictiable results from system to system)
      Removed some %lld, as these are not portable
      
      
      BUILD/FINISH.sh:
        Remove configure files from storage engines (as some of them may be old versions and may cause conflicts)
      client/mysqldump.c:
        Removed compiler warning
      client/mysqlslap.c:
        Removed compiler warning
      client/mysqltest.c:
        Removed compiler warning
      cmd-line-utils/readline/bind.c:
        Removed compiler warning
      cmd-line-utils/readline/histfile.c:
        Removed compiler warning
      include/my_global.h:
        Ensure that my_size_t is always unsigned (to get predictiable results from system to system)
        Moved my_offset_t here from parse_file.h
      sql/event_data_objects.cc:
        Removed compiler warning
      sql/event_scheduler.cc:
        Removed compiler warning
      sql/field.h:
        Removed compiler warning
      sql/ha_ndbcluster_binlog.cc:
        Removed compiler warning
      sql/ha_partition.cc:
        Removed compiler warning
      sql/item_strfunc.cc:
        Removed compiler warning
      sql/log_event.cc:
        Removed compiler warning
      sql/mysqld.cc:
        Removed compiler warning
      sql/parse_file.h:
        Moved my_offset_t to my_global.h
      sql/rpl_utility.cc:
        Removed compiler warning
      sql/sql_binlog.cc:
        Removed compiler warning
      sql/sql_cache.cc:
        Removed compiler warning
      sql/tztime.cc:
        Removed compiler warning
      storage/archive/ha_archive.cc:
        Removed compiler warning
        Removed %lld as it's not portable
      storage/heap/hp_write.c:
        Removed compiler warning
      storage/innobase/os/os0file.c:
        Removed compiler warning
      storage/myisam/myisampack.c:
        Removed compiler warning
      storage/myisammrg/myrg_rkey.c:
        Removed compiler warning
      storage/ndb/include/kernel/signaldata/DictTabInfo.hpp:
        Use my_offsetof instead of offsetof to get rid of compiler warnings
      storage/ndb/src/kernel/blocks/dbdict/printSchemaFile.cpp:
        Removed compiler warning
      storage/ndb/src/kernel/blocks/dbtup/DbtupRoutines.cpp:
        Removed compiler warning
        Note: Someone from NDB team should check this fix!
      storage/ndb/src/kernel/vm/Rope.cpp:
        Removed compiler warning
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/Ndb.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/Ndblist.cpp:
        Removed compiler warning
      c1477a3f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-marvel · 24bbc92b
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      BUILD/SETUP.sh:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      sql/log_event.cc:
        Manual merge
      sql/sql_binlog.cc:
        Manual merge
      24bbc92b
  4. 26 Nov, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/home/my/mysql-5.0 · f7004087
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      client/mysqldump.c:
        Auto merged
      include/errmsg.h:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql-common/client.c:
        Auto merged
      mysql-test/mysql-test-run-shell.sh:
        SCCS merged
      f7004087
    • unknown's avatar
      Fixed a LOT of compiler warnings · 788ad30f
      unknown authored
      Added missing DBUG_RETURN statements (in mysqldump.c)
      Added missing enums
      Fixed a lot of wrong DBUG_PRINT() statements, some of which could cause crashes
      Removed usage of %lld and %p in printf strings as these are not portable or produces different results on different systems.
      
      
      client/mysqldump.c:
        Fixed some compiler warnings
        Added some missing DBUG_RETURN
        Remove copying of 'cluster' database
      client/mysqlslap.c:
        Fixed compiler warnings
      client/mysqltest.c:
        After merge fix
      extra/yassl/taocrypt/include/algebra.hpp:
        Removed compiler warning
      mysql-test/include/im_check_env.inc:
        Fixed race condition (mysqld1 could report 'starting' or 'online'
      mysql-test/mysql-test-run.pl:
        After merge fixes
        Added missing directory to LD_LIBRARY_PATH
      mysql-test/r/ctype_cp1250_ch.result:
        After merge fix
      mysql-test/r/im_cmd_line.result:
        Fixed race condition
      mysql-test/r/im_daemon_life_cycle.result:
        Fixed race condition
      mysql-test/r/im_instance_conf.result:
        Fixed race condition
      mysql-test/r/im_life_cycle.result:
        Fixed race condition
      mysql-test/r/im_utils.result:
        Fixed race condition
      mysql-test/r/log_tables.result:
        Fixed wrong result
      mysql-test/t/disabled.def:
        Disabled ndb_restore_partion, as ndb_restore_compate caused it to fail, becasue of table 'cluster/def/schema' which is stored in ndb_backup50
      mysys/my_compress.c:
        Removed compiler warnings
      mysys/my_getopt.c:
        Ensure we always have at least one space between option name and value
      plugin/fulltext/plugin_example.c:
        Removed compiler warnings
      server-tools/instance-manager/mysql_connection.cc:
        After merge fix
      sql/event_data_objects.cc:
        Fixed compiler warnings
        Fixed platform compatibility issues (%lld is not portable)
      sql/event_data_objects.h:
        Fixed compiler warnings
      sql/event_db_repository.cc:
        Fixed compiler warnings
      sql/event_queue.cc:
        Fixed compiler warnings
      sql/event_scheduler.cc:
        Fixed compiler warnings
      sql/events.cc:
        Fixed compiler warnings
      sql/field.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warnings
      sql/ha_partition.cc:
        Fixed compiler warnings
      sql/handler.cc:
        Fixed compiler warnings
      sql/item_cmpfunc.cc:
        Fixed DBUG_PRINT style
      sql/item_func.cc:
        Fixed compiler warnings
      sql/log.cc:
        Fixed compiler warnings
      sql/log_event.cc:
        Fixed compiler warnings
      sql/mysqld.cc:
        Fixed compiler warnings
      sql/opt_range.cc:
        Fixed compiler warnings
      sql/repl_failsafe.cc:
        Indentation fixes
      sql/rpl_rli.cc:
        Fixed compiler warnings
      sql/rpl_tblmap.cc:
        Fixed compiler warnings
      sql/set_var.cc:
        Fixed compiler warnings
      sql/slave.cc:
        Fixed compiler warnings
      sql/sp_head.cc:
        Fixed compiler warnings
      sql/sql_base.cc:
        Fixed compiler warnings
        Fixed indentation
      sql/sql_binlog.cc:
        Fixed compiler warnings
      sql/sql_cache.cc:
        Fixed compiler warnings
      sql/sql_class.cc:
        Fixed compiler warnings
      sql/sql_handler.cc:
        Fixed compiler warnings
      sql/sql_lex.cc:
        Fixed compiler warnings
      sql/sql_parse.cc:
        Fixed compiler warnings
      sql/sql_partition.cc:
        Fixed compiler warnings
      sql/sql_prepare.cc:
        Fixed compiler warnings
      sql/sql_table.cc:
        Fixed compiler warnings
      sql/sql_test.cc:
        Fixed DBUG_PRINT style
      sql/sql_trigger.cc:
        Fixed DBUG_PRINT style
      sql/table.cc:
        Fixed compiler warnings
      storage/federated/ha_federated.cc:
        Fixed compiler warnings
      storage/myisam/mi_rsamepos.c:
        Fixed compiler warnings
      storage/ndb/include/ndb_global.h.in:
        After merge fix
      storage/ndb/include/util/NdbOut.hpp:
        Inform gcc that ndbout_c takes a printf() string as argument
      storage/ndb/include/util/SimpleProperties.hpp:
        After merge fixes
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbacc/DbaccMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Fixed compiler warnings
        Fixed usage of uninitialized value (Got help from Jonas with patch)
      storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/lgman.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/pgman.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/restore.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupCommit.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupDiskAlloc.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupFixAlloc.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/suma/Suma.cpp:
        Fixed compiler warnings
        Added missing enum's to switch
      storage/ndb/src/kernel/vm/Configuration.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/DLHashTable.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/RWPool.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/SimulatedBlock.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/WOPool.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/ndbd_malloc_impl.cpp:
        Fixed compiler warnings
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Fixed compiler warnings
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/DictCache.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbIndexOperation.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbIndexStat.cpp:
        Initialize possible uninitialized variable
      storage/ndb/src/ndbapi/NdbOperationInt.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbRecAttr.cpp:
        Added missing enum's (To avoid compiler warnings)
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/ObjectMap.hpp:
        Fixed compiler warnings
      storage/ndb/tools/desc.cpp:
        Fixed compiler warnings
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warnings
      storage/ndb/tools/restore/consumer_restore.cpp:
        Fixed compiler warnings
      unittest/mytap/t/basic-t.c:
        Fixed compiler warnings
      unittest/mytap/tap.c:
        Fixed compiler warnings
      788ad30f
  5. 24 Nov, 2006 1 commit
  6. 23 Nov, 2006 6 commits
    • unknown's avatar
      Added option --mtr-build-thread to mysql-test-run.pl · 52fc261b
      unknown authored
      Load shared libraries from zlib (fixed that mysql-test-run.pl didn't work on some Solaris boxes)
      Added connect timeout to test to make im_daemon_life_cycle more predictable
      
      
      mysql-test/mysql-test-run.pl:
        Added option --mtr-build-thread
        Load shared libraries from zlib (fixed that mysql-test-run.pl didn't work on some Solaris boxes)
      mysql-test/t/wait_for_socket.sh:
        Added connect timeout (to make test predictable)
      52fc261b
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 0534b679
      unknown authored
      into  outpost.site:/home/cps/mysql/trees/mysql-5.1-runtime
      
      
      server-tools/instance-manager/instance_options.cc:
        manual merge
      0534b679
    • unknown's avatar
      BUG#24488 (Valgrind warnings on invalid read in mysql_client_binlog_statement): · 49009cf8
      unknown authored
      Disabling debug printouts for valgrind builds that print unallocated memory.
      
      
      sql/sql_binlog.cc:
        Disabling debug printouts for valgrind builds that print unallocated memory
      49009cf8
    • unknown's avatar
      Added some missing DBUG_RETURN · 42f6fd5f
      unknown authored
      Fixed that --valgrind works again with mysql-test-run.sh
      Extended error messages when loosing connection during mysql_real_connect()
      
      
      client/mysqldump.c:
        Added some missing DBUG_RETURN
      include/errmsg.h:
        Extended error messages when loosing connection during mysql_real_connect()
      libmysql/errmsg.c:
        Extended error messages when loosing connection during mysql_real_connect()
      mysql-test/mysql-test-run.pl:
        Don't remove .reject files at startup
      mysql-test/mysql-test-run.sh:
        Fixed that --valgrind works again
        Don't give warnings for directores in var/tmp
      sql-common/client.c:
        Extended error messages when loosing connection during mysql_real_connect()
      42f6fd5f
    • unknown's avatar
      BUG#24533 (uninitialized null bits in m_after_image): · 9fefd8eb
      unknown authored
      Removing valgrind memory checks from code.
      
      
      sql/log_event.cc:
        Removing valgrind memory checks from code.
      9fefd8eb
    • unknown's avatar
      BUG#24533 (uninitialized null but of m_after_image): · 227e8e4e
      unknown authored
      Patch to fix valgrind warning that uninitialized bytes were written. 
      The warning was caused by set_default(), which assumes that the field pointer is pointing
      into record[0], while all other functions honors the move_field_offset().
      
      
      sql/log_event.cc:
        Changing unpack_row() to always unpack into table->record[0] since the Field class hierarchy
        contain too many dependencies on the record to operate on being in table->record[0].
        Changing code to use the new unpack_row(), which requires some juggling of records in
        one case.
      227e8e4e
  7. 22 Nov, 2006 9 commits
    • unknown's avatar
      Fix Bug #22242 Instance Manager: option-parsing errors · 779d2f16
      unknown authored
      There was a memory overrun, which resulted in safemalloc
      errors. Recommit with post-review fixes.
      
      
      server-tools/instance-manager/instance_options.cc:
        Memory was overrun here: convert_dirname() adds a slash to the
        end of the string. Then it was removed (with end[-1]=0), but
        the overrun still happened, which caused sefemalloc to complain.
        
        The problem stemed from the fact that we converted the path to the
        binary, not to the directory. Now we first truncate the path and
        then convert the name of the directory, where the binary resides.
        
        E.g. Suppose that IM got an option --mysqld-path='/usr/local/bin/mysqld'.
        Then convert dirname was called. This routine takes a path to the
        dir (not binary!) and converts it for usage under particular OS.
        And at least for *nixes it *always* adds slash. E.g. for the path above
        convert_dirname() will result in path: '/usr/local/bin/mysqld/'
        Note the last slash. 
        
        The fix is to convert the path to the dir where the binary resides:
        /usr/local/bin/. Then we put back the binary name.
      779d2f16
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 68adc7b3
      unknown authored
      into  booka.:/home/alik/MySQL/devel/5.1-rt-im
      
      
      68adc7b3
    • unknown's avatar
      Make IM compiled on Win32: add pthread_join() impl. · 4f096746
      unknown authored
      
      include/my_pthread.h:
        Add pthread_join() for Windows.
      4f096746
    • unknown's avatar
      de2fbec4
    • unknown's avatar
      Merge mysql.com:/home/my/mysql-5.0 · b8fe9fb4
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/deleted/.del-my_lread.c:
        Auto merged
      BitKeeper/deleted/.del-my_lwrite.c:
        Auto merged
      client/mysqlbinlog.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      cmd-line-utils/readline/complete.c:
        Auto merged
      extra/yassl/src/ssl.cpp:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/libmysqld.c:
        Auto merged
      mysql-test/mysql-test-run-shell.sh:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/csv.test:
        Auto merged
      mysql-test/t/ctype_cp1250_ch.test:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_sapdb.test:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      mysql-test/t/group_min_max.test:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/join.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      mysql-test/t/sp-prelocking.test:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      mysql-test/t/type_newdecimal.test:
        Auto merged
      mysql-test/t/view_grant.test:
        Auto merged
      mysys/default.c:
        Auto merged
      mysys/mf_iocache.c:
        Auto merged
      mysys/mf_keycache.c:
        Auto merged
      mysys/my_alloc.c:
        Auto merged
      mysys/my_dup.c:
        Auto merged
      mysys/my_getwd.c:
        Auto merged
      mysys/my_handler.c:
        Auto merged
      mysys/my_lib.c:
        Auto merged
      mysys/my_malloc.c:
        Auto merged
      mysys/my_pread.c:
        Auto merged
      mysys/my_seek.c:
        Auto merged
      mysys/safemalloc.c:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/net_serv.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/strfunc.cc:
        Auto merged
      sql/tztime.cc:
        Auto merged
      sql/unireg.cc:
        Auto merged
      storage/heap/_check.c:
        Auto merged
      storage/heap/hp_delete.c:
        Auto merged
      storage/heap/hp_hash.c:
        Auto merged
      storage/heap/hp_open.c:
        Auto merged
      storage/heap/hp_rkey.c:
        Auto merged
      storage/heap/hp_rrnd.c:
        Auto merged
      storage/heap/hp_write.c:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisam/mi_close.c:
        Auto merged
      storage/myisam/mi_delete.c:
        Auto merged
      storage/myisam/mi_dynrec.c:
        Auto merged
      storage/myisam/mi_keycache.c:
        Auto merged
      storage/myisam/mi_page.c:
        Auto merged
      storage/myisam/mi_statrec.c:
        Auto merged
      storage/myisam/mi_test2.c:
        Auto merged
      storage/myisam/mi_write.c:
        Auto merged
      storage/myisam/myisampack.c:
        Auto merged
      storage/myisammrg/ha_myisammrg.cc:
        Auto merged
      storage/myisammrg/myrg_extra.c:
        Auto merged
      storage/ndb/include/logger/LogHandler.hpp:
        Auto merged
      storage/ndb/include/util/OutputStream.hpp:
        Auto merged
      storage/ndb/src/common/debugger/EventLogger.cpp:
        Auto merged
      storage/ndb/src/common/debugger/signaldata/BackupSignalData.cpp:
        Auto merged
      storage/ndb/src/common/logger/LogHandler.cpp:
        Auto merged
      storage/ndb/src/common/portlib/NdbMutex.c:
        Auto merged
      storage/ndb/src/common/portlib/NdbThread.c:
        Auto merged
      storage/ndb/src/common/transporter/Transporter.cpp:
        Auto merged
      storage/ndb/src/cw/cpcd/CPCD.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtux/DbtuxSearch.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Auto merged
      storage/ndb/src/kernel/error/ErrorReporter.cpp:
        Auto merged
      storage/ndb/src/kernel/error/ErrorReporter.hpp:
        Auto merged
      storage/ndb/src/kernel/error/ndbd_exit_codes.c:
        Auto merged
      storage/ndb/src/kernel/vm/TransporterCallback.cpp:
        Auto merged
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Auto merged
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/ndbapi/ClusterMgr.cpp:
        Auto merged
      storage/ndb/src/ndbapi/DictCache.cpp:
        Auto merged
      storage/ndb/src/ndbapi/Ndb.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbOperationExec.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbOperationInt.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Auto merged
      storage/ndb/src/ndbapi/Ndbif.cpp:
        Auto merged
      storage/ndb/tools/drop_index.cpp:
        Auto merged
      storage/ndb/tools/drop_tab.cpp:
        Auto merged
      storage/ndb/tools/ndb_condig.cpp:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      vio/viossl.c:
        Auto merged
      vio/viosslfactories.c:
        Auto merged
      BUILD/SETUP.sh:
        Use local version
      client/client_priv.h:
        Manual merge
      mysql-test/mysql-test-run.pl:
        Manual merge
      mysql-test/r/ctype_cp1250_ch.result:
        Manual merge
      mysql-test/t/disabled.def:
        Manual merge
      mysys/hash.c:
        Manual merge
      mysys/thr_lock.c:
        Manual merge
      server-tools/instance-manager/mysql_connection.cc:
        Manual merge
      sql/ha_ndbcluster.cc:
        Manual merge
      sql/handler.cc:
        Manual merge
      sql/item_timefunc.cc:
        Manual merge
      sql/mysqld.cc:
        Manual merge
      sql/opt_range.cc:
        Manual merge
      sql/slave.cc:
        Manual merge
      sql/sql_parse.cc:
        Manual merge
      sql/sql_prepare.cc:
        Manual merge
      sql/sql_view.cc:
        Manual merge
      sql/table.cc:
        Manual merge
      storage/archive/ha_archive.cc:
        Manual merge
      storage/federated/ha_federated.cc:
        Manual merge
      storage/federated/ha_federated.h:
        Manual merge
      storage/innobase/handler/ha_innodb.cc:
        Manual merge
      storage/ndb/include/ndb_global.h.in:
        Manual merge
      storage/ndb/include/util/InputStream.hpp:
        Manual merge
      storage/ndb/include/util/SimpleProperties.hpp:
        Manual merge
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Manual merge
      storage/ndb/src/ndbapi/NdbOperationDefine.cpp:
        Manual merge
      storage/ndb/src/ndbapi/NdbOperationSearch.cpp:
        Manual merge
      storage/ndb/src/ndbapi/Ndbinit.cpp:
        Manual merge
      storage/ndb/src/ndbapi/ndb_cluster_connection.cpp:
        Manual merge
      strings/decimal.c:
        Manual merge
      vio/viosocket.c:
        Manual merge
      b8fe9fb4
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · 498fcdc6
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21635
      
      
      498fcdc6
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug21635 · f3c9b38e
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21635
      
      
      sql/item_sum.cc:
        Auto merged
      tests/mysql_client_test.c:
        Manual merge.
      f3c9b38e
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug21635 · 5af294b9
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug21635
      
      
      sql/item_sum.cc:
        Auto merged
      tests/mysql_client_test.c:
        Manual merge.
      5af294b9
    • unknown's avatar
      BUG#21635: MYSQL_FIELD struct's member strings seem to misbehave for · 18770d2f
      unknown authored
      expression cols.
      
      The problem was that MYSQL_FIELD::org_name was set for MIN() and MAX()
      functions (COUNT() is also mentioned in the bug report but was already
      fixed).
      
      After this patch for expressions MYSQL_FIELD::name is set to either
      expression itself or its alias, and other data origin fields of
      MYSQL_FILED (db, org_table, table, org_name) are empty strings.
      
      
      sql/item_sum.cc:
        For expressions only col_name should be non-empty string.
      tests/mysql_client_test.c:
        Add test case for bug#21635: MYSQL_FIELD struct's member strings seem
        to misbehave for expression cols.
      18770d2f
  8. 21 Nov, 2006 13 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 7463704e
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      client/mysql.cc:
        Auto merged
      client/mysqlbinlog.cc:
        Auto merged
      mysql-test/mysql-test-run-shell.sh:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/r/connect.result:
        Auto merged
      mysql-test/r/drop.result:
        Auto merged
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/rpl_ndb_dd_advance.result:
        Auto merged
      mysql-test/r/show_check.result:
        Auto merged
      mysql-test/t/information_schema.test:
        Auto merged
      mysql-test/t/mysqldump.test:
        Auto merged
      mysql-test/t/rpl_ndb_dd_advance.test:
        Auto merged
      mysql-test/t/system_mysql_db_fix.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/federated/ha_federated.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      client/mysql_upgrade.c:
        Manual merge
      client/mysqltest.c:
        Manual merge
      mysql-test/mysql-test-run.pl:
        Manual merge
      storage/innobase/handler/ha_innodb.cc:
        Manual merge
      7463704e
    • unknown's avatar
      Added --debug-info to most clients to detect memory leaks in mysql-test-run · 85a590a2
      unknown authored
      Moved .progress files into the log directory
      Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name
      Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23
      Fixed some compiler warnings
      Fixed small memory leak in libmysql
      Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1
      
      
      client/client_priv.h:
        Added OPT_DEBUG_INFO and OPT_COLUMN_TYPES
      client/mysql.cc:
        Split --debug-info into --debug-info and --column-type-info
      client/mysql_upgrade.c:
        Give only error info at end if using --debug-info
      client/mysqladmin.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlbinlog.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlcheck.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlimport.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlshow.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqltest.c:
        Added --debug-info to detect memory leaks in mysqltest
        Added option --logdir to force .progress files in a specific directory
      libmysql/libmysql.c:
        Fixed memory leak
      mysql-test/include/ndb_setup_slave.inc:
        Moved cluster tables under 'mysql'
      mysql-test/include/query_cache.inc:
        Added more tests for query cache
      mysql-test/lib/init_db.sql:
        Move cluster.binlog_index -> mysql.binlog_index
      mysql-test/lib/mtr_report.pl:
        Find memory leaks
      mysql-test/mysql-test-run-shell.sh:
        Added --debug-info to programs to detect memory leaks
      mysql-test/mysql-test-run.pl:
        Added --debug-info to programs to detect memory leaks
        Force log files to var/log
        cluster tables moved under 'mysql'
      mysql-test/r/cache_innodb.result:
        New query cache test with innodb
      mysql-test/r/connect.result:
        binlog_index is now in mysql
      mysql-test/r/drop.result:
        Removed 'cluster' database
      mysql-test/r/information_schema.result:
        Removed 'cluster' database
      mysql-test/r/mysqlcheck.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_basic.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_ddl_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_discover.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_restore_compat.result:
        cluster -> mysql
      mysql-test/r/ps_1general.result:
        Removed cluster database
      mysql-test/r/rpl_create_database.result:
        Removed cluster database
      mysql-test/r/rpl_load_from_master.result:
        Removed cluster database
      mysql-test/r/rpl_loaddata_m.result:
        Removed cluster database
      mysql-test/r/rpl_ndb_bank.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_advance.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_basic.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_idempotent.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_log.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_multi.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_sync.result:
        cluster -> mysql
      mysql-test/r/rpl_row_basic_11bugs.result:
        Removed cluster database
      mysql-test/r/rpl_truncate_7ndb.result:
        Position have changed
      mysql-test/r/rpl_truncate_7ndb_2.result:
        cluster -> mysql
      mysql-test/r/schema.result:
        Removed cluster database
      mysql-test/r/show_check.result:
        Removed cluster database
      mysql-test/r/system_mysql_db.result:
        binlog_index moved under mysql
      mysql-test/r/upgrade.result:
        More tests
      mysql-test/t/information_schema.test:
        cluster -> mysql
      mysql-test/t/mysqldump.test:
        More test to detect memory leaks
      mysql-test/t/ndb_binlog_basic.test:
        cluster -> mysql
      mysql-test/t/ndb_binlog_multi.test:
        cluster -> mysql
      mysql-test/t/ndb_restore_compat.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_bank.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_dd_advance.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_idempotent.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_multi.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_sync.test:
        cluster -> mysql
      mysql-test/t/system_mysql_db_fix.test:
        Drop also binlog_index
      mysql-test/t/upgrade.test:
        Check that tables created with 3.23 works
      mysys/my_error.c:
        Remove all registered errors (to avoid memory leaks)
      mysys/my_init.c:
        call my_error_unregister_all() to avoid some possible memory leaks
      mysys/mysys_priv.h:
        Added prototype
      scripts/mysql_create_system_tables.sh:
        cluster -> mysql
      scripts/mysql_fix_privilege_tables.sql:
        Changed -- to #
        Create binlog_index table if it dosesn't exist
      sql/field.cc:
        Made offset() inline
      sql/field.h:
        Changed prototype of offset() to not make it depending on TABLE structure
      sql/field_conv.cc:
        Removed some usage of current_thd
      sql/ha_ndbcluster_tables.h:
        cluster -> mysql
      sql/item_sum.cc:
        Usage of new 'offset' parameters
      sql/key.cc:
        Changed 'find_ref_key' to not be dependent on field->table
        (This fixed a crash when using a table created in MySQL 3.23)
      sql/mysql_priv.h:
        Changed find_ref_key() to not use field->table
      sql/mysqld.cc:
        Fix that plugin_init() works properly on bootstrap
        (Previously we got warnings from plugin_init)
      sql/sql_class.cc:
        new 'field->offset()'
      sql/sql_select.cc:
        New field->offset()
      sql/table.cc:
        We don't need field->table to be set in find_ref_key() or find_field() anymore.
      storage/archive/ha_archive.cc:
        New field->offset()
      storage/federated/ha_federated.cc:
        New field->offset()
      storage/innobase/handler/ha_innodb.cc:
        Fixed compiler warnings
      storage/myisam/ha_myisam.cc:
        Fixed compiler warnings (Wrong paramter to sprintf())
        New field->offset()
      storage/myisam/ha_myisam.h:
        Fixed wrong type of table_flags
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warning
      mysql-test/r/1st.result:
        New BitKeeper file ``mysql-test/r/1st.result''
      mysql-test/std_data/old_table-323.frm:
        New BitKeeper file ``mysql-test/std_data/old_table-323.frm''
      mysql-test/t/1st.test:
        New BitKeeper file ``mysql-test/t/1st.test''
      85a590a2
    • unknown's avatar
      Short fix for Windows. · 83609387
      unknown authored
      
      server-tools/instance-manager/manager.cc:
        Make it compilable on Windows.
      83609387
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · e0b735ab
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug23159
      
      
      e0b735ab
    • unknown's avatar
      Polishing: · 7c35c3d5
      unknown authored
        - change some return types from int to bool;
        - add [ERROR] tag to log_error() output;
        - add [INFO] tag to log_info() output;
        - change log messages to be more consistent.
      
      
      server-tools/instance-manager/IMService.cpp:
        Log polishing.
      server-tools/instance-manager/commands.cc:
        Log polishing.
      server-tools/instance-manager/commands.h:
        Eliminate warnings.
      server-tools/instance-manager/instance.cc:
        Log polishing.
      server-tools/instance-manager/instance_map.cc:
        Log polishing.
      server-tools/instance-manager/instance_options.cc:
        1) Log polishing.
        2) Change int-return type to bool.
      server-tools/instance-manager/instance_options.h:
        Change int-return type to bool.
      server-tools/instance-manager/listener.cc:
        Log polishing.
      server-tools/instance-manager/log.cc:
        Log polishing.
      server-tools/instance-manager/log.h:
        Log polishing.
      server-tools/instance-manager/manager.cc:
        Log polishing.
      server-tools/instance-manager/mysql_connection.cc:
        Log polishing.
      server-tools/instance-manager/mysql_connection.h:
        Change int-return type to bool.
      server-tools/instance-manager/mysqlmanager.cc:
        Log polishing.
      server-tools/instance-manager/priv.cc:
        Log polishing.
      server-tools/instance-manager/thread_registry.cc:
        1. Print pthread_t as (unsigned long), not as (signed long)
        to avoid negative identifiers in output.
        2. Print thread id after it will be initialized, not before.
      server-tools/instance-manager/user_map.cc:
        Log polishing.
      7c35c3d5
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · 4b9f7904
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug23159
      
      
      4b9f7904
    • unknown's avatar
      Polishing: · cbfff730
      unknown authored
      1) add support for joinable threads to Thread class;
      2) move checking of thread model to Manager from mysqlmanager.cc,
      because it is needed only for IM-main process.
      
      
      server-tools/instance-manager/instance.cc:
        Use Manager::is_linux_threads() instead of global variable.
      server-tools/instance-manager/listener.cc:
        Use Thread::start(DETACHED) instead of Thread::start_detached().
      server-tools/instance-manager/manager.cc:
        1. Use Thread::start(DETACHED) instead of Thread::start_detached();
        2. Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/manager.h:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/mysqlmanager.cc:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/priv.cc:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/priv.h:
        Move checking of thread model to Manager from mysqlmanager.cc,
        because it is needed only for IM-main process.
      server-tools/instance-manager/thread_registry.cc:
        Add support of joinable threads to Thread class.
      server-tools/instance-manager/thread_registry.h:
        Add support of joinable threads to Thread class.
      cbfff730
    • unknown's avatar
      Update after merge. · 5e1c2e36
      unknown authored
      Use mutex when reading prepared_stmt_count global status variable.
      
      Update test case for bug 16365 and bug 23159: add test for
      prepared_stmt_count being decreased when some connection that had
      prepared statements is closed.
      
      
      mysql-test/r/ps.result:
        Update result for bug#16365 and bug#23159.
      mysql-test/t/ps.test:
        Update test case for bug#16365 and bug#23159: add test for
        prepared_stmt_count being decreased when some connection that had
        prepared statements is closed.
      sql/mysqld.cc:
        Use mutex when reading prepared_stmt_count global status variable.
      5e1c2e36
    • unknown's avatar
      Polishing: use the same coding style everywhere. · 817c6a4f
      unknown authored
      817c6a4f
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug23159 · 8b4a32af
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug23159
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        SCCS merged
      8b4a32af
    • unknown's avatar
      Fix after manual merge. · fdc37f06
      unknown authored
      
      mysql-test/r/ps.result:
        Fix after manual merge: update for different error message.
      mysql-test/t/ps.test:
        Fix after manual merge: use right error codes.
      fdc37f06
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug23159 · 596e29c2
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug23159
      
      
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      sql/mysqld.cc:
        Manual merge.
      sql/set_var.cc:
        Manual merge.
      596e29c2
    • unknown's avatar
      BUG#23159: prepared_stmt_count should be status variable · 7a45fb54
      unknown authored
      Make Prepared_stmt_count a global status variable, accessible via
      SHOW STATUS LIKE 'Prepared_stmt_count';.  Documentation should be
      updated.
      
      
      mysql-test/r/ps.result:
        Update result for bug#16365: Prepared Statements: DoS with too many
        open statements, according to bug#23159: prepared_stmt_count should be
        status variable.
      mysql-test/t/ps.test:
        Update test case for bug#16365: Prepared Statements: DoS with too many
        open statements, according to bug#23159: prepared_stmt_count should be
        status variable.
      sql/mysqld.cc:
        Add Prepared_stmt_count as global status variable.
      sql/set_var.cc:
        Remove prepared_stmt_count as system variable.
      7a45fb54