1. 27 Nov, 2008 2 commits
    • vasil's avatar
      branches/zip: · bac162c0
      vasil authored
      * Remove a change from win-plugin/win-plugin.diff about time_t because
        MySQL has used VS2005 for building 5.1.30.
      
      * Adjust the line numbers so the patch applies cleanly without fuzz and
        offset messages.
      
      Submitted by:	Calvin
      bac162c0
    • vasil's avatar
      branches/zip: · 7e69242a
      vasil authored
      Fix Mantis issue#130 wdl: does not handle 64-bit address
      
      - Change the call from strtoul() to strtoull()
      - Change "%16X" to "%16llx" when scanning preferred load address
      
      rb://58
      
      Submitted by:	Calvin
      Approved by:	Marko
      7e69242a
  2. 26 Nov, 2008 1 commit
    • marko's avatar
      branches/zip: row_merge_drop_temp_indexes(): Replace the WHILE 1 with · 6825b6f7
      marko authored
      WHILE 1=1 in the SQL procedure, so that the loop will actually be
      entered and temporary indexes be dropped during crash recovery.
      Thanks to Sunny Bains for pointing this out.
      
      Tested as follows:
      
      Set a breakpoint in row_merge_rename_indexes.
      
      CREATE TABLE t(a INT)ENGINE=InnoDB;
      CREATE INDEX a ON t(a);
      
      -- The breakpoint will be reached.  Kill and restart mysqld.
      SHOW CREATE TABLE t;
      -- This shows the MySQL .frm file, without and index.
      CREATE TABLE innodb_table_monitor(a INT)ENGINE=InnoDB;
      -- This will dump the InnoDB dictionary to the error log, without the index.
      6825b6f7
  3. 24 Nov, 2008 1 commit
  4. 21 Nov, 2008 3 commits
  5. 20 Nov, 2008 3 commits
  6. 19 Nov, 2008 1 commit
  7. 17 Nov, 2008 2 commits
    • michael's avatar
      branches/zip: rb://53 · d9ff256f
      michael authored
      Final version of rb://53, fixes the styling of a comment, makes
      the definition and the declaration of thd_supports_xa() identical commentwise.
      d9ff256f
    • michael's avatar
      branches/zip: · f1030783
      michael authored
      rb://53
      
      Improve innodb_supports_xa system variable handling and 
      reduces the number of retrievals of the value from MySQL.
      
      Approved by: Marko, over IM
      f1030783
  8. 12 Nov, 2008 2 commits
  9. 11 Nov, 2008 1 commit
    • marko's avatar
      branches/zip: ha_innobase::create(): Remove the dependences on · eaff0f3b
      marko authored
      DICT_TF_ZSSIZE_MAX, so that the code can be compiled with a different
      uncompressed page size by redefining UNIV_PAGE_SIZE_SHIFT in univ.i.
      Currently, the allowed values are 12, 13, or 14 (4k, 8k, 16k).
      
      Make the default compressed page size half the uncompressed page size.
      The previous default was 8 kilobytes, which is the same when compiling
      with the default 16k uncompressed page size.
      
      rb://50 approved by Pekka Lampio and Sunny Bains.
      eaff0f3b
  10. 04 Nov, 2008 2 commits
    • calvin's avatar
      branches/zip: windows plugin - fix references to array variables. · a33bdbe7
      calvin authored
      This problem surfaced when running new test innodb_bug40360.test. Both
      tx_isolation_names and binlog_format_names are name arrays, and
      should be defined as wdl_tx_isolation_names and wdl_binlog_format_names,
      not *wdl_tx_isolation_names and *wdl_binlog_format_names.
      
      Another array variable is all_charsets, which is already correctly
      defined.
      
      Approved by:	Marko (on IM)
      a33bdbe7
    • calvin's avatar
      branches/zip: ignore the failure when builtin_innobase_plugin is not · 1ec01d34
      calvin authored
      available.
      
      External variable builtin_innobase_plugin is not available when mysqld
      does not have a builtin InnoDB. The init of the Windows plugin should
      not fail in this case. 
      
      Approved by:	Marko (on IM)
      1ec01d34
  11. 31 Oct, 2008 8 commits
    • marko's avatar
      branches/zip: scripts/install_innodb_plugins_win.sql: New script, · 0746887e
      marko authored
      for installing the InnoDB plugins in Windows.  Copied from
      scripts/install_innodb_plugins.sql.
      0746887e
    • vasil's avatar
      branches/zip: · ca101da6
      vasil authored
      White-space cleanup in ChangeLog.
      ca101da6
    • vasil's avatar
      branches/zip: · f1c0cbb3
      vasil authored
      Fix Mantis issue#106 plugin init error:InnoDB: stats_on_metadata in static
      InnoDB (flags=0x2401) differs from stats_on_metadata in dynamic InnoDB (fl
      
      Ignore the NOSYSVAR flag in addition to ignoring the READONLY flag.
      
      Approved by:	Marko (https://svn.innodb.com/rb/r/42/)
      f1c0cbb3
    • calvin's avatar
      branches/zip: Windows plugin part of r2944 · bc76416c
      calvin authored
      r2944 has reference to mysql_bin_log.is_open(), which is new in InnoDB.
      Add two new entries and remove one duplicate in mysqld.def & 
      mysqld_x64.def.
      bc76416c
    • marko's avatar
    • sunny's avatar
      branches/zip: Update ChangeLog with r2943 info. · 3052e243
      sunny authored
      3052e243
    • vasil's avatar
      branches/zip: · 2d445bb4
      vasil authored
      Revert our temporary fix for "Bug#40360 Binlog related errors with binlog off"
      (r2935, r2936) and deploy MySQL's one, but put the function
      mysql_bin_log_is_engaged() inside mysql_addons.cc instead of in mysql's log.cc
      and use a different name for it so there is no collision when MySQL adds this
      function in log.cc.
      
      [note from the future: the windows part of this patch went into r2947]
      
      Approved by:	Marko (https://svn.innodb.com/rb/r/41/)
      2d445bb4
    • sunny's avatar
      branches/zip: · cb290201
      sunny authored
        1. We add a vector of locks to trx_t. This array contains the autoinc
        locks granted to a transaction. There is one per table.
      
        2. We enforce releasing of these locks in the reverse order from the
        one in which they are acquired. The assumption is that since the
        AUTOINC locks are statement level locks. Nested statements introduced
        by triggers are stacked it should hold.
      
      There was some cleanup done to the vector code too by adding const and
      some new functions. Rename dict_table_t::auto_inc_lock to autoinc_lock.
      
      Fix Bug#26316 Triggers create duplicate entries on auto-increment columns
      rb://22
      cb290201
  12. 30 Oct, 2008 7 commits
    • vasil's avatar
      branches/zip: · 6837174e
      vasil authored
      Increment the InnoDB Plugin version from 1.0.1 to 1.0.2.
      6837174e
    • marko's avatar
      f2c201c5
    • marko's avatar
    • vasil's avatar
      branches/zip: · 0ae10e23
      vasil authored
      Non-functional change: convert handler/handler0vars.h and
      handler/win_delay_loader.cc from \r\n (dos) to \n (unix) line terminators.
      0ae10e23
    • vasil's avatar
      branches/zip: · 4a2eb4a8
      vasil authored
      Add ChangeLog entry for Bug#40360 Binlog related errors with binlog off
      4a2eb4a8
    • vasil's avatar
      branches/zip: · 26bf890d
      vasil authored
      Followup to r2935: add the Windows Delay Loader stuff for the MySQL
      variable that we are accessing. If someday we have another solution for
      Bug#40360 Binlog related errors with binlog off
      then this should also be reverted.
      26bf890d
    • vasil's avatar
      branches/zip: · 8c5b85dd
      vasil authored
      Fix "Bug#40360 Binlog related errors with binlog off" in InnoDB code in order
      to have a Bug#40360-free InnoDB Plugin 1.0.2.
      
      The fix does check whether binary logging is enabled in MySQL by accessing the
      opt_bin_log global variable that is defined in sql/mysqld.cc.
      
      In case MySQL does develop another solution to this via Bug#40360 then we can
      revert this patch (except the mysql-tests).
      
      The windows-plugin part of this fix will be committed as a separate commit to
      ease eventual merge into branches/5.1 [note from the future: the separate
      commit went into r2936].
      
      Approved by:	Marko (https://svn.innodb.com/rb/r/39)
      8c5b85dd
  13. 29 Oct, 2008 7 commits
    • vasil's avatar
      branches/zip: · fe97ea6f
      vasil authored
      Add 2 ChangeLog entries for the 2 bugfixes that were merged from branches/5.1.
      fe97ea6f
    • marko's avatar
      branches/zip: Merge revisions 2854:2929 from branches/5.1, · 9d2fe138
      marko authored
      except r2924, which was merged from branches/zip r2866 to branches/5.1
      and except r2879 which was merged separately by Calvin:
      
        ------------------------------------------------------------------------
        r2902 | vasil | 2008-10-28 12:10:25 +0200 (Tue, 28 Oct 2008) | 10 lines
      
        branches/5.1:
      
        Fix Bug#38189 innodb_stats_on_metadata missing
      
        Make the variable innodb_stats_on_metadata visible to the users and
        also settable at runtime. Previously it was only "visible" as a command
        line startup option to mysqld.
      
        Approved by:    Marko (https://svn.innodb.com/rb/r/36)
        ------------------------------------------------------------------------
        r2929 | marko | 2008-10-29 21:26:14 +0200 (Wed, 29 Oct 2008) | 13 lines
      
        branches/5.1: dtype_get_sql_null_size(): return the correct storage
        size of a SQL NULL column. (Bug #40369)
      
        When MySQL Bug #20877 was fixed in r834, this function was
        accidentally modified to return 0 or 1. Apparently, the only impact of
        this bug is that fixed-length columns cannot be updated in-place from
        or to SQL NULL, even in ROW_FORMAT=REDUNDANT.  After this fix,
        fixed-length columns in ROW_FORMAT=REDUNDANT will have a constant
        storage size as they should, no matter if NULL or non-NULL.  The bug
        caused fixed-length NULL columns to occupy 1 byte.
      
        rb://37 approved by Heikki over IM.
        ------------------------------------------------------------------------
      9d2fe138
    • michael's avatar
      Remove unnecessary assert · 4c7b3cb7
      michael authored
      Approved by: Heikki, over IM
      4c7b3cb7
    • marko's avatar
      branches/zip: ha_innodb.cc: Make some functions static, so that they will · f3d875b2
      marko authored
      not be compiled as weak global symbols.  These functions must not be
      redirected to the built-in InnoDB.
      f3d875b2
    • calvin's avatar
      branches/zip: change function names in sql/mysqld.def in order · 0981c79d
      calvin authored
      to work with 5.1.29-rc.
      
      In 5.1.29, the following function names are changed:
        _hash_init
        hash_free
        hash_search
        hash_delete
      
      changed to
        _my_hash_init
        my_hash_free
        my_hash_search
        my_hash_delete
      
      Approved by:	Marko (on IM)
      0981c79d
    • marko's avatar
      branches/zip: ChangeLog: Mention Bug #27276. · 97ffec74
      marko authored
      97ffec74
    • calvin's avatar
      branches/zip: fix issue #102 - Windows plugin: resolve dbug functions · ca0f9648
      calvin authored
      during run-time.
      
      Implement wrapper functions in the plugin. The plugin will get the
      function entries from mysqld.exe during the init, and invoke the
      corresponding functions (in mysqld.exe). The list of functions are:
      
      	_db_pargs_
      	_db_doprnt_
      	_db_enter_
      	_db_return_
      	_db_dump_
      
      rb://38
      
      Approved by:	Marko
      ca0f9648