1. 23 Jun, 2007 2 commits
  2. 22 Jun, 2007 1 commit
    • unknown's avatar
      Fix for bug #29079: Semantics of "bigint" depend on platform specifics (size, signedness of char ?) · ae587cfb
      unknown authored
      Problem: long and long long types mess in a comparison may lead to wrong results on some platforms.
      Fix: prefer [unsigned] long long as [u]longlong as it's used unconditionally in many places.
      
      
      include/my_global.h:
        Fix for bug #29079: Semantics of "bigint" depend on platform specifics (size, signedness of char ?)
          - use [unsigned] long long as [u]longlong if sizeof(long long) == 8, to avoid type mess,
            as we use [unsigned] long long unconditionally in many places, for example in constants 
            with [U]LL suffix.
      ae587cfb
  3. 19 Jun, 2007 9 commits
  4. 18 Jun, 2007 14 commits
    • unknown's avatar
      Bug #28921 Queries containing UDF functions are cached · 5941479e
      unknown authored
      Fixed runtime to no longer allow the caching of queries with UDF calls.
      
      
      mysql-test/r/udf.result:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      mysql-test/t/udf.test:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      sql/sql_yacc.yy:
        Fixed code to set safe_to_cache_query=0 regardless if the function call is a UDF or SP. Where it was placed previously -- at the very end of the else testing for UDFs -- it only executed the statement if the function call was a stored procedure call.
      5941479e
    • unknown's avatar
      Bug #29053 SQL_CACHE in UNION causes non-deterministic functions to be cached · 2a9bb274
      unknown authored
      Changed code to enforce that SQL_CACHE only in the first SELECT is used to turn on caching(as documented), but any SQL_NO_CACHE will turn off caching (not documented, but a useful behaviour, especially for machine generated queries). Added test cases to explicitly test the documented caching behaviour and test cases for the reported bug. 
      
      
      mysql-test/r/query_cache.result:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      mysql-test/t/query_cache.test:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      sql/sql_yacc.yy:
        Added an explicit check to make sure "SELECT SQL_CACHE" only works on the first select in a query.
        
        The parser will always hit the outermost SELECT first, and if the SQL_CACHE option is found it sets the safe_to_query flag in the lex. Then, if there are subseqent "uncachable" subqueries or functions, as it parses those elements it sets the safe_to_query to 0. However, this cause problems if nested SELECTs also used the SQL_CACHE option, because then it would set back safe_to_query to 1, even though there are uncacheable expressions previously parsed.
        
        By adding the check to ensure only the first SELECT can turn caching on, it means a subsequent SQL_CACHE option can't turn caching back on after a uncacheable subsequery was already encountered.
      2a9bb274
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/50 · e09b329b
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      configure.in:
        Auto merged
      e09b329b
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 1919b308
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      1919b308
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/51 · 40f6e9a6
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      40f6e9a6
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 34a55d77
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      34a55d77
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/41 · bf398091
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      
      configure.in:
        Auto merged
      bf398091
    • unknown's avatar
      Sdditional fix-up for bug #26380: LOCK TABLES + FLUSH LOGS causes deadlock · b2f86cd5
      unknown authored
      FLUSH LOGS should ignore SET GLOBAL READ_ONLY.
      
      
      sql/lock.cc:
        Sdditional fix-up for bug #26380: LOCK TABLES + FLUSH LOGS causes deadlock
          - ignore SET GLOBAL READ_ONLY if MYSQL_LOCK_IGNORE_GLOBAL_READ_ONLY is set.
      sql/mysql_priv.h:
        Sdditional fix-up for bug #26380: LOCK TABLES + FLUSH LOGS causes deadlock
          - MYSQL_LOCK_IGNORE_GLOBAL_READ_ONLY added.
      sql/sql_base.cc:
        Sdditional fix-up for bug #26380: LOCK TABLES + FLUSH LOGS causes deadlock
          - ignore SET GLOBAL READ_ONLY as well if called form a logger.
      b2f86cd5
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/merge/mysql-5.0-engines · 1140898b
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/merge/mysql-5.1-engines
      
      
      1140898b
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.1 · 5504ca39
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/merge/mysql-5.1-engines
      
      
      configure.in:
        Auto merged
      5504ca39
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4831826c
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/merge/mysql-5.0-engines
      
      
      4831826c
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 · 39481ed4
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      39481ed4
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1 · 4b4c887a
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      configure.in:
        Auto merged
      4b4c887a
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0 · fe99cf3a
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0
      
      
      fe99cf3a
  5. 17 Jun, 2007 14 commits