An error occurred fetching the project authors.
  1. 10 Nov, 2007 16 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · be948d04
      unknown authored
      into  mysql.com:/scratch/tnurnberg/31700/51-31700
      
      
      sql/sql_select.cc:
        Auto merged
      be948d04
    • unknown's avatar
      Bug#31700: thd->examined_row_count not incremented for 'const' type queries · c0fb459a
      unknown authored
      add 5.1-specific test showing that 'const' access increments 'examined'
      counter in slow query log.
      
      
      mysql-test/r/log_tables.result:
        5.1-only test showing that 'const' access increments counters
      mysql-test/t/log_tables.test:
        5.1-only test showing that 'const' access increments counters
      c0fb459a
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · f60c55ea
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      f60c55ea
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32202/my51-bug26215 · 34c3b687
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      34c3b687
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32202/my50-bug26215 · 04468cba
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      04468cba
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32202/my50-bug26215 · c30eb25a
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32202/my51-bug26215
      
      
      mysql-test/r/group_by.result:
        Manual merge.
      mysql-test/t/group_by.test:
        Manual merge.
      sql/sql_select.cc:
        Manual merge.
      c30eb25a
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 40eaa33c
      unknown authored
      into  mysql.com:/home/hf/work/31893/my51-31893
      
      
      40eaa33c
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31700/50-31700 · b25bf95f
      unknown authored
      into  mysql.com:/misc/mysql/31700/51-31700
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        manual merge
      b25bf95f
    • unknown's avatar
      Bug#31700: thd->examined_row_count not incremented for 'const' type queries · a41b4763
      unknown authored
      UNIQUE (eq-ref) lookups result in table being considered as a "constant" table.
      Queries that consist of only constant tables are processed in do_select() in a
      special way that doesn't invoke evaluate_join_record(), and therefore doesn't
      increase the counters join->examined_rows and join->thd->row_count.
      
      The patch increases these counters in this special case.
      
      NOTICE:
      This behavior seems to contradict what the documentation says in Sect. 5.11.4:
      "Queries handled by the query cache are not added to the slow query log, nor
      are queries that would not benefit from the presence of an index because the
      table has zero rows or one row."
      
      No test case in 5.0 as issue shows only in slow query log, and other counters
      can give subtly different values (with regard to counting in create_sort_index(),
      synthetic rows in ROLLUP, etc.).
      
      
      sql/sql_class.h:
        add documentation for some variables
      sql/sql_select.cc:
        Don't forget const tables when counting read records!
      a41b4763
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · a72ec638
      unknown authored
      into  mysql.com:/misc/mysql/31800/51-31800
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      a72ec638
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6b00e6eb
      unknown authored
      into  mysql.com:/scratch/tnurnberg/31800/50-31800
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      6b00e6eb
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31800/50-31800 · 91ceabf3
      unknown authored
      into  mysql.com:/misc/mysql/31800/51-31800
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      91ceabf3
    • unknown's avatar
      Bug#31800: Date comparison fails with timezone and slashes for greater than comparison · ac3ef6c7
      unknown authored
      BETWEEN was more lenient with regard to what it accepted as a DATE/DATETIME
      in comparisons than greater-than and less-than were. ChangeSet makes < >
      comparisons similarly robust with regard to trailing garbage (" GMT-1")
      and "missing" leading zeros. Now all three comparators behave similarly
      in that they throw a warning for "junk" at the end of the data, but then
      proceed anyway if possible. Before < > fell back on a string- (rather than
      date-) comparison when a warning-condition was raised in the string-to-date
      conversion. Now the fallback only happens on actual errors, while warning-
      conditions still result in a warning being to delivered to the client.
      
      
      mysql-test/r/select.result:
        Show that we compare DATE/DATETIME-like strings as date(time)s
        now, rather than as bin-strings.
        Adjust older result as "2005-09-3a" is now correctly seen as
        "2005-09-3" + trailing garbage, rather than as "2005-09-30".
      mysql-test/t/select.test:
        Show that we compare DATE/DATETIME-like strings as date(time)s
        now, rather than as bin-strings.
      sql-common/my_time.c:
        correct/clarify date-related comments, particulary for check_date().
        doxygenize comment while at it.
      sql/item_cmpfunc.cc:
        get_date_from_str() no longer signals an error when all we had
        was a warning-condition -- and one we already gave the user a
        warning for at that. Preamble doxygenized.
      ac3ef6c7
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · c3e41709
      unknown authored
      into  mysql.com:/misc/mysql/31990/51-31990
      
      
      c3e41709
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e9a78d8c
      unknown authored
      into  mysql.com:/misc/mysql/31990/50-31990
      
      
      e9a78d8c
    • unknown's avatar
      Merge mysql.com:/misc/mysql/31990/50-31990 · 3e90d418
      unknown authored
      into  mysql.com:/misc/mysql/31990/51-31990
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/t/cast.test:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      3e90d418
  2. 09 Nov, 2007 6 commits
    • unknown's avatar
      Fix for bug #32202: ORDER BY not working with GROUP BY · 55499d2b
      unknown authored
      The bug is a regression introduced by the fix for bug30596. The problem
      was that in cases when groups in GROUP BY correspond to only one row,
      and there is ORDER BY, the GROUP BY was removed and the ORDER BY
      rewritten to ORDER BY <group_by_columns> without checking if the
      columns in GROUP BY and ORDER BY are compatible. This led to
      incorrect ordering of the result set as it was sorted using the
      GROUP BY columns. Additionaly, the code discarded ASC/DESC modifiers
      from ORDER BY even if its columns were compatible with the GROUP BY
      ones.
      
      This patch fixes the regression by checking if ORDER BY columns form a
      prefix of the GROUP BY ones, and rewriting ORDER BY only in that case,
      preserving the ASC/DESC modifiers. That check is sufficient, since the
      GROUP BY columns contain a unique index.
      
      
      mysql-test/r/group_by.result:
        Added a test case for bug #32202.
      mysql-test/t/group_by.test:
        Added a test case for bug #32202.
      sql/sql_select.cc:
        In cases when groups in GROUP BY correspond to only one row and there
        is ORDER BY, rewrite the query to ORDER BY <group_by_columns> only if
        the columns in ORDER BY and GROUP BY are compatible, i.e. either one
        forms a prefix for another.
      55499d2b
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · dacae0dc
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_udf.cc:
        Auto merged
      dacae0dc
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32020/my51-bug31445 · e3278b8c
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_udf.cc:
        Auto merged
      e3278b8c
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32020/my50-bug31445 · e68540a6
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      sql/sql_udf.cc:
        Auto merged
      e68540a6
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32020/my50-bug31445 · 0280133a
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32020/my51-bug31445
      
      
      mysql-test/r/skip_grants.result:
        Auto merged
      mysql-test/t/skip_grants.test:
        Auto merged
      sql/sql_udf.cc:
        Auto merged
      0280133a
    • unknown's avatar
      Fix for bug #32020: loading udfs while --skip-grant-tables is enabled · 737cdfea
      unknown authored
      causes out of memory errors
      
      The code in mysql_create_function() and mysql_drop_function() assumed
      that the only reason for UDFs being uninitialized at that point is an
      out-of-memory error during initialization. However, another possible 
      reason for that is the --skip-grant-tables option in which case UDF 
      initialization is skipped and UDFs are unavailable.
      
      The solution is to check whether mysqld is running with
      --skip-grant-tables and issue a proper error in such a case.
      
      
      mysql-test/r/skip_grants.result:
        Added a test case for bug #32020.
      mysql-test/t/skip_grants.test:
        Added a test case for bug #32020.
      sql/sql_udf.cc:
        Issue a proper error when a user tries to CREATE/DROP a UDF 
        on a server running with the --skip-grant-tables option.
      737cdfea
  3. 08 Nov, 2007 8 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · b56f1c16
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      b56f1c16
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my51-bug26215 · 5a98d8aa
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      5a98d8aa
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-4.1-opt · a5d7fa74
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      a5d7fa74
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my50-bug26215 · 0075aa49
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      0075aa49
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my41-bug26215 · 6c5a2e50
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-4.1-opt
      
      
      6c5a2e50
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my50-bug26215 · fcddc280
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32103/my51-bug26215
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/item.h:
        Auto merged
      fcddc280
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my41-bug26215 · 4713575c
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32103/my50-bug26215
      
      
      mysql-test/t/select.test:
        Auto merged
      mysql-test/r/select.result:
        Manual merge.
      sql/item.h:
        Manual merge.
      4713575c
    • unknown's avatar
      Bug#31990: MINUTE() and SECOND() return bogus results when used on a DATE · b1fc4b9e
      unknown authored
      HOUR(), MINUTE(), ... returned spurious results when used on a DATE-cast.
      This happened because DATE-cast object did not overload get_time() method
      in superclass Item. The default method was inappropriate here and
      misinterpreted the data.
      
      Patch adds missing method; get_time() on DATE-casts now returns SQL-NULL
      on NULL input, 0 otherwise. This coincides with the way DATE-columns
      behave.
      
      
      mysql-test/r/cast.result:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise.
        Show that this coincides with how DATE-columns behave.
      mysql-test/t/cast.test:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise.
        Show that this coincides with how DATE-columns behave.
      sql/item_timefunc.cc:
        Add get_time() method to DATE-cast object to overload
        the method in Item superclass that would return spurious
        results. Return zero-result; flag NULL if input was NULL.
      sql/item_timefunc.h:
        Add get_time() declaration to DATE-cast object.
      b1fc4b9e
  4. 07 Nov, 2007 3 commits
    • unknown's avatar
      Fix for bug #32103: optimizer crash when join on int and mediumint with · 0a7a55d1
      unknown authored
      variable in where clause.
      
      Problem: the new_item() method of Item_uint used an incorrect
      constructor. "new Item_uint(name, max_length)" calls
      Item_uint::Item_uint(const char *str_arg, uint length) which assumes the
      first argument to be the string representation of the value, not the
      item's name. This could result in either a server crash or incorrect
      results depending on usage scenarios.
      
      Fixed by using the correct constructor in new_item():
      Item_uint::Item_uint(const char *str_arg, longlong i, uint length).
      
      
      mysql-test/r/select.result:
        Added a test case for bug #32103.
      mysql-test/t/select.test:
        Added a test case for bug #32103.
      sql/item.h:
        Use the correct constructor for Item_uint in Item_uint::new_item().
      0a7a55d1
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug25421/my51-bug31445 · 6850e37d
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/opt_range.cc:
        Auto merged
      6850e37d
    • unknown's avatar
      Fix for bug #25421: MySQL threads don't respond to the kill command · dc0a59a2
      unknown authored
      Calculating the estimated number of records for a range scan may take a
      significant time, and it was impossible for a user to interrupt that
      process by killing the connection or the query.
      
      Fixed by checking the thread's 'killed' status in check_quick_keys() and
      interrupting the calculation process if it is set to a non-zero value.
      
      
      sql/opt_range.cc:
        Check the thread's 'killed' status in check_quick_keys() and
        interrupt the calculation process if it is set to a non-zero value.
      dc0a59a2
  5. 06 Nov, 2007 2 commits
  6. 05 Nov, 2007 5 commits