- 29 Nov, 2015 1 commit
-
-
Monty authored
This includes fixing all utilities to not have any memory leaks, as safemalloc warnings stopped tests from passing on MacOSX. - Ensure that all clients takes character-set-dir, as the libmysqlclient library will use it. - mysql-test-run now passes character-set-dir to all external clients. - Changed dynstr_free() so that it can be called twice (made freeing code easier) - Changed rpl_global_gtid_slave_state to be allocated dynamicly as it includes a mutex that needs to be initizlied/destroyed before my_end() is called. - Removed rpl_slave_state::init() and rpl_slave_stage::deinit() as their job are better handling by constructor and delete. - Print alias instead of table_name in check_duplicate_key as table_name may have been converted to lower case. Other things: - Fixed a case in time_to_datetime_with_warn() where we where using && instead of & in tests
-
- 27 Nov, 2015 1 commit
-
-
Monty authored
- Better error from check_slave_param - Better error message from TokuDB if it can't be compiled. - Marked rpl_mixed_drop_create_temp_table and rpl_stm_drop_create_temp_table as big tests to stop timeout failures on power8 - Added sync_slave_with_master to semisync_future-7591 to ensure that slave is up to date with master before calling rpl_end. - Disabled compiler warnings from connect and mroonga and on MacOSX. Mroonga: - Fixed bug when testing if file is a normal file that can be deleted - Marked a lot of date and datetime test to not run on macosx. This is because mktime() can't handle negative years and this restricts mroonga so that it can only store dates after the year 1900.
-
- 25 Nov, 2015 1 commit
-
-
Sergei Petrunia authored
warning in new gcc.
-
- 24 Nov, 2015 1 commit
-
-
Monty authored
- Added some extra command to rpl_start_stop to ensure that the IO thread has connected to the master before we shut down the server. - if signal returns signalhandler_t, use this with the alarm code - Added missing tests to sys_vars - Fixed some possible overflow bugs in tabxml.cpp
-
- 23 Nov, 2015 2 commits
- 19 Nov, 2015 1 commit
-
-
Sergei Golubchik authored
feedback was bzero-ing thd->status_vars.memory_used, but server was asserting the correct value of it
-
- 18 Nov, 2015 6 commits
-
-
Sergei Golubchik authored
-
Sergei Petrunia authored
RENAME TABLE code tries to update EITS statistics. It hung, because it used an index on (db_name,table_name) to find the table, and attempted to update these values at the same time. The fix is do what SQL UPDATE statement does when updating index that it's used for scanning: - First, buffer the rowids of rows to be updated, - then make the second pass to actually update the rows Also fixed the call to rename_table_in_stat_tables() in sql_rename.cc to pass the correct new database (before, it passed old db_name so cross- database renames were not handled correctly). Variant #2, with review feedback addressed.
-
Monty authored
rpl/rpl_mdev382 ; Wrong replace in show_binlog_events2.inc binlog/database ; Different error on Solaris if file exists mroonga/repair_table_no_index_file ; Different system error on Solaris partition_not_blackhole ; Different error on Solaris partition_myisam ; Different error on Solaris Some other failures in mroonga was because have_32bit.inc didn't correctly detect 64 bits on Solaris. Fixed using DEFAULT_MACHINE instead of MACHINE_TYPE for Sys_version_compile_machine.
-
Monty authored
-
Sergei Golubchik authored
feedback plugin needs to set tables->select_lex properly
-
Sergei Golubchik authored
make it possible to change feedback plugin wait intervals * only in debug builds * and force the feedback report to be ignored update the test to use this feature
-
- 17 Nov, 2015 2 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
- 14 Nov, 2015 2 commits
-
-
Kristian Nielsen authored
-
Monty authored
-
- 13 Nov, 2015 7 commits
-
-
Monty authored
Bug was that ReplSemiSyncMaster::commitTrx() was waiting on a condition for state to change, but didn't take into account that one could have disabled semi-sync during the wait.
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
Problem is that FLUSH TABLES WITH READ LOCK first blocks threads from starting new commits, then waits for running commits to complete. But in-order parallel replication needs commits to happen in a particular order, so this can easily deadlock. To fix this problem, this patch introduces a way to temporarily pause the parallel replication worker threads. Before starting FTWRL, we let all worker threads complete in-progress transactions, and then wait. Then we proceed to take the global read lock. Once the lock is obtained, we unpause the worker threads. Now commits are blocked from starting by the global read lock, so the deadlock will no longer occur.
-
Kristian Nielsen authored
Preparation patch, moving the GCO wait into a separate function, in preparation for adding a separate wait phase for FLUSH TABLES WITH READ LOCK.
-
Kristian Nielsen authored
Before, the Seconds_behind_master was updated already when an event was queued for a worker thread to execute later. This might lead users to interpret a low value as the slave being almost up to date with the master, while in reality there might still be lots and lots of events still queued up waiting to be applied by the slave. See https://lists.launchpad.net/maria-developers/msg08958.html for more detailed discussions.
-
- 12 Nov, 2015 3 commits
-
-
Sergei Petrunia authored
-
Monty authored
-
Monty authored
Patch backported from MariaDB 10.1 - Ensure that we wait with cleanup() until slave thread has stopped. - Added signal_thd_deleted() to signal close_connections() that all THD's has been freed. Other things - Removed not needed calls to THD_CHECK_SENTRY() when we are calling 'delete thd'.
-
- 11 Nov, 2015 1 commit
-
-
root authored
-
- 10 Nov, 2015 1 commit
-
-
Vladislav Vaintroub authored
Fix : make sure that database name is converted to lowercase in check_fk_parent_table_access(), if lowercase_table_names !=0
-
- 09 Nov, 2015 4 commits
-
-
Oleksandr Byelkin authored
View/derived fields should be taken into account when we build ref_pointer_array constructed. DBUG_ASSERTs added to avoid memory overrun.
-
Sergei Petrunia authored
Patch from Daniel Black: - Change the charset of mysql.column_stats.{min_value, max_value} from utf8_bin varchar to varbinary - Adjust the code that saves/reads the data accordingly. - Also provide upgrade statement in mysql_system_tables_fix.sql
-
Vladislav Vaintroub authored
pre/CMakeLists.txt defines CMAKE_DEBUG_POSTFIX which causes a different library name on Windows debug build (pcred.lib rather than pre.lib) However MERGE_LIBRARIES macro that is used to create static embedded library (out of other static libraries), can not handle per-configuration library names. Thus the build fails with "pre.lib not found" Fix is to remove unnecessary CMAKE_DEBUG_POSTFIX
-
Jan Lindström authored
Improved warning messages by quote marks.
-
- 06 Nov, 2015 3 commits
-
-
Oleksandr Byelkin authored
MDEV-8938 Server Crash on Update with joins Make unique table check after setup_fields of update because unique table can materialize table and we do not need field resolving after materialization.
-
Vladislav Vaintroub authored
Fix build failures caused by new C runtime library - isnan, snprintf, struct timespec are now defined, attempt to redefine them leads - P_tmpdir, tzname are no more defined - lfind() and lsearch() in lf_hash.c had to be renamed, declaration conflicts with some C runtime functions with the same name declared in a header included by stdlib.h Also fix couple of annoying warnings : - remove #define NOMINMAX from config.h to avoid "redefined" compiler warnings(NOMINMAX is already in compile flags) - disable incremental linker in Debug as well (feature not used much and compiler crashes often) Also simplify package building with Wix, require Wix 3.9 or later (VS2015 is not compatible with old Wix 3.5/3.6)
-
Alexander Barkov authored
When compiled with "-Wl,-Bsymbolic-functions" flags (e.g. when building a .deb package on Ubuntu) with TokuDB and jemalloc, mysqld crashed in toku_get_processor_frequency_cpuinfo() when free()-ing a buffer returned by getline(). getline() uses libc malloc() internally, while free() is aliased to jemalloc's free() in this configuration. Fixing not to use getline(). Using a static buffer instead.
-
- 05 Nov, 2015 2 commits
-
-
Oleksandr Byelkin authored
Make unique table check after setup_fields of update because unique table can materialize table and we do not need field resolving after materialization.
-
Vladislav Vaintroub authored
Replaced my_connect() with cross-plattform, timeout aware vio_socket_connect() function
-
- 03 Nov, 2015 1 commit
-
-
Vladislav Vaintroub authored
The regression is caused by change bind-address server parameter in MDEV-8083, so now server listens on IPv4 only by default. The problem however is that on Windows, connection to server on localhost appears to be much faster, if server listens on IPv6/dual stack. mysql_real_connect() would try to connect to IPv6 loopback first, and if this fails, the failing connect() call takes several seconds. To fix, use bind-address=* on Windows, and 127.0.0.1 elsewhere
-
- 30 Oct, 2015 1 commit
-
-
Oleksandr Byelkin authored
MDEV-8913 Derived queries with same column names as final projection causes issues when using Order By find_item_in_list() now recognize view fields like a fields even if they rever to an expression. The problem of schema name do not taken into account for field with it and derived table fixed. Duplicating code removed
-