1. 10 Dec, 2009 5 commits
  2. 09 Dec, 2009 2 commits
  3. 08 Dec, 2009 4 commits
    • Magne Mahre's avatar
      Bug#35589 SET PASSWORD caused a crash · 0eb255ee
      Magne Mahre authored
      Bug#35591 FLUSH PRIVILEGES caused a crash
      
      A race condition on the privilege hash tables (proc_priv_hash
      and func_priv_hash) caused one thread to try to delete elements
      that had already been deleted by another thread.
      
      The bug was caused by reading and saving the pointers to 
      the hash tables outside mutex protection.  This led to an
      inconsistency where a thread copied a pointer to a hash,
      another thread did the same, the first thread then deleted
      the hash, and the second then crashed when it in turn tried to
      delete the deleted hash.
      
      The fix is to ensure that operations on the shared hash structures
      happens under mutex protection (moving the locking up a little)
      
      
      0eb255ee
    • V Narayanan's avatar
      merging with mysql-next-mr-svoj · acacdb9e
      V Narayanan authored
      acacdb9e
    • V Narayanan's avatar
      merging with mysql-next-mr-svoj · dc43549f
      V Narayanan authored
      dc43549f
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-next-mr. · 6fd3866c
      Alexander Nozdrin authored
      6fd3866c
  4. 07 Dec, 2009 4 commits
    • He Zhenxing's avatar
      Auto merge · 48053751
      He Zhenxing authored
      48053751
    • Sergey Vojtovich's avatar
      WL#2511 - Add a new table to the Information Schema for TABLESPACE's · e8d01684
      Sergey Vojtovich authored
      Implemented a new INFORMATION_SCHEMA table, which is intended to
      provide information about tablespaces.
      
      mysql-test/r/information_schema.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/r/information_schema_db.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/r/mysqlshow.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/suite/funcs_1/r/is_tables_is.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      sql/handler.h:
        Added SCH_TABLESPACES to enum_schema_tables.
      sql/mysql_priv.h:
        Added human readable definitions for I_S.TABLESPACES field
        identifiers.
      sql/sql_show.cc:
        Added I_S.TABLESPACES schema. The code which handles I_S.FILES
        is capable to handle I_S.TABLESPACES as well. Thus we reuse
        this code and let functions/variables have more generic names.
      e8d01684
    • Alexander Barkov's avatar
      Bug#47756 Setting 2byte collation ID with 'set names' crashes the server · 164c7df5
      Alexander Barkov authored
      The problem is not actually related to 2byte collation IDs.
      The same crash happens if you change the collation ID in
      mysql-test/str_data/Index.xml to a value smaller than 256.
      
      Crash happened in SQL parser, because the "ident_map" and "state_map"
      arrays were not initialized in loadable utf8 collations.
      
      Fix: adding proper initialization of the "ident_map" and "state_map"
      members for loadable utf8 collations.
      164c7df5
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-next-mr. · a8e80f31
      Alexander Nozdrin authored
      a8e80f31
  5. 05 Dec, 2009 3 commits
  6. 04 Dec, 2009 9 commits
  7. 03 Dec, 2009 6 commits
    • V Narayanan's avatar
      Bug#40814 CSV engine does not parse \X characters when they occur in unquoted fields · a5aa3b3c
      V Narayanan authored
          
      When a .CSV file for table in the CSV engine contains
      \X characters as part of unquoted fields, e.g.
          
      2,naraya\nan
          
      \n is not interpreted as a new line (it is however interpreted as a
      newline in a quoted field).
          
      The old algorithm copied the entire value for a unquoted field without
      parsing the \X characters. 
          
      The new algorithm adds the capability to handle \X characters in the 
      unquoted fields of a .CSV file.
      
      mysql-test/r/csv.result:
        Bug#40814 CSV engine does not parse \X characters when they occur in unquoted fields
        
        Contains additional test output corresponding to the new 
        tests added.
      mysql-test/t/csv.test:
        Bug#40814 CSV engine does not parse \X characters when they occur in unquoted fields
        
        Contains additional tests for testing the behaviour of the CSV 
        storage engine when the fields are not enclosed in quotes and
        contain \X characters.
      storage/csv/ha_tina.cc:
        Bug#40814 CSV engine does not parse \X characters when they occur in unquoted fields
        
        Changes the parsing logic of the rows in a CSV file, to parse
        \X characters that might be present in the unquoted fields.
      a5aa3b3c
    • V Narayanan's avatar
      WL#4454 change sql_insert.cc::last_uniq_key to match keys in any order · 21aaf8dd
      V Narayanan authored
      Introduce a flag that will enable the REPLACE
      command to work correctly with an underlying
      storage engine that does not report unique key
      conflicts in the ascending order.
      
      sql/handler.h:
        WL#4454 change sql_insert.cc::last_uniq_key to match keys in any order
        
        Adds the flag that will be set by a
        SE that does not report unique key
        conflicts in the ascending order.
      sql/sql_insert.cc:
        WL#4454 change sql_insert.cc::last_uniq_key to match keys in any order
        
        modifies the function used for a last row
        replace optimization to check for the
        HA_DUPLICATE_KEY_NOT_IN_ORDER flag.
      21aaf8dd
    • Konstantin Osipov's avatar
      Merge next-mr -> next-mr-runtime · 94f25504
      Konstantin Osipov authored
      94f25504
    • V Narayanan's avatar
      WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table · e86daf9b
      V Narayanan authored
      The attached patch adds a method
      handlerton::fill_is_table that can be used
      instead of having to create specific
      handlerton::fill_*_table methods.
      
      sql/ha_ndbcluster.cc:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        Implemented the method ndbcluster_fill_is_table
        that uses the supplied table id to switch to the
        appropriate fill_*_table method.
      sql/handler.h:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        Moved the enum_schema_table enumeration
        from table.h to here. 
        
        contains the declaration for the new method
        fill_is_tables.
      sql/sql_show.cc:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        calls the fill_is_table method instead of the
        fill_files_table method.
      sql/table.h:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        removed the earlier definition of enum_schema_tables.
      e86daf9b
    • Marc Alff's avatar
      560e76c5
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-next-mr. · 87bd812f
      Alexander Nozdrin authored
      87bd812f
  8. 02 Dec, 2009 6 commits
  9. 01 Dec, 2009 1 commit
    • Evgeny Potemkin's avatar
      Bug#33546: Slowdown on re-evaluation of constant expressions. · 987e1466
      Evgeny Potemkin authored
            
      Constant expressions in WHERE/HAVING/ON clauses aren't cached and evaluated
      for each row. This causes slowdown of query execution especially if constant
      UDF/SP function are used.
            
      Now WHERE/HAVING/ON expressions are analyzed in the top-bottom direction with
      help of the compile function. When analyzer meets a constant item it
      sets a flag for the tree transformer to cache the item and doesn't allow tree
      walker to go deeper. Thus, the topmost item of a constant expression if
      cached. This is done after all other optimizations were applied to
      WHERE/HAVING/ON expressions
            
      A helper function called cache_const_exprs is added to the JOIN class.
      It calls compile method with caching analyzer and transformer on WHERE,
      HAVING, ON expressions if they're present.
      The cache_const_expr_analyzer and cache_const_expr_transformer functions are
      added to the Item class. The first one check if the item can be cached and
      the second caches it if so.
      A new Item_cache_datetime class is derived from the Item_cache class.
      It caches both int and string values of the underlying item independently to
      avoid DATETIME aware int-to-string conversion. Thus it completely relies on
      the ability of the underlying item to correctly convert DATETIME value from
      int to string and vice versa.
      
      
      mysql-test/r/func_like.result:
        A test case result is corrected after fixing bug#33546.
      mysql-test/r/func_time.result:
        A test case result is corrected after fixing bug#33546.
      mysql-test/r/select.result:
        Added a test case for the bug#33546.
      mysql-test/r/subselect.result:
        A test case result is corrected after fixing bug#33546.
      mysql-test/r/udf.result:
        Added a test case for the bug#33546.
      mysql-test/t/select.test:
        Added a test case for the bug#33546.
      mysql-test/t/udf.test:
        Added a test case for the bug#33546.
      sql/item.cc:
        Bug#33546: Slowdown on re-evaluation of constant expressions.
        The cache_const_expr_analyzer and cache_const_expr_transformer functions are
        added to the Item class. The first one check if the item can be cached and
        the second caches it if so.
        Item_cache_datetime class implementation is added.
      sql/item.h:
        Bug#33546: Slowdown on re-evaluation of constant expressions.
        Item_ref and Item_cache classes now returns basic_const_item
        from underlying item.
        The cache_const_expr_analyzer and cache_const_expr_transformer functions are
        added to the Item class.
      sql/sql_select.cc:
        Bug#33546: Slowdown on re-evaluation of constant expressions.
                
        A helper function called cache_const_exprs is added to the JOIN class.
        It calls compile method with caching analyzer and transformer on WHERE,
        HAVING, ON expressions if they're present.
      sql/sql_select.h:
        Bug#33546: Slowdown on re-evaluation of constant expressions.
        A helper function called cache_const_exprs is added to the JOIN class.
      987e1466