- 10 Apr, 2007 2 commits
- 03 Apr, 2007 2 commits
-
-
unknown authored
into bk-internal.mysql.com:/data0/bk/mysql-5.0-marvel client/mysql.cc: Auto merged heap/hp_write.c: Auto merged sql/ha_ndbcluster.cc: Auto merged sql/handler.cc: Auto merged sql/item.cc: Auto merged sql/mysqld.cc: Auto merged sql/opt_range.cc: Auto merged sql/sql_base.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_delete.cc: Auto merged sql/sql_insert.cc: Auto merged sql/sql_load.cc: Auto merged sql/sql_select.cc: Auto merged sql/sql_table.cc: Auto merged
-
unknown authored
The problem was that THD::db_access variable was not restored after database switch in stored-routine-execution code. The fix is to restore THD::db_access in this case. Unfortunately, this fix requires additional changes, because in prepare_schema_table(), called on the parsing stage, we checked privileges. That was wrong according to our design, but this flaw haven't struck so far, because it was masked. All privilege checkings must be done on the execution stage in order to be compatible with prepared statements and stored routines. So, this patch also contains patch for prepare_schema_table(), which moves the checkings to the execution phase. mysql-test/r/grant.result: Updated result file. mysql-test/t/grant.test: Added test case for BUG#27337. sql/mysql_priv.h: Added function declaration. sql/sql_db.cc: Fix for BUG#27337 -- set THD::db_access even if we're called from stored-routine-execution code. sql/sql_parse.cc: Split prepare_schema_table() into two functions: - prepare_schema_table(), which is called from the parser (parsing stage); - check_show_access(), which is called on the execution stage. sql/sql_show.cc: Ignore schema_select_lex member if its table is NULL.
-
- 02 Apr, 2007 2 commits
- 31 Mar, 2007 6 commits
-
-
unknown authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
-
unknown authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
-
unknown authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge sql/sql_base.cc: Auto merged sql/sql_select.cc: Auto merged sql/table.h: Auto merged
-
unknown authored
into bk-internal.mysql.com:/data0/bk/mysql-4.1-opt
-
unknown authored
conditions. When allocating memory for KEY_FIELD/SARGABLE_PARAM structures the function update_ref_and_keys did not take into account the fact that a single row equality could be replaced by several simple equalities. Fixed by adjusting the counter cond_count accordingly for each subquery when performing substitution of a row equality for simple equalities. mysql-test/r/row.result: Added a test case for bug #27154. mysql-test/t/row.test: Added a test case for bug #27154.
-
unknown authored
into bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
-
- 30 Mar, 2007 8 commits
-
-
unknown authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge sql/mysqld.cc: Auto merged sql/sql_base.cc: Auto merged sql/sql_select.cc: Auto merged
-
unknown authored
mysql-test/r/range.result: Auto merged mysql-test/t/range.test: Auto merged
-
unknown authored
Pushbuild fixes: - Make MAX_SEL_ARGS smaller (even 16K records_in_range() calls is more than it makes sense to do in typical cases) - Don't call sel_arg->test_use_count() if we've already allocated more than MAX_SEL_ARGs elements. The test will succeed but will take too much time for the test suite (and not provide much value). mysql-test/r/range.result: BUG#26624: high mem usage (crash) in range optimizer Pushbuild fixes: make the test go faster mysql-test/t/range.test: BUG#26624: high mem usage (crash) in range optimizer Pushbuild fixes: make the test go faster
-
unknown authored
into mysql.com:/home/kent/bk/tmp/mysql-4.1-build
-
unknown authored
into janus.mylan:/usr/home/serg/Abk/mysql-5.0 sql/ha_ndbcluster.cc: Auto merged
-
unknown authored
NO_AUTO_VALUE_ON_ZERO mode. In the NO_AUTO_VALUE_ON_ZERO mode the table->auto_increment_field_not_null variable is used to indicate that a non-NULL value was specified by the user for an auto_increment column. When an INSERT .. ON DUPLICATE updates the auto_increment field this variable is set to true and stays unchanged for the next insert operation. This makes the next inserted row sometimes wrongly have 0 as the value of the auto_increment field. Now the fill_record() function resets the table->auto_increment_field_not_null variable before filling the record. The table->auto_increment_field_not_null variable is also reset by the open_table() function for a case if we missed some auto_increment_field_not_null handling bug. Now the table->auto_increment_field_not_null is reset at the end of the mysql_load() function. Reset the table->auto_increment_field_not_null variable after each write_row() call in the copy_data_between_tables() function. sql/field_conv.cc: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. A comment is corrected. sql/handler.cc: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. Now the handler::update_auto_increment() function doesn't reset the table->auto_increment_field_not_null variable as it is done in the fill_record() function. sql/sql_base.cc: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. Now the fill_record() function resets the table->auto_increment_field_not_null variable before filling the record. The table->auto_increment_field_not_null variable is also reset by the open_table() function for a case if we missed some auto_increment_field_not_null handling bug. sql/sql_insert.cc: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. Now the the table->auto_increment_field_not_null is reset at the end of the mysql_insert() an in the select_insert class destructor. sql/sql_load.cc: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. Now the table->auto_increment_field_not_null is reset at the end of the mysql_load() function. sql/sql_table.cc: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. Reset the table->auto_increment_field_not_null variable after each write_row() call in the copy_data_between_tables() function. sql/table.h: Bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. A comment added. mysql-test/r/insert_update.result: Added the test case for the bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode. mysql-test/t/insert_update.test: Added the test case for the bug#23233: 0 as LAST_INSERT_ID() after INSERT .. ON DUPLICATE in the NO_AUTO_VALUE_ON_ZERO mode.
-
unknown authored
into chilla.local:/home/mydev/mysql-5.0-axmrg sql/ha_ndbcluster.cc: Auto merged sql/ha_ndbcluster.h: Auto merged
-
unknown authored
into mysql.com:/home/bar/mysql-5.0.b22638
-
- 29 Mar, 2007 18 commits
-
-
unknown authored
into chilla.local:/home/mydev/mysql-5.0-axmrg
-
unknown authored
(Fixes valgrind warnings)
-
unknown authored
into mysql.com:/home/my/mysql-5.0 client/mysql_upgrade.c: manual merge
-
unknown authored
client/mysql_upgrade.c: Fixed memory leak Fixed indentation
-
unknown authored
into mysql.com:/home/svoj/devel/mysql/BUG25521/mysql-5.0-engines
-
unknown authored
into bk-internal.mysql.com:/data0/bk/mysql-5.0-marvel
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B26815-5.0-opt sql/item_sum.cc: Auto merged sql/sql_select.cc: Auto merged
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B26815-5.0-opt mysql-test/r/func_gconcat.result: Auto merged mysql-test/t/func_gconcat.test: Auto merged sql/item_sum.cc: Auto merged sql/sql_select.cc: Auto merged
-
unknown authored
When creating a temporary table the concise column type of a string expression is decided based on its length: - if its length is under 512 it is stored as either varchar or char. - otherwise it is stored as a BLOB. There is a flag (convert_blob_length) to create_tmp_field that, when >0 allows to force creation of a varchar if the max blob length is under convert_blob_length. However it must be verified that convert_blob_length (settable through a SQL option in some cases) is under the maximum that can be stored in a varchar column. While performing that check for expressions in create_tmp_field_from_item the max length of the blob was used instead. This causes blob columns to be created in the heap temp table used by GROUP_CONCAT (where blobs must not be created in the temp table because of the constant convert_blob_length that is passed to create_tmp_field() ). And since these blob columns are not expected in that place we get wrong results. Fixed by checking that the value of the flag variable is in the limits that fit into VARCHAR instead of the max length of the blob column. mysql-test/r/func_gconcat.result: Bug #26815: test case mysql-test/t/func_gconcat.test: Bug #26815: test case sql/item_sum.cc: Bug #26815: wrong length was checked sql/sql_select.cc: Bug #26815: wrong length was checked
-
unknown authored
into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
-
unknown authored
into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge sql/mysqld.cc: Auto merged sql/sql_base.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_select.cc: Auto merged
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B27300-5.0-opt
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B27300-5.0-opt
-
unknown authored
mysql-test/r/range.result: Auto merged mysql-test/t/range.test: Auto merged
-
unknown authored
- Post-review fixes
-
unknown authored
Thanks to Gluh for suggestion.
-
unknown authored
into mysql.com:/home/bar/mysql-5.0.b27079
-
unknown authored
into mysql.com:/home/bar/mysql-5.0.b22378
-
- 28 Mar, 2007 2 commits
-
-
unknown authored
Don't install ndb man pages if no ndb configured config-win.h, CMakeLists.txt, README, configure.js: Removed Cybozu patches configure.in: Don't install ndb man pages if no ndb configured CMakeLists.txt: Removed Cybozu patches include/config-win.h: Removed Cybozu patches win/README: Removed Cybozu patches win/configure.js: Removed Cybozu patches
-
unknown authored
into ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0-marvel BitKeeper/deleted/.del-_dynrec.c~48dd758f5a5450df: Auto merged BitKeeper/deleted/.del-_page.c~148b1a613d052ee8: Auto merged BitKeeper/deleted/.del-_search.c~f509292aa1ff18ff: Auto merged BitKeeper/deleted/.del-close.c~fd62629496ee5bcc: Auto merged BitKeeper/deleted/.del-delete.c~65ee8daaa75a14b6: Auto merged BitKeeper/deleted/.del-my_tempnam.c~a8562f15dad3012f: Auto merged BitKeeper/deleted/.del-open.c~95b3b75042fae00a: Auto merged BitKeeper/deleted/.del-rkey.c~cc54c6498352f999: Auto merged client/mysql.cc: Auto merged client/mysqldump.c: Auto merged include/my_sys.h: Auto merged include/raid.h: Auto merged myisam/mi_close.c: Auto merged BitKeeper/deleted/.del-sort.c~e2e56b5a37ce86f4: Auto merged BitKeeper/deleted/.del-write.c~8f1918b1f6770e54: Auto merged myisam/mi_page.c: Auto merged myisam/myisamchk.c: Auto merged mysys/default.c: Auto merged mysys/mf_keycaches.c: Auto merged mysys/my_dup.c: Auto merged mysys/my_fopen.c: Auto merged mysys/my_handler.c: Auto merged mysys/my_malloc.c: Auto merged mysys/my_static.c: Auto merged mysys/my_write.c: Auto merged mysys/safemalloc.c: Auto merged mysys/tree.c: Auto merged mysys/typelib.c: Auto merged regex/regexec.c: Auto merged sql/item.cc: Auto merged sql/item_cmpfunc.cc: Auto merged sql/opt_range.cc: Auto merged sql/sql_repl.cc: Auto merged sql-common/my_time.c: Auto merged BitKeeper/deleted/.del-compiler_warnings.supp: Delete: support-files/compiler_warnings.supp client/mysqlbinlog.cc: Manual merge from 4.1. client/sql_string.cc: Manual merge from 4.1. extra/perror.c: Manual merge from 4.1. heap/_check.c: Manual merge from 4.1. heap/hp_delete.c: Manual merge from 4.1. heap/hp_hash.c: Manual merge from 4.1. heap/hp_open.c: Manual merge from 4.1. heap/hp_rkey.c: Manual merge from 4.1. heap/hp_rrnd.c: Manual merge from 4.1. heap/hp_write.c: Manual merge from 4.1. libmysql/libmysql.c: Manual merge from 4.1. libmysqld/libmysqld.c: Manual merge from 4.1. myisam/mi_delete.c: Manual merge from 4.1. myisam/mi_dynrec.c: Manual merge from 4.1. myisam/mi_keycache.c: Manual merge from 4.1. myisam/mi_statrec.c: Manual merge from 4.1. myisammrg/myrg_extra.c: Manual merge from 4.1. mysys/hash.c: Manual merge from 4.1. mysys/list.c: Manual merge from 4.1. mysys/mf_iocache.c: Manual merge from 4.1. mysys/mf_keycache.c: Manual merge from 4.1. mysys/my_alloc.c: Manual merge from 4.1. mysys/my_fstream.c: Manual merge from 4.1. mysys/my_getwd.c: Manual merge from 4.1. mysys/my_lib.c: Manual merge from 4.1. mysys/my_lread.c: Manual merge from 4.1. mysys/my_lwrite.c: Manual merge from 4.1. mysys/my_pread.c: Manual merge from 4.1. mysys/my_read.c: Manual merge from 4.1. mysys/my_realloc.c: Manual merge from 4.1. mysys/my_seek.c: Manual merge from 4.1. mysys/raid.cc: Manual merge from 4.1. mysys/thr_lock.c: Manual merge from 4.1. ndb/src/mgmclient/CommandInterpreter.cpp: Manual merge from 4.1. sql/ha_archive.cc: Manual merge from 4.1. sql/ha_innodb.cc: Manual merge from 4.1. sql/ha_ndbcluster.cc: Manual merge from 4.1. sql/item_subselect.cc: Manual merge from 4.1. sql/log.cc: Manual merge from 4.1. sql/log_event.cc: Manual merge from 4.1. sql/mysqld.cc: Manual merge from 4.1. sql/net_serv.cc: Manual merge from 4.1. sql/slave.cc: Manual merge from 4.1. sql/sql_cache.cc: Manual merge from 4.1. sql/sql_class.cc: Manual merge from 4.1. sql/sql_delete.cc: Manual merge from 4.1. sql/sql_parse.cc: Manual merge from 4.1. sql/sql_prepare.cc: Manual merge from 4.1. sql-common/client.c: Manual merge from 4.1. sql/sql_select.cc: Manual merge from 4.1. sql/sql_table.cc: Manual merge from 4.1. sql/sql_update.cc: Manual merge from 4.1. sql/strfunc.cc: Manual merge from 4.1. sql/table.cc: Manual merge from 4.1. sql/tztime.cc: Manual merge from 4.1. sql/unireg.cc: Manual merge from 4.1. tests/mysql_client_test.c: Manual merge from 4.1.
-