1. 19 May, 2011 1 commit
  2. 18 May, 2011 5 commits
  3. 16 May, 2011 6 commits
  4. 14 May, 2011 2 commits
  5. 13 May, 2011 7 commits
    • Marc Alff's avatar
      Bug#12552516 LF_HASH REQUIRES MY_THREAD_INIT() · d343f5e3
      Marc Alff authored
      Before this fix, a thread instrumented for the performance schema,
      that would perform file io operations, could crash inside the LF_HASH
      implementation, in cases when my_thread_init is not called.
      
      The crash itself has not been reported in 5.5 but similar crashes have
      been found in 5.6-based development branches, using LF_HASH for
      more instrumentation.
      
      The possibility of a crash in 5.5 is confirmed by code analysis.
      
      The problem is that, when my_thread_init() is not called,
      which can happen for threads in storage engines or thirs party code,
      my_thread_var is NULL.
      
      Using my_thread_var->stacks_ends_here in mysys/lf_alloc-pin.c is unsafe.
      
      Given that my_thread_var is used:
      - only for stacks_ends_here
      - only on platform with HAVE_ALLOCA
      - only when there is enough room on the stack
      and given that the LF_HASH implementation has a fallback
      algorythm implemented already when using alloca is not possible,
      using my_thread_var->stacks_ends_here is in fact not a strict requirement,
      and can be relaxed.
      
      The fix is to:
      - test explicitly if my_thread_var is NULL, to account for cases
        when my_thread_init() is not used by the calling thread.
      - not use alloca in this case, and rely on the fall back code already in place.
        so that the LF_HASH can be supported even without my_thread_init().
      
      The implementation of mysys/lf_alloc-pin.c has been fixed to support this new usage.
      The units tests in unittest/mysys/lf-t.c have been adjusted accordingly.
      d343f5e3
    • Mikael Ronstrom's avatar
    • Mikael Ronström's avatar
      merge · e44579d2
      Mikael Ronström authored
      e44579d2
    • Bjorn Munch's avatar
      null upmerge · 94d657bf
      Bjorn Munch authored
      94d657bf
    • Bjorn Munch's avatar
      merge from 5.1-mtr · 067fa4a5
      Bjorn Munch authored
      067fa4a5
    • Bjorn Munch's avatar
      merge from 5.5-mtr · 0610c9a7
      Bjorn Munch authored
      0610c9a7
    • MySQL Build Team's avatar
      changed the VERSION tag to 14 · cb0f843e
      MySQL Build Team authored
      cb0f843e
  6. 12 May, 2011 16 commits
  7. 11 May, 2011 3 commits