1. 10 Dec, 2007 1 commit
  2. 07 Dec, 2007 1 commit
    • unknown's avatar
      Bug #27440 read_only allows create and drop database · 5826a5c4
      unknown authored
      When read_only option was enabled, a user without SUPER privilege could
      perform CREATE DATABASE and DROP DATABASE operations.
      
      This patch adds a check to make sure this isn't possible. It also attempts to 
      simplify the logic used to determine if relevant tables are updated,
      making it more human readable.
      
      
      mysql-test/r/read_only.result:
        Updated result file
      mysql-test/t/read_only.test:
        A test case is added which shows that it is not possible to drop or create a
        database in read-only mode despite having the GRANT permissions to do so,
        SUPER user excepted.
      sql/sql_parse.cc:
        - Simplified complex predicate by grouping it in a read friendly way.
        - Added predicate to fail on database updates while running in read-only
          mode.
      5826a5c4
  3. 26 Nov, 2007 8 commits
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 6b15ed1c
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      6b15ed1c
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug16470/my51-bug16470 · f1ad502a
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        manual merge
      f1ad502a
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/29592-5.0 · 08e232b9
      unknown authored
      into  mysql.com:/Users/davi/mysql/bugs/29592-5.1
      
      
      include/mysql.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysql/libmysql.def:
        Auto merged
      libmysqld/libmysqld.def:
        Auto merged
      include/mysql_h.ic:
        Update ABI check file.
      08e232b9
    • unknown's avatar
      Bug#16470 crash on grant if old grant tables · 1ddb4722
      unknown authored
      Loading 4.1 into 5.0 or 5.1 failed silently because procs_priv table missing.
      This caused the server to crash on any attempt to store new grants because
      of uninitialized structures.
      
      This patch breaks up the grant loading function into two phases to allow
      for procs_priv table to fail with an warning instead of crashing the server.
      
      
      mysql-test/r/grant.result:
        Test case
      mysql-test/t/grant.test:
        Test case making sure that FLUSH PRIVILEGES doesn't crash the server if
        procs_priv is removed.
      sql/sql_acl.cc:
        - Refactored grant_reload into two phases: 1. open and lock tables_priv and 
          columns_priv tables, read the data, close tables. 2. open and lock
          procs_priv, read data, close table. Since the tables are independant of
          each other there will be no race conditions and it will be possible to
          handle situations where the procs_priv table isn't present.
        - Refactored the helper function grant_load into new grant_load (without
          procs_priv table) and grant_load_procs_priv.
      sql/sql_parse.cc:
        - Changed comment style to doxygen style.
      1ddb4722
    • unknown's avatar
      Bug#29592 SQL Injection issue · b8a19c22
      unknown authored
      Remove the mysql_odbc_escape_string() function. The function
      has multi-byte character escaping issues, doesn't honor the
      NO_BACKSLASH_ESCAPES mode and is not used anymore by the
      Connector/ODBC as of 3.51.17.
      
      
      include/mysql.h:
        Remove mysql_odbc_escape_string() prototype.
      include/mysql_h.ic:
        Update abi check file, mostly line changes and mysql_odbc_escape_string
        removal.
      libmysql/libmysql.c:
        Remove mysql_odbc_escape_string() body.
      libmysql/libmysql.def:
        Remove mysql_odbc_escape_string()
      libmysqld/libmysqld.def:
        Remove mysql_odbc_escape_string()
      b8a19c22
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug32436/my51-bug32436 · 1522ef3f
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/item_func.cc:
        Auto merged
      1522ef3f
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug32436/my50-bug32436 · 0b65a2e7
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug32436/my51-bug32436
      
      
      sql/item_func.cc:
        Auto merged
      0b65a2e7
    • unknown's avatar
      Bug #32436 KILL QUERY completely deadlocks mysqld · fea1524d
      unknown authored
      Sending several "KILL QUERY" statements to target a connection running
      "SELECT SLEEP" could freeze the server.
      
      The locking order in Item_func_sleep was wrong and this could lead to a
      dead lock.
      
      This patch solves the issue by resolving the locking order properly.
      
      
      sql/item_func.cc:
        - Moved LOCK_user_locks critical region so that it doesn't share space with
          mysys_var->mutex region; this can lead to deadlock.
      fea1524d
  4. 23 Nov, 2007 2 commits
  5. 22 Nov, 2007 10 commits
  6. 21 Nov, 2007 15 commits
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31153/my51-bug31153 · 569c2dcd
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      569c2dcd
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 787316f2
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build
      
      
      787316f2
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 1fb0a096
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      1fb0a096
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build · a393b62e
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      support-files/compiler_warnings.supp:
        merge fix
      a393b62e
    • unknown's avatar
      add wrong warning to suppression file · 98c55d39
      unknown authored
      
      support-files/compiler_warnings.supp:
        we want that.
      98c55d39
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build · 6d5ab945
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      support-files/compiler_warnings.supp:
        merge fix
      6d5ab945
    • unknown's avatar
      Merge mleich@bk-internal.mysql.com:/home/bk/mysql-5.0-build · e8673939
      unknown authored
      into  five.local.lan:/work/trees/mysql-5.0-build-src-clean
      
      
      e8673939
    • unknown's avatar
      ignore readline warnings · 75f14d9b
      unknown authored
      
      support-files/compiler_warnings.supp:
        readline is not maintained by us
      75f14d9b
    • unknown's avatar
      Merge five.local.lan:/work/merge/mysql-5.0-build-30418 · 705d58f8
      unknown authored
      into  five.local.lan:/work/merge/mysql-5.1-build-31610
      
      
      mysql-test/suite/funcs_1/datadict/datadict_master.inc:
        Auto merged
      mysql-test/suite/funcs_1/datadict/datadict_show_schema.inc:
        Auto merged
      mysql-test/suite/funcs_1/datadict/datadict_tables.inc:
        Auto merged
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        Auto merged
      mysql-test/suite/funcs_1/r/memory__datadict.result:
        Auto merged
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        Auto merged
      705d58f8
    • unknown's avatar
      This changeset fixes · b6c38105
      unknown authored
         Bug#31567 "datadict" tests (all engines) fail:
                   Reference protocol is non-standard build
         Bug#30418 "datadict" tests (all engines) fail:
                   Dependency on the host name for ordering   
      Modifications:
         1. The standard builds (build team) do not contain
            the collation 'utf8_general_cs'.
            The common developer builds (compuile-....-max)
            contain this collation.
            Solution fitting to both build variants:
               Exclude the collation 'utf8_general_cs' from
               result sets.
         2. Use mysqltest builtin sorting of result set for
            the statement where the hostname affects the
            row order.
      
      
      mysql-test/suite/funcs_1/datadict/datadict_master.inc:
        Exclude collation 'utf8_general_cs' from result set.
      mysql-test/suite/funcs_1/datadict/datadict_show_schema.inc:
        Use mysqltest builtin sorting of result set.
      mysql-test/suite/funcs_1/datadict/datadict_tables.inc:
        Exclude collation 'utf8_general_cs' from result set.
      mysql-test/suite/funcs_1/r/innodb__datadict.result:
        Updated  results
      mysql-test/suite/funcs_1/r/memory__datadict.result:
        Updated  results
      mysql-test/suite/funcs_1/r/myisam__datadict.result:
        Updated  results
      b6c38105
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31153/my50-bug31153 · bc54a373
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug31153/my51-bug31153
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Null merge.
      sql/sql_base.cc:
        Manual merge
      sql/sql_lex.h:
        Manual merge
      bc54a373
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31153/my50-bug31153 · 1ae0237f
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.0-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge.
      1ae0237f
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/build/b25146/51 · df20252c
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      
      client/mysql.cc:
        Auto merged
      df20252c
    • unknown's avatar
      Merge endora.local:/Users/davi/mysql/mysql-5.0-runtime · dd98703b
      unknown authored
      into  endora.local:/Users/davi/mysql/mysql-5.1-runtime
      
      
      dd98703b
    • unknown's avatar
      Bug #25146: Some warnings/errors not shown when using --show-warnings · 49b527ab
      unknown authored
      In several cases, an error when processing the query would cause mysql to
      return to the top level without printing warnings.  Fix is to always
      print any available warnings before returning to the top level.
      
      
      client/mysql.cc:
        In com_go(), ensure that warnings are printed even if an error
        occurred when processing the query.  Before this patch, an error
        in several places would return to the top level without printing
        associated warnings.
        
        Attempt to avoid printing the warning, though, if it's a duplicate
        of mysql_error() for the connection handle.
      mysql-test/r/mysql.result:
        Add test for bug 25146
      mysql-test/t/mysql.test:
        Add test for bug 25146
      49b527ab
  7. 20 Nov, 2007 3 commits