1. 12 Jan, 2012 8 commits
  2. 11 Jan, 2012 4 commits
  3. 10 Jan, 2012 5 commits
    • Nirbhay Choubey's avatar
      0306cde0
    • Nirbhay Choubey's avatar
      BUG#11760384 - 52792: mysqldump in XML mode does not dump · 99e462ab
      Nirbhay Choubey authored
                           routines.
      
      mysqldump in xml mode did not dump routines, events or
      triggers.
      
      This patch fixes this issue by fixing the if conditions
      that disallowed the dump of above mentioned objects in
      xml mode, and added the required code to enable dump
      in xml format.
      
      
      client/mysqldump.c:
        BUG#11760384 - 52792: mysqldump in XML mode does not dump
                              routines.
        
        Fixed some if conditions to allow execution of dump methods
        for xml and further added the relevant code at places to produce
        the dump in xml format.
      mysql-test/r/mysqldump.result:
        Added a test case for Bug#11760384.
      mysql-test/t/mysqldump.test:
        Added a test case for Bug#11760384.
      99e462ab
    • Sneha Modi's avatar
      Bug#11748572: ALLOCATING A LARGE QUERY CACHE IS NOT DETERMINISTIC · aaa2ba39
      Sneha Modi authored
      Moving query_cache_size_basic_32.test and query_cache_size_basic_64.test from experimental
      to disabled as a solution has still not been found.
      aaa2ba39
    • Yasufumi Kinoshita's avatar
      Bug#12400341 INNODB CAN LEAVE ORPHAN IBD FILES AROUND · ad6a4986
      Yasufumi Kinoshita authored
      If we meet DB_TOO_MANY_CONCURRENT_TRXS during the execution tab_create_graph from row_create_table_for_mysql(), .ibd file for the table should be created already but was not deleted for the error handling.
      
      rb:875 approved by Jimmy Yang
      ad6a4986
    • Yasufumi Kinoshita's avatar
      Bug#12400341 INNODB CAN LEAVE ORPHAN IBD FILES AROUND · 115f5e85
      Yasufumi Kinoshita authored
      If we meet DB_TOO_MANY_CONCURRENT_TRXS during the execution tab_create_graph from row_create_table_for_mysql(), .ibd file for the table should be created already but was not deleted for the error handling.
      
      rb:875 approved by Jimmy Yang
      115f5e85
  4. 09 Jan, 2012 2 commits
    • Jon Olav Hauglid's avatar
      Merge from mysql-5.1-security to mysql-5.5-security · f621aa90
      Jon Olav Hauglid authored
      Text conflict in sql/sql_yacc.yy
      f621aa90
    • Jon Olav Hauglid's avatar
      Backport from mysql-trunk of: · b8291e2b
      Jon Olav Hauglid authored
      ------------------------------------------------------------
      revno: 3258
      committer: Jon Olav Hauglid <jon.hauglid@oracle.com>
      branch nick: mysql-trunk-bug12663165
      timestamp: Thu 2011-07-14 10:05:12 +0200
      message:
        Bug#12663165 SP DEAD CODE REMOVAL DOESN'T UNDERSTAND CONTINUE HANDLERS
        
        When stored routines are loaded, a simple optimizer tries to locate
        and remove dead code. The problem was that this dead code removal
        did not work correctly with CONTINUE handlers.
        
        If a statement triggers a CONTINUE handler, the following statement
        will be executed after the handler statement has completed. This
        means that the following statement is not dead code even if the
        previous statement unconditionally alters control flow. This fact
        was lost on the dead code removal routine, which ended up with
        removing instructions that could have been executed. This could
        then lead to assertions, crashes and generally bad behavior when
        the stored routine was executed.
        
        This patch fixes the problem by marking as live code all stored
        routine instructions that are in the same scope as a CONTINUE handler.
        
        Test case added to sp.test.
      b8291e2b
  5. 06 Jan, 2012 4 commits
  6. 05 Jan, 2012 1 commit
  7. 04 Jan, 2012 1 commit
  8. 03 Jan, 2012 1 commit
  9. 02 Jan, 2012 2 commits
    • Tatjana Azundris Nuernberg's avatar
      ed1ba992
    • Tatjana Azundris Nuernberg's avatar
      BUG#11755281/47032: ERROR 2006 / ERROR 2013 INSTEAD OF PROPER ERROR MESSAGE · 251fa88a
      Tatjana Azundris Nuernberg authored
      If init_command was incorrect, we couldn't let users execute
      queries, but we couldn't report the issue to the client either
      as it does not expect error messages before even sending a
      command. Thus, we simply disconnected them without throwing
      a clear error.
      
      We now go through the proper sequence once (without executing
      any user statements) so we can report back what the problem
      is. Only then do we disconnect the user.
      
      As always, root remains unaffected by this as init_command is
      (still) not executed for them.
      
      mysql-test/r/init_connect.result:
        We now report a proper error if init_command fails.
        Expect as much.
      mysql-test/t/init_connect.test:
        We now report a proper error if init_command fails.
        Expect as much.
      sql/sql_connect.cc:
        If init_command fails, throw an error explaining this to
        the user.
      251fa88a
  10. 29 Dec, 2011 5 commits
  11. 28 Dec, 2011 2 commits
    • Marko Mäkelä's avatar
      Merge mysql-5.1 to mysql-5.5. · 1b6cb012
      Marko Mäkelä authored
      1b6cb012
    • Marko Mäkelä's avatar
      Bug#13418934 REMOVE HAVE_PURIFY DEPENDENCES FROM INNODB · e498a1bf
      Marko Mäkelä authored
      InnoDB: Remove HAVE_purify, UNIV_INIT_MEM_TO_ZERO, UNIV_SET_MEM_TO_ZERO.
      
      The compile-time setting HAVE_purify can mask potential bugs.
      It is being set in PB2 Valgrind runs. We should simply get rid of it,
      and replace it with UNIV_MEM_INVALID() to declare uninitialized memory
      as such in Valgrind-instrumented binaries.
      
      os_mem_alloc_large(), ut_malloc_low(): Remove the parameter set_to_zero.
      
      ut_malloc(): Define as a macro that invokes ut_malloc_low().
      
      buf_pool_init(): Never initialize the buffer pool frames. All pages
      must be initialized before flushing them to disk.
      
      mem_heap_alloc(): Never initialize the allocated memory block.
      
      os_mem_alloc_nocache(), ut_test_malloc(): Unused function, remove.
      
      rb:813 approved by Jimmy Yang
      e498a1bf
  12. 26 Dec, 2011 1 commit
  13. 24 Dec, 2011 1 commit
  14. 23 Dec, 2011 3 commits
    • Nirbhay Choubey's avatar
      Bug#12809202 61854: MYSQLDUMP --SINGLE-TRANSACTION · 5e487124
      Nirbhay Choubey authored
                   --FLUSH-LOG BREAKS CONSISTENCY
      
      The transaction started by mysqldump gets committed
      implicitly when flush-log is specified along with
      single-transaction option, and hence can break
      consistency.
      
      This is because, COM_REFRESH is executed in order
      to flush logs and starting from 5.5 this command
      performs an implicit commit.
      
      Fixed by making sure that COM_REFRESH is executed
      before the transaction has started and not after it.
      
      Note : This patch triggers following behavioral
             changes in mysqldump :
      
      1) After this patch we no longer flush logs before
         dumping each database if --single-transaction
         option is given like it was done before (in the
         absence of --lock-all-tables and --master-data
         options).
      
      2) Also, after this patch, we start acquiring
         FTWRL before flushing logs in cases when only
         --single-transaction and --flush-logs are given.
         It becomes safe to use mysqldump with these two
         options and without --master-data parameter for
         backups.
      
      
      client/mysqldump.c:
        Bug#12809202 61854: MYSQLDUMP --SINGLE-TRANSACTION
                     --FLUSH-LOG BREAKS CONSISTENCY
        
        Added logic to make sure that, if flush-log option
        is specified, mysql_refresh() is never executed after
        the transaction has started.
        
        Added verbose messages for all the executions of
        mysql_refresh() in order to track its invocation.
      mysql-test/r/mysqldump.result:
        Added test case for Bug#12809202.
      mysql-test/t/mysqldump.test:
        Added test case for Bug#12809202.
      5e487124
    • Ramil Kalimullin's avatar
      Auto-merge from mysql-5.1. · a3380233
      Ramil Kalimullin authored
      a3380233
    • Ramil Kalimullin's avatar
      Fix for bug#11758931 - 51196: SLAVE SQL: GOT AN ERROR WRITING · 289af257
      Ramil Kalimullin authored
      COMMUNICATION PACKETS, ERROR_CODE: 1160
      
      Addendum: for some queries table->in_use might be NULL -
      check it.
      289af257