1. 03 Aug, 2009 2 commits
  2. 24 Jul, 2009 2 commits
  3. 06 Jul, 2009 1 commit
  4. 26 Jun, 2009 1 commit
  5. 25 Jun, 2009 1 commit
  6. 23 Jun, 2009 1 commit
    • unknown's avatar
      Fix memory leak in mysql_ssl_set() when called more than once. · e8474840
      unknown authored
      Fix sleep() synchronisation in innodb_information_schema test case.
      
      mysql-test/t/innodb_information_schema.test:
        Using sleep for synchronisation does not work!!!
        Replace by looping until the required condition is met.
      sql-common/client.c:
        mysql_ssl_set() did not free old pointers before overwriting with new ones (happens when
        mysql_ssl_set() is called twice without calling mysql_close() in-between).
        
        This sometimes caused memory leaks in the slave depending on exact timing of
        master/slave shutdown.
        
        Fixed by freeing old pointers before installing new ones in mysql_ssl_set(), just like
        mysql_options() does.
      e8474840
  7. 22 Jun, 2009 1 commit
    • unknown's avatar
      More XtraDB after-merge fixes following review and buildbot runs: · 7c5e321b
      unknown authored
       - Better fix for --innodb-use-sys-malloc causing Valgrind warnings.
       - Different fix for INNODB_IBUF_MAX_SIZE variable changing default value.
       - Fix some problems with the safe mutex lazy init patch.
      
      mysql-test/include/mtr_check.sql:
        Do not check INNODB_IBUF_MAX_SIZE for changes. It is not a dynamic variable, so cannot
        be changed by a test case anyway, and the value may vary slightly from one start of the
        server to the next.
      mysql-test/lib/mtr_cases.pm:
        Even just starting and stopping the server with --innodb-use-sys-malloc to check for
        disabled test case under valgrind will cause valgrind leak warnings. So add not_valgrind
        to the list of conditions also tested for directly in mysql-test-run.pl.
      mysql-test/mysql-test-run.pl:
        Even just starting and stopping the server with --innodb-use-sys-malloc to check for
        disabled test case under valgrind will cause valgrind leak warnings. So add not_valgrind
        to the list of conditions also tested for directly in mysql-test-run.pl.
      mysys/thr_mutex.c:
        Fix a few problems found during review of the lazy init safe mutex patch.
      storage/xtradb/ibuf/ibuf0ibuf.c:
        Revert previous fix of INNODB_IBUF_MAX_SIZE default varying slightly between server starts.
        (Fixed instead by ignoring that variable in the test suite).
      7c5e321b
  8. 18 Jun, 2009 1 commit
    • unknown's avatar
      Fix test cases after merge of XtraDB into MariaDB. · 2a663359
      unknown authored
      Manually merge some InnoDB changes into XtraDB.
      Fix ALTER TABLE bug in XtraDB with wrong comparison of row type.
      
      mysql-test/include/varchar.inc:
        Fix in test case that which of several duplicate keys triggers an error is not
        deterministic.
      mysql-test/mysql-test-run.pl:
        InnoDB does not bother to free resources individually during shutdown, but due to using
        its own memory tracking it nevertheless can free everything at exit. But XtraDB adds an
        option, on by default, to skip this extra tracking. This causes lots of Valgrind
        warnings, so needs to be disabled for Valgrind testing.
      mysql-test/r/innodb.result:
        Fix in test case that which of several duplicate keys triggers an error is not
        deterministic.
      mysql-test/t/innodb-use-sys-malloc.test:
        InnoDB does not bother to free resources individually during shutdown, but due to using
        its own memory tracking it nevertheless can free everything at exit. But XtraDB adds an
        option, on by default, to skip this extra tracking. This causes lots of Valgrind
        warnings, so needs to be disabled for Valgrind testing.
      sql/sql_table.cc:
        Add some useful DBUG while debugging alter table.
      storage/xtradb/handler/ha_innodb.cc:
        Fix that check_if_incompatible_data did not realise that ROW_TYPE_DEFAULT is identical
        to the default row format ROW_TYPE_COMPACT, causing excessive table copying in
        ALTER TABLE
        Add some useful DBUG while debugging alter table.
        Manually merge into XtraDB a few small changes for InnoDB from upstream MySQL.
      storage/xtradb/include/pars0pars.h:
        Manually merge into XtraDB a few small changes for InnoDB from upstream MySQL.
      storage/xtradb/include/univ.i:
        Manually merge a MariaDB fix in InnoDB into XtraDB.
      2a663359
  9. 15 Jun, 2009 1 commit
  10. 11 Jun, 2009 2 commits
    • unknown's avatar
      Merge of Percona XtraDB into MariaDB. · 4b2aafb3
      unknown authored
      4b2aafb3
    • unknown's avatar
      Merge latest XtraDB from lp:percona-xtradb into MariaDB. · 93bcda59
      unknown authored
      
      include/my_sys.h:
        Move generic file parsing functions out to shared code, as they are used in several places.
      mysys/mf_iocache2.c:
        Move generic file parsing functions out to shared code, as they are used in several places.
      sql/log_event.cc:
        Fix XtraDB build with embedded server.
        XtraDB needs access to replication stuff, which is missing in embedded server.
        Solved by defining wrapper function for this which is compiled differently for normal and
        embedded case.
      sql/log_event.h:
        Fix XtraDB build with embedded server.
        XtraDB needs access to replication stuff, which is missing in embedded server.
        Solved by defining wrapper function for this which is compiled differently for normal and
        embedded case.
      sql/slave.cc:
        Move generic file parsing functions out to shared code, as they are used in several places.
      93bcda59
  11. 10 Jun, 2009 1 commit
    • unknown's avatar
      Fix XtraDB to build with atomic operations, for good performance. · d2d7b5bb
      unknown authored
      The root of the problem is that ./configure mixed together two different things. One is the
      availability of GCC atomic operation intrinsics. The other is the selection of which
      primitives to use for my_atomic implementation.
      
      Then at some point a hack was made to not use GCC intrinsics in my_atomic to work around
      some test failures. But because the two things are mixed in ./configure, this as a side
      effect also makes GCC intrinsics unavailable for XtraDB.
      
      Fixed by splitting this in two in configure, so that we have HAVE_GCC_ATOMIC_BUILTINS for
      GCC intrinsics availability and MY_ATOMIC_MODE_GCC_BUILTINS for use in my_atomic.
      d2d7b5bb
  12. 09 Jun, 2009 4 commits
    • unknown's avatar
      XtraDB after-merge fixes. · bb9a3f0c
      unknown authored
      Fixes to get the test suite to run without failures.
      
      mysql-test/r/information_schema.result:
        Additional variables available now.
        Sort output to avoid depending on engine order.
      mysql-test/r/information_schema_all_engines.result:
        More variables now.
      mysql-test/r/innodb-autoinc.result:
        Avoid picking up pbxt variables in result
      mysql-test/r/innodb-index.result:
        Save state to not corrupt following testcases.
        Suppress an expected warning.
      mysql-test/r/innodb-zip.result:
        Work around a problem with dependency on zlib version
      mysql-test/r/innodb.result:
        Checksums have changed in Maria.
        Save and restore server state to not corrupt following testcases.
      mysql-test/r/innodb_bug36169.result:
        Save and restore server state to not corrupt following testcases.
      mysql-test/r/innodb_xtradb_bug317074.result:
        Save and restore server state to not corrupt following testcases.
      mysql-test/r/row-checksum-old.result:
        Update result file
      mysql-test/r/row-checksum.result:
        Update result file
      mysql-test/t/information_schema.test:
        Sort output to avoid depending on engine order.
      mysql-test/t/innodb-analyze.test:
        Save and restore server state to not corrupt following testcases.
      mysql-test/t/innodb-autoinc.test:
        Save and restore server state to not corrupt following testcases.
      mysql-test/t/innodb-index.test:
        Save state to not corrupt following testcases.
        Suppress an expected warning.
      mysql-test/t/innodb-zip.test:
        Work around a problem with dependency on zlib version
      mysql-test/t/innodb.test:
        Save and restore server state to not corrupt following testcases.
        Update --replace statements for new mysql-test-run
      mysql-test/t/innodb_bug34300.test:
        Save and restore server state to not corrupt following testcases.
      mysql-test/t/innodb_bug36169.test:
        Save and restore server state to not corrupt following testcases.
      mysql-test/t/innodb_bug36172.test:
        Save and restore server state to not corrupt following testcases.
      mysql-test/t/innodb_xtradb_bug317074.test:
        Save and restore server state to not corrupt following testcases.
      mysql-test/t/partition_innodb.test:
        Fix regexps to work with new SHOW INNODB STATUS output.
      mysys/thr_mutex.c:
        Initialize mutex deadlock detection lazily.
        This allows to test XtraDB, which initializes huge amounts of mutexes without using any but a few of them.
      storage/xtradb/ibuf/ibuf0ibuf.c:
        Fix problem where value of INNODB_IBUF_MAX_SIZE would depend on the alignment of memory
        allocated by the buffer pool.
      storage/xtradb/include/sync0rw.h:
        Fix XtraDB to compile without GCC atomic operation intrinsics (performance may suffer
        when they are not available though).
      storage/xtradb/include/sync0rw.ic:
        Fix XtraDB to compile without GCC atomic operation intrinsics (performance may suffer
        when they are not available though).
      storage/xtradb/include/univ.i:
        Fix for MariaDB
      storage/xtradb/setup.sh:
        Remove no longer needed file from XtraDB.
      storage/xtradb/srv/srv0start.c:
        Fix for MariaDB
      bb9a3f0c
    • unknown's avatar
      XtraDB after-merge fixes. · a03c9ff5
      unknown authored
      The original XtraDB (and InnoDB plugin) is shipped as a separate source tree which is copied
      into the MySQL source, after which a setup.sh script must be run to move things into place.
      
      Now that XtraDB is part of the MariaDB source tree, this commit fixes these things up once
      and for all:
      
       - New innodb build scripts.
       - Test suite fixes (new tests and patches to existing).
       - Remove files no longer needed due to this.
      a03c9ff5
    • unknown's avatar
      XtraDB after-merge fix: Fix building from storage/xtradb/ instead of storage/innodb/ · 8be051d7
      unknown authored
      .bzrignore:
        XtraDB compiles innodb in storage/xtradb instead of storage/innobase
      CMakeLists.txt:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      libmysqld/CMakeLists.txt:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      storage/innobase/plug.in.disabled:
        Disable building old InnoDB from storage/innobase/ directory.
        
        We will keep the files around to avoid getting merge conflicts for every MySQL upstream
        change to InnoDB.
      storage/xtradb/CMakeLists.txt:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      storage/xtradb/COPYING:
        Remove not needed file from XtraDB.
      storage/xtradb/Makefile.am:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      storage/xtradb/Makefile.in:
        Remove not needed file from XtraDB.
      storage/xtradb/handler/ha_innodb.cc:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      storage/xtradb/plug.in:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      storage/xtradb/row/row0ins.c:
        Take InnoDB code from storage/xtradb/ instead of storage/innobase/
      8be051d7
    • unknown's avatar
      a6b7f713
  13. 07 Jun, 2009 1 commit
    • Michael Widenius's avatar
      Added tests to cover more server code · 1f81aa5f
      Michael Widenius authored
      Author: Stewart Smith
      
      mysql-test/r/alter_table.result:
        Testing of ALTER TABLE .. DROP DEFAULT
      mysql-test/r/limit.result:
        Testing of LIMIT ... OFFSET
      mysql-test/t/alter_table.test:
        Testing of ALTER TABLE .. DROP DEFAULT
      mysql-test/t/limit.test:
        Testing of LIMIT ... OFFSET
      1f81aa5f
  14. 05 Jun, 2009 3 commits
    • Michael Widenius's avatar
      774ceff0
    • Michael Widenius's avatar
      4c4480e9
    • Michael Widenius's avatar
      Added option --staging-run to mysql-test-run to mark slow, not important... · 3d831149
      Michael Widenius authored
      Added option --staging-run to mysql-test-run to mark slow, not important tests, to not be run in staging trees
      Use MY_MUTEX_INIT_FAST for pool mutex
      
      mysql-test/mysql-test-run.pl:
        Added option --staging-run
        Added information about --parallell=# to help message
      mysql-test/suite/federated/federated_server.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/maria/t/maria-preload.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/rpl/t/rpl_optimize.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/rpl/t/rpl_relayrotate.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/rpl/t/rpl_row_001.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/rpl/t/rpl_row_sp003.test:
        Slow test, don't run with --staging-run
      mysql-test/suite/rpl/t/rpl_start_stop_slave.test:
        Slow test, don't run with --staging-run
      mysql-test/t/compress.test:
        Slow test, don't run with --staging-run
      mysql-test/t/count_distinct3.test:
        Slow test, don't run with --staging-run
      mysql-test/t/index_merge_innodb.test:
        Slow test, don't run with --staging-run
      mysql-test/t/information_schema_all_engines.test:
        Slow test, don't run with --staging-run
      mysql-test/t/innodb_mysql.test:
        Slow test, don't run with --staging-run
      mysql-test/t/pool_of_threads.test:
        Slow test, don't run with --staging-run
      mysql-test/t/preload.test:
        Slow test, don't run with --staging-run
      mysql-test/t/ssl.test:
        Slow test, don't run with --staging-run
      mysql-test/t/ssl_compress.test:
        Slow test, don't run with --staging-run
      mysql-test/valgrind.supp:
        Suppress warnings from SuSE 11.1 on x86
      sql/scheduler.cc:
        Use MY_MUTEX_INIT_FAST for pool mutex
      3d831149
  15. 02 Jun, 2009 2 commits
  16. 25 May, 2009 1 commit
  17. 22 May, 2009 2 commits
    • unknown's avatar
    • unknown's avatar
      After-merge fixes for problems seen in buildbot after merging MySQL-5.1.35. · 48083d73
      unknown authored
       - Version number.
       - Valgrind false alarms in libz.
       - New variant of suppression for Valgrind warning in dlclose().
       - Fix double free() in plugin init error case.
      
      configure.in:
        Fix version number. We should reset the maria variant back to `1' when the MySQL version
        number increases.
      include/my_sys.h:
        Fix false alarms in Valgrind for zlib.
        
        Apply same fix as for archive storage handler also to the cases of compression in the
        client protocol, and to the compression SQL function.
      mysql-test/valgrind.supp:
        A new variant of the dlclose() suppression is needed now.
      mysys/my_compress.c:
        Fix false alarms in Valgrind for zlib.
        
        Apply same fix as for archive storage handler also to the cases of compression in the
        client protocol, and to the compression SQL function.
      sql/handler.cc:
        Fix a double free() in error case for plugin initialisation.
      sql/item_strfunc.cc:
        Fix false alarms in Valgrind for zlib.
        
        Apply same fix as for archive storage handler also to the cases of compression in the
        client protocol, and to the compression SQL function.
      48083d73
  18. 20 May, 2009 1 commit
  19. 19 May, 2009 2 commits
    • Michael Widenius's avatar
      Merge · a129a824
      Michael Widenius authored
      support-files/build-tags:
        Merge.
      a129a824
    • Michael Widenius's avatar
      Fixed problems in merge · 224108a1
      Michael Widenius authored
      
      mysql-test/r/information_schema.result:
        Fixed a result file.
      mysql-test/r/innodb-autoinc.result:
        Fixed a result file.
      mysql-test/t/connect.test:
        Fixed a problem with merge, needed to close
        connections and use the default
      224108a1
  20. 18 May, 2009 1 commit
  21. 12 May, 2009 1 commit
    • Michael Widenius's avatar
      Merge fixes. · b94f191a
      Michael Widenius authored
      mysql-test/mysql-test-run.pl:
        Fixed missed lines in merge.
      storage/maria/plug.in:
        Fixed problem with configuration. This is now included
        top level.
      storage/pbxt/plug.in:
        Fixed problem with configuration. This is
        included now in top level.
      b94f191a
  22. 11 May, 2009 1 commit
  23. 09 May, 2009 1 commit
  24. 06 May, 2009 1 commit
    • unknown's avatar
      We are now using Valgrind rather than purify, and have for quite some time. · b125770a
      unknown authored
      Consequently, rename HAVE_purify to HAVE_valgrind, and related changes.
      Leave some comments about purify when not clear that they apply also to Valgrind.
      Fix redundant IF_VALGRIND declaration.
      
      Misc. small fixes:
       - Fixes for pool-of-threads patch.
       - Fixes for push of PBXT storage engine.
       - mysql-test-run.pl fix.
       - Fix build problem in compile-pentium64-max.
      
      
      BUILD/SETUP.sh:
        Rename purify -> valgrind.
      BUILD/build_mccge.sh:
        Rename purify -> valgrind.
      BUILD/compile-dist:
        Fix that PBXT was missing in source tarball after `BUILD/compile-dist && make dist`
      BUILD/compile-pentium64-max:
        Fix a build problem with BUILD/compile-pentium64-max on CentOS/Fedora Core 10 amd64.
              
        On these systems, there is libz.so but no libz.a. Finding libz.so, ./configure decides
        to use system zlib. But since BUILD/compile-pentium64-max builds a fully static binary
        with -all-static, the link of mysqld fails due to missing libz.a.
              
        Fix by using bundled zlib in the build script.
      BUILD/compile-solaris-sparc-purify:
        Rename purify -> valgrind.
      include/m_string.h:
        Rename purify -> valgrind.
      include/my_global.h:
        Rename purify -> valgrind.
      mysql-test/Makefile.am:
        Fix that PBXT test suite was missing from `make dist` source tarball.
      mysql-test/lib/mtr_unique.pm:
        Better fix to avoid races when chmod'ing the semaphore file.
        (Though using chmod 666 shared files in /tmp/ is still not a very good solution).
      mysql-test/t/pool_of_threads.cnf:
        Fix that test case pool_of_threads fails if run on mysqld with no --with-libevent support.
      mysys/mf_qsort.c:
        Rename purify -> valgrind.
      mysys/my_alloc.c:
        Rename purify -> valgrind.
      mysys/my_init.c:
        Rename purify -> valgrind.
      mysys/my_rnd.c:
        Rename purify -> valgrind.
      mysys/safemalloc.c:
        Rename purify -> valgrind.
      scripts/mysql_config.pl.in:
        Rename purify -> valgrind.
      scripts/mysql_config.sh:
        Rename purify -> valgrind.
      sql/field_conv.cc:
        Rename purify -> valgrind.
      sql/filesort.cc:
        Rename purify -> valgrind.
      sql/ha_partition.cc:
        Rename purify -> valgrind.
      sql/hostname.cc:
        Rename purify -> valgrind.
      sql/item_timefunc.cc:
        Rename purify -> valgrind.
      sql/log_event.cc:
        Rename purify -> valgrind.
      sql/log_event_old.cc:
        Rename purify -> valgrind.
      sql/my_decimal.h:
        Rename purify -> valgrind.
      sql/mysqld.cc:
        Rename purify -> valgrind.
        Fix redundant IF_VALGRIND declaration.
      sql/opt_range.cc:
        Rename purify -> valgrind.
      sql/opt_range.h:
        Rename purify -> valgrind.
      sql/records.cc:
        Rename purify -> valgrind.
      sql/rpl_rli.cc:
        Rename purify -> valgrind.
      sql/rpl_rli.h:
        Rename purify -> valgrind.
      sql/set_var.cc:
        Fix missing static declaration on pool_of_threads.
      sql/slave.cc:
        Rename purify -> valgrind.
      sql/sql_base.cc:
        Rename purify -> valgrind.
      sql/sql_binlog.cc:
        Rename purify -> valgrind.
      sql/sql_class.cc:
        Rename purify -> valgrind.
      sql/sql_list.h:
        Rename purify -> valgrind.
      sql/sql_load.cc:
        Rename purify -> valgrind.
      sql/sql_select.cc:
        Rename purify -> valgrind.
      sql/table.cc:
        Rename purify -> valgrind.
      storage/archive/azio.c:
        Rename purify -> valgrind.
      storage/innobase/buf/buf0buf.c:
        Rename purify -> valgrind.
      storage/innobase/include/univ.i:
        Rename purify -> valgrind.
      storage/innobase/srv/srv0start.c:
        Rename purify -> valgrind.
      storage/maria/ha_maria.cc:
        Rename purify -> valgrind.
      storage/maria/ma_blockrec.c:
        Rename purify -> valgrind.
      storage/maria/ma_check.c:
        Rename purify -> valgrind.
      storage/maria/ma_loghandler.c:
        Rename purify -> valgrind.
      storage/maria/ma_packrec.c:
        Rename purify -> valgrind.
      storage/maria/ma_page.c:
        Rename purify -> valgrind.
      storage/maria/ma_pagecrc.c:
        Rename purify -> valgrind.
      storage/maria/ma_search.c:
        Rename purify -> valgrind.
      storage/myisam/mi_check.c:
        Rename purify -> valgrind.
      storage/myisam/mi_page.c:
        Rename purify -> valgrind.
      storage/myisam/mi_search.c:
        Rename purify -> valgrind.
      storage/myisammrg/ha_myisammrg.cc:
        Rename purify -> valgrind.
      strings/bcmp.c:
        Rename purify -> valgrind.
      strings/decimal.c:
        Rename purify -> valgrind.
      strings/strmake.c:
        Rename purify -> valgrind.
      b125770a
  25. 05 May, 2009 1 commit
  26. 04 May, 2009 3 commits
  27. 28 Apr, 2009 1 commit