- 09 Oct, 2004 1 commit
-
-
konstantin@mysql.com authored
crashes server (prepared statements)": the bug was that all boolean items always recovered its original arguments at statement cleanup stage. This collided with Item_subselect::select_transformer, which tries to permanently change the item tree to use a transformed subselect instead of original one. So we had this call sequence for prepare: mysql_stmt_prepare -> JOIN::prepare -> Item_subselect::fix_fields -> the item tree gets transformed -> Item_bool_rowready_func2::cleanup, item tree is recovered to original state, while it shouldn't have been; mysql_stmt_execute -> attempts to execute a broken tree -> crash. Now instead of bluntly recovering all arguments of bool functions in Item_bool_rowready_func2::cleanup, we recover only those which were changed, and do it in one place. There still would exist a possibility for a collision with subselect tranformation, if permanent and temporary changes were performed at the same stage. But fortunately subselect transformation is always done first, so it doesn't conflict with the optimization done by propogate_cond_constants. Now we have: mysql_stmt_prepare -> JOIN::prepare -> subselect transformation permanently changes the tree -> cleanup doesn't recover anything, because nothing was registered for recovery. mysql_stmt_execute -> JOIN::prepare (the tree is already transformed, so it doesn't change), JOIN::optimize -> propogate_cond_constants -> temporary changes the item tree with constants -> JOIN::execute -> cleanup -> the changes done by propogate_cond_constants are recovered, as they were registered for recovery.
-
- 08 Oct, 2004 5 commits
-
-
konstantin@mysql.com authored
doesn't need to have it's own recovery mechanism.
-
joerg@mysql.com authored
-
heikki@hundin.mysql.fi authored
into hundin.mysql.fi:/home/heikki/mysql-4.1
-
heikki@hundin.mysql.fi authored
Fix bug #5975 about UTF-8 chars and prefix indexes; do not print warnings if a column prefix is > 255 bytes
-
magnus@neptunus.(none) authored
-
- 07 Oct, 2004 31 commits
-
-
kent@mysql.com authored
To make client_test work as mysql-test-run test case, needs to install it
-
konstantin@mysql.com authored
into mysql.com:/media/sda1/mysql/mysql-4.1-5748-anew
-
konstantin@mysql.com authored
crashes mysqld": implementation for a generic item tree modifications registry. Every item tree modification which should be rolled back for subsequent execution of a prepared statement or stored procedure should be saved in the registry. All such modifications are rolled back at once during cleanup stage of PS. Actual fix for the bug just adds a call to register modifications to convert_constant_item. Post review fixes implemented.
-
-
-
into a80-186-41-201.elisa-laajakaista.fi:/home/my/bk/mysql-4.1
-
-
heikki@hundin.mysql.fi authored
Fix bug #5137: if innodb_file_per_table was specified, CREATE TEMPORARY TABLE ... TYPE=InnoDB said that cannot find path specified, and made mysqld to exit(1)
-
lenz@mysql.com authored
- Updated Docs/Makefile.am and scripts/make_win_src_distribution.sh accordingly
-
lenz@mysql.com authored
into mysql.com:/space/my/mysql-4.1-build
-
tomas@poseidon.ndb.mysql.com authored
into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
...
-
tomas@poseidon.ndb.mysql.com authored
-
heikki@hundin.mysql.fi authored
Merge manually the InnoDB mysqldump -l crash patch (crash with LOCK TABLES ... LOCAL) from 4.0 to 4.1; some code cleanup
-
lenz@mysql.com authored
into mysql.com:/space/my/mysql-4.1-build
-
monty@mysql.com authored
into mysql.com:/home/my/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
-
joerg@mysql.com authored
function being used before it was defined - "forward" declaration was insufficient.
-
monty@mysql.com authored
-
dlenev@mysql.com authored
differently when converting column to auto_increment in 4.1" with current tree.
-
monty@mysql.com authored
into mysql.com:/home/my/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
-
monty@mysql.com authored
into mysql.com:/home/my/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
-
dlenev@brandersnatch.localdomain authored
to auto_increment in 4.1". Now we are enforcing NO_AUTO_VALUE_ON_ZERO mode during ALTER TABLE only if we are converting one auto_increment column to another auto_increment column (this also includes most common case when we don't do anything with such column). Also now when we convert some column to TIMESTAMP NOT NULL column with ALTER TABLE we convert NULL values to current timestamp, (as we do this in INSERT). One can still get old behavior by setting system TIMESTAMP variable to 0.
-
brian@brian-akers-computer.local authored
into brian-akers-computer.local:/Users/brian/mysql/mysql-4.1
-
tomas@poseidon.ndb.mysql.com authored
-
monty@mysql.com authored
Some bigger code changes was necessary becasue of the multi-table-update and the new HANDLER code
-
brian@brian-akers-computer.local authored
Clean up from Bar and Antony code review. Found an issue with the header file were it could end up corrupted.
-
- 06 Oct, 2004 3 commits
-
-
rburnett@build.mysql.com authored
into build.mysql.com:/users/rburnett/mysql-4.0
-
rburnett@build.mysql.com authored
mysqld.cc: Added call to create_pid_file to start_signal_handler on windows. Also removed the #ifndef WINDOWS from two calls that deletes the pid file
-
monty@mysql.com authored
Noteworthy: - New HANDLER code - New multi-update-grant-check code - Table lock code in ha_innodb.cc was not applied
-