- 18 Aug, 2015 3 commits
-
-
Monty authored
- UNINIT_VAR() was required for 4.8.3 on openSUSE 13.2
-
Monty authored
Ensure that fields declared with NOT NULL doesn't have DEFAULT values if not specified and if not timestamp or auto_increment In original code, sometimes one got an automatic DEFAULT value in some cases, in other cases not. For example: create table t1 (a int primary key) - No default create table t2 (a int, primary key(a)) - DEFAULT 0 create table t1 SELECT .... - Default for all fields, even if they where defined as NOT NULL ALTER TABLE ... MODIFY could sometimes add an unexpected DEFAULT value. The patch is quite big because we had some many test cases that used CREATE ... SELECT or CREATE ... (...PRIMARY KEY(xxx)) which doesn't have an automatic DEFAULT anymore. Other things: - Removed warnings from InnoDB when waiting from semaphore (got this when testing things with --big)
-
Monty authored
Issue was two fold (both in MyISAM and Aria) - optimize and repair failed if there was an old .TMM file around. As optimized and repair are protected against multiple execution, I decided to change so that we just truncate the file if it exists. - I had missed to check for error condition if creation of the temporary index file failed. This caused the strange behaviour that it looked as if optimized would have worked once.
-
- 24 Jul, 2015 1 commit
-
-
Sergey Vojtovich authored
Attempting to kill query owned by different user now returns better error: "You are not owner of query N" instead of "You are not owner of thread N".
-
- 23 Jul, 2015 2 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 22 Jul, 2015 2 commits
-
-
Sergei Golubchik authored
-
Jan Lindström authored
Analysis: In fil_crypt_space_needs_rotation we first make sure that tablespace is found and then separately that it is normal tablespace. Thus, tablespace could be dropped between these two functions calls. Fix: If space is not found from fil_system return tablespace type ULINT_UNDEFINED and naturally do not continue rotating space.
-
- 21 Jul, 2015 1 commit
-
-
Jan Lindström authored
Analysis: There is race between drop table and encryption threads that could cause encryption thread to enter mutex that has been already released. Fix: When destroying crypt_data first enter the mutex and set crypt data unavailable, then release the memory and clean up the data. This should make the race more unprobable. Additionally, added big_test for create_or_replace as it could fail testcase timeout if you have slow I/O (tested that testcase passes with --mem).
-
- 20 Jul, 2015 5 commits
-
-
Sergei Golubchik authored
as a workaround until the bug is fixed don't run mroonga tests in --embedded mode by default
-
Sergei Golubchik authored
WARN_DEPRECATED_NO_REPLACEMENT(NULL, ...) was causing a warning, because it expanded into NULL->variables.errmsgs[...]
-
-
Sergei Golubchik authored
because the actual merge was already done in dced5146 as a patch
-
Nirbhay Choubey authored
In non-wsrep builds, wsrep_running_threads should be defined to (0).
-
- 19 Jul, 2015 4 commits
-
-
Elena Stepanova authored
The version in sysvars_innodb,32bit,xtradb.rdiff was not updated
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
--gtid-ignore-duplicates was comparing sequence numbers as 32-bit, so after 2**32 transactions things would start to fail.
-
- 17 Jul, 2015 1 commit
-
-
Elena Stepanova authored
The test did not wait until the server shuts down
-
- 16 Jul, 2015 2 commits
-
-
Monty authored
Problem was that for queries of type: select rand() r, rand() p, rand() = rand() from a having r = p The optimizer thought that r = p was same as rand() = rand() and this would always be true. The problem was that when testing if two expressions are equal, we didn't take into account no determinstic functions. The fix is to not compare non deterministic functions as equal.
-
Monty authored
Other things: - Avoid calling init_and_set_log_file_name() when opening binary log. - Remove newlines early when reading from index file. - Ensure that reset_logs() will work even if thd is 0 (Can happen on startup) - Added thd to sart_slave_threads() for better error handling.
-
- 15 Jul, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 14 Jul, 2015 6 commits
-
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Nirbhay Choubey authored
-
Alexander Barkov authored
-
- 13 Jul, 2015 1 commit
-
-
Alexander Barkov authored
-
- 10 Jul, 2015 3 commits
-
-
Nirbhay Choubey authored
Enable replication of GRANT/REVOKE ROLE commands across galera nodes.
-
Monty authored
Cleanups, fixed warnings from valgrind, fixed failing tests (because on changes in WSREP initialization)
-
Monty authored
This should not have caused any notable errors in most cases. After fix, we are not using keys to solve MIN/MAX if the string used for comparision is longer thant the column-
-
- 09 Jul, 2015 2 commits
-
-
Monty authored
Conflicts: sql/item_subselect.cc Fixed also typo in comment
-
Monty authored
- Cache variables.lc_messages->errmsgs->errmsgs in variables.errmsgs This gives us 15 byte less code space and 2 memory references for any access to language dependent message, of which there are 500 in the server..
-
- 08 Jul, 2015 2 commits
-
-
Alexander Barkov authored
In some cases NO_ZERO_DATE did not allow datetime values with zero date part and non-zero time part (e.g. '0000-00-00 10:20:30.123456'). Allowing values of this kind in all known pieces of the code.
-
Nirbhay Choubey authored
Additional changes : * On startup, do not initialize wsrep if wsrep_on=0. * On shutdown, stop wsrep replication only if > 0 wsrep threads are running.
-
- 07 Jul, 2015 2 commits
-
-
Alexander Barkov authored
-
Alexander Barkov authored
-
- 06 Jul, 2015 2 commits
-
-
Monty authored
- Renaming variables so that they don't shadow others (After this patch one can compile with -Wshadow and get much fewer warnings) - Changed ER(ER_...) to ER_THD(thd, ER_...) when thd was known or if there was many calls to current_thd in the same function. - Changed ER(ER_..) to ER_THD_OR_DEFAULT(current_thd, ER...) in some places where current_thd is not necessary defined. - Removing calls to current_thd when we have access to thd Part of this is optimization (not calling current_thd when not needed), but part is bug fixing for error condition when current_thd is not defined (For example on startup and end of mysqld) Notable renames done as otherwise a lot of functions would have to be changed: - In JOIN structure renamed: examined_rows -> join_examined_rows record_count -> join_record_count - In Field, renamed new_field() to make_new_field() Other things: - Added DBUG_ASSERT(thd == tmp_thd) in Item_singlerow_subselect() just to be safe. - Removed old 'tab' prefix in JOIN_TAB::save_explain_data() and use members directly - Added 'thd' as argument to a few functions to avoid calling current_thd.
-
Nirbhay Choubey authored
-