1. 29 Jun, 2003 1 commit
    • unknown's avatar
      SET CHARACTER SET DEFAULT didn't work (Bug #462) · e224c123
      unknown authored
      
      BUILD/compile-pentium-debug-max:
        Removed -DBIG_TABLES because of problems with gdb 5.3
      sql/set_var.cc:
        SET CHARACTER SET DEFAULT didn't work
      sql/set_var.h:
        SET CHARACTER SET DEFAULT didn't work
      e224c123
  2. 27 Jun, 2003 2 commits
    • unknown's avatar
      Fixed testcase after last changes · 5768f4a3
      unknown authored
      5768f4a3
    • unknown's avatar
      Added thread variable max_seeks_for_key · c2cb9b97
      unknown authored
      Change optimizer to prefer key lookups before table scan
      Change table scans to be done after tables with constrains on scanned table 
      
      
      mysql-test/r/distinct.result:
        Update results
      mysql-test/r/group_by.result:
        Update results
      mysql-test/r/heap.result:
        Update results
      mysql-test/r/join.result:
        Update results
      mysql-test/r/key_diff.result:
        Update results
      mysql-test/r/myisam.result:
        Update results
      mysql-test/r/order_by.result:
        Update results
      mysql-test/r/select_safe.result:
        Update results
      mysql-test/t/distinct.test:
        Change test to be repeatable
      mysql-test/t/join.test:
        Change test to be repeatable
      mysql-test/t/select_safe.test:
        Add tests for MAX_SEEKS_FOR_KEY
      sql/handler.h:
        Optimize structure for 64 bit machines (and to avoid problems with gdb)
      sql/item_cmpfunc.cc:
        Initialize not_null_tables_cache properly
      sql/mysqld.cc:
        Added max_seeks_for_key
      sql/set_var.cc:
        Added max_seeks_for_key
      sql/sql_class.h:
        Added max_seeks_for_key
      sql/sql_select.cc:
        Added max_seeks_for_key
        Change optimizer to prefer key lookups before table scan.
        Change table scans to be done after tables with constrains on scanned table
      c2cb9b97
  3. 26 Jun, 2003 2 commits
    • unknown's avatar
      Fixed memory allocation in Unique to not allocate too much memory · 7539980e
      unknown authored
      
      myisam/mi_info.c:
        Updated comments
      mysys/tree.c:
        Added comment
      sql/net_serv.cc:
        Added comment
      7539980e
    • unknown's avatar
      LEFT JOIN optimization: Change LEFT JOIN to normal join if possible · a3beaaa3
      unknown authored
      
      mysql-test/r/select.result:
        Added test for LEFT JOIN optimization
      mysql-test/t/select.test:
        Added test for LEFT JOIN optimization
      sql/item.h:
        LEFT JOIN optimization
      sql/item_cmpfunc.cc:
        LEFT JOIN optimization
      sql/item_cmpfunc.h:
        LEFT JOIN optimization
      sql/item_func.cc:
        LEFT JOIN optimization
      sql/item_func.h:
        LEFT JOIN optimization
      sql/item_strfunc.cc:
        LEFT JOIN optimization
      sql/sql_base.cc:
        Heart of LEFT JOIN optimization
      a3beaaa3
  4. 23 Jun, 2003 9 commits
  5. 22 Jun, 2003 2 commits
    • unknown's avatar
      dict0dict.h, dict0dict.c, ha_innodb.cc: · e0be1a89
      unknown authored
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      
      
      sql/ha_innodb.cc:
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      innobase/dict/dict0dict.c:
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      innobase/include/dict0dict.h:
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      e0be1a89
    • unknown's avatar
      Fixed cleanup_load_tmpdir() which deleted nothing. · f403da4b
      unknown authored
      
      sql/log_event.cc:
        - cleanup_load_tmpdir() did not work at all because it forgot to indicate
        the directory part of the path when calling my_delete().
        - A misplaced R_POS_OFFSET (fortunately this was no bug as this constant is 0).
      sql/sql_repl.cc:
        - fix fake_rotate_event() for pos>4G (correction of a change I pushed yesterday).
      f403da4b
  6. 21 Jun, 2003 1 commit
  7. 20 Jun, 2003 5 commits
  8. 19 Jun, 2003 3 commits
    • unknown's avatar
      Fix error msg. Bug #681 · 332334e8
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      332334e8
    • unknown's avatar
      Fix for bug #616 mysqld crash / SSL with SQLyog · 4eef86c6
      unknown authored
      4eef86c6
    • unknown's avatar
      SCRUM · 85d2282e
      unknown authored
      Task ID 894:
      Backport default_week_format variable to 4.0
      
      
      mysql-test/r/func_time.result:
        Backport default_week_format variable to 4.0
      mysql-test/t/func_time.test:
        Backport default_week_format variable to 4.0
      sql/mysqld.cc:
        Backport default_week_format variable to 4.0
      sql/set_var.cc:
        Backport default_week_format variable to 4.0
      sql/sql_class.h:
        Backport default_week_format variable to 4.0
      sql/sql_yacc.yy:
        Backport default_week_format variable to 4.0
      85d2282e
  9. 18 Jun, 2003 6 commits
  10. 17 Jun, 2003 4 commits
    • unknown's avatar
      row0vers.c, row0sel.c, row0ins.c: · 1efc292b
      unknown authored
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      
      
      innobase/row/row0ins.c:
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      innobase/row/row0sel.c:
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      innobase/row/row0vers.c:
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      1efc292b
    • unknown's avatar
      Changed change_master() to use ER_MASTER_INFO (better display). · b518744d
      unknown authored
      
      mysql-test/r/rpl_rotate_logs.result:
        result update
      mysql-test/t/rpl_rotate_logs.test:
        comments and test update with the error code
      sql/slave.cc:
        A DBUG_PRINT
      sql/sql_repl.cc:
        Use ER_MASTER_INFO instead of custom message and zero error code (which display
        badly).
      b518744d
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.0 · 926d86db
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      926d86db
    • unknown's avatar
      Better error reporting in mysql-test-run (don't hide the important message · 800bbfa0
      unknown authored
      with 'head').
      Test fix (this sync_with_master was nonsense).
      Now all tests pass in 4.0 in autobuild.
      
      
      mysql-test/mysql-test-run.sh:
        Error reporting (how mysql-test-run filters the messages which mysqltest prints
        on stderr) is not reliable. It does a 'head the first line only' which in
        my case caused me to lose some time, because in fact the worrying message was
        on the second line (logically, the one which caused the die() is at the
        end of the $TIMEFILE file, not at the beginning).
        Doing a 'tail' is better but not perfect (depending on the build, one may get
        "Maximum memory usage" as the last line); it's always good to have all messages
        and spot the important one oneself. So we print all $TIMEFILE (that's a few lines
        at most).
      mysql-test/t/rpl_rotate_logs.test:
        Dont sync_with_master as the SQL slave thread may be stopped at this moment;
        just wait_for_slave_to_stop. Doing sync_with_master caused a non-deterministic
        behaviour, because (note that save_master_pos was called to early) sometimes
        MASTER_POS_WAIT() started before the SQL thread died (because of unique
        violation) so returned 0, other times it started after the SQL thread died
        so returned NULL (which is reported by mysqltest as an error, on stderr).
      800bbfa0
  11. 16 Jun, 2003 4 commits
    • unknown's avatar
      fulltext and left join bug fixed · ad5c763e
      unknown authored
      
      mysql-test/t/fulltext.test:
        explain select fulltext test
      mysql-test/t/fulltext_left_join.test:
        explain select fulltext test
      ad5c763e
    • unknown's avatar
      e85ecbc1
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.0 · 3286e4e1
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      3286e4e1
    • unknown's avatar
      Fix for nightly build test failure (test update). · 366fd92e
      unknown authored
      More messages.
      Testcase for bug 651.
      
      
      client/mysqltest.c:
        More explicit error message if MASTER_POS_WAIT() returns NULL.
      mysql-test/r/rpl_loaddata.result:
        result update
      mysql-test/r/rpl_master_pos_wait.result:
        result update
      mysql-test/t/rpl000001.test:
        sync_with_master (=MASTER_POS_WAIT()) was called when we could expect the SQL slave thread had stopped.
        As I yesterday changed code so that "SQL thread stops => MASTER_POS_WAIT() returns NULL immediately" (bugfix),
        sync_with_master received NULL (on build.mysql.com, not on my machine; this is a question of milliseconds,
        if the slave server will process MASTER_POS_WAIT() before or after the slave SQL thread has stopped), and
        in mysqltest.c, sync_with_master complained that it could not sync.
        So I just remove this sync_with_master, which does not make sense anymore: we just wait for the slave SQL
        thread to stop.
      mysql-test/t/rpl_loaddata.test:
        Discovered we had wait_for_slave_to_stop, so used it as it automates things.
      mysql-test/t/rpl_master_pos_wait.test:
        Discovered we had 'send' to send a query without waiting for the resultn so could had a testcase for bug 651.
        Shorter timeouts as there is no risk the position is reached.
      sql/slave.cc:
        A longer DBUG_PRINT.
      366fd92e
  12. 15 Jun, 2003 1 commit
    • unknown's avatar
      row0mysql.c, dict0dict.ic: · 722e8060
      unknown authored
        Cleanup
      ha_innodb.cc, data0type.h:
        Make sure non-latin1 users can downgrade from 4.0.14 to an earlier version if they have not created DATA_BLOB column prefix indexes
      
      
      innobase/include/data0type.h:
        Make sure non-latin1 users can downgrade from 4.0.14 to an earlier version if they have not created DATA_BLOB column prefix indexes
      sql/ha_innodb.cc:
        Make sure non-latin1 users can downgrade from 4.0.14 to an earlier version if they have not created DATA_BLOB column prefix indexes
      innobase/include/dict0dict.ic:
        Cleanup
      innobase/row/row0mysql.c:
        Cleanup
      722e8060