- 23 Jun, 2005 1 commit
-
-
unknown authored
The source of the problem is in Field_longlong::cmp. If 'this' is an unsigned number, the method casts both the current value, and the constant that we compare with to an unsigned number. As a result if the constant we compare with is a negative number, it wraps to some unsigned number, and the comparison is incorrect. When the optimizer chooses the "range" access method, this problem causes handler::read_range_next to reject the current key when the upper bound key is a negative number because handler::compare_key incorrectly considers the positive and negative keys to be equal. The current patch does not correct the source of the problem in Field_longlong::cmp because it is not easy to propagate sign information about the constant at query execution time. Instead the patch changes the range optimizer so that it never compares unsiged fields with negative constants. As an added benefit, queries that do such comparisons will execute faster because the range optimizer replaces conditions like: (a) (unsigned_int [< | <=] negative_constant) == FALSE (b) (unsigned_int [> | >=] negative_constant) == TRUE with the corresponding constants. In some cases this may even result in constant time execution. mysql-test/r/range.result: - Changed incorrect result of an old test - Added new results for BUG#11185 mysql-test/t/range.test: - Added new tests for BUG#11185 - Deleted an old comment because now the problem is fixed sql/opt_range.cc: Added a new optimization to the range optimizer where we detect that an UNSIGNED field is compared with a negative constant. Depending on the comparison operator, we know directly that the result of the comparison is either TRUE or FALSE for all input values, and we need not check each value. This optimization is also necessary so that the index range access method produces correct results when comparing unsigned fields with negative constants.
-
- 21 Jun, 2005 8 commits
-
-
unknown authored
Added optional paths for finding mysqld on Windows Added language/charset options to embedded mysql_client_test mysql-test/mysql-test-run.pl: Added optional paths for finding mysqld on Windows Added language/charset options to embedded mysql_client_test
-
unknown authored
into moonbone.local:/work/mysql-4.1-bug-10886 sql/sql_insert.cc: Auto merged
-
unknown authored
Temporary field wasn't restored to default values after ON DUPLICATE KEY UPDATE event, which results in wrong data being inserted in new record. sql/sql_insert.cc: Fix bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY UPDATE produces bad results mysql-test/t/insert_select.test: Test case for bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY UPDATE produces bad results mysql-test/r/insert_select.result: Test case for bug #10886 - INSERT ... SELECT ... ON DUPLICATE KEY UPDATE produces bad results
-
unknown authored
into rurik.mysql.com:/home/igor/mysql-4.1
-
unknown authored
into rurik.mysql.com:/home/igor/dev/mysql-4.1-1
-
unknown authored
Added a test case for bug #11295. item_buff.cc: Fixed bug #11295. This a correction for the patch of bug #11088 that takes into account a possible NULL values of the BLOB column. sql/item_buff.cc: Fixed bug #11295. This a correction for the patch of bug #11088 that takes into account a possible NULL values of the BLOB column. mysql-test/t/group_by.test: Added a test case for bug #11295. mysql-test/r/group_by.result: Added a test case for bug #11295.
-
unknown authored
into mysql.com:/usr/local/home/marty/MySQL/mysql-4.1
-
unknown authored
More compact and safe handling of path names. Support for running in Windows source tree. Use libtool wrapper, instead of messing with library path names, and objects in .libs dir. mtr_misc.pl: Utility function that search aand check path names mtr_report.pl: Patch by Carsten, set correct reject/result/eval if not main suite mysql-test/lib/mtr_report.pl: Patch by Carsten, set correct reject/result/eval if not main suite mysql-test/lib/mtr_misc.pl: Utility function that search aand check path names mysql-test/mysql-test-run.pl: More compact and safe handling of path names. Support for running in Windows source tree. Use libtool wrapper, instead of messing with library path names, and objects in .libs dir.
-
- 20 Jun, 2005 24 commits
-
-
unknown authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
unknown authored
Bug#11466: Script can now get test case name from test case file path on command line mysql-test-run.pl: Bug#11466: Added --skip-ndbcluster/--skip-ndb option mtr_cases.pl: Don't set --default-time-zone if opt file sets it Restart the server if time zone is given in opt file mysql-test-run.pl: Don't remove symlink to "var" directory in cleanup Removed duplicate/unessesary options to mysqld mysql-test/mysql-test-run.pl: Bug#11466: Added --skip-ndbcluster/--skip-ndb option mysql-test/lib/mtr_cases.pl: Bug#11466: Script can now get test case name from test case file path on command line
-
unknown authored
into mysql.com:/Users/kent/mysql/bk/mysql-4.1
-
unknown authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
unknown authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
unknown authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
unknown authored
into rurik.mysql.com:/home/igor/mysql-4.1
-
unknown authored
Added a test case for bug #11385. group_by.test: Added a test case for bug #11385. field.h: Fixed bug #11385. The bug was due to not defined method decimals for the class Field_datetime. sql/field.h: Fixed bug #11385. The bug was due to not defined method decimals for the class Field_datetime. mysql-test/t/group_by.test: Added atest case for bug #11385. mysql-test/r/group_by.result: Added a test case for bug #11385.
-
unknown authored
commit. (Bug #10840) client/mysql.cc: Add cast of unsigned value stored in signed char
-
unknown authored
Corrected dependency for "lex_hash.h", to avoid occasional make failure sql/Makefile.am: Corrected dependency for "lex_hash.h", to avoid occasional make failure
-
unknown authored
Added CR for readability sql/ha_ndbcluster.cc: Added CR for readability
-
unknown authored
-
unknown authored
into mysql.com:/usr/local/home/marty/MySQL/mysql-4.1
-
unknown authored
into igor-inspiron.creware.com:/home/igor/mysql-4.1 sql/sql_select.cc: Auto merged
-
unknown authored
into mysql.com:/home/dlenev/src/mysql-4.1-bg11060
-
unknown authored
INSERT ... SELECT with UNION" (reviewed version). Altough bug manifest itself only starting from 5.0 it is better to apply fix to 4.1 to keep some assumptions true and make code more future-proof. mysql-test/r/ps.result: Added test case for bug #11060 "Server crashes on re-execution of prepared INSERT ... SELECT with UNION". mysql-test/t/ps.test: Added test case for bug #11060 "Server crashes on re-execution of prepared INSERT ... SELECT with UNION". sql/sql_insert.cc: select_insert::prepare(): Item::fix_fields() methods operate assuming that LEX::current_select points to the select to which current item belongs. Thus during check_insert_fields() routine execution LEX::current_select should point ot the first select in query since this is the select with which items in insert list is associated. But if we have INSERT SELECT UNION SELECT type of query LEX::current_select will point to the fake_select_lex instead since select_insert::prepare() is called during processing of JOIN which corresponds to this select_lex. So we have set LEX::current_select before calling check_insert_fields() and restore it afterwards.
-
unknown authored
Use the Perl version of mysql-test-run Makefile.am: Use the Perl version of mysql-test-run
-
unknown authored
Corrected path to 'mysql_fix_privilege_tables' mysql-test/mysql-test-run.pl: Corrected path to 'mysql_fix_privilege_tables'
-
unknown authored
into mysql.com:/usr/local/home/marty/MySQL/mysql-4.1
-
unknown authored
Corrected path to 'mysql_fix_privilege_tables' Corrected dummy --manager-port to take integer argument mysql-test/mysql-test-run.pl: Corrected path to 'mysql_fix_privilege_tables'
-
unknown authored
into mysql.com:/usr/local/home/marty/MySQL/mysql-4.1 sql/ha_ndbcluster.cc: Auto merged
-
unknown authored
into dl145c.mysql.com:/home/ndbdev/tomas/mysql-4.1
-
unknown authored
remove typecheck in ndb handler not needed sql/ha_ndbcluster.cc: remove typecheck in ndb handler not needed
-
unknown authored
ndb/src/kernel/SimBlockList.cpp: GCC 4.0 build fix
-
- 19 Jun, 2005 2 commits
-
-
unknown authored
Added dummy --manager-port flag, for backward compatibility Back port from 5.0, correction of paths to SSL pem files mtr_cases.pl: Removed hard coded exclude list for embedded server mysql-test-run.pl: Set environment variable MYSQL_SHOW, to be used in test cases mysql-test/lib/mtr_cases.pl: Removed hard coded exclude list for embedded server mysql-test/mysql-test-run.pl: Added dummy --manager-port flag, for backward compatibility Back port from 5.0, correction of paths to SSL pem files
-
unknown authored
into mysql.com:/Users/kent/mysql/bk/mysql-4.1
-
- 18 Jun, 2005 2 commits
- 17 Jun, 2005 3 commits
-
-
unknown authored
which the query contained more words than we allocated space. (Bug #7858) myisam/ft_boolean_search.c: Fix calculation of max number of elements -- "words" may not have spaces between them. mysql-test/t/fulltext.test: Modify test to be specific to reported bug (fix for old bug wasn't quite enough) mysql-test/r/fulltext.result: Update results
-
unknown authored
-
unknown authored
into rurik.mysql.com:/home/igor/mysql-4.1
-