1. 14 Dec, 2009 2 commits
    • Sven Sandberg's avatar
      Post-push fixes after wrong merge from 5.1->rep+2->rep+3. · e83c9f62
      Sven Sandberg authored
      Problem: The test was written before BUG#45827 was fixed.
      The test contained code that assumed the wrong behavior,
      pre-BUG#45827. Then, the fix for BUG#45827 was merged
      from 5.1-rep+2 to 5.1-rep+3. Since the test case assumed
      the wrong behavior, it failed. This should have been fixed
      by making the test assume the correct behavior, but was
      fixed by updating the result file to assert failure.
      Fix 1: fix the test to assume correct behavior
      (post-BUG#45827), update result file.
      Fix 2: make test fail with 'die' instead of 'exit' when
      wrong behavior is detected. Thus, the test cannot be
      silenced with a wrong result file in case the behavior
      will change again.
      
      
      mysql-test/extra/rpl_tests/create_recursive_construct.inc:
        Replaced 'exit' by 'die' to avoid similar
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Updated result file.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Since BUG#45827 is now fixed, we need to update the test case
        in two places where it expects the wrong result because of
        BUG#45827.
      e83c9f62
    • Alfranio Correia's avatar
      46fe96c1
  2. 03 Dec, 2009 1 commit
    • unknown's avatar
      WL#5142 FLUSH LOGS should take optional arguments for which log(s) to flush · ac647f5a
      unknown authored
      Support for flushing individual logs, so that the user can
      selectively flush a subset of the server logs.
      
      Flush of individual logs is done according to the 
      following syntax:
      
        FLUSH <log_category> LOGS;
      
      The syntax is extended so that the user is able to flush a
      subset of logs:
      
        FLUSH [log_category LOGS,];
      
      where log_category is one of:
        SLOW
        ERROR
        BINARY
        ENGINE
        GENERAL
        RELAY.
      
      
      mysql-test/suite/rpl/r/rpl_flush_logs.result:
        Test result for WL#5142.
      mysql-test/suite/rpl/t/rpl_flush_logs.test:
        Added the test file to verify if the 'flush individual log' 
        statement works fine.
      sql/log.cc:
        Added the two functions to flush slow and general log.
      sql/sql_parse.cc:
        Added code to flush specified logs against the option.
      sql/sql_yacc.yy:
        Added code to parse the 'flush * log' statement syntax and 
        set its option to Lex->type.
      ac647f5a
  3. 02 Dec, 2009 1 commit
  4. 30 Nov, 2009 3 commits
  5. 28 Nov, 2009 1 commit
  6. 27 Nov, 2009 1 commit
  7. 26 Nov, 2009 1 commit
  8. 24 Nov, 2009 1 commit
    • Luis Soares's avatar
      BUG#42150: binlog_start_comment.test failed: Error writing file 'UNOPENED' · 76623d35
      Luis Soares authored
      NOTE: backporting BUG#42150 into next-mr
            Includes latest Andrei's patch (see [2 Feb 18:40] Bugs System)
            and merge.test post-push fix (see [3 Feb 18:04] Bugs System)
      
      The reason of the bug appeared to be overreacting on absense of a
      binlog file although the file name had been presented in in the master
      binlog index file.
      By convention, there should have been only a warning printed and the rest of
      `reset master' logics completed.  This did not happen on windows
      due to incorrect value of my_errno returned from nt_share_delete().
            
      Fixed with correcting my_errno assignment in nt_share_delete() to be ENOENT in 
      he event of no binlog file. Some minor refactoring has been made.
      76623d35
  9. 22 Nov, 2009 1 commit
    • Luis Soares's avatar
      BUG#40611: MySQL cannot make a binary log after sequential number · 2fe9fb2b
      Luis Soares authored
      beyond unsigned long.
      BUG#44779: binlog.binlog_max_extension may be causing failure on 
      next test in PB
                  
      NOTE1: this is the backport to next-mr.
      NOTE2: already includes patch for BUG#44779.
                  
      Binlog file extensions would turn into negative numbers once the
      variable used to hold the value reached maximum for signed
      long. Consequently, incrementing value to the next (negative) number
      would lead to .000000 extension, causing the server to fail.
                              
      This patch addresses this issue by not allowing negative extensions
      and by returning an error on find_uniq_filename, when the limit is
      reached. Additionally, warnings are printed to the error log when the
      limit is approaching. FLUSH LOGS will also report warnings to the
      user, if the extension number has reached the limit. The limit has been
      set to 0x7FFFFFFF as the maximum.
      
      mysql-test/suite/binlog/t/binlog_max_extension.test:
        Test case added that checks the maximum available number for
        binlog extensions.
      sql/log.cc:
        Changes to find_uniq_filename and test_if_number.
      sql/log.h:
        Added macros with values for MAX_LOG_UNIQUE_FN_EXT and
        LOG_WARN_UNIQUE_FN_EXT_LEFT, as suggested in review.
      2fe9fb2b
  10. 20 Nov, 2009 1 commit
    • Andrei Elkin's avatar
      Bug #48463 backporting from 6.0-rpl to celosia a set of bugs · 976e1559
      Andrei Elkin authored
      The mentioned on the bug report set of bugs fixes have not be pushed to the main trees.
      
      Fixed with extracting commits done to 6.0-rpl tree and applying them to the main 5.1.
      Notes.
      1. part of changes - the mtr's specific - were packported to the main 5.0 tree for mtr v1
         as http://lists.mysql.com/commits/46562
         However, there is no that fix anymore in the mtr v2. (This fact was mailed to mtr maintaining
         people).
      
      2. Bug@36929  crash in kill_zombie_dump_threads-> THD::awake() with replication tests
         is not backported because the base code of the patch is libevent and that was removed
         from the main trees due to its instability.
      
      client/mysqlbinlog.cc:
        fixes for BUG#35546
      mysql-test/suite/rpl/r/rpl_bug41902.result:
        the new tests result file is added.
      mysql-test/suite/rpl/t/rpl_bug41902-slave.opt:
        conf file for bug41902 testing is added.
      mysql-test/suite/rpl/t/rpl_bug41902.test:
        regression tests for Bug #41902 is added.
      sql/log.cc:
        collection of changes due to Bug #48463.
      sql/log.h:
        collection of changes due to Bug #48463.
      sql/rpl_rli.h:
        collection of changes due to Bug #48463.
      sql/slave.cc:
        collection of changes due to Bug #48463.
      sql/sql_repl.cc:
        collection of changes due to Bug #48463.
      976e1559
  11. 16 Nov, 2009 1 commit
    • Luis Soares's avatar
      BUG#48048: Deprecated constructs need removal in Betony · 625ddcd5
      Luis Soares authored
      Post-push fix: Removed MTRv1 arguments according to the
      original patch. Although there is a version check, the patch
      was pushed to a 5.1 GA staging tree, while the version check 
      considers version 5.2. This makes the deprecated parameters 
      to be used, despite the fact that they are not valid anymore.
      
      Part of MTRv1 is currently used in RQG semisync test, and this
      was causing the test to fail on slave startup.
      
      It should be safe to uncomment when merging up to celosia.
      625ddcd5
  12. 15 Nov, 2009 1 commit
    • He Zhenxing's avatar
      Postfix after merge · 558feaa2
      He Zhenxing authored
      After fix of bug46322, logging to table is turned off, each test
      that need this should turn on it in it's opt file.
      
      Add suppression to unsafe statement warnings for binlog_unsafe.test.
      
      mysql-test/suite/binlog/t/binlog_unsafe-master.opt:
        After fix of bug46322, logging to table is turned off, each test that need this should turn on it in it's opt file.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        suppress Unsafe statement warnings
      558feaa2
  13. 13 Nov, 2009 5 commits
    • Luis Soares's avatar
      BUG#44188: STOP SLAVE should flush info files and relay logs. · 9220e09f
      Luis Soares authored
            
      Replication info files are not being flushed and synced when the
      command 'STOP SLAVE' is issued. This means that one cannot just
      rely on existing values on those files when the slave has been
      stopped. Having consistent, uncorrupted and up-to-date info files
      when stopping the slave would be most useful, for instance, for
      snapshotting purposes (a procedure that is often used for
      restoring slaves).
            
      This patch addresses this by instrumenting the
      terminate_slave_threads function so that it also flushes and
      syncs the *info files as well as the relay log whenever it gets
      called, ie, on 'STOP SLAVE'.  Although this imposes a performance
      trade-off (specifically when stopping the slave), it should have
      no negative influence on overall replication performance (impact
      is only noticeable on 'STOP SLAVE').
      9220e09f
    • Luis Soares's avatar
      BUG#48048: Deprecated constructs need removal in Betony · bcb25587
      Luis Soares authored
      Post-push fix: Reverting change in Makefile.am which was
      causing windows not to build client/.
      bcb25587
    • Luis Soares's avatar
      manual merge: mysql-5.1-rep+2 (bug tree) --> mysql-5.1-rep+2 (latest) · d8ca6b9d
      Luis Soares authored
      CONFLICTS
      =========
      
      Text conflict in sql/sql_yacc.yy
      1 conflicts encountered. 
      d8ca6b9d
    • unknown's avatar
      Backport Bug #45827 Stmt using two autoinc values does not produce unsafe warning · 0d46e588
      unknown authored
            
      One statement that have more than one different tables to update with 
      autoinc columns just was marked as unsafe in mixed mode, so the unsafe 
      warning can't be produced in statement mode.
            
      To fix the problem, mark the statement as unsafe in statement mode too.
      
      
      mysql-test/extra/rpl_tests/rpl_insert_id.test:
        The test case is updated due to the patch of bug#45827.
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        The test result is updated due to the patch of bug#45827.
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Test result for bug#45827.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Added test to verify if stmt that have more than one
        different tables to update with autoinc columns will 
        produce unsafe warning
      mysql-test/suite/rpl/r/rpl_stm_auto_increment_bug33029.result:
        The test result is updated due to the patch of bug#45827.
      mysql-test/suite/rpl/t/rpl_trigger.test:
        The test case is updated due to the patch of bug#45827.
      mysql-test/suite/rpl/t/rpl_variables_stm.test:
        The test case is updated due to the patch of bug#45827.
      sql/sql_base.cc:
        Reomved the 'set_current_stmt_binlog_row_based_if_mixed' function 
        for producing unsafe warnings by executing 'decide_logging_format' 
        function later in statement mode
      0d46e588
    • Alfranio Correia's avatar
      Post-fix for WL#2687 WL#5072 BUG#40278 BUG#47175 · 4677f4de
      Alfranio Correia authored
      Create a set of test cases to see if some DDL statements implicitly commit
      a transaction on the NDB and are written directly to the binary log without
      going through either the Statement- or Transactional-Cache.
      4677f4de
  14. 11 Nov, 2009 3 commits
    • Alfranio Correia's avatar
      Post-fix after mysql-5.1-rep+2 --> mysql-5.1-rep+3. · 518f7932
      Alfranio Correia authored
      mysql-test/extra/binlog_tests/binlog_failure_mixing_engines.test:
        Merged the test case into rpl_mixing_engines.test.
      mysql-test/extra/rpl_tests/rpl_mixing_engines.inc:
        Incorporated some tests from binlog_failure_mixing_engines.test and
        fixed after BUG#47323.
      mysql-test/extra/rpl_tests/rpl_mixing_engines.test:
        Incorporated some tests from binlog_failure_mixing_engines.test and
        fixed after BUG#47323.
      mysql-test/suite/binlog/r/binlog_mixed_failure_mixing_engines.result:
        Merged the test case into rpl_mixing_engines.test.
      mysql-test/suite/binlog/r/binlog_row_failure_mixing_engines.result:
        Merged the test case into rpl_mixing_engines.test.
      mysql-test/suite/binlog/t/binlog_mixed_failure_mixing_engines.test:
        Merged the test case into rpl_mixing_engines.test.
      mysql-test/suite/binlog/t/binlog_row_failure_mixing_engines.test:
        Merged the test case into rpl_mixing_engines.test.
      mysql-test/suite/rpl/r/rpl_mixed_mixing_engines.result:
        Incorporated some tests from binlog_failure_mixing_engines.test and
        changed after BUG#47323.
      mysql-test/suite/rpl/r/rpl_row_mixing_engines.result:
        Incorporated some tests from binlog_failure_mixing_engines.test and
        changed after BUG#47323.
      mysql-test/suite/rpl/r/rpl_stm_mixing_engines.result:
        Incorporated some tests from binlog_failure_mixing_engines.test and
        changed after BUG#47323.
      518f7932
    • Alfranio Correia's avatar
      Post-fix for merge mysql-5.1-rep+2 --> mysql-5.1-rep+3 · 6ed2c824
      Alfranio Correia authored
      mysql-test/extra/rpl_tests/rpl_implicit_commit_binlog.test:
        Re-enabled some parts of the test after BUG#46572
      mysql-test/suite/rpl/r/rpl_mixed_implicit_commit_binlog.result:
        Re-enabled some parts of the test after BUG#46572
      mysql-test/suite/rpl/r/rpl_mysql_upgrade.result:
        Suppressed warning messages due to unsafe statements.
      mysql-test/suite/rpl/r/rpl_row_implicit_commit_binlog.result:
        Re-enabled some parts of the test after BUG#46572
      mysql-test/suite/rpl/r/rpl_stm_implicit_commit_binlog.result:
        Re-enabled some parts of the test after BUG#46572
      mysql-test/suite/rpl/t/rpl_mixed_implicit_commit_binlog.test:
        Re-enabled some parts of the test after BUG#46572
      mysql-test/suite/rpl/t/rpl_mysql_upgrade.test:
        Suppressed warning messages due to unsafe statements.
      mysql-test/suite/rpl/t/rpl_row_implicit_commit_binlog.test:
        Re-enabled some parts of the test after BUG#46572
      mysql-test/suite/rpl/t/rpl_stm_implicit_commit_binlog.test:
        Re-enabled some parts of the test after BUG#46572
      6ed2c824
    • Luis Soares's avatar
      BUG#48048: Deprecated constructs need removal in Betony · 7cf9ee96
      Luis Soares authored
      Removed test case that was left without significance after
      backporting the deprecated constructs from 6.0 codebase.
      7cf9ee96
  15. 10 Nov, 2009 1 commit
  16. 06 Nov, 2009 1 commit
  17. 04 Nov, 2009 6 commits
  18. 03 Nov, 2009 9 commits
    • Alfranio Correia's avatar
      WL#2687 WL#5072 BUG#40278 BUG#47175 · 19c380aa
      Alfranio Correia authored
      Non-transactional updates that take place inside a transaction present problems
      for logging because they are visible to other clients before the transaction
      is committed, and they are not rolled back even if the transaction is rolled
      back. It is not always possible to log correctly in statement format when both
      transactional and non-transactional tables are used in the same transaction.
      
      In the current patch, we ensure that such scenario is completely safe under the
      ROW and MIXED modes.
      19c380aa
    • Davi Arnaut's avatar
      Automerge. · cca9eeb6
      Davi Arnaut authored
      cca9eeb6
    • Davi Arnaut's avatar
      69859d8d
    • Konstantin Osipov's avatar
      A fix and a test case for · cb0cca86
      Konstantin Osipov authored
      Bug#41756 "Strange error messages about locks from InnoDB".
            
      In JT_EQ_REF (join_read_key()) access method, 
      don't try to unlock rows in the handler, unless certain that 
      a) they were locked
      b) they are not used.
      
      Unlocking of rows is done by the logic of the nested join loop,
      and is unaware of the possible caching that the access method may
      have. This could lead to double unlocking, when a row
      was unlocked first after reading into the cache, and then 
      when taken from cache, as well as to unlocking of rows which
      were actually used (but taken from cache).
            
      Delegate part of the unlocking logic to the access method,
      and in JT_EQ_REF count how many times a record was actually 
      used in the join. Unlock it only if it's usage count is 0.
      
      Implemented review comments.
      
      mysql-test/r/innodb_lock_wait_timeout_1.result:
        Update results (Bug41756).
      mysql-test/t/innodb_lock_wait_timeout_1.test:
        Add a test case (Bug#41756).
      sql/item_subselect.cc:
        Complete struct READ_RECORD initialization with a new
        member to unlock records.
      sql/records.cc:
        Extend READ_RECORD API with a method to unlock read records.
      sql/sql_select.cc:
        In JT_EQ_REF (join_read_key()) access method, 
        don't try to unlock rows in the handler, unless certain that 
        a) they were locked
        b) they are not used.
      sql/sql_select.h:
        Add members to TABLE_REF to count TABLE_REF buffer usage count.
      sql/structs.h:
        Update declarations.
      cb0cca86
    • Magnus Blåudd's avatar
      Merge bug#47867 to 5.1-bugteam · 7b7f0149
      Magnus Blåudd authored
      7b7f0149
    • Konstantin Osipov's avatar
      A fix and a test case for · 06c9d62a
      Konstantin Osipov authored
      Bug#41756 "Strange error messages about locks from InnoDB".
      
      In JT_EQ_REF (join_read_key()) access method,
      don't try to unlock rows in the handler, unless certain that
      a) they were locked
      b) they are not used.
      
      Unlocking of rows is done by the logic of the nested join loop,
      and is unaware of the possible caching that the access method may
      have. This could lead to double unlocking, when a row
      was unlocked first after reading into the cache, and then
      when taken from cache, as well as to unlocking of rows which
      were actually used (but taken from cache).
      
      Delegate part of the unlocking logic to the access method,
      and in JT_EQ_REF count how many times a record was actually
      used in the join. Unlock it only if it's usage count is 0.
      
      Implemented review comments.
      
      
      mysql-test/r/bug41756.result:
        Add result file (Bug#41756)
      mysql-test/t/bug41756-master.opt:
        Use --innodb-locks-unsafe-for-binlog, as in 5.0 just
        using read_committed isolation is not sufficient to 
        reproduce the bug.
      mysql-test/t/bug41756.test:
        Add a test file (Bug#41756)
      sql/item_subselect.cc:
        Complete struct READ_RECORD initialization with a new
        member to unlock records.
      sql/records.cc:
        Extend READ_RECORD API with a method to unlock read records.
      sql/sql_select.cc:
        In JT_EQ_REF (join_read_key()) access method,
        don't try to unlock rows in the handler, unless certain that
        a) they were locked
        b) they are not used.
      sql/sql_select.h:
        Add members to TABLE_REF to count TABLE_REF buffer usage count.
      sql/structs.h:
        Update declarations.
      06c9d62a
    • Kristofer Pettersson's avatar
      automerge · cafe3c7f
      Kristofer Pettersson authored
      cafe3c7f
    • Kristofer Pettersson's avatar
    • Sergey Vojtovich's avatar
      Merge of innodb-zip-ss6129 snapshot. · 0212e736
      Sergey Vojtovich authored
      0212e736