1. 13 Nov, 2007 1 commit
    • unknown's avatar
      Bug #31960 All embedded test crash · ee21ace7
      unknown authored
      Crash happens as a result of NO_EMBEDDED_ACCESS_CHECKS option
      (which is default for embedded server).
      check_table_access failed on using unintialized structure.
      Better solutions here is to disable that code completely in this case.
      Though the crash happens only in 6.0 i belive it's good to do it in 5.1
      
      
      sql/mysql_priv.h:
        Bug #31960 All embedded test crash.
        
        Access check functions from sql_parse.cc defined as FALSE if
        NO_EMBEDDED_ACCESS_CHECKS
      sql/sql_parse.cc:
        Bug #31960 All embedded test crash.
        
        Implementation of access checkings functions #ifdefed out for
        NO_EMBEDDED_ACCESS_CHECKS
      ee21ace7
  2. 05 Nov, 2007 5 commits
  3. 02 Nov, 2007 10 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 608f4e7d
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      608f4e7d
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215 · 0d45d202
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      0d45d202
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · e397a7b0
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      e397a7b0
    • unknown's avatar
      5.1-specific changes for bug #26215 after merging the patch from 5.0: · 2048ac02
      unknown authored
      - Added trigger tests back.
      - Fixed test cases to match the extended output format of SHOW CREATE ...
      - Replaced 'gptr' with 'uchar *'.
      
      
      client/mysql.cc:
        Replaced 'gptr' with 'uchar *'.
      mysql-test/r/mysql_comments.result:
        Fixed test cases to match the extended output format of SHOW CREATE ...
        Added trigger tests back.
      mysql-test/t/mysql_comments.sql:
        Added trigger tests back.
      2048ac02
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · 62f31fac
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215
      
      
      client/mysql.cc:
        Manual merge.
      62f31fac
    • unknown's avatar
      Fix for: · 1daa54d6
      unknown authored
        bug #26215: mysql command line client should not strip comments
                    from SQL statements
      and
        bug #11230: Keeping comments when storing stored procedures
      
      With the introduction of multiline comments support in the command line
      client (mysql) in MySQL 4.1, it became impossible to preserve
      client-side comments within single SQL statements or stored routines.
      This feature was useful for monitoring tools and maintenance.
      
      The patch adds a new option to the command line client
      ('--enable-comments', '-c') which allows to preserve SQL comments and
      send them to the server for single SQL statements, and to keep comments
      in the code for stored procedures / functions / triggers.
      
      The patch is a modification of the contributed patch from bug #11230
      with the following changes:
      - code style changes to conform to the coding guidelines
      - changed is_prefix() to my_strnncoll() to detect the DELIMITER
      command, since the first one is case-sensitive and not charset-aware
      - renamed t/comments-51.* to t/mysql_comments.*
      - removed tests for comments in triggers since 5.0 does not have SHOW
      CREATE TRIGGER (those tests will be added back in 5.1).
      
      The test cases are only for bug #11230. No automated test case for bug
      #26215 is possible due to the test suite deficiencies (though the cases
      from the bug report were tested manually).
      
      
      client/mysql.cc:
        Applied the contributed patch from bug11230 with the following changes:
        - code style changes to conform to the coding guidelines
        - changed is_prefix() to my_strnncoll() to detect the DELIMITER
        command, since the first one is case-sensitive and not charset-aware
        
        The patch adds a new option to the command line client which allows to
        preserve SQL comments and send them to the server to ensure better
        error reporting and to, keep comments in the code for stored procedures
        / functions / triggers.
      mysql-test/r/mysql_comments.result:
        Added test cases for bug11230.
      mysql-test/t/mysql_comments.sql:
        Added test cases for bug11230.
      mysql-test/t/mysql_comments.test:
        Added test cases for bug11230.
      1daa54d6
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 7524dbaa
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      7524dbaa
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · db499fbd
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31794-5.1-opt
      
      
      db499fbd
    • unknown's avatar
      Bug#31630 debug assert with explain extended select ... from i_s · dacf99b5
      unknown authored
      added 'in_rows' column value for 'describe extended' for the case 
      when 'describe' handles I_S table
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_select.cc:
        added 'in_rows' column value for 'describe extended' for the case 
        when 'describe' handles I_S table
      dacf99b5
    • unknown's avatar
      Bug#31113 mysqldump 5.1 can't handle a dash ("-") in database names · 2c6a5fd2
      unknown authored
      db name should be quoted. this code does communication with the server.
      it's always ok to quote names in this case.
      
      
      client/mysqldump.c:
        db name should be quoted. this code does communication with the server.
        it's always ok to quote names in this case.
      mysql-test/r/mysqldump.result:
        test result
      mysql-test/t/mysqldump.test:
        test case
      2c6a5fd2
  4. 01 Nov, 2007 4 commits
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B31794-5.0-opt · 4cb4a53e
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B31794-5.1-opt
      
      
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      4cb4a53e
    • unknown's avatar
      Bug #31794: no syntax error on SELECT id FROM t HAVING count(*)>2 · 660eb5bb
      unknown authored
      The HAVING clause is subject to the same rules as the SELECT list
      about using aggregated and non-aggregated columns.
      But this was not enforced when processing implicit grouping from
      using aggregate functions.
      Fixed by performing the same checks for HAVING as for SELECT.
      
      
      mysql-test/r/func_group.result:
        Bug #31794: test case
      mysql-test/t/func_group.test:
        Bug #31794: test case
      sql/sql_select.cc:
        Bug #31794: Check HAVING in addition to SELECT list
      660eb5bb
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 61bd5d0f
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31866-5.1-opt
      
      
      61bd5d0f
    • unknown's avatar
      Bug #31866: MySQL Server crashes on SHOW CREATE TRIGGER statement · 124af3f8
      unknown authored
      SHOW CREATE TRIGGER was not checking for detected errors 
      opening/reading the trigger file. 
      Fixed to return the already generated error.
      
      
      mysql-test/r/trigger.result:
        Bug #31866: test case
      mysql-test/t/trigger.test:
        Bug #31866: test case
      sql/sql_show.cc:
        Bug #31866: test for error and return it.
      124af3f8
  5. 30 Oct, 2007 4 commits
  6. 29 Oct, 2007 14 commits
    • unknown's avatar
      after merge fix · f97b8e48
      unknown authored
      f97b8e48
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 2b3e5606
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/type_decimal.result:
        Auto merged
      mysql-test/t/type_decimal.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      2b3e5606
    • unknown's avatar
      Bug#30889: filesort and order by with float/numeric crashes server · 9e6bb07d
      unknown authored
      There are two problems with ROUND(X, D) on an exact numeric 
      (DECIMAL, NUMERIC type) field of a table:
      1) The implementation of the ROUND function would change the number of decimal
      places regardless of the value decided upon in fix_length_and_dec. When the
      number of decimal places is not constant, this would cause an inconsistent
      state where the number of digits was less than the number of decimal places,
      which crashes filesort.
      
      Fixed by not allowing the ROUND operation to add any more decimal places than
      was decided in fix_length_and_dec.
      
      2) fix_length_and_dec would allow the number of decimals to be greater than
      the maximium configured value for constant values of D. This led to the same 
      crash as in (1).
      
      Fixed by not allowing the above in fix_length_and_dec.
      
      
      mysql-test/r/type_decimal.result:
        Bug#30889: Test result
      mysql-test/t/type_decimal.test:
        Bug#30889: Test case
      sql/item_func.cc:
        Bug#30889: 
        - Avoid setting number of digits after decimal point (scale) higher than its 
          maximum value.
        - Avoid increasing the number of decimal places in ::decimal_op
      sql/item_func.h:
        Bug#30889: Added comments to the declarations of Item_func_numhybrid::<type>_op
        family of methods.
      9e6bb07d
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 91ca02ad
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      91ca02ad
    • unknown's avatar
      Bug#30897 GROUP_CONCAT returns extra comma on empty fields · d5b1d620
      unknown authored
      The fix is a copy of Martin Friebe's suggestion.
      added testing for no_appended which will be false if anything,
      including the empty string is in result
      
      
      mysql-test/r/func_gconcat.result:
        test result
      mysql-test/t/func_gconcat.test:
        test case
      sql/item_sum.cc:
        added testing for no_appended which will be False if anything,
        including the empty string is in result
      d5b1d620
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 6b750312
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/information_schema.result:
        manual merge
      mysql-test/t/information_schema.test:
        manual merge
      6b750312
    • unknown's avatar
      backported test case from 5.1 · 95e66de2
      unknown authored
      95e66de2
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · a056854e
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      a056854e
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 04eb31c6
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/mysqld.cc:
        Null merge.
      04eb31c6
    • unknown's avatar
      25939026
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 7d9c59b7
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      7d9c59b7
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 8a5f350f
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      8a5f350f
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug29131/my51-bug29131 · 33a8fdea
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      33a8fdea
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug29131/my50-bug29131 · b52ab3bd
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      b52ab3bd
  7. 28 Oct, 2007 1 commit
    • unknown's avatar
      Many files: · 849dec44
      unknown authored
        Error message numbers.
      
      
      mysql-test/suite/rpl/r/rpl_extraCol_innodb.result:
        Error message numbers.
      mysql-test/suite/rpl/r/rpl_extraCol_myisam.result:
        Error message numbers.
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        Error message numbers.
      849dec44
  8. 27 Oct, 2007 1 commit