1. 12 Feb, 2004 1 commit
  2. 11 Feb, 2004 11 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · f2753fe9
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.1-bg2248
      
      
      include/mysql.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      f2753fe9
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 7df19a09
      unknown authored
      into bar.intranet.mysql.r18.ru:/usr/home/bar/mysql-4.1
      
      
      7df19a09
    • unknown's avatar
      Bug 2701: Function CHARSET() inconsistency · b268952f
      unknown authored
      CONVERT3 was removed, it was for test purposes,
      and rather harmful.
      
      
      b268952f
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 861d3f41
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.2208
      
      
      sql/sql_parse.cc:
        Auto merged
      861d3f41
    • unknown's avatar
      Addition to the fix for #2208 · e5c142a4
      unknown authored
      Made code shorter and more correct
      
      
      libmysql/client_settings.h:
        cli_next_result removed
      libmysql/libmysql.c:
        cli_next_result removed
      e5c142a4
    • unknown's avatar
      Manual merge. · 28ac1ba4
      unknown authored
      28ac1ba4
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · e2f0e8f2
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      
      e2f0e8f2
    • unknown's avatar
      Fix for BUG#2703 · 0aa48dc5
      unknown authored
      "MySQL server does not detect if garbage chars at the end of query":
      
      Detect garbage chars at the end of the query or at the end of a query
      for a prepared statement (which happens if mysql_real_query() or mysql_prepare()
      were called with a too big 'length' parameter (bigger than the real intended
      length of the query: then we receive a query + garbage characters from the
      client). This resulted in garbage chars written into the binlog.
      Now instead the client receives something like:
      'You have an error in your SQL syntax.  Check the manual that corresponds
      to your MySQL server version for the right syntax to use near '!stmt'
      at line 1' i.e. the server is pointing at the weird tail of the query
      (this '!stmt' are the garbage chars sent by the client).
      All tests pass, except mysqldump.test and ctype_utf8.test but they failed
      before the patch.
      
      
      sql/sql_parse.cc:
        Detect garbage chars at the end of the query
        (which happens if mysql_real_query() was called with a too big 'length'
        parameter (bigger than the real intended length of the query: then
        we receive a query + garbage characters from the client).
      sql/sql_prepare.cc:
        Detect garbage chars at the end of the query
        (which happens if mysql_prepare() was called with a too big 'length'
        parameter (bigger than the real intended length of the query: then
        we receive a query + garbage characters from the client).
      tests/client_test.c:
        The change to sql_parse.cc and sql_prepare.cc rightfully gives many
        syntax errors to tests/client_test.c which is full of
        mysql_prepare(mysql, "SHOW TABLES", 100).
        Correcting all these commands.
      0aa48dc5
    • unknown's avatar
      mysqlimport.c, mysqldump.c, mysqlcheck.c, mysql.cc: · 24e3862c
      unknown authored
        No needs to load charset index if the character set is build-in.
      
      
      client/mysql.cc:
        No needs to load charset index if the character set is build-in.
      client/mysqlcheck.c:
        No needs to load charset index if the character set is build-in.
      client/mysqldump.c:
        No needs to load charset index if the character set is build-in.
      client/mysqlimport.c:
        No needs to load charset index if the character set is build-in.
      24e3862c
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 662510b9
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.1-bg2248
      
      
      662510b9
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · a47488ab
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.2208
      
      
      a47488ab
  3. 10 Feb, 2004 23 commits
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · 6b86e0eb
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      
      6b86e0eb
    • unknown's avatar
      Fix for prepared statements: · 38caa8c0
      unknown authored
      added setting of 'neg' in Item_param::set_time() (looks like the only forgotten
      member).
      It's the second place I find where 'neg' was forgotten.
      The symptom was unexpected negative times in the binary log when running
      tests/client_test.c (test_date() in fact):
      # at 43009
      #040210 15:46:42 server id 1  log_pos 43009     Query   thread_id=1     exec_time=0     error_code=0
      SET TIMESTAMP=1076424402;
      INSERT INTO test_date VALUES('2000-01-10 11:16:20','-11:16:20' etc
      
      
      sql/item.cc:
        Don't forget to copy 'neg'.
      38caa8c0
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.1 · ce8c907f
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2592/mysql-4.1
      
      
      ce8c907f
    • unknown's avatar
      code cleanup of processing MY_LEX_USER_VARIABLE_DELIMITER · 69651163
      unknown authored
      in sql/sql_lex.cc
      
      
      sql/sql_lex.cc:
        code cleanup of processing MY_LEX_USER_VARIABLE_DELIMITER
      69651163
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · 23103e44
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      
      23103e44
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 8f5ad02a
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.1-bg2248
      
      
      8f5ad02a
    • unknown's avatar
      Another implementation of send_eof() cleanup · 98216bc9
      unknown authored
      98216bc9
    • unknown's avatar
      configure.in: · f709bc18
      unknown authored
        FreeBSD "ps" detection usually failed, in 90% cases,
        on FreeBSD-5.1. This change should work fine under
        5.x and 4.x, and I believe in 3.x. too. 
      
      
      configure.in:
        FreeBSD "ps" detection usually failed, in 90% cases. Thi
      f709bc18
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 86c161e6
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.2208
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      86c161e6
    • unknown's avatar
      Bug #2368 Multibyte charsets do not check that incoming data is well-formed · ad2c55b6
      unknown authored
      It was together with the previous but. This test tends to prove it.
      
      
      ad2c55b6
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 186ec6c7
      unknown authored
      into bar.intranet.mysql.r18.ru:/usr/home/bar/mysql-4.1
      
      
      186ec6c7
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 859aedb4
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2592/mysql-4.1
      
      
      sql/sql_lex.cc:
        Auto merged
      859aedb4
    • unknown's avatar
      correcting mysql-test/r/mysqldump.result after merge · e4f3eb79
      unknown authored
      
      mysql-test/r/mysqldump.result:
        correcting result after merge
      e4f3eb79
    • unknown's avatar
      Merge · e711cc30
      unknown authored
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/mysqldump.result:
        e
      e711cc30
    • unknown's avatar
      added skiped newline to the end of file mysql-test/t/mysqldump.test · aaa35925
      unknown authored
      
      mysql-test/t/mysqldump.test:
        added skiped newline to the end of file
      aaa35925
    • unknown's avatar
      Follow-up of a discussion on dev-docs@ : · 757c8c8a
      unknown authored
      Don't show PSEUDO_THREAD_ID in SHOW VARIABLES because:
      - we don't want people to discover this variable as it could never do good to
      set it (it was designed for use by mysqlbinlog only, so that a thread can have
      several temp tables of the same name at the same time)
      - if we show it in SHOW VARIABLES, Mysql Administrator will display it and
      this will force us to put a description, so all MySQL Administrator user
      will be aware of this variable, some may have the idea to set it with a SET
      command, and then it will cause bad things.
      The variable is still settable, and still visible with SELECT @@.
      
      
      sql/set_var.cc:
        Don't show PSEUDO_THREAD_ID in SHOW VARIABLES because:
        - we don't want people to discover this variable as it could never do good to
        set it (it was designed for use by mysqlbinlog only, so that a thread can have
        several temp tables of the same name at the same time)
        - if we show it in SHOW VARIABLES, Mysql Administrator will display it and
        this will force us to put a description, so all MySQL Administrator user
        will be aware of this variable, some may have the idea to set it with a SET
        command, and then it will cause bad things.
        The variable is still settable, and still visible with SELECT @@.
      757c8c8a
    • unknown's avatar
      Fixed bug #2248 "mysql_fetch without prior mysql_execute hangs" · 94f215cb
      unknown authored
      Done clean-up in prep stmt API functions:
      1) Removed some checks that were performed only in debug version
      were making debug version more tolerable to user errors than 
      production (and thus caused problems for example masking some
      bugs). 
      2) Also removed some other checks to make prep stmt API 
      consistent with the rest of C API (this also in line with 
      general politics - make checks in only those places where 
      errors are very common and hard to spot).
      
      
      include/mysql.h:
        Removed CHECK_EXTRA_ARGUMENTS define since it is no longer used 
        anywhere.
      libmysql/libmysql.c:
        Added check that will cause mysql_fetch() to bark then it is 
        used without calling mysql_execute() before.
        Removed checks that were performed only in debug version and
        caused problems since they were making debug version more 
        tolerable to user errors than production. Also removed some
        other checks to make prep stmt API consistent in this regard 
        with the rest of C API (this also in line with general politics -
        make checks in only those places where errors are very common 
        and hard to spot).
      tests/client_test.c:
        Updated tests to reflect removal of some checks in prep stmt API.
        Removed lines that caused bug #2473 to pop up, should be added 
        as separate test with the fix for this bug.
        Added test for bug#2248 "mysql_fetch without prior mysql_execute 
        hangs"
      94f215cb
    • unknown's avatar
      Wrong type of an argument was sent to my_printf_error(), which · dc792940
      unknown authored
      caused UDF functions to segmenation fault when they tried to
      print an error during wrong usage.
      
      
      dc792940
    • unknown's avatar
      An include was missing. · 4138b2ac
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      4138b2ac
    • unknown's avatar
      Fix for #2208 (multi-query returns wrong result in embedded library) · b4fc7c7f
      unknown authored
      now we execute only one first select during mysql_real_query
      others - during 'mysql_next_result'
      
      
      include/mysql.h:
        'virtual' next_result added
      libmysql/client_settings.h:
        cli_next_result declaration added
      libmysql/libmysql.c:
        mysql_next_result now works in embedded library as well
      libmysqld/lib_sql.cc:
        emb_next_result implemented
      sql/sql_class.h:
        fields to store the rest of the query added
      sql/sql_parse.cc:
        Saving the rest of the query added for embedded case
      b4fc7c7f
    • unknown's avatar
      http://bugs.mysql.com/bug.php?id=2368 · 102a9c6f
      unknown authored
      Multibyte charsets do not check that incoming data is well-formed
      
      
      102a9c6f
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 2282ec0f
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      2282ec0f
    • unknown's avatar
      after merge & valgrind test fixes (BUG#2120) · ecb11989
      unknown authored
      
      sql/sql_derived.cc:
        memory leack fixed
      sql/sql_lex.cc:
        flag to avoid double cleaning
      sql/sql_lex.h:
        flag to avoid double cleaning
      sql/sql_select.cc:
        right way to cleanup JOIN_TAB
      sql/sql_select.h:
        right way to cleanup JOIN_TAB
      sql/sql_union.cc:
        flag to avoid double cleaning
      ecb11989
  4. 09 Feb, 2004 5 commits
    • unknown's avatar
      Fix for the rpl_until.test. · d5b3cb44
      unknown authored
      Don't use --command in tests; use command.
      
      
      mysql-test/r/rpl_until.result:
        result update
      mysql-test/t/rpl_until.test:
        real-sleep is incorrect syntax; mysqltest knows only real_sleep.
        Tip: don't use -- before commands; if mysqltest does not recognize the command
        after -- it just says "it must be a comment", so there is no syntax error detection.
        If you don't use the -- it will report the syntax error.
        The typo caused no sleep, so the slave did not have time to stop.
        Now it has time so we needn't replace the Slave_SQL_Running
        (and it's better to not replace it, because if we don't see that it
        is running, it will trigger errors just a bit later).
      d5b3cb44
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · da81724a
      unknown authored
      into mysql.com:/home/kostja/mysql/mysql-4.1-root
      
      
      da81724a
    • unknown's avatar
      switch off SERVER_MORE_RESULTS_EXISTS, but · c4d0631b
      unknown authored
      don't set other flags: it breaks future extensions
      
      
      c4d0631b
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · d4767576
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      mysql-test/r/derived.result:
        Auto merged
      mysql-test/t/derived.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      d4767576
    • unknown's avatar
      Ensure that result from date_format() is binary · 74b81a80
      unknown authored
      Removed warnings from test suite
      
      
      mysql-test/r/ctype_utf8.result:
        Update results after fix of return argument from date_format()
      mysql-test/r/date_formats.result:
        Remove unnecessary warnings
      mysql-test/r/type_decimal.result:
        Remove unnecessary warnings
      mysql-test/r/warnings.result:
        Remove unnecessary warnings
      mysql-test/t/ctype_utf8.test:
        Fixed test
      mysql-test/t/date_formats.test:
        Remove unnecessary warnings
      mysql-test/t/type_decimal.test:
        Remove unnecessary warnings
      mysql-test/t/warnings.test:
        Remove unnecessary warnings
      sql/field.cc:
        Optimize
      sql/item_timefunc.cc:
        Ensure that result from date_format() is binary
      strings/ctype-simple.c:
        Better names for arguments
      74b81a80