1. 22 Jun, 2010 6 commits
    • Gleb Shchepa's avatar
      Bug #30584: delete with order by and limit clauses does not · ef4c0f68
      Gleb Shchepa authored
                  use limit efficiently
      Bug #36569: UPDATE ... WHERE ... ORDER BY... always does a
                  filesort even if not required
      
      Also two bugs reported after QA review (before the commit
      of bugs above to public trees, no documentation needed):
      
      Bug #53737: Performance regressions after applying patch
                  for bug 36569
      Bug #53742: UPDATEs have no effect after applying patch
                  for bug 36569
      
      
      Execution of single-table UPDATE and DELETE statements did not use the 
      same optimizer as was used in the compilation of SELECT statements. 
      Instead, it had an optimizer of its own that did not take into account 
      that you can omit sorting by retrieving rows using an index.
      
      Extra optimization has been added: when applicable, single-table 
      UPDATE/DELETE statements use an existing index instead of filesort. A 
      corresponding SELECT query would do the former.
      
      Also handling of the DESC ordering expression has been added when
      reverse index scan is applicable.
      
      From now on most single table UPDATE and DELETE statements show the 
      same disk access patterns as the corresponding SELECT query. We verify 
      this by comparing the result of SHOW STATUS LIKE 'Sort%
      
      Currently the get_index_for_order function 
      a) checks quick select index (if any) for compatibility with the
         ORDER expression list or
      b) chooses the cheapest available compatible index, but only if 
         the index scan is cheaper than filesort.
      Second way is implemented by the new test_if_cheaper_ordering
      function (extracted part the test_if_skip_sort_order()).
      
      
      
      mysql-test/r/log_state.result:
        Updated result for optimized query, bug #36569.
      mysql-test/r/single_delete_update.result:
        Test case for bug #30584, bug #36569 and bug #53742.
      mysql-test/r/update.result:
        Updated result for optimized query, bug #30584.
        Note:
        "Handler_read_last 1" omitted, see bug 52312:
        lost Handler_read_last status variable.
      mysql-test/t/single_delete_update.test:
        Test case for bug #30584, bug #36569 and bug #53742.
      sql/opt_range.cc:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
        
        * get_index_for_order() has been rewritten entirely and moved
          to sql_select.cc
        
        New QUICK_RANGE_SELECT::make_reverse method has been added.
      sql/opt_range.h:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
        
        * get_index_for_order() has been rewritten entirely and moved
          to sql_select.cc
        
        New functions:
        * QUICK_SELECT_I::make_reverse()
        * SQL_SELECT::set_quick()
      sql/records.cc:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
        
        * init_read_record_idx() has been modified to allow reverse index scan
        
        New functions:
        * rr_index_last()
        * rr_index_desc()
      sql/records.h:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
        
        init_read_record_idx() has been modified to allow reverse index scan
      sql/sql_delete.cc:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
            
        mysql_delete: an optimization has been added to skip
        unnecessary sorting with ORDER BY clause where select
        result ordering is acceptable.
      sql/sql_select.cc:
        Bug #30584, bug #36569, bug #53737, bug #53742:
          UPDATE/DELETE ... WHERE ... ORDER BY...  always does a filesort
          even if not required
            
        The const_expression_in_where function has been modified
        to accept both Item and Field pointers.
        
        New functions:
        * get_index_for_order()
        * test_if_cheaper_ordering() has been extracted from
          test_if_skip_sort_order() to share with get_index_for_order()
        * simple_remove_const()
      sql/sql_select.h:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
            
        New functions:
        * test_if_cheaper_ordering()
        * simple_remove_const()
        * get_index_for_order()
      sql/sql_update.cc:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
            
        mysql_update: an optimization has been added to skip
        unnecessary sorting with ORDER BY clause where a select
        result ordering is acceptable.
      sql/table.cc:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
        
        New functions:
        * TABLE::update_const_key_parts()
        * is_simple_order()
      sql/table.h:
        Bug #30584, bug #36569: UPDATE/DELETE ... WHERE ... ORDER BY...
                                always does a filesort even if not required
        
        New functions:
        * TABLE::update_const_key_parts()
        * is_simple_order()
      ef4c0f68
    • Vladislav Vaintroub's avatar
      Fix syntax error (missing space in SET command), that effectively prevents... · 21e943e0
      Vladislav Vaintroub authored
      Fix syntax error (missing space in SET command),  that effectively prevents mysqld from being build with SSL.
      21e943e0
    • Vladislav Vaintroub's avatar
      Fix ~1000 warnings class/struct mismatch. · 3c74f80a
      Vladislav Vaintroub authored
      Handle this warning in the future as error, this will prevent pushing to main trees.
      3c74f80a
    • Alexander Nozdrin's avatar
      Auto-merge (empty) from mysql-trunk. · ad95121e
      Alexander Nozdrin authored
      ad95121e
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-trunk-bugfixing. · a96267c1
      Alexander Nozdrin authored
      a96267c1
    • Magne Mahre's avatar
      Post-push fixups for WL#5349 · 7657ee10
      Magne Mahre authored
      
      mysql-test/suite/perfschema/t/no_threads-master.opt:
        Innodb will start multiple threads, which is
        not compatible with --one-thread.   Disable
        innodb to be able to run the test case.
      7657ee10
  2. 21 Jun, 2010 3 commits
  3. 20 Jun, 2010 1 commit
    • Magne Mahre's avatar
      Post-push fixup for WL#5349 · 240afacf
      Magne Mahre authored
      InnoDB came in a new version "simultanously" with the
      commit.  This patch is a minor change to the new innodb
      regression test suite. 
      240afacf
  4. 18 Jun, 2010 2 commits
  5. 17 Jun, 2010 19 commits
  6. 16 Jun, 2010 3 commits
  7. 15 Jun, 2010 6 commits
    • Joerg Bruehe's avatar
      Fix bug#27072: RPM autostarts the server · 766f6a76
      Joerg Bruehe authored
      This is the fix for 5.5, where the behaviour on both installation
      and upgrade is changed:
      On installation, we do not start the server, to allow automated
      installs (which happen in some indeterminate machine status).
      If the server was stopped when the upgrade begins, we assume the
      administrator is taking manual action, so we do not start the (new)
      server at the end of the upgrade.
      We still install the start/stop script, so it will be started on reboot.
      
      
      support-files/mysql.spec.sh:
        In the "pre" section of the spec file, check the server status, and write
        the result to a file.
        In the "post" section, evaluate the status file, and start the server if
        it was running during status analysis.
        In 5.5, we do *not* start the server if there is no status file (which will happen on first installation, when there is no data directory yet).
      766f6a76
    • Joerg Bruehe's avatar
      Fix bug#27072: RPM autostarts the server · b3eac87c
      Joerg Bruehe authored
      This is the fix for 5.1, where only the behaviour on upgrade is changed:
      If the server was stopped when the upgrade begins, we assume the
      administrator is taking manual action, so we do not start the (new)
      server at the end of the upgrade.
      We still install the start/stop script, so it will be started on reboot.
      
      
      support-files/mysql.spec.sh:
        In the "pre" section of the spec file, check the server status, and write
        the result to a file.
        In the "post" section, evaluate the status file, and start the server if
        it was running during status analysis.
        In 5.1, we start the server if there is no status file (which will happen
        on first installation, when there is no data directory yet).
      b3eac87c
    • Alexey Kopytov's avatar
      Bug#52208: gis fails on some platforms (Solaris, HP-UX, Linux) · c388c044
      Alexey Kopytov authored
      On [Open]Solaris/x86 the FPU was not switched to 64-bit double
      precision mode when the server binary was built with Sun
      Studio. That caused GIS test failures due to differences in
      expected and actual results.
      c388c044
    • Vasil Dimov's avatar
      Increment InnoDB version number from 1.1.1 to 1.1.2, · 5a0b9cd2
      Vasil Dimov authored
      the 1.1.1 release will be included inside MySQL 5.5.5 and is
      up to (inclusive):
      vasil.dimov@oracle.com-20100602124314-21l3cb27w4rbfqrq
      5a0b9cd2
    • Alexey Kopytov's avatar
      Backport of the patch for bug52208 to 5.1 since the · d2e58e4e
      Alexey Kopytov authored
      root cause of 52208 resulted in another test failure
      in 5.1.
      d2e58e4e
    • Konstantin Osipov's avatar
      Fix a build break with cmake: remove the custom defines · 65428955
      Konstantin Osipov authored
      that prevented hp_test2 to link in non-debug builds.
      
      storage/heap/hp_test2.c:
        Don't try to define DBUG if we're building without
        DBUG -- that won't work,since dbug libary will be empty
        in non-debug builds and cmake.
      65428955