1. 08 Apr, 2008 2 commits
  2. 07 Apr, 2008 6 commits
    • unknown's avatar
      Fix a compilation warning (unused variable). · 797bfd6e
      unknown authored
      797bfd6e
    • unknown's avatar
      A fix for Bug#32724 "innodb_mysql.test fails randomly". · 17ec1c3c
      unknown authored
      Enable back the disabled test case.
      
      
      mysql-test/t/disabled.def:
        Enable the test case innodb_mysql.
      sql/sql_parse.cc:
        Fix the random failure of innodb_mysql test. The failure is not
        random any more after a patch for Bug 12713 added asserts around
        handler commit.
      17ec1c3c
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · ed0fd2f6
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-symlink
      
      
      ed0fd2f6
    • unknown's avatar
      d017acee
    • unknown's avatar
      Bug#34183 Missing DBUG_RETURN in alloc_root · 3f63ba7f
      unknown authored
      DBUG_RETURN was missing form an exit path in 5.1 branch of alloc_root
      
      
      mysys/my_alloc.c:
        Fixed missing DBUG_RETURN
      3f63ba7f
    • unknown's avatar
      Fix for bug #35733 "main.symlink.test fails". · d5990c28
      unknown authored
      The problem was that symlink.test failed due to debug assertions or
      due to errors emitted for wrong statements (in non-debug builds)
      if 6.0 version of server was run with --thread-handling=pool-of-threads
      option.
      
      The above problems were caused by that on the one hand code mi_create()
      which handles case when error is returned relies on my_errno being set
      to appropriate non-0 value, but on the other it has not done this
      in case when error was emitted due to discovery that share for table
      which we are going to create is already present in the list of open
      shares. Running server with pool-of-threads option just exposed this
      bug since in this scheduler mode my_errno is reset to 0 when connection
      (THD) is reattached to the "real" thread.
      
      This fix ensures that code in mi_create() properly sets my_errno in
      the case described above.
      
      Since original reason that caused this bug to be exposed in 6.0 tree
      might also under very special conditions lead to incorrect behavior
      of earlier versions of server (i.e. to errors emitted for wrong
      statements) this patch is also being pushed into 5.1 tree.
      
      No test case is present as this code is already covered by a test
      case + pushbuild options combination in 6.0.
      
      
      storage/myisam/mi_create.c:
        Code in mi_create() which handles case when error is returned relies
        on my_errno being set to appropriate non-0 value. Adjusted code which
        emits error when we discover that share for table which we are going
        to create is already present in the list of open shares to do this.
      d5990c28
  3. 01 Apr, 2008 3 commits
  4. 31 Mar, 2008 2 commits
  5. 28 Mar, 2008 3 commits
    • unknown's avatar
      Fix for Bug#32748: Inconsistent handling of assignments to · bae7b267
      unknown authored
      general_log_file/slow_query_log_file.
      
      The problem was that log file path was rejected if directory
      path was empty. The fix is to reject log file path only if it
      is entirely empty.
      
      
      mysql-test/r/log_state.result:
        Update result file.
      mysql-test/t/log_state.test:
        A test case for Bug#32748: Inconsistent handling of assignments to
        general_log_file/slow_query_log_file.
      sql/set_var.cc:
        Accept file path if dirname is empty.
        Reject file path if it is empty.
      bae7b267
    • unknown's avatar
      A patch for Bug#34820: log_output can be set to illegal value. · fba9e7c8
      unknown authored
      We have "set" variables, which can accept empty values
      (like sql_mode), and which can not (like log_output). The problem
      was that the code does not distinguish them and allow empty
      values for every set variable.
      
      The fix is to introduce an attribute of a set variable telling
      whether it can accept empty values.
      
      
      mysql-test/r/variables.result:
        Update result file.
      mysql-test/t/variables.test:
        A test case for Bug#34820: log_output can be set to illegal value.
      sql/set_var.cc:
        Don't allow empty values if it is prohibitted.
      sql/set_var.h:
        Add a flag (m_allow_empty_value) telling if an empty value is
        acceptable for this variable.
      fba9e7c8
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1 · 1abfb6e0
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      1abfb6e0
  6. 27 Mar, 2008 24 commits