- 12 Mar, 2014 2 commits
-
-
Michael Widenius authored
mysql-test/r/create_or_replace.result: Added test of releasing of metadata locks mysql-test/t/create_or_replace.test: Added test of releasing of metadata locks sql/handler.h: Added marker if table was deleted as part of CREATE OR REPLACE sql/sql_base.cc: Added Locked_tables_list::unlock_locked_table() sql/sql_class.h: New prototypes sql/sql_insert.cc: Unlock metadata locks for deleted table in case of error. Also do unlock tables if this was the only locked table. sql/sql_table.cc: Unlock metadata locks for deleted table in case of error. Also do unlock tables if this was the only locked table.
-
Michael Widenius authored
Remove memory warnings if mysql client aborts early Changed copyright for clients client/mysql.cc: Free memory if get_options fails, so that we don't get warnings from safemalloc include/welcome_copyright_notice.h: Added SkySQL to client copyrights mysql-test/valgrind.supp: Added suppressions for memory leaks from dlopen() for OpenSUSE 12.3 storage/oqgraph/mysql-test/oqgraph/regression_mdev5744.result: Suppress warning storage/oqgraph/mysql-test/oqgraph/regression_mdev5744.test: Suppress warning
-
- 07 Mar, 2014 1 commit
-
-
Sergey Vojtovich authored
my_atomic_load() is implemented as __sync_fetch_and_or(var, 0) which writes or-ed value back to var. Memory writes as such have worse performance and scalability than reads. gcc 4.7 and up offers better facility for atomic loads/stores. Use it whenever it is available.
-
- 10 Mar, 2014 4 commits
-
-
Elena Stepanova authored
-
Elena Stepanova authored
before that, which caused indeterministic outcome
-
Michael Widenius authored
Fixed MDEV-5724 "Server crashes on SQL select containing more group by and left join statements using innodb tables" The problem was that a big record was allocated on the stack, which casued stack to run out. Fixed by using my_safe_alloca() instead of my_alloca() when allocating records. Now only records <= 16384 are allocated on the stack. mysql-test/r/stack-crash.result: Added test case mysql-test/t/stack-crash.test: Added test case storage/maria/ma_blockrec.c: Use my_safe_alloca() instead of my_alloca() storage/maria/ma_dynrec.c: Use my_safe_alloca() instead of my_alloca() storage/maria/maria_def.h: Added MARIA_MAX_RECORD_ON_STACK storage/maria/maria_pack.c: Use my_safe_alloca() instead of my_alloca()
-
Michael Widenius authored
The issue was that create...trigger part of the test suite used a debug_sync point that before was never triggered (in other words, wrong meaningless test). With the new create ... replace code the debug sync point is triggered and the test case could not handled that. I fixed this by adding a wait and go for the debug syncpoint in the test. Removed some compiler warnings from mysql_cond_timedwait include/mysql/psi/mysql_thread.h: Removed compiler warnings mysql-test/r/create-big.result: New test result mysql-test/t/create-big.test: Fixed test case as create_table_select_before_check_if_exists was not before triggered by the code.
-
- 08 Mar, 2014 1 commit
-
-
Sergei Golubchik authored
-
- 07 Mar, 2014 6 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
unknown authored
MDEV-5789: race between rpl_parallel_change_thread_count and slave start upon server start without --skip-slave-start Make sure to signal the condition variable for the thread pool after the new threads have been added to the pool. Thanks to user nanyi607rao, who reported this bug on maria-developers@.
-
unknown authored
When an rpl_group_info object was returned from the free list, the rgi->deferred_events_collecting and rgi->deferred_events was not correctly re-inited. Additionally, the rgi->deferred_events was incorrectly freed in free_rgi(), which causes unnecessary malloc/free (or crash when re-init is not done). Thanks to user nanyi607rao, who reported this bug on maria-developers@.
-
Alexander Barkov authored
This constant uses my_time.h, which inclusion is not desirable in nt_servc.cc
-
- 06 Mar, 2014 3 commits
-
-
Alexander Barkov authored
-
Sergey Vojtovich authored
Reduced number of my_hash_sort_bin() calls from 4 to 1 per query. Reduced number of memory accesses done by my_hash_sort_bin(). Details: - let MDL subsystem use pre-calculated hash value for hash inserts and deletes - let table cache use pre-calculated MDL hash value - MDL namespace is excluded from hash value calculation, so that hash value can be used by table cache as is - hash value for MDL is calculated as resulting hash value + MDL namespace - extended hash implementation to accept user defined hash function
-
unknown authored
-
- 05 Mar, 2014 1 commit
-
-
Sergei Golubchik authored
-
- 04 Mar, 2014 12 commits
-
-
Sergey Petrunya authored
- MariaDB-5.5 part of the fix: since we can't easily fix query optimization for I_S tables, run the affected-tablespaces query with semijoin=off. It happens to have a good query plan with that setting. [This is a forward-port to MariaDB 10.0]
-
Sergey Petrunya authored
-
Sergei Golubchik authored
-
Michael Widenius authored
- Removed double call to trans_begin() for GTID BEGIN event - Don't set OPTION_BEGIN before calling trans_begin() as this causes extra work in trans_begin() sql/log_event.cc: Removed double call to trans_begin for GTID BEGIN event. Don't set OPTION_BEGIN before calling trans_begin() as this causes extra work in trans_begin(). This was done by removing parsing of "BEGIN" and instead executing trans_begin() direct. This is much faster, but we lost the ability logging of possible slow "BEGIN" statements. As this should never happen it can be ignored.
-
Michael Widenius authored
mysql-test/suite/rpl/t/rpl_heartbeat_basic.test: Added sync_slave_with_master to remove timing problem
-
unknown authored
Patch from Tomas Matejicek Add missing error code to is_networ_error(), to allow slave to automatically attempt reconnection also in this case.
-
unknown authored
-
unknown authored
-
unknown authored
The problem was when a GTID event was part of a group commit, and so contained a commit id. The code that replaces GTID with a BEGIN event for old slaves did not correctly handle this case. Fix the code so that the GTID with commit id can also be properly replaced with a BEGIN query event. The extra two bytes are in the BEGIN event replaced with a dummy, empty time zone string.
-
Sergey Petrunya authored
- Make do_fill_table() use join_tab->cache_select->cond if it is present. When join_tab->cache_select->cond is present, join_tab->select_cond doesn't have any conditions that are usable for I_S optimizations.
-
unknown authored
Older master has no GTID events, so such events are not available for deciding on scheduling of event groups and so on. With this patch, we run such events from old masters single-threaded, in the sql driver thread. This seems better than trying to make the parallel code handle the data from older masters; while possible, this would require a lot of testing (as well as possibly some extra overhead in the scheduling of events), which hardly seems worthwhile.
-
Sergei Golubchik authored
-
- 03 Mar, 2014 2 commits
-
-
Sergey Petrunya authored
- Fix valgrind failure: make test_if_order_by_key() account for extended keys feature.
-
unknown authored
With parallel replication, there can be any number of events queued on in-memory lists in the worker threads. For normal STOP SLAVE, we want to skip executing any remaining events on those lists and stop as quickly as possible. However, for START SLAVE UNTIL, when the UNTIL position is reached in the SQL driver thread, we must _not_ stop until all already queued events for the workers have been executed - otherwise we would stop too early, before the actual UNTIL position had been completely reached. The code did not handle UNTIL correctly, stopping too early due to not executing the queued events to completion. Fix this, and also implement that an explicit STOP SLAVE in the middle (when the SQL driver thread has reached the UNTIL position but the workers have not) _will_ cause an immediate stop.
-
- 02 Mar, 2014 3 commits
-
-
Sergei Golubchik authored
MDEV-5748 Assertion `status_var.memory_used == 0' fails on disconnect after opening an OQGRAPH table make sure MY_THREAD_SPECIFIC is not set for memroot that can be transferred between threads
-
Sergei Golubchik authored
MDEV-5674 Valgrind warnings "Conditional jump or move depends on uninitialised value" in create_sort_index with small sort_buffer_size *found_rows wasn't initialized when filesort() failed (it didn't matter, but valgrind was unhappy)
-
Sergei Golubchik authored
use the Alter_inplace_info::ALTER_COLUMN_OPTION flag if field/column flags were altered. change ha_example to use check_if_supported_inplace_alter() instead of obsolete check_if_incompatible_data()
-
- 01 Mar, 2014 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
parser: error out on empty role names
-
Sergei Golubchik authored
-
- 28 Feb, 2014 2 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-