1. 05 Feb, 2008 3 commits
  2. 04 Feb, 2008 2 commits
  3. 01 Feb, 2008 6 commits
  4. 31 Jan, 2008 5 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0 · dc8e43ed
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      dc8e43ed
    • unknown's avatar
      Changes to fix tests in pushbuild. · 1fa51318
      unknown authored
      
      mysql-test/include/have_local_infile.inc:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/include/have_local_infile.inc
      mysql-test/r/have_local_infile.require:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/r/have_local_infile.require
      mysql-test/t/binlog_start_comment.test:
        Test requires that local_infile is on, so added require for that.
      mysql-test/t/rpl_sp.test:
        Adding missing sync_slave_with_master causing following tests to fail.
      1fa51318
    • unknown's avatar
      Fixes to make code compile on Windows. · 34b9c6f5
      unknown authored
      
      sql/sql_repl.cc:
        Adding cast to remove compile error on Windows platform.
      34b9c6f5
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 6357f5cc
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      
      6357f5cc
    • unknown's avatar
      Bug #32149 Long semaphore wait for adaptive hash latch · a3f80f54
      unknown authored
      Fix by calling ha_release_temporary_latches() before ::filesort().
      
      
      sql/filesort.cc:
        Call ha_release_temporary_latches() before performing
        a (possibly long) ::filesort().
      a3f80f54
  5. 30 Jan, 2008 5 commits
    • unknown's avatar
      Bug#24624: MySQL client ignores its own completion table · 4621dbf5
      unknown authored
      Nothing was in the command-line dictionary, because of the wrong 
      order of instructions when populating it.
      
      This is a smaller, less optimistic patch that both fixes a bug and
      refreshes the list of keywords that the command-line library (e.g., 
      readline) can use to expand typed commands.  Now, read from the 
      command list /after/ we free the list, not before.
      
      The best way is to read the keywords from the lexer code, but that
      doesn't work everywhere yet.  Grr.
      
      
      client/mysql.cc:
        Order the instructions for clearing and populating the keyword list,
        to be in that order.
        
        Additionally, add more keywords.
      4621dbf5
    • unknown's avatar
      Disabling rpl_transaction test for non-debug builds. · 79f20964
      unknown authored
      
      mysql-test/t/rpl_transaction.test:
        Test only works for debug build.
      79f20964
    • unknown's avatar
      Changes to make tests pass in pushbuild. · 55fbcacf
      unknown authored
      
      mysql-test/r/bdb_notembedded.result:
        Result change.
      mysql-test/r/rpl_loaddata_map.result:
        Result change.
      mysql-test/t/rpl_loaddata_map.test:
        Blanking out file id as well.
      55fbcacf
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · 20677056
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      mysql-test/r/blackhole.result:
        Auto merged
      mysql-test/r/case.result:
        Auto merged
      mysql-test/r/mysqlbinlog2.result:
        Auto merged
      mysql-test/t/blackhole.test:
        Auto merged
      mysql-test/t/case.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      20677056
    • unknown's avatar
      Merge zhe@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 7faa7d60
      unknown authored
      into  mail.hezx.com:/media/sda3/work/mysql/bkwork/bug26489_corruption_in_relay_log/5.0
      
      
      7faa7d60
  6. 29 Jan, 2008 4 commits
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-4.1-build · f36fb541
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-build
      
      
      client/mysql.cc:
        Auto merged
      f36fb541
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-4.1-maint--bug33841 · 3349566d
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-4.1-build
      
      
      3349566d
    • unknown's avatar
      update test result · 6766554f
      unknown authored
      
      mysql-test/r/rpl_grant.result:
        update result
      6766554f
    • unknown's avatar
      BUG#26489 Corruption in relay logs · 5a039fa2
      unknown authored
      Here is the scenario that causes the failure.(by Mats)
      
      1. The to-be corrupt log event (let's call it X), is split into two
         packets B and C on the network level (net_write_buff()). The parts
         are X = (x',x''). The part x' ends up in packet B and part x''
         ends up in packet C. Prior to the corrupt event X, the event Y has
         been written successfully, but has been split into two packets as
         well, which we call (y',y'').
      2. The master sends packet A = (y'',x') to the slave, increases the
         packet sequence number, the slave receives the packet, but fails
         to reply before the master gets a timeout.
      3. Since the master got a timeout, it reports failure, and aborts
         sending the binary log by exiting mysql_binlog_send(). However, it
         leaves the buffer intact, still holding y'' (but not x', since the
         write_pos is not increased).
      4. After exiting mysql_binlog_send(), the master does a
         disconnection of the client thread, which involves sending an
         error message e to the client (i.e., the slave).
      5. In this case, net_write_buff() is used again, but this time the
         old contents of the packet is used so that the new packet is
         D = (y'',e). Note that this will use a new packet sequence number,
         since the packet number was increased in step 2.
      6. The slave receives the tail y'' of the Y log event, concatenates
         this with x' (which it already received), and writes the event
         (x',y'') it to the relay log since it hasn't noticed anything is
         amiss.
      7. It then tries to read more bytes, which is either e (if the length
         given for X just happened to match the length given for Y, or just
         plain garbage because the slave is out of sync with what is
         actually sent.
      8. After a while, the SQL thread tries to execute the event (x',y''),
         which is very likely to be just nonsense.
      
      The problem can be fixed by not resetting net->error after the call of 
      mysql_binlog_send, so the error message will not be sent and the connection
      will be closed.
      
      
      sql/sql_parse.cc:
        Do not reset net->error, if net->error == 2, we should not try to use the connection again
      5a039fa2
  7. 28 Jan, 2008 3 commits
  8. 27 Jan, 2008 1 commit
    • unknown's avatar
      Fix test case for Bug #25347 so that it actually tests the code fix, · 32f59206
      unknown authored
      and so that it works correctly on Windows.
      
      
      mysql-test/r/mysqlcheck.result:
        Flush tables before monkeying around with underlying MyISAM data files
      mysql-test/t/mysqlcheck.test:
        Fix the test case for bug #25347 so that it actually does test the behavior.
        Also, this makes it work on Windows by ensuring that mysqld doesn't hold the
        underlying MyISAM files open while we try to corrupt them on disk.
        
        Flush tables before monkeying around with underlying MyISAM data files;
        --use-frm, so that mysqlcheck will succeed.
      32f59206
  9. 25 Jan, 2008 4 commits
    • unknown's avatar
      Un-break test case on Windows, for bug #25347 · 9dbd3877
      unknown authored
      
      mysql-test/t/mysqlcheck.test:
        Use --remove_file and --write_file instead of --exec rm and --exec touch.
      9dbd3877
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/50 · 893d98fb
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      sql/sql_select.cc:
        Auto merged
      893d98fb
    • unknown's avatar
      Bug#33841: mysql client crashes when returning results for long-\ · 60ea77d4
      unknown authored
      	running queries
      
      Bug#33976: buffer overflow of variable time_buff in function com_go()
      
      An internal buffer was too short.  Overextending could smash the 
      stack on some architectures and cause SEGVs.  This is not a problem
      that could be exploited to run arbitrary code.
      
      To fix, I expanded one buffer to cover all the size that could be
      written to (we know the abolute max).
      
      
      client/mysql.cc:
        Bump up the max size of the time-elapsed buffer displayed at the end
        of queries.
      60ea77d4
    • unknown's avatar
      BUG#33862 completely failed DROP USER statement gets replicated · d2b4d051
      unknown authored
      The problem is when create/rename/drop users, the statement was logged regardless of error, even if no data has been changed, the statement was logged.
      
      After this patch, create/rename/drop users don't write the binlog if the statement makes no changes, if the statement does make any changes, log the statement with possible error code.
      
      This patch is based on the patch for BUG#29749, which is not pushed
      
      
      sql/sql_acl.cc:
        when create/rename/drop users, don't write the binlog if the statement make no changes
      mysql-test/r/rpl_user.result:
        New BitKeeper file ``mysql-test/r/rpl_user.result''
      mysql-test/t/rpl_user.test:
        New BitKeeper file ``mysql-test/t/rpl_user.test''
      d2b4d051
  10. 24 Jan, 2008 4 commits
    • unknown's avatar
      Merge quad.:/mnt/raid/alik/MySQL/devel/5.0 · a89ba0c6
      unknown authored
      into  quad.:/mnt/raid/alik/MySQL/devel/5.0-rt-merged-5.0
      
      
      a89ba0c6
    • unknown's avatar
      Fix bug in BK trigger for sending changes to InnoDB devs. · e09b41cf
      unknown authored
      
      BitKeeper/triggers/triggers-lib.pl:
        Fix bug in innodb_send_changes_mail() that always displayed
        details for the most recent changeset (-r+) instead of the
        $cset function argument.
      e09b41cf
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/inno/jan23/50 · b5e3c1f8
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      
      b5e3c1f8
    • unknown's avatar
      Applied innodb-5.0-ss2223 snapshot · 8bfec4b2
      unknown authored
      Fixes:
      
      Bug #32083: server crashes on show status when InnoDB is not initialized
        innodb_export_status(): Check that InnoDB has been initialized
        before invoking srv_export_innodb_status().  (Bug #32083)
        This bug does not exist in MySQL/InnoDB 5.1.
      
      
      sql/ha_innodb.cc:
        Applied innodb-5.0-ss2223 snapshot
        
        Revision r2223:
        branches/5.0: innodb_export_status(): Check that InnoDB has been initialized
        before invoking srv_export_innodb_status().  (Bug #32083)
        
        This bug does not exist in MySQL/InnoDB 5.1.
      8bfec4b2
  11. 23 Jan, 2008 3 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/inno/50-triggers · c441c6f2
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      
      c441c6f2
    • unknown's avatar
      Add triggers to notify InnoDB developers when MySQL developers change files · 14b1de42
      unknown authored
      that they control.
      
      
      BitKeeper/triggers/post-commit.innodb.pl:
        Trigger to notify InnoDB developers about changes in InnoDB
        files.
      BitKeeper/triggers/post-incoming.innodb.pl:
        Trigger to notify InnoDB developers about changes in InnoDB
        files.
      BitKeeper/triggers/pre-commit.innodb.pl:
        Trigger to warn MySQL developers that they have changed InnoDB files,
        and that their changes will be sent to the InnoDB developers if they
        choose to commit.
      BitKeeper/triggers/triggers-lib.pl:
        Utility functions for BK triggers written in Perl.
      14b1de42
    • unknown's avatar
      manual merge · 8430df5a
      unknown authored
      8430df5a