1. 14 Jan, 2006 1 commit
    • unknown's avatar
      item_timefunc.cc: · f36a0fee
      unknown authored
        fix for bug#15828 after review
      
      
      sql/item_timefunc.cc:
        fix for bug#15828 after review
      f36a0fee
  2. 13 Jan, 2006 5 commits
  3. 12 Jan, 2006 4 commits
  4. 11 Jan, 2006 1 commit
  5. 10 Jan, 2006 3 commits
  6. 09 Jan, 2006 8 commits
  7. 08 Jan, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/home/my/mysql-4.0 · 13c27a97
      unknown authored
      into  mysql.com:/home/my/mysql-4.1
      
      
      client/mysqlimport.c:
        Auto merged
      myisam/myisam_ftdump.c:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        merge (keep old code)
      sql/sql_handler.cc:
        manual merge
      13c27a97
    • unknown's avatar
      Fixed bug #14274: a query with a having clause containing only set function... · 770e0e81
      unknown authored
      Fixed bug #14274: a query with a having clause containing only set function returned a wrong result set.
      
      
      mysql-test/r/having.result:
        Added a test case for bug #14274.
      mysql-test/t/having.test:
        Added a test case for bug #14274.
      sql/sql_select.cc:
        Fixed bug #14274: a query with a having clause containing only set function returned a wrong result set.
        It happened because processing of the set functions in having started with a call of the split_sum_func
        method, instead of the split_sum_func2 method.
      770e0e81
  8. 06 Jan, 2006 1 commit
    • unknown's avatar
      Fixes during review of new pushed code: · 2dcedd9c
      unknown authored
      Remove wrong fix for Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
      Safety fix for bug #13855 "select distinct with group by caused server crash"
      
      
      client/mysqlimport.c:
        Remove not used variable
      myisam/myisam_ftdump.c:
        Fixed compiler warning
      sql/item_cmpfunc.cc:
        Removed compiler warning
      sql/sql_handler.cc:
        Remove wrong fix for Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash.
        It's better to let mysql_lock_tables reopen the TABLE object in case of OPTIMIZE TABLE and fix items AFTER mysql_lock_table() instead of before
      sql/sql_select.cc:
        Safety fix for bug #13855 "select distinct with group by caused server crash"
        The previous patch only removed the symptomps, this fix removed the cause of the problem
        (Which was that not all hidden_fields was stored in the temporary table)
      2dcedd9c
  9. 04 Jan, 2006 2 commits
    • unknown's avatar
      A fix for Bug#7209 "Client error with "Access Denied" on updates · f577d864
      unknown authored
      when high concurrency": remove HASH::current_record and make it
      an external search parameter, so that it can not be the cause of a 
      race condition under high concurrent load.
      The bug was in a race condition in table_hash_search,
      when column_priv_hash.current_record was overwritten simultaneously
      by multiple threads, causing the search for a suitable grant record
      to fail.
      No test case as the bug is repeatable only under concurrent load.
      
      
      include/hash.h:
        - remove current_record from HASH, instead modify hash_first,
        hash_next to accept HASH_SEARCH_STATE as an IN/OUT parameter
      mysys/hash.c:
        - remove HASH::current_record
        - change declarations of functions that use HASH in read-only mode
          to accept const HASH * instead of HASH *. 
        - implement hash_search; move the old implementation of hash_search
        to hash_first
      mysys/testhash.c:
        - adjust the test case to changed function declarations
      sql/lock.cc:
        - adjust to changed declarations of hash_search, hash_next
      sql/sql_acl.cc:
        - adjust to changed declarations of hash_search, hash_next
      sql/sql_base.cc:
        - adjust to changed declarations of hash_search, hash_nex
      sql/sql_cache.cc:
        - adjust to a changed declaration of hash_replace
      f577d864
    • unknown's avatar
      ndb - Make testDatabuffer clean up tables · 522bbb83
      unknown authored
      
      ndb/test/ndbapi/testDataBuffers.cpp:
        Make testDatabuffer clean up tables
      522bbb83
  10. 31 Dec, 2005 1 commit
  11. 29 Dec, 2005 1 commit
  12. 28 Dec, 2005 2 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · c37389cf
      unknown authored
      into moonbone.local:/work/14583-bug-4.1-mysql
      
      
      c37389cf
    • unknown's avatar
      BUG#15775 "drop user" command does not refresh acl_check_hosts · 9a8dde9b
      unknown authored
         - DROP USER command didn't reload the acl_check_hosts cache causing subsequent 
           connect's via TCP to fail randomly.
         - 4.1 version
      
      
      mysql-test/r/grant2.result:
        Update test results
      mysql-test/t/grant2.test:
        Add test for to check that connect via TCP work after "drop user"
      sql/sql_acl.cc:
        Reload acl_check_hosts as its memory is mapped to acl_user
        Use acl_user->host.hostname when searching the acl_check_hosts list
      9a8dde9b
  13. 27 Dec, 2005 3 commits
    • unknown's avatar
      Fix bug#14583 · 9a128b97
      unknown authored
      When InnoDB compares varchar field in ucs2 with given key using bin collation,
      it calls my_strnncollsp_ucs2_bin() to perform comparison.
      Because field length was lesser than length of key field should be padded
      with trailing spaces in order to get correct result. 
      Because  my_strnncollsp_ucs2_bin() was calling my_strnncollp_ucs2_bin(), which
      doesn't pads field, wrong comparison result was returned. This results in
      wrong result set.
      
      my_strnncollsp_ucs2_bin() now compares fields like my_strnncollsp_ucs2 do,
      but using binary collation.
      
      
      mysql-test/t/ctype_ucs.test:
        Test case for bug#14583  Wrong my_strnncollsp_ucs2_bin() behaviour results in skipping
        correct records.
      mysql-test/r/ctype_ucs.result:
        Test case for bug#14583  Wrong my_strnncollsp_ucs2_bin() behaviour results in skipping correct records.
      strings/ctype-ucs2.c:
        Fix bug#14583 Wrong my_strnncollsp_ucs2_bin() behaviour results in skipping
        correct records.my_strnncollsp_ucs2_bin() now compares fields like my_strnncollsp_ucs2 do,
        but using binary collation.
      9a128b97
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 4b543591
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.1-bug5390
      
      
      libmysqld/ha_blackhole.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      4b543591
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.0 · 409a4729
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.0-bug5390
      
      
      409a4729
  14. 23 Dec, 2005 1 commit
  15. 21 Dec, 2005 2 commits
    • unknown's avatar
      bug#15908 - ndb · 887d498b
      unknown authored
        When scan is completed, but lqhkeyreq is outstanding on primary replica and
        starting node dies, scan will not be closed leading to error handling of failed
        node not completing
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        New error code
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Set scan state to WAIT_LQHKEY_COPY when scan is finished but LQHKEYREQ is outstanding
      887d498b
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/4.1/main · 128babca
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/4.1/cleanup
      
      
      128babca
  16. 20 Dec, 2005 2 commits
    • unknown's avatar
      mysql.cc: · fd46c788
      unknown authored
        Typo in help message.
      
      
      client/mysql.cc:
        Typo in help message.
      fd46c788
    • unknown's avatar
      build fix · e54c3c88
      unknown authored
      e54c3c88
  17. 19 Dec, 2005 1 commit
    • unknown's avatar
      Bug#15581: COALESCE function truncates mutli-byte TINYTEXT values · e1c61413
      unknown authored
      field.cc:
        BLOB variations have number-in-bytes limit,
        unlike CHAR/VARCHAR which have number-of-characters limits.
        A tinyblob column can store up to 255 bytes.
        In the case of basic Latin letters (which use 1 byte per character)
        we can store up to 255 characters in a tinyblob column.
        When passing an utf8 tinyblob column as an argument into
        a function (e.g. COALESCE) we need to reserve 3*255 bytes.
        I.e. multiply length in bytes to mbcharlen for the character set.
        Although in reality a tinyblob column can never be 3*255 bytes long,
        we need to set max_length to multiply to make fix_length_and_dec()
        of the function-caller (e.g. COALESCE) calculate the correct max_length
        for the column being created.
      
      ctype_utf8.result, ctype_utf8.test:
        Adding test case.
      
      
      mysql-test/t/ctype_utf8.test:
        Adding test case.
      mysql-test/r/ctype_utf8.result:
        Adding test case.
      sql/field.cc:
        Bug#15581: COALESCE function truncates mutli-byte TINYTEXT values
        BLOB variations have byte limits,
        unlike CHAR/VARCHAR which have number-of-character limits.
        It means tinyblob can store up to 255 bytes.
        All of them can be basic latin letters which use 1 byte
        per character.
        I.e. we can store up to 255 characters in a tinyblob column.
        When passing a tinyblob column as an argument into
        a function (for example COALESCE or CONCAT) we
        need to reserve 3*255 bytes in the case of utf-8.
        I.e. multiply length in bytes to mbcharlen for the
        character set.
      e1c61413