1. 20 Jun, 2006 1 commit
    • unknown's avatar
      SHOW STATUS does not anymore change local status variables (except... · f3a56a17
      unknown authored
      SHOW STATUS does not anymore change local status variables (except com_show_status). Global status variables are still updated.
      SHOW STATUS are not anymore put in slow query log because of no index usage.
      
      Implemntation done by removing orig_sql_command and moving logic of SHOW STATUS to mysql_excute_command()
      This simplifies code and allows us to remove some if statements all over the code.
      
      Upgraded uc_update_queries[] to sql_command_flags and added more bitmaps to better categorize commands.
      This allowed some overall simplifaction when testing sql_command.
      
      Fixes bugs:
      Bug#10210: running SHOW STATUS increments counters it shouldn't
      Bug#19764: SHOW commands end up in the slow log as table scans
      
      
      mysql-test/r/grant_cache.result:
        Fixed results after SHOW STATUS doesn't anymore affect status variables
      mysql-test/r/information_schema.result:
        Added extra test to cover more code
      mysql-test/r/query_cache.result:
        Remove resuts from previous tests
      mysql-test/r/status.result:
        Added more tests for testing of last_query_cost and how SHOW STATUS affects status variables.
        (Bug#10210)
      mysql-test/r/temp_table.result:
        Fixed results after SHOW STATUS doesn't anymore affect status variables
      mysql-test/r/union.result:
        Fixed results after SHOW STATUS is not logged to slow query log
        (Bug#19764)
      mysql-test/t/events_microsec.test:
        Disable warnings at init
      mysql-test/t/information_schema.test:
        Added extra test to cover more code
      mysql-test/t/query_cache.test:
        Remove resuts from previous tests
      mysql-test/t/status.test:
        Added more tests for testing of last_query_cost and how SHOW STATUS affects status variables.
        (Bug #10210)
      sql/mysql_priv.h:
        Added 'sql_command_flags'
      sql/sql_class.cc:
        New function add_diff_to_status(), used to update global status variables when using SHOW STATUS
      sql/sql_class.h:
        New function 'fill_information_schema_tables()'
        (One could not anymore use fill_derived_tables() for this as only_view_structures() is not relevant for information schema tables)
        Added defines for bit flags in sql_command_flags[]
      sql/sql_lex.cc:
        Remove orig_sql_command
      sql/sql_lex.h:
        Remove orig_sql_command
      sql/sql_parse.cc:
        Rename uc_update_queries -> sql_command_flags.
        Enhanced 'sql_command_flags' to better classify SQL commands
        uc_update_queries[] != 0 is changed to (sql_command_flags[] & CF_CHANGES_DATA)
        lex->orig_sql_command == SQLCOM_END is changed to (sql_command_flags[lex->sql_command] & CF_STATUS_COMMAND) == 0)
        
        Simplify incrementing of thd->status_var.com_stat[] as we don't have to do special handling for SHOW commands.
        
        Split SQLCOM_SELECT handling in mysql_execute_command() to a separate function.
        Added special handling of SHOW STATUS commands in mysql_execute_command() and call common SQLCOM_SELECT handling.
        These changes allows us to easily fix that we save and restore status variables during execution of a SHOW STATUS command.
        Don't log SHOW STATUS commands to slow query log.
        
        This fixes Bug#10210 and Bug#19764 without adding additional 'if' code.
        (The new code is faster than the original as we now have fewer if's than before)
      sql/sql_prepare.cc:
        Clean up prepare-check handling of SQLCOM commands by using sql_command_flags[]
        This simplifes code and ensures that code works even if someone forgets to put a new status commands into the switch statement.
      sql/sql_select.cc:
        Remove special handling of SHOW STATUS.
        (This is now done in SQLCOM_SHOW_STATUS part in mysql_execute_command())
      sql/sql_show.cc:
        Remove orig_sql_command
        Only change sql_command during 'open_normal_and_derived_tables()' (for views) and not for the full duration of generating data.
        Changed 'show status' to use thd->initial_status_var to ensure that the current statement is not affecting the to-be-used values.
        Use thd->fill_information_schema_tables() instead of 'thd->fill_derived_tables()' as the later wrongly checks the value of sql_command.
      sql/sql_yacc.yy:
        Remove usage of orig_sql_command.
        One side effect of this is that we need to test for cursors if the current command is a SELECT or a SHOW command.
      sql/structs.h:
        Updated comment
      f3a56a17
  2. 19 Jun, 2006 3 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · cd3fa2ee
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      include/my_sys.h:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      cd3fa2ee
    • unknown's avatar
      unsigned char -> uchar · 4b316e6f
      unknown authored
      Added missing copyright
      Indentation and prototype fixes
      Fixed compiler warning
      
      
      include/my_sys.h:
        Fix prototype for my_print_open_files.
        Indentation fixes
      mysys/mf_keycache.c:
        Fix that key cache can be compiled without #define THREAD
      mysys/my_error.c:
        Indentation cleanups
      mysys/my_memmem.c:
        Added missing copyright.
        Fix include files
      sql/event.cc:
        unsigned char -> uchar
      sql/field.cc:
        unsigned char -> uchar
      sql/filesort.cc:
        Indentation fix
      sql/ha_ndbcluster.cc:
        unsigned char -> uchar
      sql/ha_ndbcluster_binlog.cc:
        unsigned char -> uchar
      sql/item_strfunc.cc:
        unsigned char -> uchar
      sql/log_event.cc:
        unsigned char -> uchar
      sql/opt_range.cc:
        Indentation fixes
      sql/sql_crypt.cc:
        unsigned char -> uchar
      sql/sql_string.cc:
        unsigned char -> uchar
      sql/tztime.cc:
        unsigned char -> uchar
      storage/heap/hp_extra.c:
        Clear also next_block (See heap_scan_init)
      storage/heap/hp_test2.c:
        Set required struct memeber max_table_size
        (Fixes that hp_test2 works again)
      storage/myisam/mi_rsamepos.c:
        Fixed bug in mi_rsame_with_pos
      strings/decimal.c:
        Fixed compiler warning
      4b316e6f
    • unknown's avatar
      rpl_log.test, rpl_stm_log.result: · 9f8c532f
      unknown authored
        Fixed failing test case
      field.cc, item_cmpfunc.cc, select.result:
        After merge fix
      
      
      mysql-test/r/select.result:
        After merge fix
      mysql-test/r/rpl_stm_log.result:
        Fixed failing test case
      sql/item_cmpfunc.cc:
        After merge fix
      sql/field.cc:
        After merge fix
      mysql-test/extra/rpl_tests/rpl_log.test:
        Fixed failing test case
      9f8c532f
  3. 18 Jun, 2006 1 commit
    • unknown's avatar
      Manually merged · 610b1a4e
      unknown authored
      
      configure.in:
        Auto merged
      client/mysqlbinlog.cc:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/archive.result:
        Auto merged
      mysql-test/r/auto_increment.result:
        Auto merged
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/multi_update.result:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Auto merged
      mysql-test/r/replace.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/t/auto_increment.test:
        Auto merged
      mysql-test/t/delayed.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/multi_update.test:
        Auto merged
      mysql-test/t/ndb_lock.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/structs.h:
        Auto merged
      storage/archive/ha_archive.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      610b1a4e
  4. 17 Jun, 2006 6 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 60a9c875
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      60a9c875
    • unknown's avatar
      atomic ops: · d1fb2922
      unknown authored
          my_atomic_XX_t -> intXX, no implicit locking anymore
          simplified framework, support for requested cleanups
      
      
      dbug/dbug.c:
        compiler warning
      include/atomic/nolock.h:
        my_atomic_XX_t -> intXX
      include/atomic/rwlock.h:
        my_atomic_XX_t -> intXX, no implicit locking anymore
      include/atomic/x86-gcc.h:
        my_atomic_XX_t -> intXX, no implicit locking anymore
      include/atomic/x86-msvc.h:
        my_atomic_XX_t -> intXX
        simplified defines
        support for cleanups
      include/my_atomic.h:
        my_atomic_XX_t -> intXX, no implicit locking anymore
        simplified framework, support for requested cleanups
      unittest/examples/no_plan-t.c:
        compiler warning
      unittest/mysys/Makefile.am:
        fix for dependencies
      unittest/mysys/my_atomic-t.c:
        my_atomic_XX_t -> intXX, no implicit locking anymore
      unittest/mytap/tap.c:
        cosmetic fix
      d1fb2922
    • unknown's avatar
      ndb - bug#19285 post merge 5.0->5.1 fix (error codes) · 4f36bb01
      unknown authored
      
      storage/ndb/src/ndbapi/ndberror.c:
        postmerge fix
      4f36bb01
    • unknown's avatar
      Merge clam.ndb.mysql.com:/space/pekka/ndb/version/my50-bug19285 · 03c6f8cb
      unknown authored
      into  clam.ndb.mysql.com:/space/pekka/ndb/version/my51-bug19285
      
      
      storage/ndb/src/ndbapi/NdbBlob.cpp:
        SCCS merged
      storage/ndb/src/ndbapi/ndberror.c:
        use local
      03c6f8cb
    • unknown's avatar
      ndb - bug#19285 minor fixes · 76d2ecea
      unknown authored
      
      ndb/src/ndbapi/NdbBlob.cpp:
        bug#19285 minor fixes
      ndb/src/ndbapi/ndberror.c:
        bug#19285 minor fixes
      76d2ecea
    • unknown's avatar
      Merge clam.ndb.mysql.com:/space/pekka/ndb/version/my50-bug19285 · 6e0cdd89
      unknown authored
      into  clam.ndb.mysql.com:/space/pekka/ndb/version/my51-bug19285
      
      
      storage/ndb/include/ndbapi/NdbBlob.hpp:
        manual merge
      storage/ndb/include/ndbapi/NdbScanOperation.hpp:
        SCCS merged
      storage/ndb/src/ndbapi/NdbBlob.cpp:
        SCCS merged
      storage/ndb/src/ndbapi/NdbBlobImpl.hpp:
        manual merge
      storage/ndb/src/ndbapi/ndberror.c:
        use local - add 4275 afterwards
      storage/ndb/test/ndbapi/testBlobs.cpp:
        automerge
      6e0cdd89
  5. 16 Jun, 2006 25 commits
    • unknown's avatar
      Merge moonbone.local:/work/tmp_merge-5.0 · 9ec3f63f
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      configure.in:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/archive.result:
        Auto merged
      mysql-test/r/auto_increment.result:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Auto merged
      mysql-test/r/rpl_log.result:
        Auto merged
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/t/auto_increment.test:
        Auto merged
      mysql-test/t/ndb_lock.test:
        Auto merged
      mysql-test/t/rpl_log.test:
        Auto merged
      sql/ha_archive.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      9ec3f63f
    • unknown's avatar
      Manually merged · 9d3ddf38
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/archive.result:
        Auto merged
      mysql-test/r/auto_increment.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Auto merged
      mysql-test/r/rpl_log.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/t/auto_increment.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/ndb_lock.test:
        Auto merged
      mysql-test/t/rpl_log.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      9d3ddf38
    • unknown's avatar
      select.result: · 60d55cc5
      unknown authored
        After merge fix
      
      
      mysql-test/r/select.result:
        After merge fix
      60d55cc5
    • unknown's avatar
      Manually merged · d0f39b6a
      unknown authored
      
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      d0f39b6a
    • unknown's avatar
      Merge moonbone.local:/home/evgen/bk-trees/mysql-4.1-opt · 707de39a
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      707de39a
    • unknown's avatar
      Manually merged · de292d67
      unknown authored
      
      configure.in:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      de292d67
    • unknown's avatar
      item_strfunc.cc: · ca22a81b
      unknown authored
        Fix for bug#16716 for --ps-protocol mode.
      item_cmpfunc.cc:
        Fix for a memory allocation/freeing problem in agg_cmp_type() after fix
      for bug#16377. Few language corrections.
      
      
      sql/item_cmpfunc.cc:
        Fix for a memory allocation/freeing problem in agg_cmp_type(). Few language corrections.
      sql/item_strfunc.cc:
        Fix for bug#16716 for --ps-protocol mode.
      ca22a81b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 0d8d39c8
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/m51
      
      
      sql/log.cc:
        Auto merged
      0d8d39c8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · a245f597
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/m51
      
      
      a245f597
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 1e56f376
      unknown authored
      into  mysql.com:/home/cps/mysql/devel/5.1-csv-remove-mmap
      
      
      1e56f376
    • unknown's avatar
      Merge mronstrom@bk-internal.mysql.com:/home/bk/mysql-5.1 · 9479462b
      unknown authored
      into  c-0409e253.1238-1-64736c10.cust.bredbandsbolaget.se:/home/pappa/mysql-5.1-fix
      
      
      9479462b
    • unknown's avatar
      9224719d
    • unknown's avatar
      remove wrong assert · 6f160532
      unknown authored
      6f160532
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 1a7be737
      unknown authored
      into  mysql.com:/Users/emurphy/src/mysql/clean/mysql-5.1
      
      
      1a7be737
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 9addb8fd
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.1/main
      
      
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      9addb8fd
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/merge-queue · 70cf8240
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.0/main
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      70cf8240
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/merge-queue · ee1969d2
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.1/main
      
      
      storage/ndb/include/mgmapi/mgmapi.h:
        Auto merged
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Auto merged
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.hpp:
        Auto merged
      ee1969d2
    • unknown's avatar
      String::set(double) and set(longlong) -> set_real() and set_int() · 0237d9b0
      unknown authored
      fix Field::store(double) being used instead of store(longlong)
      
      NB: overloading functions is evil
      
      
      0237d9b0
    • unknown's avatar
      after-merge fixes. · dd285aac
      unknown authored
      
      mysql-test/r/rpl_log.result:
        after-merge fix.
      sql/ha_archive.cc:
        after-merge fix.
      sql/item_func.cc:
        after-merge fix.
      sql/sql_class.cc:
        after-merge fix.
      sql/sql_class.h:
        after-merge fix.
      dd285aac
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 61f4440c
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.1/main
      
      
      mysql-test/r/ndb_condition_pushdown.result:
        Auto merged
      mysql-test/r/type_newdecimal.result:
        Auto merged
      mysql-test/r/view_grant.result:
        Auto merged
      mysql-test/t/ndb_condition_pushdown.test:
        Auto merged
      mysql-test/t/type_newdecimal.test:
        Auto merged
      mysql-test/t/view_grant.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/valgrind.supp:
        Manual merge
      61f4440c
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-5.0 · 81284709
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.1
      
      
      mysql-test/t/ndb_lock.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.hpp:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Merge (using local)
      81284709
    • unknown's avatar
      Post_merges fixes. · b47705ab
      unknown authored
      b47705ab
    • unknown's avatar
      Fixing false alarm errors on windows build from a clean clone. · 59d38c15
      unknown authored
      
      win/build-vs71.bat:
        Don't trigger 'could not find the file specified' errors when 
        running from a clean clone.
      win/build-vs8.bat:
        Don't trigger 'could not find the file specified' errors when 
        running from a clean clone.
      59d38c15
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1-opt · 79966e67
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/t/func_group.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      mysql-test/r/func_group.result:
        SCCS merged
      79966e67
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · eb219834
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/field.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      eb219834
  6. 15 Jun, 2006 4 commits