An error occurred fetching the project authors.
  1. 19 Oct, 2005 1 commit
  2. 12 Oct, 2005 1 commit
  3. 04 Oct, 2005 1 commit
    • unknown's avatar
      Final patch for 5.0 for simplifying storage engine code. We now have just one... · ed35cecd
      unknown authored
      Final patch for 5.0 for simplifying storage engine code. We now have just one set of ifdefs. I may also remove the code for creating new handlers.
      May changes were to simplify storage engine setup and support for legacy call to show storage engines.
      
      
      mysql-test/r/ps_1general.result:
        Fixed test results for new listing order
      sql/examples/ha_tina.cc:
        Removed dead code
      sql/examples/ha_tina.h:
        Removed dead code
      sql/ha_archive.cc:
        Capitalized sotrage engine name and moved disabled code.
      sql/ha_berkeley.cc:
        Moved deisabled code
      sql/ha_federated.cc:
        Removed disabled code
      sql/ha_innodb.cc:
        Removed disabled message
      sql/ha_ndbcluster.cc:
        Removed disabled message
      sql/handler.cc:
        Added in legacy support for sotrage engine listing (ala Serg's request). Removed handlertons variables and we now have simplified ha_init code.
      sql/handler.h:
        No longer need handlertons array.
      ed35cecd
  4. 03 Oct, 2005 2 commits
    • unknown's avatar
      InnoDB: Display an error message in /* */ comments · 9595cc33
      unknown authored
      in SHOW CREATE TABLE if a temporary file cannot be created.
      (Bug #13002)
      
      
      sql/ha_innodb.cc:
        ha_innobase::get_foreign_key_create_info(): Display an error
        message to the user if a temporary file cannot be created.
      9595cc33
    • unknown's avatar
      Next big patch for loadable storage engines! · 5655d31d
      unknown authored
      Handlerton array is now created instead of using sys_table_types_st. All storage engines can now have inits and giant ifdef's are now gone for startup. No compeltely clean yet, handlertons will next be merged with sys_table_types. Federated and archive now have real cleanup if their inits fail. 
      
      
      sql/examples/ha_archive.cc:
        Modifications for new ha_init code. The init method now checks for errors and will not start up if the errors occur.
      sql/examples/ha_archive.h:
        Change for new init method.
      sql/examples/ha_example.cc:
        New handlerton pieces.
      sql/examples/ha_tina.cc:
        New handlerton pieces.
      sql/ha_berkeley.cc:
        New handlerton pieces, plus changes for ha_init changes. I'm not happy with our current "skip" setup.
      sql/ha_berkeley.h:
        Change in init return.
      sql/ha_blackhole.cc:
        Changes for new handlerton pieces.
      sql/ha_federated.cc:
        Changes for new handlerton and true cleanup code.
      sql/ha_heap.cc:
        Changes for new handlerton returns.
      sql/ha_innodb.cc:
        Changes for handlerton code.
      sql/ha_innodb.h:
        Change in init.
      sql/ha_myisam.cc:
        Changes for additional handlerton bits.
      sql/ha_myisammrg.cc:
        Changes for  new handlerton bits.
      sql/ha_ndbcluster.cc:
        Changes for new handlerton bits.
      sql/ha_ndbcluster.h:
        Changes for handlerton bits.
      sql/handler.cc:
        Changes for ditching show_table_type_st types, and collapsing it into a handlerton array. The ha_init now just loops through all handlers to init (much cleaner...). handlertons and sys_table_types should be merged next.
      sql/handler.h:
        Additions for sys_table_types
      sql/log.cc:
        Clean up of binlog for changes in handlerton
      sql/mysql_priv.h:
        Removed unneeded define for binlog_init
      sql/sql_show.cc:
        Changes for change in handlerton to sys_table_types
      5655d31d
  5. 01 Oct, 2005 1 commit
  6. 30 Sep, 2005 3 commits
    • unknown's avatar
      Bug#11238 · 8f842e8f
      unknown authored
      "SELECT ... FOR UPDATE executed as consistent read inside LOCK TABLES"
      Do not discard lock_type information as handler::start_stmt() may require knowledge.
      (fixed by Antony)
      
      
      8f842e8f
    • unknown's avatar
      InnoDB: After review fix · afed50ae
      unknown authored
      sql/ha_innodb.cc:
        Avoid bitwise arithmetics, as it might be difficult to read.  The
        added readability costs one register and two instructions on x86.
      afed50ae
    • unknown's avatar
      InnoDB: On UPDATE, trim UCS2 columns correctly. (Bug #12178) · a14a34be
      unknown authored
      sql/ha_innodb.cc:
        innobase_convert_and_store_changed_col(), calc_row_difference():
         Replace parameter "is_unsigned" with "prtype".
        innobase_convert_and_store_changed_col():
         When trimming spaces, note that UCS2 spaces are 0x0020, not 0x20.
      a14a34be
  7. 29 Sep, 2005 2 commits
    • unknown's avatar
      Minor corrections to InnoDB function comments · 612b9ceb
      unknown authored
      innobase/include/mem0mem.h:
        Correct the comment of mem_heap_create_func().
      innobase/include/mem0mem.ic:
        Correct the comment of mem_heap_create_func().
      sql/ha_innodb.cc:
        Correct comments regarding return value
      612b9ceb
    • unknown's avatar
      Fixed a bug checksum table locks the InnoDB table and does not use a · 2c0e2a14
      unknown authored
      consistent read (Bug #12669). This fixes InnoDB part of the bug.
      
      
      mysql-test/r/innodb.result:
        Added results for a checksum test.
      mysql-test/t/innodb.test:
        Addeed a test case for a checksum bug #12669.
      sql/ha_innodb.cc:
        Use consistent read for checksum table.
      2c0e2a14
  8. 28 Sep, 2005 2 commits
    • unknown's avatar
      InnoDB: Remove compiler warnings. · a11fc734
      unknown authored
      innobase/os/os0proc.c:
        Add UT_NOT_USED for parameters in dummy implementations of AWE functions.
      sql/ha_innodb.cc:
        Tweak casts to eliminate compiler warnings.
      a11fc734
    • unknown's avatar
      Fixed a bug checksum table locks the InnoDB table and does not use a · 2de206b4
      unknown authored
      consistent read (Bug #12669).
      
      
      mysql-test/r/innodb.result:
        Added test results for a checksum test.
      mysql-test/t/innodb.test:
        Added test case for a checksum bug #12669.
      sql/ha_innodb.cc:
        Use consistent read for checksum table and convert MySQL lock type
        to the TL_READ because at the moment MySQL uses TL_READ_NO_INSERT.
      2de206b4
  9. 23 Sep, 2005 3 commits
    • unknown's avatar
      Fix bug #3443, better foreign key error messsages. · e4b0b0d0
      unknown authored
      innobase/dict/dict0dict.c:
        Add 'add_newline' parameter to dict_print_info_on_foreign_key_in_create_format.
      innobase/include/dict0dict.h:
        Add 'add_newline' parameter to dict_print_info_on_foreign_key_in_create_format.
      innobase/include/os0file.h:
        Add os_file_read_string.
      innobase/include/trx0trx.h:
        Add trx_set_detailed_error and trx_set_detailed_error_from_file functions
        and a detailed_error field to trx_struct.
      innobase/include/ut0mem.h:
        Add ut_strlcpy.
      innobase/os/os0file.c:
        Add os_file_read_string.
      innobase/row/row0ins.c:
        Add row_ins_set_detailed function and call it when needed.
        
        Adapt to changes in dict_print_info_on_foreign_key_in_create_format.
      innobase/trx/trx0trx.c:
        Add trx_set_detailed_error and trx_set_detailed_error_from_file.
        
        Clear trx->detailed_error in trx_create.
      innobase/ut/ut0mem.c:
        Add ut_strlcpy.
      mysql-test/r/innodb.result:
        Add new tests, adapt existing ones whose output was changed.
      mysql-test/t/innodb.test:
        Add new tests, adapt existing ones whose output was changed.
      sql/ha_innodb.cc:
        Add get_error_message.
        
        Clear trx->detailed_error in start_stmt and external_lock.
      sql/ha_innodb.h:
        Add get_error_message.
      sql/handler.cc:
        Add special case code in print_error for HA_ERR_ROW_IS_REFERENCED and
        HA_ERR_NO_REFERENCED_ROW.
        
        Change SETMSG to point to new error messages.
      sql/share/errmsg.txt:
        Add ER_ROW_IS_REFERENCED_2 and ER_NO_REFERENCED_ROW_2.
      e4b0b0d0
    • unknown's avatar
      InnoDB: Minor fixes. · 8acd0fa4
      unknown authored
      innobase/include/trx0trx.h:
        Fix invalid comment.
      sql/ha_innodb.cc:
        Change some memory allocations to fail-on-error.
        
        Cast argument of my_free to gptr, not char*.
      8acd0fa4
    • unknown's avatar
      InnoDB: Fix bug #13315, index columns having a maximum length of 767. · 6fbbb1d5
      unknown authored
      innobase/data/data0data.c:
        Adapt to DICT_MAX_COL_PREFIX_LEN rename.
      innobase/dict/dict0dict.c:
        Adapt to DICT_MAX_COL_PREFIX_LEN rename.
      innobase/include/dict0mem.h:
        Rename DICT_MAX_COL_PREFIX_LEN to DICT_MAX_INDEX_COL_LEN.
      innobase/include/row0mysql.h:
        Add field_lengths parameter to row_create_index_for_mysql.
      innobase/rem/rem0rec.c:
        Adapt to DICT_MAX_COL_PREFIX_LEN rename.
      innobase/row/row0mysql.c:
        Add field_lengths parameter to row_create_index_for_mysql and use it to
        check for too long index columns.
      mysql-test/r/innodb.result:
        New tests.
      mysql-test/t/innodb.test:
        New tests.
      sql/ha_innodb.cc:
        Create temporary field_lengths buffer and pass it to
        row_create_index_for_mysql.
      6fbbb1d5
  10. 20 Sep, 2005 1 commit
    • unknown's avatar
      WL#2787 (Add view definer/owner to the view definition (.frm) to check... · 3fe752f5
      unknown authored
      WL#2787 (Add view definer/owner to the view definition (.frm) to check privileges on used tables and stored routines when using a VIEW.)
      Part 2 postreview fixes.
      
      
      sql/ha_innodb.cc:
        Renamed structure st_security_context to class Security_context
      sql/item_func.cc:
        Renamed structure st_security_context to class Security_context
      sql/item_strfunc.cc:
        fixed USER() function
      sql/log.cc:
        variable used to optimize access to security context
      sql/mysql_priv.h:
        Renamed structure st_security_context to class Security_context
      sql/mysqld.cc:
        main security context used direcly
      sql/sp_head.cc:
        Renamed structure st_security_context to class Security_context
        removed unneed variable
      sql/sp_head.h:
        Comment inmroved
        Renamed structure st_security_context to class Security_context
      sql/sql_acl.cc:
        Renamed structure st_security_context to class Security_context
        fixed function comment and return value
        variable used to optimize access to security context
        Renamed method of Security_ontext
      sql/sql_acl.h:
        fixed return value type
      sql/sql_class.cc:
        Renamed structure st_security_context to class Security_context
      sql/sql_class.h:
        Renamed structure st_security_context to class Security_context
        Method renamed
      sql/sql_db.cc:
        Renamed structure st_security_context to class Security_context
        fixed layout
      sql/sql_parse.cc:
        registration of wanted access for underlying tables
      sql/sql_show.cc:
        Renamed structure st_security_context to class Security_context
        fixed layout
      sql/sql_yacc.yy:
        Renamed structure st_security_context to class Security_context
      3fe752f5
  11. 19 Sep, 2005 1 commit
    • unknown's avatar
      Cleanup for handlerton structure to allow for loadable engine work. This is... · fa8fcecb
      unknown authored
      Cleanup for handlerton structure to allow for loadable engine work. This is the first in a series of patches. 
      
      
      sql/examples/ha_archive.cc:
        Now declared externally.
      sql/examples/ha_example.cc:
        Now declared externally
      sql/examples/ha_tina.cc:
        Now declared externally
      sql/ha_berkeley.cc:
        Now declared externally
      sql/ha_blackhole.cc:
        Now declared externally
      sql/ha_federated.cc:
        Now declared externally.
      sql/ha_heap.cc:
        Now declared externally.
      sql/ha_innodb.cc:
        Now declared externally.
      sql/ha_myisam.cc:
        Now declared externally
      sql/ha_myisammrg.cc:
        Now declared externally.
      sql/ha_ndbcluster.cc:
        Now declared externally.
      sql/handler.cc:
        Changes for eventual loadable engines. This will allow us to gain faster access to the handlerton (eventually this will just be a handlteron array).
      sql/handler.h:
        New alias structure and change to show_table_st to place handlerton in the structure.
      fa8fcecb
  12. 15 Sep, 2005 1 commit
    • unknown's avatar
      WL#2787 (part 2, ver 3 (merged)) changed securety context switching · 84f029a4
      unknown authored
      libmysqld/lib_sql.cc:
        changed securety context switching
      mysql-test/r/rpl_sp.result:
        now it show real information from changed security context of SP (checked)
      sql/ha_innodb.cc:
        changed securety context switching
      sql/item.cc:
        changed securety context switching
      sql/item_func.cc:
        changed securety context switching
      sql/item_strfunc.cc:
        changed securety context switching
      sql/log.cc:
        changed securety context switching
      sql/mysql_priv.h:
        changed securety context switching
      sql/mysqld.cc:
        changed securety context switching
      sql/repl_failsafe.cc:
        changed securety context switching
      sql/set_var.cc:
        changed securety context switching
      sql/slave.cc:
        changed securety context switching
      sql/sp.cc:
        changed securety context switching
      sql/sp_head.cc:
        changed securety context switching
        in case of inability to switch context  we return error now
      sql/sp_head.h:
        changed securety context switching
      sql/sql_acl.cc:
        changed securety context switching
      sql/sql_acl.h:
        changed securety context switching
      sql/sql_base.cc:
        changed securety context switching
      sql/sql_class.cc:
        changed securety context switching
      sql/sql_class.h:
        changed securety context switching
      sql/sql_db.cc:
        changed securety context switching
      sql/sql_insert.cc:
        changed securety context switching
      sql/sql_parse.cc:
        changed securety context switching
      sql/sql_show.cc:
        changed securety context switching
      sql/sql_trigger.cc:
        changed securety context switching
      sql/sql_view.cc:
        changed securety context switching
      sql/sql_yacc.yy:
        changed securety context switching
      84f029a4
  13. 06 Sep, 2005 1 commit
    • unknown's avatar
      InnoDB: Reject foreign keys in temporary tables. Closes bug #12084. · 2d1c26cc
      unknown authored
      innobase/dict/dict0dict.c:
        Add reject_fks parameter to dict_create_foreign_constraints_low and
        dict_create_foreign_constraints.
      innobase/include/dict0dict.h:
        Add reject_fks parameter to dict_create_foreign_constraints.
      innobase/include/row0mysql.h:
        Add reject_fks parameter to row_table_add_foreign_constraints.
      innobase/row/row0mysql.c:
        Add reject_fks parameter to row_table_add_foreign_constraints.
      sql/ha_innodb.cc:
        In create, pass correct reject_fks argument to
        row_table_add_foreign_constraints depending on whether we're creating a
        temporary table or not. Also move duplicated cleanup code to a single
        place.
      2d1c26cc
  14. 04 Sep, 2005 3 commits
    • unknown's avatar
      row0mysql.c, ha_innodb.cc: · c02509b1
      unknown authored
        Fix bug #12308 : do not roll back the whhole transaction in a lock wait timeout error, just roll back the latest SQL statement; note that the locks set in the latest SQL statements remain, as InnoDB does not know what locks were set in which SQL statement
      
      
      sql/ha_innodb.cc:
        Fix bug #12308 : do not roll back the whhole transaction in a lock wait timeout error, just roll back the latest SQL statement; note that the locks set in the latest SQL statements remain, as InnoDB does not know what locks were set in which SQL statement
      innobase/row/row0mysql.c:
        Fix bug #12308 : do not roll back the whhole transaction in a lock wait timeout error, just roll back the latest SQL statement; note that the locks set in the latest SQL statements remain, as InnoDB does not know what locks were set in which SQL statement
      c02509b1
    • unknown's avatar
      ha_innodb.cc: · d6b70bf4
      unknown authored
        Better comments about auto-inc and SHOW TABLE STATUS
      
      
      sql/ha_innodb.cc:
        Better comments about auto-inc and SHOW TABLE STATUS
      d6b70bf4
    • unknown's avatar
      ha_innodb.cc: · 53379f98
      unknown authored
        Fix bug #12973 : set the table handle field auto_increment_value if ::info() is called with the flag HA_STATUS_AUTO
      
      
      sql/ha_innodb.cc:
        Fix bug #12973 : set the table handle field auto_increment_value if ::info() is called with the flag HA_STATUS_AUTO
      53379f98
  15. 31 Aug, 2005 2 commits
    • unknown's avatar
      ha_innodb.cc: · 8510e747
      unknown authored
        Fix bug #12410 : InnoDB was too permissive with LOCK TABLE ... READ LOCAL, and alowed new inserts to the table; we now make READ LOCAL equivalent to READ for InnoDB; note that this will cause slightly more locking in mysqldump, but makes the InnoDB table dumps consistent with MyISAM table dumps; note that the real code change patch was accidentally pushed with my another patch 5 minutes ago
      
      
      sql/ha_innodb.cc:
        Fix bug #12410 : InnoDB was too permissive with LOCK TABLE ... READ LOCAL, and alowed new inserts to the table; we now make READ LOCAL equivalent to READ for InnoDB; note that this will cause slightly more locking in mysqldump, but makes the InnoDB table dumps consistent with MyISAM table dumps; note that the real code change patch was accidentally pushed with my another patch 5 minutes ago
      8510e747
    • unknown's avatar
      ha_innodb.cc: · 138e44b8
      unknown authored
        Fix bug #12852 : do not increment the open handle count to a table if the table does not have an .ibd file and InnoDB decides to return an error from the ::open() function; then the table can be dropped even if the user has tried to open it
      
      
      sql/ha_innodb.cc:
        Fix bug #12852 : do not increment the open handle count to a table if the table does not have an .ibd file and InnoDB decides to return an error from the ::open() function; then the table can be dropped even if the user has tried to open it
      138e44b8
  16. 30 Aug, 2005 2 commits
    • unknown's avatar
      ha_innodb.cc: · a02f8735
      unknown authored
        Reorder out-of-order status variables
      
      
      sql/ha_innodb.cc:
        Reorder out-of-order status variables
      a02f8735
    • unknown's avatar
      Bug #11946: Review fixes. · c12a760c
      unknown authored
      sql/ha_innodb.cc:
        Add 'value' parameter to reset_auto_increment.
      sql/ha_innodb.h:
        Add 'value' parameter to reset_auto_increment.
      sql/handler.h:
        Add 'value' parameter to reset_auto_increment.
      sql/mysql_priv.h:
        Add 'reset_auto_increment' parameter to mysql_delete.
      sql/sql_delete.cc:
        Add 'reset_auto_increment' parameter to mysql_delete, and use it instead
        of checking for SQLCOM_TRUNCATE.
        
        mysql_truncate: Adapt to changes in mysql_delete.
      sql/sql_parse.cc:
        mysql_execute_command: Adapt to changes in mysql_delete.
      c12a760c
  17. 25 Aug, 2005 1 commit
    • unknown's avatar
      ha_innodb.cc: · 0f94385b
      unknown authored
        Fix typo
      
      
      sql/ha_innodb.cc:
        Fix typo
      0f94385b
  18. 24 Aug, 2005 1 commit
    • unknown's avatar
      ha_innodb.cc: · 4c76d94f
      unknown authored
        Fix bug #12779 : never give a row count estimate of 0 to the MySQL query optimizer, as then left join optimizer may beleive it KNOWS that the table is empty; note that this fix may change query optimization of many other queries where one table is empty; note that the proper fix would be to make the query optimizer to know that the row count estimates it receives really are just estimates, it cannot assume they are certain
      
      
      sql/ha_innodb.cc:
        Fix bug #12779 : never give a row count estimate of 0 to the MySQL query optimizer, as then left join optimizer may beleive it KNOWS that the table is empty; note that this fix may change query optimization of many other queries where one table is empty; note that the proper fix would be to make the query optimizer to know that the row count estimates it receives really are just estimates, it cannot assume they are certain
      4c76d94f
  19. 17 Aug, 2005 1 commit
    • unknown's avatar
      Fix bug #11946, truncate not always resetting the auto-increment counter · fa31a995
      unknown authored
      in InnoDB tables.
      
      
      mysql-test/r/innodb.result:
        New tests.
      mysql-test/t/innodb.test:
        New tests.
      sql/ha_innodb.cc:
        Add reset_auto_increment.
      sql/ha_innodb.h:
        Add reset_auto_increment.
      sql/handler.h:
        Add reset_auto_increment.
      sql/sql_delete.cc:
        Call handler->reset_auto_increment when needed.
      fa31a995
  20. 16 Aug, 2005 1 commit
  21. 12 Aug, 2005 2 commits
    • unknown's avatar
      BUG#12162 - one can start two transactions with the same XID. · 87ae5a15
      unknown authored
      Now we keep all active XID's in a hash
      
      
      87ae5a15
    • unknown's avatar
      InnoDB: Print more than 300 characters of queries in various error conditions, · babc9f5d
      unknown authored
      most notably deadlocked ones in SHOW INNODB STATUS. Fixes bug #7819.
      
      
      innobase/btr/btr0pcur.c:
        Adapt to changes in trx_print.
      innobase/include/trx0trx.h:
        Add max_query_len parameter to trx_print.
      innobase/lock/lock0lock.c:
        Adapt to changes in trx_print.
      innobase/row/row0ins.c:
        Adapt to changes in trx_print.
      innobase/row/row0sel.c:
        Adapt to changes in trx_print.
      innobase/row/row0umod.c:
        Adapt to changes in trx_print.
      innobase/row/row0upd.c:
        Adapt to changes in trx_print.
      innobase/srv/srv0srv.c:
        Adapt to changes in trx_print.
      innobase/trx/trx0trx.c:
        Add max_query_len parameter to trx_print.
      sql/ha_innodb.cc:
        Add max_query_len parameter to innobase_mysql_print_thd.
      babc9f5d
  22. 11 Aug, 2005 2 commits
    • unknown's avatar
      Fixed some warning and error messages so that they use · 1d3d9ec1
      unknown authored
      sql_print_warning() and sql_print_error() instead of fprintf to stderr.
      Above functions are tuned for different platforms so that the behavior
      is consistent around platforms. Using fprintf() different behavior can
      be expected at least on Windows and Unix.
      
      
      1d3d9ec1
    • unknown's avatar
      set_var.cc, mysqld.cc, ha_innodb.h, ha_innodb.cc, srv0srv.c, srv0srv.h: · 8158bb03
      unknown authored
        Added innodb_commit_concurrency variable
      
      
      innobase/include/srv0srv.h:
        Added innodb_commit_concurrency variable
      innobase/srv/srv0srv.c:
        Added innodb_commit_concurrency variable
      sql/ha_innodb.cc:
        Added innodb_commit_concurrency variable
      sql/ha_innodb.h:
        Added innodb_commit_concurrency variable
      sql/mysqld.cc:
        Added innodb_commit_concurrency variable
      sql/set_var.cc:
        Added innodb_commit_concurrency variable
      8158bb03
  23. 10 Aug, 2005 1 commit
    • unknown's avatar
      A fix and a test case for Bug#12243 "MySQL Server crashes with 2 · 6861b1bf
      unknown authored
      cursors (+ commit)" and Bug#11832 "Server crash with InnoDB + Cursors"
      See comments to the changed files.
      
      
      innobase/include/read0read.h:
        - add cursor_view_t::n_mysql_tables_in_use
      innobase/read/read0read.c:
        - maintain cursor_view_t::n_mysql_tables_in_use. InnoDB
        maintains trx->n_mysql_tables_in_use to know when it can auto-commit
        a read-only statement. When this count drops to zero,
        MySQL has ended processing of such statement and InnoDB can commit.
        Cursors should not break this invariant, and should exclude the tables
        used in a cursor from the count of active tables.
        When a cursor is closed, the number of its tables is added back, 
        to ensure that close_thread_tables->unlock_external->
        ha_innobase::external_lock(F_UNLCK) won't drop the count in trx 
        below zero.
      innobase/row/row0sel.c:
        - remove the restoration of the global read view from 
        row_search_for_mysql: MySQL may call row_search_for_mysql
        more than once when fetching a row for a cursor (e.g. if there
        is a WHERE clause that filters out some rows).
      sql/ha_innodb.cc:
        - add more verbose printout for the case when we close an InnoDB
        connection without priorlly issuing a commit or rollback. The problem
        should be investigated.
      tests/mysql_client_test.c:
        - add a test case for Bug#12243 "MySQL Server crashes with 2 cursors 
        (+ commit)"
      6861b1bf
  24. 09 Aug, 2005 2 commits
    • unknown's avatar
      Fix bug #12340 Wrong comparison in ha_innobase::cmp_ref() · 71a8b11f
      unknown authored
      When PRIMARY KEY is present ha_innobase::cmp_ref() uses it to compare refs.
      After comparing part of key it moves pointers to compare next part.
      For varchar parts pointers were moved only by length of parts, not including
      bytes containig part length itself. This results in wrong comparision and
      wrong number of deleted records.
      
      
      
      sql/ha_innodb.cc:
        Fix bug #12340  ha_innobase::cmp_ref() moves pointers by wrong length.
      mysql-test/t/innodb.test:
        Test case for bug #12340 ha_innobase::cmp_ref() moves pointers by wrong length.
      mysql-test/r/innodb.result:
        Test case for bug #12340 ha_innobase::cmp_ref() moves pointers by wrong length.
      71a8b11f
    • unknown's avatar
      Fixed test that failed on 32 bit systems · c4228519
      unknown authored
      sql/ha_innodb.cc:
        Don't print not critical warning if log_warnings is not set
        Use sql_print_warning() instead of fprintf().
        (We should not use fprintf() as this causes problems on windows and with the embedded server)
      c4228519
  25. 08 Aug, 2005 1 commit
    • unknown's avatar
      ha_innodb.cc: · 807a9c8d
      unknown authored
        Add a forgotten newline to a print
      
      
      sql/ha_innodb.cc:
        Add a forgotten newline to a print
      807a9c8d
  26. 03 Aug, 2005 1 commit
    • unknown's avatar
      ha_innodb.cc: · 1bdc18b9
      unknown authored
        Fix compilation error in the fix of Bug #12263
      
      
      sql/ha_innodb.cc:
        Fix compilation error in the fix of Bug #12263
      1bdc18b9