1. 09 Mar, 2007 5 commits
  2. 08 Mar, 2007 7 commits
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-bug25673 · 39f350e2
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug25673
      
      
      storage/myisam/rt_index.c:
        Auto merged
      39f350e2
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug25673 · 86589331
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug25673
      
      
      myisam/rt_index.c:
        Auto merged
      86589331
    • unknown's avatar
      Bug#25673 - spatial index corruption, error 126 incorrect key file for table · 35d58191
      unknown authored
      After backport fix.
      Added forgotten DBUG_RETURNs, which was detected in 5.1 only.
      
      
      35d58191
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-bug25673 · 2923b0d4
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug25673
      
      
      mysql-test/r/gis-rtree.result:
        Auto merged
      mysql-test/t/gis-rtree.test:
        Auto merged
      storage/myisam/rt_index.c:
        Auto merged
      storage/myisam/rt_key.c:
        Auto merged
      storage/myisam/rt_split.c:
        Auto merged
      2923b0d4
    • unknown's avatar
      2157f642
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug25673 · 6e969d2b
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug25673
      
      
      myisam/rt_index.c:
        Auto merged
      myisam/rt_key.c:
        Auto merged
      mysql-test/t/gis-rtree.test:
        Auto merged
      myisam/rt_split.c:
        Bug#25673 - spatial index corruption, error 126 incorrect key file for table
        Manual merge from 4.1
      mysql-test/r/gis-rtree.result:
        Bug#25673 - spatial index corruption, error 126 incorrect key file for table
        Manual merge from 4.1
      6e969d2b
    • unknown's avatar
      Bug#25673 - spatial index corruption, error 126 · 548a39a1
      unknown authored
                incorrect key file for table
      
      In certain cases it could happen that deleting a row could
      corrupt an RTREE index.
      
      According to Guttman's algorithm, page underflow is handled
      by storing the page in a list for later re-insertion. The
      keys from the stored pages have to be inserted into the
      remaining pages of the same level of the tree. Hence the
      level number is stored in the re-insertion list together
      with the page.
      
      In the MySQL RTree implementation the level counts from zero
      at the root page, increasing numbers for levels down the tree.
      
      If during re-insertion of the keys the tree height grows, all
      level numbers become invalid. The remaining keys will be
      inserted at the wrong level.
      
      The fix is to increment the level numbers stored in the
      reinsert list after a split of the root block during reinsertion.
      
      
      myisam/rt_index.c:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added a loop in rtree_delete() to increment the level numbers
        stored in the reinsert list after a split of the root block
        during reinsertion.
        Added comments and DBUG statements.
      myisam/rt_key.c:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added DBUG statements.
      myisam/rt_split.c:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added DBUG statements.
      mysql-test/r/gis-rtree.result:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added the test result.
      mysql-test/t/gis-rtree.test:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added a test.
      548a39a1
  3. 06 Mar, 2007 2 commits
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-bug26464 · 1d6584e6
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.1-bug26464
      
      
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      storage/myisammrg/ha_myisammrg.h:
        Bug#26464 - insert delayed + update + merge = corruption
        Manual merge from 5.0
      1d6584e6
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug26464 · 2f863451
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug26464
      
      
      mysql-test/t/merge.test:
        Auto merged
      mysql-test/r/merge.result:
        Bug#26464 - insert delayed + update + merge = corruption
        Manual merge from 4.1
      sql/ha_myisammrg.h:
        Bug#26464 - insert delayed + update + merge = corruption
        Manual merge from 4.1
      2f863451
  4. 05 Mar, 2007 1 commit
    • unknown's avatar
      Bug#26464 - insert delayed + update + merge = corruption · da9c659c
      unknown authored
      Using INSERT DELAYED on MERGE tables could lead to table
      corruptions.
      
      The manual lists a couple of storage engines, which can be
      used with INSERT DELAYED. MERGE is not in this list.
      
      The attempt to try it anyway has not been rejected yet.
      This bug was not detected earlier as it can work under
      special circumstances. Most notable is low concurrency.
      
      To be safe, this patch rejects any attempt to use INSERT
      DELAYED on MERGE tables.
      
      
      mysql-test/r/merge.result:
        Bug#26464 - insert delayed + update + merge = corruption
        Added test result.
      mysql-test/t/merge.test:
        Bug#26464 - insert delayed + update + merge = corruption
        Added test.
      sql/ha_myisammrg.h:
        Bug#26464 - insert delayed + update + merge = corruption
        Removed HA_CAN_INSERT_DELAYED flag from table_flags().
        The insert delayed thread upgrades the lock from the first
        entry in MYSQL_LOCK::locks only. Hence it is incapable to
        handle MERGE tables, which have as many entries in this
        array as they have MyISAM sub-tables.
      da9c659c
  5. 02 Mar, 2007 2 commits
  6. 28 Feb, 2007 5 commits
    • unknown's avatar
      BUG#26238 - inserted delayed always inserts 0 for BIT columns · af44be2d
      unknown authored
      INSERT DELAYED inserts garbage for BIT columns.
      
      When delayed thread clones TABLE object, it didn't adjusted bit_ptr
      to newly created record (though it correctly adjusts ptr and null_ptr).
      
      This is fixed by correctly adjusting bit_ptr when performing a clone.
      With this fix BIT values are stored correctly by INSERT DELAYED.
      
      
      mysql-test/r/delayed.result:
        A test case for BUG#26238.
      mysql-test/t/delayed.test:
        A test case for BUG#26238.
      sql/field.h:
        Added move_field() to Field_bit class. When moving a field, adjust
        bit_ptr also, which is specific to Field_bit class.
      af44be2d
    • unknown's avatar
    • unknown's avatar
      BUG#26080 - Memory Storage engine not working properly · d9dbd4ca
      unknown authored
      Extending varchar column length with ALTER TABLE may result in unusable
      memory table.
      
      The problem is that we use fast ALTER TABLE in this case, which is not
      supported by now.
      
      This is fixed by refusing fast ALTER TABLE when extending varchar column.
      In other words force copy of a table during ALTER TABLE.
      
      Affects MEMORY tables in 5.1 only.
      
      
      mysql-test/r/heap.result:
        A test case for BUG#26080.
      mysql-test/t/heap.test:
        A test case for BUG#26080.
      storage/heap/ha_heap.cc:
        For MEMORY, if varchar column extended, it should return incompatible for
        now. In other words force copy of a table during alter table.
      d9dbd4ca
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.1 · 53c5511a
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      53c5511a
    • unknown's avatar
      valgrind error fix · 8010d987
      unknown authored
      8010d987
  7. 27 Feb, 2007 8 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 9cf5f2c9
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.1-bug26117
      
      
      9cf5f2c9
    • unknown's avatar
      BUG#26117 "index_merge sort-union over partitioned table crashes" · b68a2201
      unknown authored
      Before the fix: 
        ha_partition objects had ha_partition::m_part_info==NULL and that caused
        crash
      After: 
      - The new ha_partition::clone() function makes the clones use parent's
        m_part_info value.
      - The parent ha_partition object remains responsible for deallocation of
        m_part_info.
      
      
      mysql-test/r/partition_innodb.result:
        BUG#26117 "index_merge sort-union over partitioned table crashes"
         - Testcase
      mysql-test/t/partition_innodb.test:
        BUG#26117 "index_merge sort-union over partitioned table crashes"
         - Testcase
      b68a2201
    • unknown's avatar
      Fix (last) compiler warnings · ae72e394
      unknown authored
      
      storage/innobase/pars/lexyy.c:
        Fix compiler warnings (fix is also in pars0lex.l)
      support-files/compiler_warnings.supp:
        Extra safety to ensure we really get rid of warning :)
      ae72e394
    • unknown's avatar
      Remove compiler warnings · 3956f591
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Fix warning when using --extern
      sql/field.cc:
        Fix wrong fix
      sql/ha_ndbcluster.cc:
        Better fixes to remove compiler warnings
      sql/ha_ndbcluster_binlog.cc:
        Better fixes to remove compiler warnings
      sql/log.cc:
        Fix compiler warnings
      sql/sql_parse.cc:
        Indentation fix
      sql/sql_table.cc:
        Indentation fixes
      storage/myisammrg/ha_myisammrg.cc:
        Fix compiler warnings
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Fix compiler warnings
      support-files/compiler_warnings.supp:
        Suppress all 'safe' warnings, as detected by win64
      win/README:
        Fixed typo
      3956f591
    • unknown's avatar
      Fixes for compiler warnings. · 175507b7
      unknown authored
      
      include/my_dbug.h:
        Added macro for fixing compiler warnings.
      sql/field.cc:
        Fixed compiler warnings.
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings.
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warnings.
        Changed some tabs into spaces.
      sql/rpl_injector.h:
        Fixed compiler warnings.
      sql/sql_binlog.cc:
        Fixed compiler warnings.
      sql/sql_repl.cc:
        Fixed compiler warnings.
      sql/sql_table.cc:
        Fixed compiler warnings.
      storage/myisammrg/ha_myisammrg.cc:
        Fixed compiler warnings.
      strings/ctype-ucs2.c:
        Fixed compiler warnings.
      strings/ctype-utf8.c:
        Fixed compiler warnings.
      support-files/compiler_warnings.supp:
        Added suppressed warnings.
      175507b7
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 13f1e40b
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      13f1e40b
    • unknown's avatar
      removed unused variable · 3a520a78
      unknown authored
      3a520a78
    • unknown's avatar
      after merge fix · 6e133525
      unknown authored
      6e133525
  8. 26 Feb, 2007 9 commits
    • unknown's avatar
      after merge fix · 79a6e0fe
      unknown authored
      79a6e0fe
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 6247e1b2
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      6247e1b2
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.1 · 536adef6
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      536adef6
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · de5d4e32
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      de5d4e32
    • unknown's avatar
      after merge fix · bab42f67
      unknown authored
      bab42f67
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · b1060052
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/subselect3.result:
        Auto merged
      mysql-test/r/type_blob.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      BitKeeper/deleted/.del-bdb.result:
        Auto merged
      mysql-test/extra/binlog_tests/blackhole.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/blackhole/ha_blackhole.cc:
        Auto merged
      mysql-test/r/binlog_stm_blackhole.result:
        manual merge
      mysql-test/r/insert_select.result:
        manual merge
      mysql-test/r/subselect.result:
        manual merge
      mysql-test/r/update.result:
        manual merge
      mysql-test/t/insert_select.test:
        manual merge
      mysql-test/t/subselect.test:
        manual merge
      sql/sql_help.cc:
        manual merge
      sql/sql_insert.cc:
        manual merge
      sql/sql_update.cc:
        manual merge
      b1060052
    • unknown's avatar
      Merge ymer.(none):/tmp/mysql-5.0 · 1eb71c68
      unknown authored
      into  ymer.(none):/tmp/mysql-5.1
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      storage/ndb/include/util/OutputStream.hpp:
        Auto merged
      storage/ndb/src/common/debugger/EventLogger.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dblqh/Dblqh.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/ndbcntr/Ndbcntr.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      storage/ndb/src/kernel/blocks/qmgr/Qmgr.hpp:
        Auto merged
      storage/ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Auto merged
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/InitConfigFileParser.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/ndbapi/ClusterMgr.hpp:
        Auto merged
      storage/ndb/src/ndbapi/SignalSender.cpp:
        Auto merged
      1eb71c68
    • unknown's avatar
      Compiler warning suppression fix: Add missing file to 'make dist'. · 8c336fbc
      unknown authored
      
      support-files/Makefile.am:
        Add missing file to 'make dist'.
      8c336fbc
    • unknown's avatar
      item.cc, item.h: · 90d4f809
      unknown authored
        Post fix for bug#23800.
      
      
      sql/item.h:
        Post fix for bug#23800.
      sql/item.cc:
        Post fix for bug#23800.
      90d4f809
  9. 25 Feb, 2007 1 commit
    • unknown's avatar
      item.h: · 84e68927
      unknown authored
        Post fix for bug#23800.
        Copy the table name of an Item_outer_ref to the conventional memory.
      
      
      sql/item.h:
        Post fix for bug#23800.
        Copy the table name of an Item_outer_ref to the conventional memory.
      84e68927