.

go/neo/master.go

@@ -20,6 +20,12 @@
 package neo
 // master node
 
+// XXX master organization
+//
+// - main goroutine that is the only mutator of nodeTab, partTab, etc
+// - per peer workers are spawned that interact with main via channels
+// - δnodeTab, δpartTab updates are proxied to peer by another per-peer goroutine
+
 import (
 	"context"
 	stderrors "errors"
@@ -47,9 +53,10 @@ type Master struct {
 	node *xneo.Node
 
 	// master manages node and partition tables and broadcast their updates
-	// to all nodes in the cluster
-	notifyWG  sync.WaitGroup // nodeTab/partTab updates are proxied by per-peer goroutine
-	notifyTab map[proto.NodeID]chan _ΔClusterState // registered in notifyTab XXX ^^^
+	// to all connected nodes. δnodeTab/δpartTab updates are proxied to
+	// a peer by per-peer goroutine reading from .notifyTab[peer.nid] channel.
+	notifyWG  sync.WaitGroup
+	notifyTab map[proto.NodeID]chan _ΔClusterState  // XXX naming -> δStateNotifyTab?
 
 	// last allocated oid & tid
 	// XXX how to start allocating oid from 0, not 1 ?
@@ -883,9 +890,6 @@ func storCtlService(ctx context.Context, stor *xneo.PeerNode) (err error) {
 	slink := stor.Link()
 	defer task.Runningf(&ctx, "%s: stor service", slink.RemoteAddr())(&err)
 
-	// XXX send nodeTab ? -> yes
-	// XXX send clusterInformation ?
-
 	// XXX current neo/py does StartOperation / NotifyReady as separate
 	//     sends, not exchange on the same conn. - fixed
 	ready := proto.NotifyReady{}
@@ -934,7 +938,7 @@ func (m *Master) serveClient(ctx context.Context, cli *xneo.PeerNode) (err error
 	defer xio.CloseWhenDone(ctx, clink)()	// XXX -> cli.ResetLink?
 
 	// FIXME send initial nodeTab and partTab before starting serveClient1
-	// (move those initial sends from keepPeerUpdated to here)
+	// (move those initial sends from keepPeerUpdated to .accept)
 
 	// M -> C notifications about cluster state
 	wg.Go(func() error {

go/neo/server.go

@@ -71,8 +71,6 @@ func Serve(ctx context.Context, l *neo.Listener, srv Server) error {
 // ----------------------------------------
 // XXX move -> master.go
 
-
-
 // reject sends rejective identification response and closes associated link
 func reject(ctx context.Context, req *neonet.Request, resp proto.Msg) {
 	err1 := req.Reply(resp)