1. 25 Sep, 2020 9 commits
  2. 24 Sep, 2020 2 commits
    • Kirill Smelkov's avatar
      X neotest: info-local: Fix NIC display for virtio devices · f2beeb95
      Kirill Smelkov authored
      For virtio NICs /sys/class/net/<NIC>/device lead to $pcidev/virtioX, not just $pcidev, e.g.:
      
      	$ realpath /sys/class/net/ens3/device
      	/sys/devices/pci0000:00/0000:00:03.0/virtio0
      
      and we were extracting virtio0 instead of 0000:00:03.0 as PCI device identifier.
      
      -> Fix it by recognizing and stripping /virtioX suffix.
      f2beeb95
    • Kirill Smelkov's avatar
      X neotest: info-local: Fix it when CPU frequence/idle information is not available · 4942c900
      Kirill Smelkov authored
      For example under KVM it was failing as
      
          cpu:	Intel(R) Xeon(R) CPU E5-2678 v3 @ 2.50GHz
          cat: /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq: No such file or directory
            File "<string>", line 1
              print '%.2fGHz' % ( / 1E6)
                                  ^
          SyntaxError: invalid syntax
      
          $ lscpu
          Architecture:        x86_64
          CPU op-mode(s):      32-bit, 64-bit
          Byte Order:          Little Endian
          Address sizes:       40 bits physical, 48 bits virtual
          CPU(s):              40
          On-line CPU(s) list: 0-39
          Thread(s) per core:  1
          Core(s) per socket:  1
          Socket(s):           40
          NUMA node(s):        1
          Vendor ID:           GenuineIntel
          CPU family:          6
          Model:               63
          Model name:          Intel(R) Xeon(R) CPU E5-2678 v3 @ 2.50GHz
          Stepping:            2
          CPU MHz:             2494.238
          BogoMIPS:            4988.47
          Virtualization:      VT-x
          Hypervisor vendor:   KVM
          Virtualization type: full
          L1d cache:           32K
          L1i cache:           32K
          L2 cache:            4096K
          L3 cache:            16384K
          NUMA node0 CPU(s):   0-39
          Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology cpuid tsc_known_freq pni pclmulqdq vmx ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt arat
      
      -> Fix it by checking whether cpufreq/cpuidle directories are available, and display "?" if they are not.
      4942c900
  3. 15 Sep, 2020 3 commits
  4. 03 Aug, 2020 4 commits
  5. 14 Jul, 2020 22 commits
    • Kirill Smelkov's avatar
      Merge branch 'master' into t · 242455f7
      Kirill Smelkov authored
      * master: (31 commits)
        go/zodb/zeo: Make "no serial on load after object deleted" to be a known bug
        go/zodb/zeo: Cosmetics
        go/zodb/zeo: Load: Fix thinko when rejecting result
        go/zodb/zeo: Add support for invalidations
        go/zodb/zeo: Teach zlink to serve incoming notification and requests
        go/zodb/zeo: MsgPack support
        go/zodb/zeo: Accept both int|bool for pickled message flags
        go/zodb/zeo: Factor-out tuple handling into encoding
        go/zodb/zeo: Factor-out string|bytes handling into encoding
        go/zodb/zeo: proto: Use enc.<X> and enc.as<X> to encode/decode type X
        go/zodb/zeo: Introduce notion of encoding
        go/zodb/zeo: Factor-out code to prepare pkt from message into pktEncode
        go/zodb/zeo: Start moving things related to protocol and messages encoding into proto.go
        go/zodb/zeo: Shutdown zlink on first error
        go/zodb/zeo: Use zlink as term for link in between peers
        go/zodb/zeo: Don't avoid defer
        go/zodb/zeo: errgroup -> xsync.WorkGroup
        go/zodb/zeo: Initial tests
        go/zodb/zeo: Fix thinko in openByURL error context
        go/internal/xtesting: LoadDBHistory
        ...
      242455f7
    • Kirill Smelkov's avatar
      go/zodb/zeo: Make "no serial on load after object deleted" to be a known bug · 049cb9a0
      Kirill Smelkov authored
      This turns zeo tests to pass.
      The bug is reported upstream here: https://github.com/zopefoundation/ZODB/issues/318
      049cb9a0
    • Kirill Smelkov's avatar
      go/zodb/zeo: Make "no serial on load after object deleted" to be a known bug · 90332630
      Kirill Smelkov authored
      This turns zeo tests to pass.
      The bug is reported upstream here: https://github.com/zopefoundation/ZODB/issues/318
      90332630
    • Kirill Smelkov's avatar
      . · ce37c318
      Kirill Smelkov authored
      ce37c318
    • Kirill Smelkov's avatar
      go/zodb/zeo: Cosmetics · d3bb1868
      Kirill Smelkov authored
      d3bb1868
    • Kirill Smelkov's avatar
      go/zodb/zeo: Load: Fix thinko when rejecting result · 149187b4
      Kirill Smelkov authored
      If xres fails to convert to tuple, we should error about xres, not res
      which is always tuple(nil).
      149187b4
    • Kirill Smelkov's avatar
      go/zodb/zeo: Add support for invalidations · d3a0bccb
      Kirill Smelkov authored
      Receive invalidation from server and send corresponding events to watchq.
      Care to send only events with tid > at0 that we initially returned when opening.
      
      Tests pass, but they need https://github.com/zopefoundation/ZEO/pull/160
      d3a0bccb
    • Kirill Smelkov's avatar
      go/zodb/zeo: Teach zlink to serve incoming notification and requests · 2aa27ef9
      Kirill Smelkov authored
      This will be used in the next patch to handle invalidateTransaction
      messages.
      2aa27ef9
    • Kirill Smelkov's avatar
      go/zodb/zeo: MsgPack support · 63d322b9
      Kirill Smelkov authored
      ZEO5 adds way for messages to be encoded via either pickles or MessagePack.
      However until now we were always using pickles.
      Let's add msgpack support to be able to e.g. use wire encoding that
      server prefers.
      
      MsgPack support is almost fully localized in encoding.
      We use tinylib/msgp runtime routines to decode/encode msg fields with known types,
      and shamaton/msgpack to decode/encode msg.arg, which is interface{},
      because msgp does not generally work for arbitrary reflections.
      
      For msgpack=true, tests state is the same as with pickles: handshake
      works, but load fails when verifying that Load returns correct error for
      deleted object:
      
          TestLoad/py/msgpack=false: xtesting.go:272: load 0285cbacc06d3a4c:0000000000000007: returned err unexpected:
              have: /tmp/zeo170183943/1.fs.zeosock: load 0285cbacc06d3a4c:0000000000000007: 0000000000000007: no such object
              want: /tmp/zeo170183943/1.fs.zeosock: load 0285cbacc06d3a4c:0000000000000007: 0000000000000007: object was deleted @0285cbacc06d3a4c
          TestLoad/py/msgpack=false: xtesting.go:272: load 0285cbad858bf2e6:0000000000000006: returned err unexpected:
              have: /tmp/zeo170183943/1.fs.zeosock: load 0285cbad858bf2e6:0000000000000006: 0000000000000006: no such object
              want: /tmp/zeo170183943/1.fs.zeosock: load 0285cbad858bf2e6:0000000000000006: 0000000000000006: object was deleted @0285cbad858bf2e6
          TestLoad/py/msgpack=false: xtesting.go:290: load 7fffffffffffffff:0000000000000007: returned err unexpected:
              have: /tmp/zeo170183943/1.fs.zeosock: load 7fffffffffffffff:0000000000000007: 0000000000000007: no such object
              want: /tmp/zeo170183943/1.fs.zeosock: load 7fffffffffffffff:0000000000000007: 0000000000000007: object was deleted @0285cbacc06d3a4c
          TestLoad/py/msgpack=false: xtesting.go:290: load 7fffffffffffffff:0000000000000006: returned err unexpected:
              have: /tmp/zeo170183943/1.fs.zeosock: load 7fffffffffffffff:0000000000000006: 0000000000000006: no such object
              want: /tmp/zeo170183943/1.fs.zeosock: load 7fffffffffffffff:0000000000000006: 0000000000000006: object was deleted @0285cbad858bf2e6
      
          TestLoad/py/msgpack=true: xtesting.go:272: load 0285cbacc06d3a4c:0000000000000007: returned err unexpected:
              have: /tmp/zeo247652538/1.fs.zeosock: load 0285cbacc06d3a4c:0000000000000007: 0000000000000007: no such object
              want: /tmp/zeo247652538/1.fs.zeosock: load 0285cbacc06d3a4c:0000000000000007: 0000000000000007: object was deleted @0285cbacc06d3a4c
          TestLoad/py/msgpack=true: xtesting.go:272: load 0285cbad858bf2e6:0000000000000006: returned err unexpected:
              have: /tmp/zeo247652538/1.fs.zeosock: load 0285cbad858bf2e6:0000000000000006: 0000000000000006: no such object
              want: /tmp/zeo247652538/1.fs.zeosock: load 0285cbad858bf2e6:0000000000000006: 0000000000000006: object was deleted @0285cbad858bf2e6
          TestLoad/py/msgpack=true: xtesting.go:290: load 7fffffffffffffff:0000000000000007: returned err unexpected:
              have: /tmp/zeo247652538/1.fs.zeosock: load 7fffffffffffffff:0000000000000007: 0000000000000007: no such object
              want: /tmp/zeo247652538/1.fs.zeosock: load 7fffffffffffffff:0000000000000007: 0000000000000007: object was deleted @0285cbacc06d3a4c
          TestLoad/py/msgpack=true: xtesting.go:290: load 7fffffffffffffff:0000000000000006: returned err unexpected:
              have: /tmp/zeo247652538/1.fs.zeosock: load 7fffffffffffffff:0000000000000006: 0000000000000006: no such object
              want: /tmp/zeo247652538/1.fs.zeosock: load 7fffffffffffffff:0000000000000006: 0000000000000006: object was deleted @0285cbad858bf2e6
      
      This is due to https://github.com/zopefoundation/ZODB/issues/318
      63d322b9
    • Kirill Smelkov's avatar
      go/zodb/zeo: Accept both int|bool for pickled message flags · f7543195
      Kirill Smelkov authored
      It is already documented in pktDecodeZ comment that flags is int|bool.
      However until now we were decoding it only as int.
      
      As is it was working, but it will fail when receiving e.g.
      invalidateTransaction message, because ZEO/py server actually uses bool
      when sending it:
      
          https://github.com/zopefoundation/ZEO/blob/5.2.1-20-gcb26281d/src/ZEO/asyncio/base.py#L139
      
      Fix it.
      This will be covered by watch tests, when watch support will be added in a followup patch.
      f7543195
    • Kirill Smelkov's avatar
      go/zodb/zeo: Factor-out tuple handling into encoding · fe24c62f
      Kirill Smelkov authored
      Handle pickled lists as valid input when decoding tuples.
      fe24c62f
    • Kirill Smelkov's avatar
    • Kirill Smelkov's avatar
      go/zodb/zeo: proto: Use enc.<X> and enc.as<X> to encode/decode type X · ffe0d6e9
      Kirill Smelkov authored
      This is more uniform and will be followed by all data types in the next patch.
      Here rename tid/oid pack/unpack routines correspondingly.
      Add docstrings for X=tid|oid.
      ffe0d6e9
    • Kirill Smelkov's avatar
      go/zodb/zeo: Introduce notion of encoding · 0696cd64
      Kirill Smelkov authored
      Keep information about which message encoding is used on the wire in
      encoding type. Make pktDecode/pktEncode and data type conversion
      utilities be methods of this type. For now there is only 'pickles'
      encoding, but we'll soon introduce 'msgpack'.
      
      Currently not everything related to pickles is localized in encoding -
      we'll be moving more bits to encoding in the followup patches.
      0696cd64
    • Kirill Smelkov's avatar
    • Kirill Smelkov's avatar
      go/zodb/zeo: Start moving things related to protocol and messages encoding into proto.go · 362e555a
      Kirill Smelkov authored
      First step:
      
      - move msg and msgFlags
      - move pktDecode
      - move functions to pack/unpack tid and oid
      
      more to come.
      362e555a
    • Kirill Smelkov's avatar
      go/zodb/zeo: Shutdown zlink on first error · e7ae218b
      Kirill Smelkov authored
      The same behaviour as ZEO/py does.
      e7ae218b
    • Kirill Smelkov's avatar
      go/zodb/zeo: Use zlink as term for link in between peers · b82154d5
      Kirill Smelkov authored
      Just renaming.
      b82154d5
    • Kirill Smelkov's avatar
      go/zodb/zeo: Don't avoid defer · 5a48e702
      Kirill Smelkov authored
      Starting from Go1.14 defer is no longer slow:
      https://golang.org/doc/go1.14#runtime
      5a48e702
    • Kirill Smelkov's avatar
      8889743e
    • Kirill Smelkov's avatar
      go/zodb/zeo: Initial tests · 589faf07
      Kirill Smelkov authored
      As promised in b65f6d0f (go/zodb: Teach ZODB/go to access ZEO (draft))
      let's start to add tests for ZEO/go client.
      
      The client is tested against ZEO/py server.
      Cover handshake and Load.
      
      Load currently fails beause in ZODB/py POSKeyError does not allow to
      distinguish whether it is no object at all or object exists and its data
      was not found for tid_before.
      
          --- FAIL: TestLoad/py (0.22s)
              zeo_test.go:217: load 0285cbacc06d3a4c:0000000000000007: returned err unexpected:
                  have: /tmp/zeo273044293/1.fs.zeosock: load 0285cbacc06d3a4c:0000000000000007: 0000000000000007: no such object
                  want: /tmp/zeo273044293/1.fs.zeosock: load 0285cbacc06d3a4c:0000000000000007: 0000000000000007: object was deleted @0285cbacc06d3a4c
              zeo_test.go:217: load 0285cbad858bf2e6:0000000000000006: returned err unexpected:
                  have: /tmp/zeo273044293/1.fs.zeosock: load 0285cbad858bf2e6:0000000000000006: 0000000000000006: no such object
                  want: /tmp/zeo273044293/1.fs.zeosock: load 0285cbad858bf2e6:0000000000000006: 0000000000000006: object was deleted @0285cbad858bf2e6
              zeo_test.go:217: load 7fffffffffffffff:0000000000000006: returned err unexpected:
                  have: /tmp/zeo273044293/1.fs.zeosock: load 7fffffffffffffff:0000000000000006: 0000000000000006: no such object
                  want: /tmp/zeo273044293/1.fs.zeosock: load 7fffffffffffffff:0000000000000006: 0000000000000006: object was deleted @0285cbad858bf2e6
              zeo_test.go:217: load 7fffffffffffffff:0000000000000007: returned err unexpected:
                  have: /tmp/zeo273044293/1.fs.zeosock: load 7fffffffffffffff:0000000000000007: 0000000000000007: no such object
                  want: /tmp/zeo273044293/1.fs.zeosock: load 7fffffffffffffff:0000000000000007: 0000000000000007: object was deleted @0285cbacc06d3a4c
      
      Problem reported upstream:
      
      -> https://github.com/zopefoundation/ZODB/issues/318
      589faf07
    • Kirill Smelkov's avatar
      go/zodb/zeo: Fix thinko in openByURL error context · 24c9f49f
      Kirill Smelkov authored
      No need to use trailing : suffix as xerr.Contextf automatically adds one.
      24c9f49f