.

wcfs/wcfs.go

@@ -2133,17 +2133,17 @@ func (root *Root) lookup(name string, fctx *fuse.Context) (_ *Head, err error) {
 	}
 
 	revDir = &Head{
-		// XXX how to test forgets:
+		// TODO how to test forgets:
 		// echo 2 >/proc/sys/vm/drop_caches	(root)
 		// mount -i -oremount $mntpt		(root ?)  (shrinks dcache)
 		// notify invalidate dentry from inside fs
-		fsNode: newFSNode(&fsOptions{Sticky: false}),	// XXX + Head.OnForget() -> del root.revTab[]
+		fsNode: newFSNode(&fsOptions{Sticky: false}), // TODO + Head.OnForget() -> del root.revTab[]
 		rev:    rev,
-		zconn:  zconnRev,	// XXX + Head.OnForget() -> release zconn (= abort zconn.TxnCtx)
+		zconn:  zconnRev, // TODO + Head.OnForget() -> release zconn (= abort zconn.TxnCtx)
 	}
 
 	bfdir := &BigFileDir{
-		fsNode:  newFSNode(&fsOptions{Sticky: false}),	// XXX + BigFileDir.OnForget()
+		fsNode:  newFSNode(&fsOptions{Sticky: false}),	// TODO + BigFileDir.OnForget()
 		head:    revDir,
 		fileTab: make(map[zodb.Oid]*BigFile),
 		δFtail:  nil, // δFtail not needed/used for @revX/
@@ -2209,7 +2209,7 @@ func (head *Head) bigfopen(ctx context.Context, oid zodb.Oid) (_ *BigFile, err e
 	}
 
 	f := &BigFile{
-		fsNode:    newFSNode(&fsOptions{Sticky: false}),	// XXX + BigFile.OnForget -> del .head.bfdir.fileTab[]
+		fsNode:    newFSNode(&fsOptions{Sticky: false}), // TODO + BigFile.OnForget -> del .head.bfdir.fileTab[]
 		head:      head,
 		zfile:     zfile,
 		blksize:   blksize,
@@ -2319,7 +2319,7 @@ func (zh *_wcfs_Zhead) Open(flags uint32, fctx *fuse.Context) (nodefs.File, fuse
 	groot.head.zheadMu.Lock()         // TODO +fctx -> cancel
 	defer groot.head.zheadMu.Unlock()
 
-	// XXX del zheadSockTab[sk] on sk.File.Release (= client drops opened handle)
+	// TODO del zheadSockTab[sk] on sk.File.Release (= client drops opened handle)
 	gdebug.zheadSockTab[sk] = struct{}{}
 	return sk.File(), fuse.OK
 }
@@ -2531,7 +2531,8 @@ func _main() (err error) {
 	}
 
 	// wait for unmount
-	// XXX the kernel does not send FORGETs on unmount - release left node resources ourselves?
+	// NOTE the kernel does not send FORGETs on unmount - but we don't need
+	// to release left node resources ourselves, because it is just memory.
 	<-serveCtx.Done()
 	log.Infof("stop %q %q", mntpt, zurl)
 	return nil