[erp5_core] Mass Workflow Transition does not fail with only one possible transition

bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_zuite/testMassWorkflowTransition.zpt

@@ -290,6 +290,52 @@
 <tr><td>select</td>
     <td>//select[@name="field_workflow_action"]</td>
     <td>value=invalidate_action</td></tr>
+
+<tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/submit_dialog" />
+<tal:block tal:define="notification_configuration python: {'class': 'error', 'text': 'Form updated.'}">
+  <tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/wait_for_notification" />
+</tal:block>
+
+<tr><td>waitForElementPresent</td>
+    <td>//textarea[@name="field_workflow_dialog_your_comment"]</td><td></td></tr>
+<tr><td>type</td>
+    <td>//textarea[@name="field_workflow_dialog_your_comment"]</td>
+    <td>Pain perdu</td></tr>
+<tr><td>pause</td><td>2000</td><td></td></tr>
+<tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/submit_dialog" />
+<tal:block tal:define="notification_configuration python: {'class': 'success', 'text': 'Workflow modification in progress.'}">
+  <tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/wait_for_notification" />
+</tal:block>
+
+<tr><td>open</td>
+    <td>${base_url}/Zuite_waitForActivities</td><td></td></tr>
+<tr><td>assertTextPresent</td>
+    <td>Done.</td><td></td></tr>
+
+<tr><td>open</td>
+    <td>${renderjs_url}/#/foo_module</td><td></td></tr>
+<tal:block tal:define="pagination_configuration python: {'header': '(1 - 3 / 6)', 'footer': 'Records 1 - 3 / 6'}">
+  <tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/check_listbox_pagination_text" />
+</tal:block>
+
+<tr><td>waitForElementPresent</td>
+    <td>//div[@data-gadget-scope="field_listbox"]//tbody/tr[1]/td[1]//a</td><td></td></tr>
+<tr><td>click</td>
+    <td>//div[@data-gadget-scope="field_listbox"]//tbody/tr[1]/td[1]//a</td><td></td></tr>
+
+<tr><td>waitForElementPresent</td>
+    <td>//div[@data-role="header"]//a[@data-i18n="Views"]</td><td></td></tr>
+<tr><td>click</td>
+    <td>//div[@data-role="header"]//a[@data-i18n="Views"]</td><td></td></tr>
+
+<tr><td>waitForElementPresent</td>
+    <td>//div[@role="main"]//ul[@data-role="listview"]//a[@data-i18n="History"]</td><td></td></tr>
+<tr><td>click</td>
+    <td>//div[@role="main"]//ul[@data-role="listview"]//a[@data-i18n="History"]</td><td></td></tr>
+<tr><td>waitForTextPresent</td>
+    <td>Pain perdu</td><td></td></tr>
+<tr><td>assertTextPresent</td>
+    <td>Pain perdu</td><td></td></tr>
 </tbody></table>
 </body>
 </html>
\ No newline at end of file

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Base_getFormIdForWorkflowAction.py

@@ -33,9 +33,5 @@ for result in result_list:
     if workflow_action == action['id']:
       return action_form_id  # early return for performance reasons
 
-if not workflow_action and len(id_form_dict) == 1:
-  # if we have only one possible workflow transition we suppose it is the default one
-  return id_form_dict.items()[0][1]
-
 # if we have no idea what workflow form we should use - just use ~~the default one~~ nothing
 return ""

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Folder_listWorkflow.py

@@ -40,9 +40,6 @@ for result in context.Base_searchUsingFormIdAndQuery(form_id, query, limit=50):
 if not transition_dict:
   workflow_list.append((translate("No state change possible"), ""))
 
-if len(transition_dict) == 1:
-  workflow_list = []  # if there is only one workflow possible - do not bother with an empty option
-
 # transition_dict.items() is in form (id, title) but ERP5 requires (title, id) so we reverse
 if transition_dict:
   workflow_list.extend((title, id) for id, title in sorted(transition_dict.items(), key=lambda x: x[1]))