1. 28 Apr, 2022 2 commits
  2. 27 Apr, 2022 2 commits
    • Vincent Pelletier's avatar
      Products.CMFActivity.ActivityTool: Store user object in activity. · f363ac65
      Vincent Pelletier authored
      When spawning an activity, store the current security context's user in
      the Message object itself, so the activity security context can be
      re-created with the same security during activity execution.
      This allows a user to be modified (different groups, global roles, maybe
      removed altogether) after they spawned activities and before these activities
      could run.
      It also means that any temporary custom group or global role granted to
      that user (by a privilege elevation mechanism out of the scope of this
      change) will still be effective during the activity execution.
      This follows the principle that
        foo.activate(...).bar(...)
      should be equivalent to its "immediate execution" version
        foo.bar(...)
      by ensuring that the security context of the activity is the same as the
      one which was applied to the code which spawned that activity,
      independently of any intermediate configuration change - hence improving
      (deferred and fragmentary) transaction isolation.
      
      This also removes the need to look the user up, then looking up their
      assignments (and other documents involved in group computation), etc,
      saving the cost of these calls.
      
      Also, remove redundant user_name argument of Message.changeUser method.
      f363ac65
    • Jérome Perrin's avatar
      *: remove remaining bits of old PDF preview · 428833f3
      Jérome Perrin authored
      The action was removed in 6dce55b0 (dms: drop PDF thumbnail view, 2021-06-01)
      but some CSS declarations were not removed.
      
      Also remove some old commented out javascript that was referencing the
      old PDF preview
      428833f3
  3. 26 Apr, 2022 5 commits
  4. 25 Apr, 2022 3 commits
  5. 22 Apr, 2022 7 commits
  6. 21 Apr, 2022 3 commits
  7. 18 Apr, 2022 1 commit
  8. 15 Apr, 2022 10 commits
  9. 14 Apr, 2022 6 commits
    • Romain Courteaud's avatar
    • Jérome Perrin's avatar
      full_text_myisam_catalog: skip coding style test · ab44309f
      Jérome Perrin authored
      This business template conflicts with full_text_mroonga_catalog, because
      it overrides same paths. Because this bt is generally not recommended
      and might even be removed, it's better not to complicate coding style test
      infrastructure to support this pattern.
      ab44309f
    • Jérome Perrin's avatar
      *: re-export components without the error_message workflow variable · f1a814e2
      Jérome Perrin authored
      follow up of 8a335cca (component: fix error_message saved in every line of history, 2022-02-18)
      f1a814e2
    • Jérome Perrin's avatar
      CodingStyle: verify that business template re-exporting is stable · 7fd94178
      Jérome Perrin authored
      re-exporting a business template that was just installed should not be
      different.
      
      By having a test reporting diffs in export, we can detect changes in ERP5 or
      dependencies which would cause the business template format to become different.
      The primary reason for doing this was to make sure that on the way to Zope4 we
      don't have changes in exported data, especially lossly changes that would not
      be detected in test suite, but this is also good because it helps detecting
      changes that cause a difference in output - then if we introduce a change that
      cause different business template export, we also have to make a change to
      re-export everything to new format, which helps keeping the git history cleaner
      because there's one big commit with all the changes instead of having many small
      commits. This is also good because it detects mistakes when modifying business
      templates files directly with a text editor.
      
      The test can be configured to ignore some paths, using fnmatch pattern (which
      unlike business patterns do not support ** for recursive match). This is also
      helpful when using this test case to check customer configuration business
      templates, where we may want to ignore some PathTemplateItem for conveniance.
      
      This also include fix for almost all current cases where re-exporting produce
      a diff, except a few cases that the reason for the diff was not understood, they
      were added to the ignore list instead.
      
      
      See merge request nexedi/erp5!1575
      7fd94178
    • Jérome Perrin's avatar
      Formulator,xhtml_style: render multi radio and checkboxs with a label · 4086f9a6
      Jérome Perrin authored
      This way, clicking on the label is enough to select the radio button,
      or tick the checkbox, no need to click on the small button.
      This is also probably better for accessibility.
      
      CSS is adjusted a bit, so that the style for "general" field labels
      do not apply to this new label.
      4086f9a6
    • Jérome Perrin's avatar
      *_ui_test: make Zelenium tests compatible with Zope4 ZMI · 87c30a04
      Jérome Perrin authored
      The status message no longer use system-msg class, use simpler
      "assertTextPresent" that should be enough.
      
      Simplify the waiting for static pages, clickAndWait is enough.
      87c30a04
  10. 12 Apr, 2022 1 commit