- 04 Dec, 2017 2 commits
- 01 Dec, 2017 6 commits
-
-
Sebastien Robin authored
-
Sebastien Robin authored
-
Sebastien Robin authored
-
Sebastien Robin authored
-
Sebastien Robin authored
-
Sebastien Robin authored
-
- 30 Nov, 2017 14 commits
-
-
Sebastien Robin authored
-
Ayush Tiwari authored
This contains changes for 2 points: 1. To improve view of ERP5 Catalog and its sub-objects . 2. Export Catalog Methods with no duplication between attributes and properties after migration. These changes are pointed out in comment here: nexedi/erp5!178 (comment 52224) /reviewed-on nexedi/erp5!510
-
Ayush Tiwari authored
-
Ayush Tiwari authored
BusinessTemplate: Look for string type in property map while extracting Properties for CatalogTemplateMethodItem
-
Ayush Tiwari authored
After migration of ERP5 Catalog and sub-objects, the filter attributes are now properties of Catalog Method(s). So, they are now already exported in xml file for the method. Thus, no need to duplicate export in _catalog_keys file. Also, installation should take care of the changes.
-
Ayush Tiwari authored
Also, add tests for them
-
Ayush Tiwari authored
[erp5_core]: No need to have export_properties action for ERP5 Catalog as we do cleanup of old manage_exportProperties function
-
Ayush Tiwari authored
-
Ayush Tiwari authored
-
Ayush Tiwari authored
According to guidelines, documents should have 'edit_workflow'. https://www.erp5.com/documentation/developer/guideline/programming/erp5-Guideline.Programming.Naming.Conventions#never-forget-edit-workflow-on-documents
-
Ayush Tiwari authored
This follows the guidelines and also make it feasible to go to listbox to search or make changes in sub-object list. Also, - Add 'More columns' in listbox for viewing Catalog Method list. - Add title field in listbox view for Catalog content and Catalog Filter List - Fixup links on these views which were not consistent.
-
Roque Porchetto authored
-
Sebastien Robin authored
-
Sebastien Robin authored
-
- 29 Nov, 2017 2 commits
-
-
Cédric Le Ninivin authored
-
Sebastien Robin authored
When accessing an ERP5 Site, we might have automatic migration of tools. When this happens, we might not have yet access to scripts like ERP5Type_asSecurityGroupId. There was already try/except, so just move slightly more code inside.
-
- 28 Nov, 2017 1 commit
-
-
Vincent Pelletier authored
-
- 27 Nov, 2017 2 commits
-
-
Tristan Cavelier authored
forgot to commit related template_document_id_list
-
Tomáš Peterka authored
/#/bug_module/20171103-82F24A /reviewed-on nexedi/erp5!489
-
- 24 Nov, 2017 3 commits
-
-
Ayush Tiwari authored
As pointed by /Jerome, it is only used for ZMI classes 557c20bd (comment 52113)
-
Ayush Tiwari authored
Catalog Tool has been added as a portal_action, so update in tests was needed: nexedi/erp5@ba2b3566
-
Vincent Bechu authored
/reviewed-on nexedi/erp5!505
-
- 23 Nov, 2017 4 commits
-
-
Ayush Tiwari authored
After ERP5-ification of catalog, its better to have Catalog Tool in action list for ERP5.
-
Cédric Le Ninivin authored
erp5_xhtml_style: Update ckeditor appcache
-
Vincent Pelletier authored
Also, drop whitespaces at end of line.
-
Tomáš Peterka authored
- Revert changes which led to lost of formatting. - Implement decimal precision for non-editable mode - Implement thousands separator - Add test for FloadField from original XHTML interface /reviewed-on nexedi/erp5!500
-
- 22 Nov, 2017 3 commits
-
-
Sebastien Robin authored
-
Łukasz Nowak authored
-
Sebastien Robin authored
Since last changes on Item_getTrackingList, we no longer have item_quantity, so the column "Quantity" was displaying nothing. So use quantity instead.
-
- 21 Nov, 2017 3 commits
-
-
Georgios Dagkakis authored
This reverts commit 45bb448f. Since it caused a regression in saving portal_components. To be re-thought and re-implemented
-
Georgios Dagkakis authored
This reverts commit f6e81b41. Since it caused a regression in saving portal_components. To be re-thought and re-implemented
-
Ayush Tiwari authored
Migrating current portal_catalog to erp5 object. # Major changes : - We have new classes for various objects based on base classes which we use for ERP5 objects. | Old class | New class | Parent Class | Portal Type | | ------------ | ------------- | ----------------- | ----------------| | CatalogTool | ERP5CatalogTool | BaseTool | Catalog Tool | | SQLCatalog | Catalog | ERP5Type.Folder | Catalog | | ZSQLMethod | SQLMethod | XMLObject | SQL method | - All the major attributes for these objects has been changed to properties. For these, we have some property_sheets added. - **Catalog** : Properties like sql_clear_catalog, sql_search_result_keys, etc - **CatalogTool** : Properties like default_erp5_catalog_id, archive_path, etc - **SQLMethod** : Properties like arguments, templates, etc - **CatalogFilter** : For CatalogMethod objects, we have added filter properties which earlier used to be an attribute of SQLCatalog saving object in PersistentMapping. # Installation : - **New ERP5 Instance** : For a new ERP5 instance, you get installed ERP5 Catalog Tool and ERP5 Catalog by default. Concerning sub-objects and python scripts, we have added an extra step in installation of `CatalogMethodTemplateItem` (mentioned in next section). This part is conversion of catalog methods to ERP5 objects. This adds little extra time to installation of BT5 containing catalog methods. - **Running ERP5 Instance**: We migrate the objects(`portal_catalog` as well as its sub objects) dynamically to the new portal_types, thanks to usage of `__of__` and `__bootstrap`. Concerning dynamic migration, it is handled via `synchronizeDynamicModule` function, which cover all steps in a transaction, hence any error in between rolls back the changes. # Migration Steps for running instance : 1. Rebase your erp5 repository on new code. 2. Restart `zope` process. 3. Wait for activities to finish. Thereafter you can check from `portal_catalog/manage_main` that we have catalog and sub-objects as ERP5 objects. But you still won't be able to see the `view` for those objects, so we move to next step of upgrading Business Templates. *It is normal to get error that catalog view is unaccessible*. You can check if you get this error both for `portal_catalog` as well as `erp5_mysql_innodb` also. 4. Restart `zope` process **again**. 5. Update `genbt5list`. 6. In template tool, upgrade business templates and upgrade `erp5_core` Business Templates. Wait for activities to finish(may take some time, 1-2 mins). After that, you are good to go and use ERP5 Catalog. **Changes in bt5 installation for CatalogMethodTemplateItem** - When we don't have default catalog installaed : *Use case: Installation of BT5 during ERP5 setup* In this case, while installation of `erp5_mysql_innodb_catalog`, we create the catalog and install all CatalogMethodTemplateItem there. Also, in the mean process, we convert the zsql methods and script(python) to erp5 objects. This process is only carried once, i.e at the installation of catalog. This is done in `ObjectTemplateItem.install` function - When we have `ERP5 Catalog` installed : *Use case: Installing BT5 containing ZSQL Method while we have ERP5 Catalog installed* We use `install` function for `Class CatalogMethodTemplateItem` in this case. Here, we check for `aq_parent` of the catalog method and if it is an 'ERP5 Catalog', we convert it to erp5 objects. # Performance : - Adding extra step in BT5 installation adds some extra time to performance. - Because, in every erp5 objects, object lookup is done via `_getOb` rather than `__getattr__`, so this adds a bit in improving performance. - Overall, we lose around 2~3% performance. # Problem pertaining/Limitations : - Need to restart erp5_site before upgrading BT5(s) - Current structure of migration uses `__of__` function to migrate catalog which in turn makes a call to generation of dynamic classes for catalog object. This is where it calls `_importClass` method, which ends up calling `setDefaultClassProperties` function on multiple layer of classes including `ERP5Site`. Thus, we end up having `isRADContent` for portal object which comes as a hindrance when we try to index objects in acquisition such as `portal_skins`, etc. # Extra points to be noted : - `Catalog` object shouldn't be indexable(because of the problem which may arise due to circular dependency). - Dynamic migration keeps all the old attributes for now, so as not to lose any user made change. # Concerning Links : - Documentation WebPage : https://www.erp5.com/erp5-Migrating.erp5.catalog - Test Suite : https://nexedi.erp5.net/test_suite_module/284 - Latest Test Result : https://nexedi.erp5.net/test_result_module/20171120-61F85D0C - Latest Performance Result : https://nexedi.erp5.net/test_result_module/20171120-2615A7B /reviewed-on nexedi/erp5!178
-