- 07 Mar, 2023 4 commits
-
-
Kazuhiko Shiozaki authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Duplicating the id is bad. Checking the meta_type is not perfect, but it is one step better.
-
Jérome Perrin authored
Updating pandas to 0.24.2 revealed as : File "develop-eggs/astroid-1.3.8+slapospatched001-py2.7.egg/astroid/raw_building.py", line 360, in _set_proxied return _CONST_PROXY[const.value.__class__] KeyError: <type 'numpy.ufunc'> when linting code referencing pandas. The problem is actually with some numpy `ufunc`, such as numpy.sin, but we don't seem to have code using it in the test suite.
-
- 06 Mar, 2023 4 commits
-
-
Gabriel Monnerat authored
Creating Stripe Payment Session and HTTP Exchange in the same transaction can raise conflict errors and when it happens, we already created the session on the Stripe side. With this, when this happens, we receive one useless webhook to inform that the session has expired. Also, batch_mode was removed because we only use it in tests. The tests were updated to use like in production. This change will probably avoid the issue below: ``` ------ 2023-03-01 13:03:33,503 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/stripe_payment_session_module/20230301-1B990F0, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/stripe_payment_session_module/20230301-1B990F0', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=... ------ 2023-03-01 13:03:33,516 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/system_event_module/20230301-9DDE8DD8, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/system_event_module/20230301-9DDE8DD8', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=... ------ 2023-03-01 13:03:33,549 INFO ZPublisher.Conflict ReadConflictError at ......_startStripePaymentSession: database read conflict error (oid 0x06be91ef, serial this txn started with 0x03eec0ca6bdaf611 2023-03-01 10:50:25.278590, serial currently committed 0x03eec0d78f096a55 2023-03-01 11:03:33.524245) (12 conflicts (0 unresolved) since startup at Tue Jan 17 03:21:57 2023) ------ 2023-03-01 13:03:35,057 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/stripe_payment_session_module/20230301-1E233DB, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/stripe_payment_session_module/20230301-1E233DB', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=... ------ 2023-03-01 13:03:35,066 INFO Tracking queuing message: activity=SQLDict, object_path=/erp5/system_event_module/20230301-5C3B7E3, method_id=immediateReindexObject, args=(), kw={}, activity_kw={'group_id': '', 'serialization_tag': '/erp5/system_event_module/20230301-5C3B7E3', 'alternate_method_id': 'alternateReindexObject', 'group_method_id': 'portal_catalog/catalogObjectList'}, user_name=... ``` See merge request nexedi/erp5!1747
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
erp5_core: remove Guard Role field in Worklist_view, as it should be defined in predicate listbox at the bottom.
-
Gabriel Monnerat authored
Creating Stripe Payment Session and HTTP Exchange in the same transaction can raise conflict errors and when it happens, we already created the session on the Stripe side. With this, when this happens, we receive one useless webhook to inform that the session has expired. Also, batch_mode was removed because we only use it in tests. The tests were updated to use like in production.
-
- 05 Mar, 2023 1 commit
-
-
Arnaud Fontaine authored
See slapos!1122 for SlapOS.
-
- 03 Mar, 2023 31 commits
-
-
Jérome Perrin authored
This listbox can be used to show documents that user is not allowed to access, so this `cell/getId` can raise. In Zope2 it was raising Unauthorized and this Unauthorized was catched, on Zope4 it is raising NotFound, which is no longer catch since 850e436e ( Products.ERP5Form.Form: Let NotFound exceptions propagate during rendering, 2022-11-25), so this NotFound was raised as a site error, which caused an error in the test.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Jérome Perrin authored
Only the most used forms are updated
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Jérome Perrin authored
This middleware is enabled in Zope's mkwsginstance [1] and also in test, [2], we should also enable it here for consistency. It is necessary to handle exceptions when no standard_error_message skin exists, like it is the case today in RJS skin selection. 1: https://github.com/zopefoundation/Zope/blob/828b1973e39f4dc1bf51fea0cd11a236d28ec3b5/src/Zope2/utilities/skel/etc/zope.ini.in#L16 2: https://github.com/zopefoundation/Zope/blob/828b1973e39f4dc1bf51fea0cd11a236d28ec3b5/src/Testing/ZopeTestCase/functional.py#L136
-
Jérome Perrin authored
It's not functionally different and this way it is more beautiful on Zope 4
-
Jérome Perrin authored
Update ZMI pages with the design of Products.ZMySQLDA and with the usage of manage_page_header, which sets the content-type to html
-
Jérome Perrin authored
Products.CMFCore.CachingPolicyManager.CPMCache became a new style class
-
Jérome Perrin authored
-
Kazuhiko Shiozaki authored
because __str__() returns id in Zope2 but returns login in Zope4.
-
Jérome Perrin authored
XMLExportImport encode strings in base64 when they can not safely be represented in XML (including for exemple "\n"), so we can not use this information to decide if this a BINBYTES or a BINSTRING pickle opcode. For now, it's still unclear how bytes and str should be handled, so while using python2 it's better to keep using str everywhere and not introduce zodbpickle.binary that looks like str on python2 but will become bytes on python3 and have consistent data everywhere (ie. everything str) BINBYTES is not fully removed from the patch, because we'll want to use it later, but it is in "if" that is always false.
-
Jérome Perrin authored
On Zope4 these settings are no longer in zope.conf
-
Jérome Perrin authored
We now target transaction 3 so this patch is not longer compatible and no longer needed according to discussions on the launchpad issue. _sort_key is also set to '1' on recent Products.ZSQLMethods
-
Arnaud Fontaine authored
For now, remove it completely. If necessary `registerHelp()` can be used. commit f3ab4409bfa9a3e1943099c8ae391a2f0273b53b Date: Sat Jul 2 18:26:53 2011 +0000 Removed the old help system, in favor of the current Sphinx documentation hosted at http://docs.zope.org/zope2/. For backwards compatibility the `registerHelp` and `registerHelpTitle` methods are still available on the ProductContext used during the `initialize` function.
-
Jérome Perrin authored
Unlike StringIO.StringIO().tell() and open().tell(), which all return int, io.BytesIO().tell() returns long. Because io.BytesIO is used when uploading files on Zope4, this cause PropertySheetValidity errors when checking consistency, because Data.size property is expected to be int.
-
Jérome Perrin authored
Checks that created document types match constraints
-
Jérome Perrin authored
-
Jérome Perrin authored
Previously, we were using an encoded string, which in practice worked, but with python3, WSGI server will encode as latin1 (because WSGI is latin1) and already with Zope4 on python2 we have issues with testing, as functional testing fake WSGI server only accepts ascii headers [1] 1: https://github.com/zopefoundation/Zope/blob/cddecf7e/src/Testing/ZopeTestCase/functional.py#L125-L126
-
Jérome Perrin authored
-
Jérome Perrin authored
No longer needed on Zope4, from commit dc5b9292f (Merge pull request 387 from zopefoundation/re-379-revert-repr, 2018-10-26)
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-