- 15 Apr, 2022 7 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Jérome Perrin authored
We were installing erp5_upgrader with its test dependencies, so it was installing erp5_full_text_mroonga_catalog. We were also installing erp5_full_text_myisam_catalog, so we ended up with two full text business template installed (and the order of this installation was not deterministic). This was problematic, because we were installing all the test dependencies of erp5_upgrader, but we don't really need them here and one goal of CodingStyleTest is to install only the dependencies of tested business templates, as a way to verify that dependencies are correctly specified. This new approach hooks at another level, to install a full text business template only if the tested business template has a dependency to the virutal "erp5_full_text_catalog" bt, but no dependency to a concrete bt (which happens for example in erp5_base) and to install erp5_upgrader without its test dependencies. As a result, we also run without erp5_base unless it's an explicit dependency. This also reverts commit ab44309f ( full_text_myisam_catalog: skip coding style test) that is no longer needed with this new approach.
-
Jérome Perrin authored
Some other documents from erp5_core import RoundingModel, all this can not be in erp5_base
-
Jérome Perrin authored
-
Jérome Perrin authored
These forms use proxy fields from erp5_base, they can not be in erp5_core.
-
Jérome Perrin authored
In case of snapshot test failure, we generated a form in a data:test/html link. This was working on chrome at the time, but it no longer work these days, probably because we switched to Same-Site cookie for authentication. Anyway, this also had the problem that it's not so convenient to use when updating the reference from the actual screenshot took from the test running on test node. These change this to generate a simple download link, and the workflow to update reference snapshot becomes to click this link to get the new image, upload it to development zope instance and re-export the business template.
-
- 14 Apr, 2022 6 commits
-
-
Romain Courteaud authored
-
Jérome Perrin authored
This business template conflicts with full_text_mroonga_catalog, because it overrides same paths. Because this bt is generally not recommended and might even be removed, it's better not to complicate coding style test infrastructure to support this pattern.
-
Jérome Perrin authored
follow up of 8a335cca (component: fix error_message saved in every line of history, 2022-02-18)
-
Jérome Perrin authored
re-exporting a business template that was just installed should not be different. By having a test reporting diffs in export, we can detect changes in ERP5 or dependencies which would cause the business template format to become different. The primary reason for doing this was to make sure that on the way to Zope4 we don't have changes in exported data, especially lossly changes that would not be detected in test suite, but this is also good because it helps detecting changes that cause a difference in output - then if we introduce a change that cause different business template export, we also have to make a change to re-export everything to new format, which helps keeping the git history cleaner because there's one big commit with all the changes instead of having many small commits. This is also good because it detects mistakes when modifying business templates files directly with a text editor. The test can be configured to ignore some paths, using fnmatch pattern (which unlike business patterns do not support ** for recursive match). This is also helpful when using this test case to check customer configuration business templates, where we may want to ignore some PathTemplateItem for conveniance. This also include fix for almost all current cases where re-exporting produce a diff, except a few cases that the reason for the diff was not understood, they were added to the ignore list instead. See merge request nexedi/erp5!1575
-
Jérome Perrin authored
This way, clicking on the label is enough to select the radio button, or tick the checkbox, no need to click on the small button. This is also probably better for accessibility. CSS is adjusted a bit, so that the style for "general" field labels do not apply to this new label.
-
Jérome Perrin authored
The status message no longer use system-msg class, use simpler "assertTextPresent" that should be enough. Simplify the waiting for static pages, clickAndWait is enough.
-
- 13 Apr, 2022 2 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
py2 urlparse module was removed.
-
- 12 Apr, 2022 2 commits
-
-
Romain Courteaud authored
Always recalculate the full matrixbox content if one change is found. Add mutex to prevent raise condition between render and getContent.
-
Arnaud Fontaine authored
-
- 11 Apr, 2022 1 commit
-
-
Kazuhiko Shiozaki authored
-
- 09 Apr, 2022 1 commit
-
-
Jérome Perrin authored
-
- 08 Apr, 2022 6 commits
-
-
Jérome Perrin authored
In case of ConflictError, request will be retied for HTTPRequest.retry_max_count times. For Zope 2, the default value of the class attribute was 3, but on Zope 4, default value is 0 and this is set to 3 on startup (by Zope2.Startup.handlers.root_wsgi_handler). This startup code is not executed by runUnitTest, we need to set HTTPRequest.retry_max_count somewhere, otherwise ConflictError are not retried during tests.
-
Jérome Perrin authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
See ed0c1297
-
Jérome Perrin authored
-
- 07 Apr, 2022 4 commits
-
-
Jérome Perrin authored
The status message no longer use system-msg class, use simpler "assertTextPresent" that should be enough. Simplify the waiting for static pages, clickAndWait is enough.
-
Jérome Perrin authored
I'll make a commit to handle all tests
-
Jérome Perrin authored
With the new workflow implementation, error_message variable is required, because we intentionally clone previous workflow history entries when passing transition, as this leads to smaller pickle size See merge request nexedi/erp5!1560
-
Romain Courteaud authored
Use the html_viewer gadget
-
- 06 Apr, 2022 10 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
This reverts commit 82595cd8.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
This supports both python2 and python3. For python3, this decode() properly arguments returned by string_literal() to have str(), otherwise the query string is an str() (DocumentTemplate) and the arguments are bytes(). In other places, bytes() is used directly but in this case this is not needed and would require monkey patching (at least) DocumentTemplate.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
- 05 Apr, 2022 1 commit
-
-
Arnaud Fontaine authored
-