Commit 86baacc6 authored by Han-Wen Nienhuys's avatar Han-Wen Nienhuys

nodefs: Return mount nodes only once for DefaultNode.

parent 447764e6
...@@ -114,6 +114,9 @@ func (n *defaultNode) OpenDir(context *fuse.Context) ([]fuse.DirEntry, fuse.Stat ...@@ -114,6 +114,9 @@ func (n *defaultNode) OpenDir(context *fuse.Context) ([]fuse.DirEntry, fuse.Stat
ch := n.Inode().Children() ch := n.Inode().Children()
s := make([]fuse.DirEntry, 0, len(ch)) s := make([]fuse.DirEntry, 0, len(ch))
for name, child := range ch { for name, child := range ch {
if child.mountPoint != nil {
continue
}
var a fuse.Attr var a fuse.Attr
code := child.Node().GetAttr(&a, nil, context) code := child.Node().GetAttr(&a, nil, context)
if code.Ok() { if code.Ok() {
......
...@@ -162,3 +162,47 @@ func TestDeletedUnmount(t *testing.T) { ...@@ -162,3 +162,47 @@ func TestDeletedUnmount(t *testing.T) {
t.Error("should succeed", code) t.Error("should succeed", code)
} }
} }
type defaultFS struct {
nodefs.FileSystem
root nodefs.Node
}
func (fs *defaultFS) Root() nodefs.Node {
return fs.root
}
func TestDefaultNodeMount(t *testing.T) {
fs := &defaultFS{
nodefs.NewDefaultFileSystem(),
nodefs.NewDefaultNode(),
}
dir, err := ioutil.TempDir("", "go-fuse")
if err != nil {
t.Fatalf("TempDir: %v", err)
}
defer os.RemoveAll(dir)
s, conn, err := nodefs.MountFileSystem(dir, fs, nil)
if err != nil {
t.Fatalf("MountFileSystem: %v", err)
}
go s.Serve()
defer s.Unmount()
sub := &defaultFS{
nodefs.NewDefaultFileSystem(),
nodefs.NewDefaultNode(),
}
if err := conn.Mount(fs.Root().Inode(), "sub", sub, nil); !err.Ok() {
t.Fatalf("Mount: %v", err)
}
if entries, err := ioutil.ReadDir(dir); err != nil {
t.Fatalf("ReadDir: %v", err)
} else if len(entries) != 1 {
t.Fatalf("got %d entries", len(entries))
} else if entries[0].Name() != "sub" {
t.Fatalf("got %q, want %q", entries[0].Name(), "sub")
}
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment