client: fix possible corruption in case of network failure with a storage

In case of storage disconnection, one packet (VoteTransaction) was not handled
the same way as other writes, and the failure was not reported to the master
so that it arbitrates the vote. The transaction was therefore partially
committed.

neo/client/app.py

@@ -562,7 +562,7 @@ class Application(ThreadedApplication):
         for uuid, status in involved_nodes.iteritems():
             if status == 1 and uuid not in trans_nodes:
                 self._askStorageForWrite(txn_context, uuid, packet)
-        self.waitResponses(txn_context.queue)
+        self.waitStoreResponses(txn_context)
         # If there are failed nodes, ask the master whether they can be
         # disconnected while keeping the cluster operational. If possible,
         # this will happen during tpc_finish.

neo/tests/threaded/test.py

@@ -1652,6 +1652,32 @@ class Test(NEOThreadedTest):
                 self.tic()
                 self.assertPartitionTable(cluster, pt)
 
+    @with_cluster(partitions=2, storage_count=2)
+    def testMasterArbitratingVoteAfterFailedVoteTransaction(self, cluster):
+        """
+        Check that the master node arbitrates the vote when a failure happens
+        at the end of the first phase (VoteTransaction).
+        """
+        t, c = cluster.getTransaction()
+        tid = cluster.client.last_tid
+        r = c.root()
+        r[0] = ''
+        delayed = []
+        with cluster.moduloTID(1), ConnectionFilter() as f:
+            @f.delayAskVoteTransaction
+            def _(conn):
+                delayed.append(None)
+                s, = (s for s in cluster.storage_list if conn.uuid == s.uuid)
+                conn, = s.getConnectionList(cluster.client)
+                conn.em.wakeup(conn.close)
+                return False
+            self.assertRaises(NEOStorageError, t.commit)
+        self.tic()
+        self.assertEqual(len(delayed), 1)
+        self.assertEqual(tid, cluster.client.last_tid)
+        self.assertEqual(cluster.neoctl.getClusterState(),
+                         ClusterStates.RUNNING)
+
     @with_cluster()
     def testAbortTransaction(self, cluster):
         t, c = cluster.getTransaction()