- 30 Nov, 2015 6 commits
-
-
Julien Muchembled authored
NEO did not ensure that all data and metadata are written on disk before tpc_finish, and it was for example vulnerable to ENOSPC errors. In other words, some work had to be moved to tpc_vote: - In tpc_vote, all involved storage nodes are now asked to write all metadata to ttrans/tobj and _commit_. Because the final tid is not known yet, the tid column of ttrans and tobj now contains NULL and the ttid respectively. - In tpc_finish, AskLockInformation is still required for read locking, ttrans.tid is updated with the final value and this change is _committed_. - The verification phase is greatly simplified, more reliable and faster. For all voted transactions, we can know if a tpc_finish was started by getting the final tid from the ttid, either from ttrans or from trans. And we know that such transactions can't be partial so we don't need to check oids. So in addition to minimizing the risk of failures during tpc_finish, we also fix a bug causing the verification phase to discard transactions with objects for which readCurrent was called. On performance side: - Although tpc_vote now asks all involved storages, instead of only those storing the transaction metadata, the client has been improved to do this in parallel. The additional commits are also all done in parallel. - A possible improvement to compensate the additional commits is to delay the commit done by the unlock. - By minimizing the time to lock transactions, objects are read-locked for a much shorter period. This is even more important that locked transactions must be unlocked in the same order. Transactions with too many modified objects will now timeout inside tpc_vote instead of tpc_finish. Of course, such transactions may still cause other transaction to timeout in tpc_finish.
-
Julien Muchembled authored
-
Julien Muchembled authored
This fixes a regression in commit 83fe64bf when ttrans has several rows to the same data_id.
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
- Server connections can now be in 'connecting' state. - connectionAccepted event (which has never been used so far) is merged into connectionCompleted.
-
- 25 Nov, 2015 13 commits
-
-
Julien Muchembled authored
This is a workaround to fix holes if replication is interrupted after new data is committed.
-
Julien Muchembled authored
-
Julien Muchembled authored
AssertionError are certainly more severe that any other exception (including OperationFailure) because the process is in an unknown state.
-
Julien Muchembled authored
This could have been useful in testStorageFailureDuringTpcFinish: close() could not be called from answerTransactionFinished because it deadlocked while trying to send notifications.
-
Julien Muchembled authored
The test was relying on fact on the fact that 'c.abort()' caused an assertion failure, which closed the connection and then raised OperationFailure. Actually, I wanted to close the connection on master, but it's clearer this way.
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
Previous code relied on the fact that the exception target is kept past the end of the except clause. 2to3 is not smart enough to detect that. Without this change, a different OperationalError exception would be ignored because there's already a local variable of the same name.
-
Julien Muchembled authored
This was forgotten when this table was introduced in commit f9a8500d
-
Julien Muchembled authored
If needed, sortStorageList can be extended in the future to support a 'readable' parameter.
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
We can never receive several answers from the same node. testVerification is dropped for the same reason as for testEvent and most of testConnection, since there is much incoming changes for verification.
-
- 03 Nov, 2015 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
- Last known TID was not updated when recovering a transaction. - Missing OIDs were ignored, which caused partial transactions to be committed instead of being deleted.
-
- 29 Oct, 2015 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
- 26 Oct, 2015 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
The previous SQL query caused a full table scan of the 'trans' table at startup.
-
- 21 Oct, 2015 3 commits
-
-
Julien Muchembled authored
I used git-diff for each file and concatenated the result to preverse the order.
-
Julien Muchembled authored
-
Julien Muchembled authored
This fixes invalid next_serial entries in cache, and the following error for values not in cache: Traceback (most recent call last): File "ZODB/Connection.py", line 856, in setstate self._setstate(obj) File "ZODB/Connection.py", line 894, in _setstate self._load_before_or_conflict(obj) File "ZODB/Connection.py", line 922, in _load_before_or_conflict if not self._setstate_noncurrent(obj): File "ZODB/Connection.py", line 945, in _setstate_noncurrent assert end is not None AssertionError
-
- 20 Oct, 2015 1 commit
-
-
Julien Muchembled authored
-
- 19 Oct, 2015 4 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
When run with MySQL, testBasicStore (neo.tests.threaded.test.Test) was slow and generated log exceeded 29MB.
-
Julien Muchembled authored
-
- 16 Oct, 2015 1 commit
-
-
Julien Muchembled authored
This increases the number of rows to check per AskCheck*Range packets.
-
- 13 Oct, 2015 1 commit
-
-
Julien Muchembled authored
And document 3 bugs found by running many times testBackupNodeLost. About the tic() issue, I had a case where the test exited instead of looping forever after the storage crash.
-
- 12 Oct, 2015 1 commit
-
-
Julien Muchembled authored
-
- 05 Oct, 2015 3 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
-
- 02 Oct, 2015 1 commit
-
-
Julien Muchembled authored
-