Merge branch 'eslint-update-no-param-reassign' into 'master'

Update eslintrc no-param-reassign to allow props reassignment

See merge request gitlab-org/gitlab-ce!21393

.eslintrc.yml

@@ -33,6 +33,15 @@ rules:
     - error
     - max: 1
   promise/catch-or-return: error
+  no-param-reassign:
+    - error
+    - props: true
+      ignorePropertyModificationsFor:
+        - "acc"         # for reduce accumulators
+        - "accumulator" # for reduce accumulators
+        - "el"          # for DOM elements
+        - "element"     # for DOM elements
+        - "state"       # for Vuex mutations
   no-underscore-dangle:
     - error
     - allow:

app/assets/javascripts/diffs/store/mutations.js

@@ -107,7 +107,6 @@ export default {
   },
 
   [types.EXPAND_ALL_FILES](state) {
-    // eslint-disable-next-line no-param-reassign
     state.diffFiles = state.diffFiles.map(file => ({
       ...file,
       collapsed: false,

app/assets/javascripts/fly_out_nav.js

@@ -65,8 +65,8 @@ export const hideMenu = (el) => {
 
   const parentEl = el.parentNode;
 
-  el.style.display = ''; // eslint-disable-line no-param-reassign
-  el.style.transform = ''; // eslint-disable-line no-param-reassign
+  el.style.display = '';
+  el.style.transform = '';
   el.classList.remove(IS_ABOVE_CLASS);
   parentEl.classList.remove(IS_OVER_CLASS);
   parentEl.classList.remove(IS_SHOWING_FLY_OUT_CLASS);

app/assets/javascripts/ide/stores/modules/branches/mutations.js

-/* eslint-disable no-param-reassign */
 import * as types from './mutation_types';
 
 export default {

app/assets/javascripts/ide/stores/modules/file_templates/mutations.js

-/* eslint-disable no-param-reassign */
 import * as types from './mutation_types';
 
 export default {

app/assets/javascripts/ide/stores/modules/merge_requests/mutations.js

-/* eslint-disable no-param-reassign */
 import * as types from './mutation_types';
 
 export default {

app/assets/javascripts/ide/stores/modules/pipelines/mutations.js

-/* eslint-disable no-param-reassign */
 import * as types from './mutation_types';
 import { normalizeJob } from './utils';
 

app/assets/javascripts/ide/stores/mutations.js

-/* eslint-disable no-param-reassign */
 import * as types from './mutation_types';
 import projectMutations from './mutations/project';
 import mergeRequestMutation from './mutations/merge_request';

app/assets/javascripts/ide/stores/mutations/file.js

-/* eslint-disable no-param-reassign */
 import * as types from '../mutation_types';
 import { sortTree } from '../utils';
 import { diffModes } from '../../constants';

app/assets/javascripts/jobs/store/mutations.js

-/* eslint-disable no-param-reassign */
-
 import * as types from './mutation_types';
 
 export default {

app/assets/javascripts/pipelines/components/pipelines_table_row.vue

@@ -132,10 +132,8 @@ export default {
       if (this.pipeline.ref) {
         return Object.keys(this.pipeline.ref).reduce((accumulator, prop) => {
           if (prop === 'path') {
-            // eslint-disable-next-line no-param-reassign
             accumulator.ref_url = this.pipeline.ref[prop];
           } else {
-            // eslint-disable-next-line no-param-reassign
             accumulator[prop] = this.pipeline.ref[prop];
           }
           return accumulator;

app/assets/javascripts/reports/store/mutations.js

-/* eslint-disable no-param-reassign */
 import * as types from './mutation_types';
 
 export default {

app/assets/javascripts/vue_shared/vue_resource_interceptor.js

@@ -28,7 +28,7 @@ Vue.http.interceptors.push((request, next) => {
     response.headers.forEach((value, key) => {
       headers[key] = value;
     });
-
+    // eslint-disable-next-line no-param-reassign
     response.headers = headers;
   });
 });

spec/javascripts/helpers/vue_resource_helper.js

@@ -5,6 +5,7 @@ export const headersInterceptor = (request, next) => {
     response.headers.forEach((value, key) => {
       headers[key] = value;
     });
+    // eslint-disable-next-line no-param-reassign
     response.headers = headers;
   });
 };