avoid #respond_to? in Cache.id_for

45e9d287 · http://jneen.net/ · e515aa54 · 45e9d287
Commit 45e9d287 authored Jul 17, 2017 by http://jneen.net/
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 5 deletions

lib/declarative_policy/cache.rb lib/declarative_policy/cache.rb +8 -5

No files found.
--- a/lib/declarative_policy/cache.rb
+++ b/lib/declarative_policy/cache.rb
@@ -21,11 +21,14 @@ module DeclarativePolicy
      private

      def id_for(obj)
-        if obj.respond_to?(:id) && obj.id
-          obj.id.to_s
-        else
-          "##{obj.object_id}"
-        end
+        id =
+          begin
+            obj.id
+          rescue NoMethodError
+            nil
+          end
+
+        id || "##{obj.object_id}"
      end
    end
  end