Transforming milestones link references to the short reference form

lib/banzai/filter/milestone_reference_filter.rb

@@ -11,6 +11,11 @@ module Banzai
       end
 
       def references_in(text, pattern = Milestone.reference_pattern)
+        # We'll handle here the references that follow the `reference_pattern`.
+        # Other patterns (for example, the link pattern) are handled by the
+        # default implementation.
+        return super(text, pattern) if pattern != Milestone.reference_pattern
+
         text.gsub(pattern) do |match|
           project = project_from_ref($~[:project])
           params = milestone_params($~[:milestone_iid].to_i, $~[:milestone_name])

spec/fixtures/markdown.md.erb

@@ -222,6 +222,7 @@ References should be parseable even inside _<%= merge_request.to_reference %>_ e
 - Milestone in another project: <%= xmilestone.to_reference(project) %>
 - Ignored in code: `<%= simple_milestone.to_reference %>`
 - Ignored in links: [Link to <%= simple_milestone.to_reference %>](#milestone-link)
+- Milestone by URL: <%= urls.namespace_project_milestone_url(milestone.project.namespace, milestone.project, milestone) %>
 - Link to milestone by URL: [Milestone](<%= milestone.to_reference %>)
 
 ### Task Lists

spec/support/matchers/markdown_matchers.rb

@@ -154,7 +154,7 @@ module MarkdownMatchers
     set_default_markdown_messages
 
     match do |actual|
-      expect(actual).to have_selector('a.gfm.gfm-milestone', count: 5)
+      expect(actual).to have_selector('a.gfm.gfm-milestone', count: 6)
     end
   end