Commit a9470c45 authored by Phil Hughes's avatar Phil Hughes

fixed karma failures

[ci skip]
parent b2c27518
...@@ -25,7 +25,7 @@ describe('Title component', () => { ...@@ -25,7 +25,7 @@ describe('Title component', () => {
it('renders title HTML', () => { it('renders title HTML', () => {
expect( expect(
vm.$el.querySelector('h2').innerHTML.trim(), vm.$el.innerHTML.trim(),
).toBe('Testing <img>'); ).toBe('Testing <img>');
}); });
...@@ -47,12 +47,12 @@ describe('Title component', () => { ...@@ -47,12 +47,12 @@ describe('Title component', () => {
Vue.nextTick(() => { Vue.nextTick(() => {
expect( expect(
vm.$el.querySelector('h2').classList.contains('issue-realtime-pre-pulse'), vm.$el.classList.contains('issue-realtime-pre-pulse'),
).toBeTruthy(); ).toBeTruthy();
setTimeout(() => { setTimeout(() => {
expect( expect(
vm.$el.querySelector('h2').classList.contains('issue-realtime-trigger-pulse'), vm.$el.classList.contains('issue-realtime-trigger-pulse'),
).toBeTruthy(); ).toBeTruthy();
done(); done();
......
...@@ -4,7 +4,7 @@ import actionComponent from '~/pipelines/components/graph/action_component.vue'; ...@@ -4,7 +4,7 @@ import actionComponent from '~/pipelines/components/graph/action_component.vue';
describe('pipeline graph action component', () => { describe('pipeline graph action component', () => {
let component; let component;
beforeEach(() => { beforeEach((done) => {
const ActionComponent = Vue.extend(actionComponent); const ActionComponent = Vue.extend(actionComponent);
component = new ActionComponent({ component = new ActionComponent({
propsData: { propsData: {
...@@ -14,6 +14,8 @@ describe('pipeline graph action component', () => { ...@@ -14,6 +14,8 @@ describe('pipeline graph action component', () => {
actionIcon: 'icon_action_cancel', actionIcon: 'icon_action_cancel',
}, },
}).$mount(); }).$mount();
Vue.nextTick(done);
}); });
it('should render a link', () => { it('should render a link', () => {
...@@ -27,7 +29,7 @@ describe('pipeline graph action component', () => { ...@@ -27,7 +29,7 @@ describe('pipeline graph action component', () => {
it('should update bootstrap tooltip when title changes', (done) => { it('should update bootstrap tooltip when title changes', (done) => {
component.tooltipText = 'changed'; component.tooltipText = 'changed';
Vue.nextTick(() => { setTimeout(() => {
expect(component.$el.getAttribute('data-original-title')).toBe('changed'); expect(component.$el.getAttribute('data-original-title')).toBe('changed');
done(); done();
}); });
......
...@@ -4,7 +4,7 @@ import dropdownActionComponent from '~/pipelines/components/graph/dropdown_actio ...@@ -4,7 +4,7 @@ import dropdownActionComponent from '~/pipelines/components/graph/dropdown_actio
describe('action component', () => { describe('action component', () => {
let component; let component;
beforeEach(() => { beforeEach((done) => {
const DropdownActionComponent = Vue.extend(dropdownActionComponent); const DropdownActionComponent = Vue.extend(dropdownActionComponent);
component = new DropdownActionComponent({ component = new DropdownActionComponent({
propsData: { propsData: {
...@@ -14,6 +14,8 @@ describe('action component', () => { ...@@ -14,6 +14,8 @@ describe('action component', () => {
actionIcon: 'icon_action_cancel', actionIcon: 'icon_action_cancel',
}, },
}).$mount(); }).$mount();
Vue.nextTick(done);
}); });
it('should render a link', () => { it('should render a link', () => {
......
...@@ -27,26 +27,30 @@ describe('pipeline graph job component', () => { ...@@ -27,26 +27,30 @@ describe('pipeline graph job component', () => {
}); });
describe('name with link', () => { describe('name with link', () => {
it('should render the job name and status with a link', () => { it('should render the job name and status with a link', (done) => {
const component = new JobComponent({ const component = new JobComponent({
propsData: { propsData: {
job: mockJob, job: mockJob,
}, },
}).$mount(); }).$mount();
const link = component.$el.querySelector('a'); Vue.nextTick(() => {
const link = component.$el.querySelector('a');
expect(link.getAttribute('href')).toEqual(mockJob.status.details_path); expect(link.getAttribute('href')).toEqual(mockJob.status.details_path);
expect( expect(
link.getAttribute('data-original-title'), link.getAttribute('data-original-title'),
).toEqual(`${mockJob.name} - ${mockJob.status.label}`); ).toEqual(`${mockJob.name} - ${mockJob.status.label}`);
expect(component.$el.querySelector('.js-status-icon-success')).toBeDefined(); expect(component.$el.querySelector('.js-status-icon-success')).toBeDefined();
expect( expect(
component.$el.querySelector('.ci-status-text').textContent.trim(), component.$el.querySelector('.ci-status-text').textContent.trim(),
).toEqual(mockJob.name); ).toEqual(mockJob.name);
done();
});
}); });
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment