Merge branch 'frozen-string-spec-some' into 'master'

Add some frozen string to spec/**/*.rb

See merge request gitlab-org/gitlab-ce!27341

changelogs/unreleased/frozen-string-spec-some.yml

+---
+title: Add some frozen string to spec/**/*.rb
+merge_request:
+author: gfyoung
+type: other

spec/bin/changelog_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 load File.expand_path('../../bin/changelog', __dir__)

spec/config/mail_room_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'mail_room.yml' do

spec/config/object_store_settings_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 require Rails.root.join('config', 'object_store_settings.rb')
 

spec/config/settings_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Settings do

spec/controllers/abuse_reports_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AbuseReportsController do

spec/controllers/admin/application_settings_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::ApplicationSettingsController do

spec/controllers/admin/applications_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::ApplicationsController do

spec/controllers/admin/dashboard_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::DashboardController do

spec/controllers/admin/gitaly_servers_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::GitalyServersController do

spec/controllers/admin/groups_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::GroupsController do

spec/controllers/admin/health_check_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::HealthCheckController do

spec/controllers/admin/hooks_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::HooksController do

spec/controllers/admin/identities_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::IdentitiesController do

spec/controllers/admin/impersonations_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::ImpersonationsController do

spec/controllers/admin/projects_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::ProjectsController do

spec/controllers/admin/runners_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::RunnersController do

spec/controllers/admin/services_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::ServicesController do

spec/controllers/admin/spam_logs_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::SpamLogsController do

spec/controllers/admin/users_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Admin::UsersController do

spec/controllers/application_controller_spec.rb

 # coding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe ApplicationController do

spec/controllers/autocomplete_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe AutocompleteController do

spec/controllers/boards/issues_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Boards::IssuesController do

spec/controllers/boards/lists_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Boards::ListsController do

spec/controllers/concerns/checks_collaboration_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ChecksCollaboration do

spec/controllers/concerns/continue_params_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ContinueParams do

spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ControllerWithCrossProjectAccessCheck do

spec/controllers/concerns/group_tree_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe GroupTree do

spec/controllers/concerns/internal_redirect_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe InternalRedirect do

spec/controllers/concerns/issuable_collections_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe IssuableCollections do

spec/controllers/concerns/lfs_request_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LfsRequest do

spec/controllers/concerns/project_unauthorized_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ProjectUnauthorized do

spec/controllers/concerns/send_file_upload_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe SendFileUpload do

spec/controllers/dashboard/groups_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dashboard::GroupsController do

spec/controllers/dashboard/labels_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dashboard::LabelsController do

spec/controllers/dashboard/milestones_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dashboard::MilestonesController do

spec/controllers/dashboard/projects_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dashboard::ProjectsController do

spec/controllers/dashboard/todos_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dashboard::TodosController do

spec/controllers/dashboard_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe DashboardController do

spec/controllers/explore/groups_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Explore::GroupsController do

spec/controllers/explore/projects_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Explore::ProjectsController do

spec/controllers/google_api/authorizations_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe GoogleApi::AuthorizationsController do

spec/controllers/groups/avatars_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::AvatarsController do

spec/controllers/groups/boards_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::BoardsController do

spec/controllers/groups/children_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::ChildrenController do

spec/controllers/groups/group_members_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::GroupMembersController do

spec/controllers/groups/labels_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::LabelsController do

spec/controllers/groups/milestones_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::MilestonesController do

spec/controllers/groups/runners_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::RunnersController do

spec/controllers/groups/settings/ci_cd_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::Settings::CiCdController do

spec/controllers/groups/shared_projects_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::SharedProjectsController do

spec/controllers/groups/uploads_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::UploadsController do

spec/controllers/groups/variables_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Groups::VariablesController do

spec/controllers/groups_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe GroupsController do

spec/controllers/health_check_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HealthCheckController do

spec/controllers/health_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HealthController do

spec/controllers/help_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HelpController do

spec/controllers/import/bitbucket_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::BitbucketController do

spec/controllers/import/bitbucket_server_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::BitbucketServerController do

spec/controllers/import/fogbugz_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::FogbugzController do

spec/controllers/import/gitea_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::GiteaController do

spec/controllers/import/github_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::GithubController do

spec/controllers/import/gitlab_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::GitlabController do

spec/controllers/import/gitlab_projects_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::GitlabProjectsController do

spec/controllers/import/google_code_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Import::GoogleCodeController do

spec/controllers/invites_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe InvitesController do

spec/controllers/ldap/omniauth_callbacks_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Ldap::OmniauthCallbacksController do
@@ -43,7 +45,7 @@ describe Ldap::OmniauthCallbacksController do
   end
 
   context 'sign up' do
-    let(:user) { double(email: 'new@example.com') }
+    let(:user) { double(email: +'new@example.com') }
 
     before do
       stub_omniauth_setting(block_auto_created_users: false)

spec/controllers/metrics_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe MetricsController do

spec/controllers/notification_settings_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe NotificationSettingsController do

spec/controllers/oauth/applications_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Oauth::ApplicationsController do

spec/controllers/oauth/authorizations_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Oauth::AuthorizationsController do

spec/controllers/omniauth_callbacks_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe OmniauthCallbacksController, type: :controller do
@@ -7,7 +9,7 @@ describe OmniauthCallbacksController, type: :controller do
     let(:user) { create(:omniauth_user, extern_uid: extern_uid, provider: provider) }
 
     before do
-      mock_auth_hash(provider.to_s, extern_uid, user.email)
+      mock_auth_hash(provider.to_s, +extern_uid, user.email)
       stub_omniauth_provider(provider, context: request)
     end
 
@@ -141,7 +143,7 @@ describe OmniauthCallbacksController, type: :controller do
         end
 
         shared_context 'sign_up' do
-          let(:user) { double(email: 'new@example.com') }
+          let(:user) { double(email: +'new@example.com') }
 
           before do
             stub_omniauth_setting(block_auto_created_users: false)
@@ -220,7 +222,7 @@ describe OmniauthCallbacksController, type: :controller do
     before do
       stub_omniauth_saml_config({ enabled: true, auto_link_saml_user: true, allow_single_sign_on: ['saml'],
                                   providers: [saml_config] })
-      mock_auth_hash_with_saml_xml('saml', 'my-uid', user.email, mock_saml_response)
+      mock_auth_hash_with_saml_xml('saml', +'my-uid', user.email, mock_saml_response)
       request.env["devise.mapping"] = Devise.mappings[:user]
       request.env['omniauth.auth'] = Rails.application.env_config['omniauth.auth']
       post :saml, params: { SAMLResponse: mock_saml_response }

spec/controllers/passwords_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe PasswordsController do

spec/controllers/profiles/accounts_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::AccountsController do

spec/controllers/profiles/avatars_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::AvatarsController do

spec/controllers/profiles/emails_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::EmailsController do

spec/controllers/profiles/keys_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::KeysController do

spec/controllers/profiles/notifications_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::NotificationsController do

spec/controllers/profiles/personal_access_tokens_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::PersonalAccessTokensController do

spec/controllers/profiles/preferences_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::PreferencesController do

spec/controllers/profiles/two_factor_auths_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Profiles::TwoFactorAuthsController do

spec/controllers/profiles_controller_spec.rb

+# frozen_string_literal: true
+
 require('spec_helper')
 
 describe ProfilesController, :request_store do

spec/controllers/projects/artifacts_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::ArtifactsController do

spec/controllers/projects/avatars_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::AvatarsController do

spec/controllers/projects/badges_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::BadgesController do

spec/controllers/projects/blame_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::BlameController do

spec/controllers/projects/blob_controller_spec.rb

+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Projects::BlobController do

spec/controllers/projects/boards_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::BoardsController do

spec/controllers/projects/branches_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::BranchesController do

spec/controllers/projects/ci/lints_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::Ci::LintsController do

spec/controllers/projects/commit_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::CommitController do

spec/controllers/projects/commits_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::CommitsController do

spec/controllers/projects/compare_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::CompareController do

spec/controllers/projects/cycle_analytics_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::CycleAnalyticsController do

spec/controllers/projects/deploy_keys_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::DeployKeysController do

spec/controllers/projects/deployments_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::DeploymentsController do

spec/controllers/projects/discussions_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::DiscussionsController do

spec/controllers/projects/environments_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::EnvironmentsController do

spec/controllers/projects/find_file_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::FindFileController do

spec/controllers/projects/forks_controller_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Projects::ForksController do