Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
ff378e19
Commit
ff378e19
authored
Oct 05, 2016
by
Linus G Thiel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Respond with 404 Not Found for non-existent tags
Non-existent tags should be handled with 404 Not Found.
parent
6b967138
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
3 deletions
+2
-3
CHANGELOG
CHANGELOG
+1
-2
app/controllers/projects/tags_controller.rb
app/controllers/projects/tags_controller.rb
+1
-1
No files found.
CHANGELOG
View file @
ff378e19
Please view this file on the master branch, on stable branches it's out of date.
Please view this file on the master branch, on stable branches it's out of date.
v 8.13.0 (unreleased)
v 8.13.0 (unreleased)
- Respond with 404 Not Found for non-existent tags (Linus Thiel)
- Update runner version only when updating contacted_at
- Update runner version only when updating contacted_at
- Add link from system note to compare with previous version
- Add link from system note to compare with previous version
- Use gitlab-shell v3.6.2 (GIT TRACE logging)
- Use gitlab-shell v3.6.2 (GIT TRACE logging)
...
@@ -90,8 +91,6 @@ v 8.12.1
...
@@ -90,8 +91,6 @@ v 8.12.1
- Fix issue with search filter labels not displaying
- Fix issue with search filter labels not displaying
v 8.12.0
v 8.12.0
v 8.12.0 (unreleased)
- Respond with 404 Not Found for non-existent tags
- Update the rouge gem to 2.0.6, which adds highlighting support for JSX, Prometheus, and others. !6251
- Update the rouge gem to 2.0.6, which adds highlighting support for JSX, Prometheus, and others. !6251
- Only check :can_resolve permission if the note is resolvable
- Only check :can_resolve permission if the note is resolvable
- Bump fog-aws to v0.11.0 to support ap-south-1 region
- Bump fog-aws to v0.11.0 to support ap-south-1 region
...
...
app/controllers/projects/tags_controller.rb
View file @
ff378e19
...
@@ -20,7 +20,7 @@ class Projects::TagsController < Projects::ApplicationController
...
@@ -20,7 +20,7 @@ class Projects::TagsController < Projects::ApplicationController
def
show
def
show
@tag
=
@repository
.
find_tag
(
params
[
:id
])
@tag
=
@repository
.
find_tag
(
params
[
:id
])
return
render_404
if
@tag
.
nil?
return
render_404
unless
@tag
@release
=
@project
.
releases
.
find_or_initialize_by
(
tag:
@tag
.
name
)
@release
=
@project
.
releases
.
find_or_initialize_by
(
tag:
@tag
.
name
)
@commit
=
@repository
.
commit
(
@tag
.
target
)
@commit
=
@repository
.
commit
(
@tag
.
target
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment