An error occurred fetching the project authors.
- 26 May, 2017 1 commit
-
-
Valery Sizov authored
-
- 24 May, 2017 5 commits
-
-
Douwe Maan authored
This reverts commit b0498c17
-
Alexis Reigel authored
we do this on attribute read since migrating all existing users is not a feasible solution.
-
Alexis Reigel authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- 19 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 18 May, 2017 2 commits
-
-
Douwe Maan authored
-
Michael Kozono authored
Older namespace records may be both `type == ‘Group` AND `owner_id` is not null.
-
- 17 May, 2017 2 commits
-
-
Yorick Peterse authored
This hides/disables some UI elements and API parameters related to nested groups when MySQL is used, since nested groups are not supported for MySQL.
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 15 May, 2017 1 commit
-
-
Valery Sizov authored
-
- 12 May, 2017 1 commit
-
-
Valery Sizov authored
-
- 10 May, 2017 1 commit
-
-
blackst0ne authored
-
- 08 May, 2017 3 commits
-
-
Toon Claes authored
Not assigning the trackable fields seems to cause strange side-effects.
-
Toon Claes authored
Every time a user logs in or out, the Trackable attributes are written to the database. This is causing a lot of load on the database, for data that isn't really critical. So to avoid the database being hammered, add a Gitlab::ExclusiveLease before writing trackable attributes to the database. This lease expires after an hour, so only when the attributes were written more than an hour ago, they can be written again. Otherwise they are ignored.
-
Stan Hu authored
On databases such as MySQL, it's possible to get into a timing comparison error if the value of `Confirmable#confirmation_sent_at` is within a second of `0.days.ago`. This is possible mostly in specs that test this behavior and most likely not happening in practice. The result of this error causes a user to be deemed active when it should be inactive. To prevent this error, we explicitly check the configuration setting to be `0.days.ago`. Closes gitlab-org/gitlab-ee#2362
-
- 05 May, 2017 3 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
-
- 04 May, 2017 2 commits
-
-
Valery Sizov authored
-
Valery Sizov authored
-
- 03 May, 2017 1 commit
-
-
Ruben Davila authored
-
- 01 May, 2017 1 commit
-
-
Bob Van Landuyt authored
This reflects better that it validates paths instead of a namespace model
-
- 26 Apr, 2017 1 commit
-
-
Douwe Maan authored
-
- 20 Apr, 2017 1 commit
-
-
Valery Sizov authored
-
- 19 Apr, 2017 1 commit
-
-
James Lopez authored
-
- 18 Apr, 2017 1 commit
-
-
Valery Sizov authored
-
- 14 Apr, 2017 5 commits
-
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
CE port of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/962
-
James Lopez authored
Refactored specs and added a post deployment migration to remove the activity users table.
-
James Lopez authored
It uses a user activity table instead of a column in users. Tested with mySQL and postgreSQL
-
- 11 Apr, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 10 Apr, 2017 1 commit
-
-
Robert Speicher authored
-
- 09 Apr, 2017 1 commit
-
-
blackst0ne authored
-
- 06 Apr, 2017 4 commits
-
-
Timothy Andrew authored
1. Have `MigrateToGhostUser` be a service rather than a mixed-in module, to keep things explicit. Specs testing the behavior of this class are moved into a separate service spec file. 2. Add a `user.reported_abuse_reports` association to make the `migrate_abuse_reports` method more consistent with the other `migrate_` methods.
-
Timothy Andrew authored
Introduction ------------ 1. The foreign key was not explicitly specified on the association. 2. The `AbuseReport` model contains two references to user - `reporter_id` and `user_id` 3. `user.abuse_report` is supposed to return the single abuse report where `user_id` refers to the given user. Bug Description --------------- 1. `user.abuse_report` would return an abuse report where `reporter_id` referred to the current user, if such an abuse report was present. 2. This implies a slightly more serious bug as well: - Assume User A filed an abuse report against User B - We have an abuse report where `reporter_id` is User A and `user_id` is User B - If User A is updated (`user_a.block`, for example), the abuse report would also be updated, such that both `reporter_id` _and_ `user_id` point to User A. Fix --- Explicitly declare the foreign key `user_id` in the `has_one` declaration
-
Alexis Reigel authored
-
Alexis Reigel authored
-