* upstream/master:
  Just don't expand if it's already expanded
  fix bug in webpack_helper in which force_same_domain argument was ignored breaking local rspec tests
  Fix rubocop offenses introduced in !16623
  Prefer local variables over given/let
  Try to restore page's state
  Add more views check
  Respect the latest changes from master
  Add a scenario for adding secret variables

Add a scenario for adding secret variables

See merge request gitlab-org/gitlab-ce!16607

* upstream/master:
  fix bug in webpack_helper in which force_same_domain argument was ignored breaking local rspec tests
  Fix rubocop offenses introduced in !16623
  fix documentation about node version
  Ensure the  job also run for tags
  Open links in a new tab on the user page
  Improve empty project overview
  Look for rugged with static analysis
  Cache rubocop cache for CI
  Update gitlab-styles and re-enable the RSpec/SingleLineHook cop again
  Make Gitlab::Git::Repository#run_git private
  Move user page spinach tests to RSpec
  Handle special characters on API request of issuable templates
  Update secret_values to support dynamic elements within parent
  Disable throwOnError in KaTeX to reveal user where is the problem
  Migrate restoring repo from bundle to Gitaly

Fix local RSpec tests due to bug in `webpack_bundle_tag`

Closes #42368

See merge request gitlab-org/gitlab-ce!16724

fix bug in webpack_helper in which force_same_domain argument was ignored breaking local rspec tests

Fix rubocop offenses introduced in !16623

See merge request gitlab-org/gitlab-ce!16722

fix documentation about node version

Closes #41438

See merge request gitlab-org/gitlab-ce!16720

Resolves #41438

Migrate restoring repo from bundle to Gitaly

Closes gitaly#946

See merge request gitlab-org/gitlab-ce!16623

Resolve "`only: - tags` is not taken in account in the `cache gems` job"

Closes #34952

See merge request gitlab-org/gitlab-ce!16721

Move user page spinach tests to RSpec

See merge request gitlab-org/gitlab-ce!16598

Cache rubocop cache for CI

Closes #42338

See merge request gitlab-org/gitlab-ce!16700

Disable throwOnError in KaTeX to reveal user where is the problem

See merge request gitlab-org/gitlab-ce!16684

Signed-off-by: Rémy Coutable <remy@rymai.me>

Add a lint check to restrict use of Rugged

See merge request gitlab-org/gitlab-ce!16656

Handling special characters in Issuable Templates

Closes #40028

See merge request gitlab-org/gitlab-ce!15323

Make Gitlab::Git::Repository#run_git private

See merge request gitlab-org/gitlab-ce!16622

Improve empty project overview

See merge request gitlab-org/gitlab-ce!16617

Update secret_values to support dynamic elements within parent

See merge request gitlab-org/gitlab-ce!16665

Resolve "Re-enable the `RSpec/SingleLineHook` cop"

Closes #42385

See merge request gitlab-org/gitlab-ce!16704

Open links in a new tab on the user page

See merge request gitlab-org/gitlab-ce!16705

* upstream/master:
  Make Gitaly RepositoryExists opt-out
  Fix .batch_lfs_pointers accepting a lazy enumerator
  Look at notes created just before merge when deciding if an MR can be reverted
  Update missing paths
  Default to HTTPS for all Gravatar URLs
  Add note within ux documentation that further changes should be made within the design.gitlab project
  Moves status icon into a vue file and adds tests Moves merging component into a vue file, adds i18n and better test cases
  Prefer local variables instead
  Add an test for QA::Runtime::RSAKey
  Move initialize method later.
  Also test if the fingerprint is correct
  Generate ssh key on the fly for QA

Fix .batch_lfs_pointers accepting a lazy enumerator

See merge request gitlab-org/gitlab-ce!16701

- Add section headers to project repo buttons
- Add primary button to content to add file when the repository is empty
- Change project removal primary button from project overview to secondary button
- Update headings for better alignment
- Add primary button for readme only user preference

Make Gitaly RepositoryExists opt-out

See merge request gitlab-org/gitlab-ce!16680

Look at system notes created just before merge as well as after, when deciding if an MR can be reverted

Closes #42377

See merge request gitlab-org/gitlab-ce!16678

Basically using the new expand_section

Add note within ux documentation that further changes should be made within the…

See merge request gitlab-org/gitlab-ce!16686

Default to HTTPS for all Gravatar URLs

See merge request gitlab-org/gitlab-ce!16666

Generate ssh key on the fly for QA

See merge request gitlab-org/gitlab-ce!16562