An error occurred fetching the project authors.
  1. 06 Dec, 2018 2 commits
  2. 22 Nov, 2018 1 commit
  3. 25 Oct, 2018 1 commit
    • Andrew Newdigate's avatar
      Add experimental support for Puma · 1065f8ce
      Andrew Newdigate authored
      This allows us (and others) to test drive Puma without it affecting all
      users. Puma can be enabled by setting the environment variable
      "EXPERIMENTAL_PUMA" to a non empty value.
      1065f8ce
  4. 03 Oct, 2018 1 commit
  5. 24 Sep, 2018 1 commit
  6. 31 Aug, 2018 1 commit
    • Stan Hu's avatar
      Disable the Sidekiq Admin Rack session · 4442972b
      Stan Hu authored
      GitLab already has its own session store, so this extra Sidekiq session is
      unnecessary.  In addition, the GitLab session store properly sets the Secure
      flag, unlike the default Rack session.
      
      CSRF protection in the Sidekiq /admin page continues to work with the existing
      GitLab session.
      
      See https://github.com/mperham/sidekiq/pull/3183 for more details.
      
      Part of #49120
      4442972b
  7. 30 Jul, 2018 1 commit
  8. 04 Apr, 2018 1 commit
  9. 26 Feb, 2018 1 commit
  10. 12 Dec, 2017 1 commit
  11. 05 Dec, 2017 1 commit
  12. 11 Jul, 2017 1 commit
  13. 28 Jun, 2017 1 commit
  14. 17 Mar, 2017 1 commit
    • Yorick Peterse's avatar
      Added Gitlab::Database.config · 9a20ff1c
      Yorick Peterse authored
      This returns the ActiveRecord configuration for the current environment.
      
      While CE doesn't use this very often, EE will use it in a few places for
      the database load balancing code. I'm adding this to CE so we don't end
      up with merge conflicts in this file.
      9a20ff1c
  15. 07 Mar, 2017 1 commit
  16. 06 Feb, 2017 1 commit
    • Yorick Peterse's avatar
      Don't use backup AR connections for Sidekiq · f116f87c
      Yorick Peterse authored
      Adding two extra connections does nothing other than increasing the
      number of idle database connections. Given Sidekiq uses N threads it can
      never use more than N AR connections at a time, thus we don't need more.
      
      The initializer mentioned the Sidekiq upgrade guide stating this was
      required.  This is false, the Sidekiq upgrade guide states this is
      necessary for Redis and not ActiveRecord.
      
      On GitLab.com this resulted in a reduction of about 80-100 PostgreSQL
      connections.
      
      Fixes #27713
      f116f87c
  17. 25 Jan, 2017 1 commit
    • Yorick Peterse's avatar
      Fix race conditions for AuthorizedProjectsWorker · 88e627cf
      Yorick Peterse authored
      There were two cases that could be problematic:
      
      1. Because sometimes AuthorizedProjectsWorker would be scheduled in a
         transaction it was possible for a job to run/complete before a
         COMMIT; resulting in it either producing an error, or producing no
         new data.
      
      2. When scheduling jobs the code would not wait until completion. This
         could lead to a user creating a project and then immediately trying
         to push to it. Usually this will work fine, but given enough load it
         might take a few seconds before a user has access.
      
      The first one is problematic, the second one is mostly just annoying
      (but annoying enough to warrant a solution).
      
      This commit changes two things to deal with this:
      
      1. Sidekiq scheduling now takes places after a COMMIT, this is ensured
         by scheduling using Rails' after_commit hook instead of doing so in
         an arbitrary method.
      
      2. When scheduling jobs the calling thread now waits for all jobs to
         complete.
      
      Solution 2 requires tracking of job completions. Sidekiq provides a way
      to find a job by its ID, but this involves scanning over the entire
      queue; something that is very in-efficient for large queues. As such a
      more efficient solution is necessary. There are two main Gems that can
      do this in a more efficient manner:
      
      * sidekiq-status
      * sidekiq_status
      
      No, this is not a joke. Both Gems do a similar thing (but slightly
      different), and the only difference in their name is a dash vs an
      underscore. Both Gems however provide far more than just checking if a
      job has been completed, and both have their problems. sidekiq-status
      does not appear to be actively maintained, with the last release being
      in 2015. It also has some issues during testing as API calls are not
      stubbed in any way. sidekiq_status on the other hand does not appear to
      be very popular, and introduces a similar amount of code.
      
      Because of this I opted to write a simple home grown solution. After
      all, all we need is storing a job ID somewhere so we can efficiently
      look it up; we don't need extra web UIs (as provided by sidekiq-status)
      or complex APIs to update progress, etc.
      
      This is where Gitlab::SidekiqStatus comes in handy. This namespace
      contains some code used for tracking, removing, and looking up job IDs;
      all without having to scan over an entire queue. Data is removed
      explicitly, but also expires automatically just in case.
      
      Using this API we can now schedule jobs in a fork-join like manner: we
      schedule the jobs in Sidekiq, process them in parallel, then wait for
      completion. By using Sidekiq we can leverage all the benefits such as
      being able to scale across multiple cores and hosts, retrying failed
      jobs, etc.
      
      The one downside is that we need to make sure we can deal with
      unexpected increases in job processing timings. To deal with this the
      class Gitlab::JobWaiter (used for waiting for jobs to complete) will
      only wait a number of seconds (30 by default). Once this timeout is
      reached it will simply return.
      
      For GitLab.com almost all AuthorizedProjectWorker jobs complete in
      seconds, only very rarely do we spike to job timings of around a minute.
      These in turn seem to be the result of external factors (e.g. deploys),
      in which case a user is most likely not able to use the system anyway.
      
      In short, this new solution should ensure that jobs are processed
      properly and that in almost all cases a user has access to their
      resources whenever they need to have access.
      88e627cf
  18. 16 Dec, 2016 1 commit
  19. 01 Dec, 2016 1 commit
  20. 10 Nov, 2016 3 commits
  21. 04 Nov, 2016 1 commit
    • Drew Blessing's avatar
      Set default Sidekiq retries to 3 · d498ec98
      Drew Blessing authored
      By default, Sidekiq will retry 25 times with an exponential backoff.
      This may result in jobs retrying for up to 21 days. Most Sidekiq
      failures occur when attempting to connect to external services -
      Project service hooks, web hooks, mailers, mirror updates, etc.
      We should set a default retry of 3, and if that's not sufficient
      individual workers can override this in the worker class.
      d498ec98
  22. 01 Nov, 2016 1 commit
    • Stan Hu's avatar
      Initialize Sidekiq with the list of queues used by GitLab · cde3963d
      Stan Hu authored
      The Sidekiq client API adds an entry to the Sidekiq "queues" list,
      but mail_room and gitlab-shell use redis-rb directly to insert jobs
      into Redis and thus do not make an extra "sadd" call to Redis
      each time a job is inserted. To make it possible to monitor
      these queues via the API, add an initialization step to
      set up the list at startup.
      
      Closes gitlab-com/infrastructure#682
      cde3963d
  23. 04 Aug, 2016 1 commit
  24. 26 Jul, 2016 2 commits
  25. 20 Jul, 2016 1 commit
  26. 18 Jul, 2016 1 commit
  27. 29 Jun, 2016 1 commit
  28. 20 Jun, 2016 1 commit
  29. 13 Apr, 2016 1 commit
  30. 04 Apr, 2016 1 commit
  31. 09 Mar, 2016 1 commit
  32. 22 Dec, 2015 1 commit
  33. 14 Dec, 2015 1 commit
  34. 10 Dec, 2015 1 commit
  35. 04 Dec, 2015 1 commit
  36. 26 Aug, 2015 1 commit