This is an empty modules whose names are dynamically inserted by
AccessControl.Implementation.

These constructors are not recognized by pylint and now we have
no-name-in-module errors.

Because since introduction of portal types as classes there was this
idea of deprecating those in favor of using newContent(temp_object=True,
switch to this new syntax.

Since we still have to create documents in portal_trash, only change the
minimal to get coding style tests passing again.

/reviewed-on nexedi/erp5!1024

for Person_viewAssignment form

For example, ExtensionClass (such as ValidationFailed) need to have their AST properly
generated. This fixes 'Use of super on an old style class (super-on-old-class)' error.

Besides of being needed for bootstrap, this also makes more sense than ignoring
completely ERP5Type as some modules should not be in there and should be migrated.

ZODB Components: Preparation of erp5_base migration from FS: LoginAccountProviderMixin implements ILoginAccountProvider (otherwise unused).

this is not passed correctly in submission script anyway, so selection
is not taken into account in this case

Especially important as the deleted document has an hard-coded ID which gets reused - as is the case here.

It may not be a good idea to hardcode such ids in tests too, but I cannot judge at a glance.

/cc @romain

/reviewed-on nexedi/erp5!1020

Assorted fixes for minor issues with ZODB History tab:

1. When viewing history of a website or websection in the "backoffice" interface, clicking on *View ZODB History* does not keep the `ignore_layout:int=1` request parameter that forces displaying the forms in the *View* skin selection.
2. Fix using ZODB history for documents with binary properties, such as `data` property on images and files. Instead of failing with unicode error, just display "(binary)". 
3. Put the link field in center group, forms with only fields in left group and nothing in right group have a border only on the left side. ( this is  https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#listbox-only-tabs-should-have-a-read-only-title-in-center-group )

see before:
![before__1_](/uploads/eaafe271228e960f58b7b928cb517ac9/before__1_.png)

and after:
![Screenshot_2017-11-28_at_19.32.09](/uploads/bdd0adcc80b138dca7ddcb45b2ff184a/Screenshot_2017-11-28_at_19.32.09.png)



/reviewed-on nexedi/erp5!512

This is enabled for title and description only, because that's usually
what we put on "external" documents such as invoices.

By "resource" here it means products, services, components and their
individual variations

In short, change the translation configuration from 
![Screenshot_2017-12-05_at_10.22.39](/uploads/2c72a0b35dbbde1ec6d7156f2e2f372a/Screenshot_2017-12-05_at_10.22.39.png)

to 

![Screenshot_2017-12-05_at_10.23.31](/uploads/d86c2fce6a9d134e17b5fddc983491a3/Screenshot_2017-12-05_at_10.23.31.png)


/reviewed-on nexedi/erp5!515

Fix broken tests after !1011 it was merged too fast.

/reviewed-on nexedi/erp5!1018

Some users have been using google chrome builtin translation system with
ERP5 back office (xhtml style), but the way google translation changes
the DOM sometimes break ERP5 interface.
This also have data privacy issue as this translation is done on google
servers.

https://www.w3.org/International/questions/qa-translate-flag recommends
using translate=no but the approach of the meta tag might be preferable
for our case as it prevents sending the page content to translation
service.

/reviewed-on nexedi/erp5!879

The field needs to be in center group to comply with
https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#listbox-only-tabs-should-have-a-read-only-title-in-center-group

It was failing decoding unicode

Otherwise we cannot use this feature on a website/websection using
a different skin selection.

3d3ee5da had syntax error and test were
not updated for new behavior

content_type is a bit special, because CMF's PortalFolderBase also have
a content_type method, so this was confusing ERP5Type dynamic properties
system. When the property was never set, the default value was the
method acquired from PortalFolderBase.

Fixes this by defining conten_type class attribute where needed.

This also fixes an old expected failure test, it's now possible to use
edit(content_type=something) in document without content type property
set. It works now, but thanks to what seems to be outdated code in
_valid_property_id from product/ERP5Type/patches/PropertyManager.py,
because we have stopped setting all properties to None in Base years
ago. For now, this works, but because of an outdated condition in
_valid_property_id. We may revisit later in the future.

Safe activities are:
- those which are not visible outside current transaction (IOW, queued
  in activity buffer)
- those which are already marked as failed, as no activity node will try
  to process these
Other activities may already be running.
Note: deleting even failed activities may violate activity dependencies
(other activities may be waiting on the ones being deleted, even those
not spawned yet), but if this is an issue then some other code should
take care of these as well.
Also, rework a CMFActivity test checking that activties already-spawned on
a later-deleted context get discarded instead of being executed: previous
implementation was working around the activity deletion removed in this commit.
Also, test indexation/unindexation parallelism.

uids are a way one can signal that different objects (from a ZODB point of
view, and hence an oid point of view) are actually to be considered as the
same objet (from a higher abstration point of view). For example, another
variant of the same object, as imported over an older variant.
In turn, this allows extending the protection to activities spawned from
brains, and not just from live objects.

To save a bit of time every day (and save us from typos)

As now ERP5 is mainly used though the web interface, the use of the save action is nowadays very limited

ZODB Components: Preparation of erp5_base migration from FS: Fix pylint undefined-variable errors: Remove dead code.

keywordsplitter() has never been defined so this code has been broken
since its introduction.

ZODB Components: Preparation of erp5_base migration from FS: Fix pylint undefined-variable errors: get_transaction() removed in ZODB 3.6.

ZODB Components: Preparation of erp5_base migration from FS: Fix pylint undefined-variable errors: ResourceLockedError.

We receive feedback from users saying that "when I view a mail message in event module, I see ugly html source", this was because user had set preferred text editor to monaco. Improve a bit monaco integration so that we display something better than code in a `<pre>`  for non editable editors.

We had another feedback that when using CKEditor as preferred text editor in old UI, users can not click on links when viewing an html Mail Message. But it works in new UI. I did something minimal so that this looks working until the migration to new UI is complete.

/reviewed-on nexedi/erp5!1011

With the current architecture of cache manifest, it was required that
developpers change the cache manifests referencing a web page every time
they change a web page. In practice, developers were never doing this,
so we sometimes had issues where client keep using old version of
website even though a new version has been deployed, when after
deployment we did not change the cache manifest.

To automate the scenario of modifying the cache manifest, introduce a
post-upgrade constraint that will check that the manifest is newer than
all of the referenced pages. If that's the case, the constraint can fix
by modifying the manifest content, which also changes the modification
date of the manifest, which might be used in "if-modified-since"
negociations.

According to spec [1], cache manifest is updated if the HTTP responses
is not "304 not modified" and if the manifest content is not
byte-for-byte identical to the previously cached version.

[1] https://www.w3.org/TR/2008/WD-html5-20080122/#updating1

/reviewed-on nexedi/erp5!1009

Post upgrader constraint to automatically fix modification date and an upgrader bug-fix for an issue that's revealed in this new test.

/reviewed-on nexedi/erp5!1013

This tests had a test instance URL hardcoded and was working only on
this instance.

The default size of iframe is too small for CKEditor to display dialogs
properly. Increase the height so that CKEditor display dialog boxes
correctly.

/reviewed-on nexedi/erp5!1010