- 21 Jun, 2022 1 commit
-
-
Jérome Perrin authored
and several small fixes or changes to make this easier See merge request !1642
-
- 20 Jun, 2022 2 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
This was a workaround for ChromeOS, but we realized it was not really good. Disable it for the same reasons as slapos!1196 : - not everybody use ChromeOS - this breaks the ctrl+click shortcut to go to definition/follow link - it makes ERP5 monaco editor behaves differently from others monaco editor - ChromeOS users can use chrome://flags/#use-search-click-for-right-click
-
- 15 Jun, 2022 10 commits
-
-
Levin Zimmermann authored
When cleaning up Wendelin from restricted python pandas code (see https://lab.nexedi.com/levin.zimmermann/wendelin/tree/remove-redundant-pandas), it turned out that there was one line still missing in erp5. This missing line caused a failed test in wendelin functional tests: https://erp5js.nexedi.net/#/test_result_module/20220614-1B46817BD/6 Readding the line fixed the test.
-
Jérome Perrin authored
create_server returns either a BaseWSGIServer or a MultiSocketServer, but add_task only exists in BaseWSGIServer - and the implementation is simply [1]: def add_task(self, task): self.task_dispatcher.add_task(task) by using self.task_dispatcher.add_task directly, we are compatible with both cases. This is relevant when running timerserver with runUnitTest, where we create multiple sockets, one for http and one for web-dav. 1: https://github.com/Pylons/waitress/blob/v1.4.4/src/waitress/server.py#L290-L291
-
Jérome Perrin authored
The default TestCase.__call__ collects errors in a test result that was never retrieved, so errors were silently ignored. By using TestCase.debug , we let errors propagate. --- Minimal reproduction is running directly (ie. not with python -m unittest) a script like this: import unittest class T(unittest.TestCase): def method(self): print('ah ?') boom print('oh') t = T("method") t() # no error t.debug() # NameError: name 'boom' is not defined
-
Jérome Perrin authored
This helps debugging concurrency problems
-
Jérome Perrin authored
-
Jérome Perrin authored
This allows running tests using a timer server loop, that will invoke process timer on all subscribers. The need for this is to test a custom tool using timer server.
-
Jérome Perrin authored
It was enough for 2 nodes, but with 4 nodes I sometimes saw errors.
-
Jérome Perrin authored
This was a deprecated method that no longer exists since ZEO 4 https://github.com/zopefoundation/ZEO/commit/5423f110ddc1034ea0954495957894c60f6da78c
-
Jérome Perrin authored
_setUpDummyMailHost is also used to prevent accidentally sending "real" emails, so we also like to have it enabled for other nodes.
-
- 14 Jun, 2022 4 commits
-
-
Roque authored
-
Julien Muchembled authored
-
Jérome Perrin authored
This happens in project related task report dialog ( testProjectRelatedTaskReport from erp5_report_renderjs_ui_test:testFunctionalRJSReportLanguage )
-
Jérome Perrin authored
jslint complain about trailing commas
-
- 13 Jun, 2022 4 commits
-
-
Jérome Perrin authored
using movement date rather than order date is more correct
-
Jérome Perrin authored
composition API, which is used to select the "most applicable" model (Trade Condition, Transformation, Pay Sheet Model, etc) with the same reference was only discarding deleted and validated models, but it was selecting draft models. This leads to this kind of problem: - A validated model exist, with an effective date - A new model is made by cloning the validated one, edited to set effective date from now and validated - The first validated model is also cloned by mistake, but not validated In such case, the model cloned by mistake might be used, which from user point of view is wrong, because user validated a model, so if the system use a draft instead, that's a very wrong behaviour. This change require models to be validated for the composition API to work, many tests were updated to validate the model (either in the test or in the data business template used by the test). This change might also produce different results in production, because it was possible that some draft models were selected before, now they will no longer be selected. To check for potential side effects, we recommend looking for all draft models with a reference, examine them one by one and validate the model if it's a case where user forgot to validate.
-
Vincent Pelletier authored
Since commit f363ac65 Author: Vincent Pelletier <vincent@nexedi.com> Date: Wed Mar 23 15:55:46 2022 +0900 Products.CMFActivity.ActivityTool: Store user object in activity. user_name on newly created activities is always None. As a result, activities using dummyGroupMethod are executed within the security context which spawns the group, which is System Processes, instead of the user which spawned each activity. Add a unittest for this.
-
Vincent Pelletier authored
This was broken by: commit f363ac65 Author: Vincent Pelletier <vincent@nexedi.com> Date: Wed Mar 23 15:55:46 2022 +0900 Products.CMFActivity.ActivityTool: Store user object in activity. as user_name becomes always None.
-
- 09 Jun, 2022 6 commits
-
-
Jérome Perrin authored
See merge request !1637
-
Jérome Perrin authored
This script stopped working since Catalog changed to be ERP5 document, because it was calling the unindex method of the catalog (which itself is indexable like any other ERP5 document). Update to use the uncatalogObject which is the method to unindex a document by uid. Even though it was somehow working before, it was not really correct in selecting objects, because it was using - operator on TIMESTAMP column, which is not computing a difference in seconds as this script was expecting. See for example https://stackoverflow.com/a/24504132/7607763 or the example below for an explanation. Instead, use TIMESTAMPADD to compute the start timestamp only once and use >= operator, which works as expected. This query was also sorting by indexation_timestamp, which does not use an index. Remove the sort because it's not really needed. Excluding reserved path was also not needed, we no longer use these since 69aefdff (ZSQLCatalog: Drop support for "reserved" path., 2017-09-18) --- Another reproduction of the timestamp arithmetic problem select TIMESTAMP('2021-01-02 00:00:00') - TIMESTAMP('2021-01-01 00:00:00') a, 20210102000000 - 20210101000000 aa, TIMESTAMP('2021-06-01 00:00:00') - TIMESTAMP('2021-05-31 00:00:00') b, 20210601000000 - 20210531000000 bb, TIMESTAMPDIFF(second, TIMESTAMP('2021-05-31 00:00:00'), TIMESTAMP('2021-06-01 00:00:00')) c | a | aa | b | bb | c | | ------ | ------ | ------ | ------ | ------ | | 1000000 | 1000000 | 70000000 | 70000000 | 86400 |
-
Jérome Perrin authored
-
Jérome Perrin authored
This is a bit easier to read
-
Jérome Perrin authored
-
Jérome Perrin authored
When a test fail, we make a data-url link with the HTML of the current page, so that we can easily investigate test failures n test nodes. We should not let errors that might happen here propagate, otherwise the test result is not created and the test runner does not detect that the test is finished. One case that caused such errors was failed assertion just after using goBack command without waiting
-
- 08 Jun, 2022 2 commits
-
-
Valentin Benozillo authored
-
Valentin Benozillo authored
Depending on field type, if min and max are not setup then they can be equals to the empty string or undefined.
-
- 06 Jun, 2022 6 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
PaySheet_getODTStyleSheet => PaySheetTransaction_getODTStyleSheet PaySheet_printAsODT => PaySheetTransaction_printAsODT PaySheet_viewODTPrintDialog => PaySheetTransaction_viewODTPrintDialog PaySheetModeLine_init => PaySheetModelLine_init RatioSettings_view => PaySheetModelRatioLine_view
-
Jérome Perrin authored
-
Jérome Perrin authored
Some proxy fields had inconsistent internal data structures, maybe rendering incorrectly in ods/odt styles
-
Jérome Perrin authored
-
- 01 Jun, 2022 1 commit
-
-
Vincent Pelletier authored
This was broken by: commit f363ac65 Author: Vincent Pelletier <vincent@nexedi.com> Date: Wed Mar 23 15:55:46 2022 +0900 Products.CMFActivity.ActivityTool: Store user object in activity. as user_name becomes always None.
-
- 27 May, 2022 1 commit
-
-
Jérome Perrin authored
Business templates are installed by system user, which is a special user not returned by getWrappedOwner. Because of this, the "fixing problems or activating a disabled alarm is not allowed" error was raised when checking if the owner of the alarm has manage portal permission on the alarm. This switches the implementation to explicit creation of the user when user id is the system user, so that we have a user with the permission to solve the alarm.
-
- 26 May, 2022 3 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
is* selenium commands do not fail when evaluating to false, I guess we wanted to use assert* here.
-
Jérome Perrin authored
-