- 17 Feb, 2020 4 commits
-
-
Jérome Perrin authored
This test should catch when business templates metadata in `bt/` is different from the actual content in `*TemplateItem/` . It should not happen, but sometimes we can forgot to include one or the other in commit. This also fixes problems in the currently tested business templates, there was three kind of problems: * binary files are now exported with `bin` extension, it use to be `obj`. * In several business templates, we export categories as `portal_categories/category/*`, while this looks convenient, it's problematic when categories are added by other business templates, every time developer export the business template they have to consider whether the new paths should be exported or not. This changed to list explicitly all the paths to include in business template. * some business templates were partially commited ( "erp5_dms_ui_test: Add selenium tests" ) /reviewed-on nexedi/erp5!1049
-
Jérome Perrin authored
Make it pass coding style "Hide" an action that is not really useful and problematic when used by mistake /reviewed-on !1051
-
Jérome Perrin authored
This way, the substitution mapping method can return a dynamic mapping, the only requirement is to implement __getitem__ ne use case is to be able to use the same substitution script for different CRM notification messages and only compute the "heavy" substitution variables when they are actually needed. See nexedi/erp5!1047
-
Jérome Perrin authored
-
- 14 Feb, 2020 10 commits
-
-
Vincent Pelletier authored
-
Jérome Perrin authored
We run them in coding style test suite already. Also these test now need business template repository properly configured in template tool, which is not set in default setup, so keeping them working would require extra work.
-
Jérome Perrin authored
-
Jérome Perrin authored
This reverts commit f9391847. These two paths were only half-committed, for the PDF we don't have the file content, for the test we don't have the .xml, so in practice this test never ran. I tried to run it but it does not pass, uses pause command and some xpath selector that are now unclear. PDFJS is also tested in portal_tests/erp5_km_zuite/testCheckPDFPreview
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
- 13 Feb, 2020 1 commit
-
-
Jérome Perrin authored
This action is very rarely used, typically once for each section and then never used again. Make it only enabled for Manager user, as a way to disable it, but it's still here and it still works, but it's not useful in normal operations.
-
- 12 Feb, 2020 4 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Kazuhiko Shiozaki authored
also open a new window / tab.
-
Arnaud Fontaine authored
-
- 10 Feb, 2020 9 commits
-
-
Roque authored
- use global preference to get publication section value - test updated
-
Roque authored
-
Roque authored
-
Roque authored
/reviewed-on nexedi/erp5!1017
-
Arnaud Fontaine authored
ZODB Components: Resetting Portal Type classes was also clearing Interfaces of erp5.component.* modules. __implemented__ and __provides__ attributes are cleared on Portal Type reset to break a circular reference (11e2b506). Resetting of ZODB Components is done independently of Portal Type classes, so until the next ZODB Component reset, Interfaces were not implemented anymore. 11e2b506 states that this creates a memory leak but this is not actually true as Python garbage collector will break such circular reference and collect this object, as asserted by a newly introduced Unit Test. This is probably less efficient than explicitly breaking the circular reference and thus relies on reference counting (rather than the garbage collector) but doing otherwise would require introspecting ZODB Components module to find classes implementing Interfaces (erp5.portal_type only contains classes). This only takes care of ZODB Components modules but maybe breaking circular references for Portal Type classes is not even needed (if so, this will be done in a later commit).
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: When migrating FS Mixin, set the ZODB Component reference to the class name (like Interfaces).
-
Arnaud Fontaine authored
ZODB Components: Non-core bt5 with 'Document Component' overriding standard ERP5 Document must create its own version_priority. Otherwise this will clash when standard ERP5 Document will be migrated to ZODB Components to erp5_base.
-
Arnaud Fontaine authored
Like Document and Interface Components for the same reasons (694c9fee).
-
- 07 Feb, 2020 2 commits
-
-
Jérome Perrin authored
Since 264ded5c in ERP5JS we render the form directly after a successful edit, but this was done sometimes too early, namely, the next form was rendered before interaction workflows and this leads to problems like the ones discussed in nexedi/erp5!982 (comment 92893) /reviewed-on nexedi/erp5!1040
-
Jérome Perrin authored
This test click on the delete button which deletes by an ajax request and immediatly after open the "wait for activities" page. Sometimes the second request starts before the first is committed, so there are no activities to wait for. When using ZServer, we had only one worker thread, so this was not visible, but with wsgi we have more than one so it happened sometimes. Use an old jQuery trick to wait that the first request is no longer in flight. /reviewed-on nexedi/erp5!1038
-
- 06 Feb, 2020 3 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Also covers traversal (and a lot more).
-
- 05 Feb, 2020 3 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02 SameSite=None breaks the compatibility with some browser versions. https://www.chromium.org/updates/same-site/incompatible-clients We choose Lax and not Strict so that we can open links to ERP5 from external applications and so that OAuth Logins work. Implementing the "two cookies, one for read one for write" approach suggested in https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-8.8.2 would be too big change at this point. Allow instances to surcharge the SameSite value for some specific domains if needed, by surcharging the ERP5Site_getAuthCookieSameSite script.
-
Vincent Pelletier authored
-
- 04 Feb, 2020 1 commit
-
-
Romain Courteaud authored
-
- 03 Feb, 2020 3 commits
-
-
Jérome Perrin authored
We want to render the next page after interaction workflows are executed.
-
Jérome Perrin authored
This uses a foo_interaction_workflow that sets a short title when title is set to a special value. We use it to check that when user set the title to that special value and save, next time the form is displayed, the values displayed are the ones after interaction workflow modified. This is a simple and a bit unrealistic scenario, but we have for example interaction workflows that update security definitions when some properties are modified, we want the next form to display the values after modifications. This is also the case of editions of portal components which sets the document to "modified" state and "re-validate" it at the end of transaction, unless pylint detects error.
-
Jérome Perrin authored
action added in a previous commit was removed, probably by mistake because only the metadata was removed.
-